Commit Graph

324 Commits

Author SHA1 Message Date
Chris LaFreniere
061d3510b9 Run ADS Commands from Notebooks (#11069)
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
2020-06-28 21:17:50 -07:00
Hale Rankin
7ef8acf04e Markdown toolbar > Preview toggle feature (#10963)
* Added toggle preview button to Markdown toolbar. Revised components, theme and styles to present the preview as a second column beside the markdown.

* Added showPreview to model and began working on togglePreview.

* Uncommented use of cellModel.showPreview

* add cell model event for onPreviewChange

* Renamed my showPreview boolean to prevent confusion with local boolean used in toogglePreview.

* Added CSS class when preview is enabled. Adjusted styles accordingly.

* Swapped icon show/hide references for correct sequence. Modified updatePreview to include state of doShowPreview.

* Added check for isEditMode so we can run togglePreview and show it once editor closes.

* Added listener to code.component that triggers layoutEmitter on changes to peview.

* Renamed local boolean doShowPreview. Removed unneeded code. Fixed ambiguity in my use of booleans, adding a getter and setter to textCell.

* Cleaned up implementation of new get/set for toggling preview.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-06-26 13:47:17 -07:00
Charles Gagnon
a303144226 getCredentials returns credentials for any saved connection (#11029)
* getCredentials returns credentials for any saved connection

* Update doc comment

* Add tests

* cleanup

* cleanup
2020-06-23 11:04:13 -07:00
Alex Ma
e01723f195 Additional tests for connection (#10944)
* Added providerRegistered test

* test for EditConnectionDialog

* changed wording

* added test for connectionInfo

* utils.ts tests added

* hasRegisteredServers test

* commented out editconnection tests, addl. tests

* added onConnectionChangedNotification test

* added changeGroupId tests

* Added connection  profile changes

* added connectIfNotConnected test

* added delete connection test

* isRecent and disconnect editor tests

* added registerIconProvider test

* Fix for ensureDefaultLanguageFlavor test

* added a few tests

* utils prefix test updated

* added utils tests
2020-06-22 13:51:39 -07:00
Amir Omidi
21fd8b22e7 Fix a memory leak on listener (#10294)
* Fix leak

* We don't need the full connection profiles for drag drop control

* Remove unused code

* Change test definition

* Change test definition

* Change equality check
2020-06-16 19:36:10 -07:00
Anthony Dresser
381a747b62 fix export for remote (#10934) 2020-06-16 12:10:05 -07:00
Christopher Suh
0c56e4a603 Column/Table Drag & Drop (#10702)
* able to drag objects from left pane

* changed scheme from file

* base functionality working

* extended functionality to tables

* added string literals and formatting

* cleanup

* cleanup

* added table/column parsing

* removed bad logic

* updated to use metadata

* cleanup and added sql carbon edit tags

* moved changes from vs into sql code base

* refactoring drag and drop

* cleanup

* cleanup

* cleanup

* added unit tests

* pr changes

* moved treeMock file

* fixed small bug
2020-06-15 23:52:46 -04:00
Anthony Dresser
16c27baf10 maintain scheme in insights (#10904)
* maintain scheme in insights

* fix compiles

* fix tests

* handle undefined

* fix windows tests

* fix imports

* handle remote resources
2020-06-15 14:23:31 -07:00
Maddy
26a00696d4 Fix/prev next links issue (#10523)
* intital test code

* added tests

* remove commented code

* fix for failing tests

* reuse exported enum

* changes to address comments

* add back onVisibility highlight

* port highlight fix from Chris

* fix tests
2020-06-12 18:42:17 -07:00
Amir Omidi
3608e132cb Add close button (#10898)
* Add close button

* Change the localize key
2020-06-12 13:03:18 -07:00
Cory Rivera
59575aa305 Wait for clientSession to become available before running a cell. (#10796) 2020-06-09 05:30:13 -07:00
Amir Omidi
d08a224550 Fixes #10734, register a container for the view (#10750)
* Fixes #10734, register a container for the view

* Remove unused fields
2020-06-08 11:06:04 -07:00
Anthony Dresser
72b2d9ef72 rework some of some, add query to smoke (#10591) 2020-06-05 17:25:24 -07:00
Amir Omidi
70af4cbe42 Fixes the azure auth for postgresql (#10662) 2020-06-04 16:01:50 -07:00
Anthony Dresser
a68e74527e Merge branch 'ads-master-vscode-2020-05-31T19-47-47' 2020-06-03 14:05:57 -07:00
Amir Omidi
3860f07cab Make azure portal work from server area (#10699) 2020-06-03 14:02:23 -07:00
Alan Ren
c4be667567 add custom width support for dialogs (#10641)
* add custom width support for dialogs

* comments

* fix test
2020-06-03 13:08:48 -07:00
Anthony Dresser
15d8e09491 Merge remote-tracking branch 'origin/master' into ads-master-vscode-2020-05-31T19-47-47 2020-06-03 12:35:26 -07:00
Aditya Bist
6816d2bd78 add icon for disabled triggers (#10663) 2020-06-01 14:10:06 -07:00
Anthony Dresser
7d53e744f3 fix imports 2020-05-31 13:08:12 -07:00
Amir Omidi
7d31239e64 Open in azure portal (#10535)
* initial commit to get it working

* Change configuration to use package.nls.json

* Make the necessary plumbing

* Support multi cloud

* Move the menu item to the bottom

* Fix failing tests

* Fix the tests
2020-05-29 19:59:29 -07:00
Hale Rankin
b2e0291a95 10551 - Notebook UI: Added cell toolbar component (#10558)
* 10551 - Notebook UI: Added cell toolbar component, actions scaffolding, styles and theme colors. Removed markup for legacy, hidden hover buttons. Updated instaces of icon class: mask to masked-icon.

* Uncommented lines for CellToggleMoreActions so we can see how the ellipses currently work.

* Added EditCellAction which toggles between two icons.

* Cleaned up comments and removed some unused code.

* Copied DeleteCellAction into celltoolbarActions

* Connecting model and cell model to toolbar component for necessary context.

* Pass in cell + nb model from notebook component

* Adding context for EditCellAction so we can activate a cell via icon.

* Removed my copy of AddCellAction and simply referred to the existing one.

* Fixes to propogate cell model edit mode changes

* Added onCellModeChanged event registration to code.component.

* Moved cellToggleMoreActions into cellToolbarActions. Suppressing ellipses in code and textCell components.

* Fix adding cells

* Copied and modified ToggleMoreWidgetAction for use in cellToolbarActions. Instantiating cellToggleMoreActions and adding to toolbar.

* Removed unused markup, code and styles. Moved cell toolbar template into compoent.

* Removed double-click from textCell. Changed message to indicate where content goes - without it the cell does not have dimension and cannot be found by the user.

* Removed unused code file.

* Fixing my boo boo

* Updated AddCellAction with null coalescer. Set Promise to type: void.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-05-29 18:27:36 -07:00
Charles Gagnon
107b3171f2 Add isBigDataCluster property to connection event (#10606) 2020-05-29 06:47:03 -07:00
Vladimir Chernov
8288360cc4 Assessment core extension (#10154) 2020-05-29 01:17:41 +03:00
Chris LaFreniere
6d710c7144 Add plumbing and simple notebookService tests (#10349) 2020-05-19 21:36:59 -07:00
Amir Omidi
b519d51052 Replace the ID of the generated connection profile with the one through edit data (#10413) 2020-05-15 10:48:56 -07:00
Alex Ma
8f7861deac Keybinding for Show SQL Pane (#9750)
* WIP registerKeybind

* testing command

* Moved command to query.contribution

* Moved command to editData.contribution

* simplified command

* more simplification

* Working keybind for toggle query pane added.

* removed space

* added option to always show sql pane

* removed keybind default and changed option
2020-05-14 14:06:58 -07:00
Charles Gagnon
264c34af97 Add more debug logging to fillInOrClearAzureToken (#10336)
* Add more debug logging to fillInOrClearAzureToken

* Use toErrorMessage
2020-05-11 15:09:34 -07:00
Amir Omidi
f220f6486a Stops caching the AAD token (#10251) 2020-05-08 16:46:18 -07:00
Cory Rivera
f94a9d0d58 Update Configure Python dialog to allow packages to be installed for specific kernels. (#10286) 2020-05-08 16:02:59 -07:00
Chris LaFreniere
e4614582cd Cleanup nbformat, more common tests (#10311) 2020-05-08 14:50:24 -07:00
Chris LaFreniere
dac1970c43 Notebooks: Refactor Empty Session Classes (#10265)
* Cleanup empty sessionmanager

* Cleanup

* PR Feedback import noKernel from notebookActions
2020-05-07 16:20:14 -07:00
Anthony Dresser
df5df38a55 Query Runner Tests (#10252)
* rework some code and write an inital test

* fix strict

* add more to standard test

* add to existing workflow test

* fix tests

* simplify the code

* add more tests

* remove bad import

* fix compile

* fix timestampiong
2020-05-06 13:38:12 -07:00
Alex Ma
9a7810cbee removal of unnecessary spaces. (#10275) 2020-05-05 14:58:13 -07:00
Alex Ma
921e546fd7 Edit Connection Feature added, edit existing connection in connection tree. (#10214)
* Added Edit Connection Command

* Wip changes for new connection dialog

* Testing

* WIP commit

* added ID check to ensure connection

* wip commit

* model id check implemented

* addfooterbutton now accepts events

* wip commit

* message explaining check

* temporary change

* connectionManagementService restored

* Revert "connectionManagementService restored"

This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.

* formatting test

* editConnection promise testing

* edit existing connection command added

* WIP Connection Edit

* disconnect added to editConnection promise

* WIP on editExistingConnection

* changed isEdit to true

* Amir/edit connection (#10112)

* Get edit connection working

* Delete unused code

* check for isEdit as well

* connection tree test added

* WIP connection management tests

* comment out test to find out what's wrong

* fix for one error

* added note about test skipped

* changed signature of saveprofile

* saveprofile fixed

* wrote working test

* added additional test

* changed message

* Fixes made

* fix for matcher

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-05-05 13:21:05 -07:00
Amir Omidi
5105694fb3 Render before adding to the splitView (#10261) 2020-05-05 12:05:12 -07:00
ADS Merger
93f35ca321 Merge from vscode 27ada910e121e23a6d95ecca9cae595fb98ab568 2020-04-30 00:53:43 +00:00
Chris LaFreniere
0a3a0ec80f Notebooks: Support User-Installed Kernels (#10194)
* Fixes for attach to. Still need to update cache

* Don't have jupyter hardcoded

* Handle DOTNET_ROOT env var

* Fix on load

* Put behind feature flag

* Cleanup

* Error check

* PR feedback
2020-04-29 10:34:27 -07:00
Kim Santiago
11f6790630 Add support for target location in tasks (#10179)
* Add support for target location in tasks

* bump sqltoolsservice to get addition of targetLocation to TaskNode
2020-04-28 15:35:40 -07:00
Alan Ren
4ec281313f extend the ListDatabasesRequest to allow more information to be returned (#10186)
* database detail

* revert sts change

* reuse databaseInfo interface
2020-04-28 13:32:19 -07:00
Chris LaFreniere
e9339bb0d5 Cleanup and clientSession uncomment (#10162) 2020-04-27 11:07:35 -07:00
Anthony Dresser
a1930bdc59 fix formatting 2020-04-24 14:03:37 -07:00
Charles Gagnon
8311c3985d Add PropertiesContainer ModelView component (#10115)
* Add PropertiesContainer ModelView component

* Switch to component

* Remove unneeded interface

* Update names

* Fix names
2020-04-22 16:29:46 -07:00
Charles Gagnon
cb26c1c409 Fix arrow alignment for connection dialogs (#10064) 2020-04-17 19:11:41 -07:00
Charles Gagnon
5304d65586 Fix logging for angular bootstrapping errors (#10059) 2020-04-17 14:51:44 -07:00
Anthony Dresser
5b19fe7c67 Revert "Stop executing the same code three times (#9835)" (#10026)
This reverts commit 97108bdeea.
2020-04-16 14:54:25 -07:00
Amir Omidi
97108bdeea Stop executing the same code three times (#9835)
* Stop executing the same code three times

* Remove one more extra call
2020-04-15 13:56:12 -07:00
rajeshka
b9b3c1071e Added Notebook telemetry for livesite notebooks (#9948)
* Added Notebook telemetry for livesite

* added back the metadata retension code

* Unified Telemetry services

* fixed names

* Fixed texts to use new NullAdsTelemetryService

* Validate GUID before sending it

* made GUID check a bit more robust

Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
2020-04-14 10:27:28 -07:00
Anthony Dresser
ffdde0209b Merge branch 'ads-master-vscode-2020-04-08T06-33-35' 2020-04-08 13:34:54 -07:00
Amir Omidi
8e164973ee Login spinner (#9892)
* Add a notification for handling logins

* No need to catch and rethrow

* Make it optional

* use testNotificationService
2020-04-08 12:53:48 -07:00