This PR enhances telemetry for login migrations (and in the following ways:
Add details for starting migration (number of logins migrating, type of logins)
Log Migration result (number of errors per step, duration of each step, type of logins, if system error occurred)
Add sql-migration extension to our telemetry
Adds details when trying to connect to target
Tracks clicking "done" from the wizard
Fixes bucketizing for navigating telemetry in the login migration wizard
Sample usage of kusto query for new telemetry:
RawEventsADS
| where EventName contains 'sql-migration'
| extend view = tostring(Properties['view'])
| extend action = tostring(Properties['action'])
| extend buttonPressed = tostring(Properties['buttonpressed'])
| extend pageTitle = tostring(Properties['pagetitle'])
| extend adsVersion = tostring(Properties['common.adsversion'])
| extend targetType = tostring(Properties['targettype'])
| extend tenantId = tostring(Properties['tenantid'])
| extend subscriptionId = tostring(Properties['subscriptionid'])
| where view contains "login"
//| where adsVersion contains "1.42.0-insider"
| where ClientTimestamp >= ago(18h)
| project EventName, ClientTimestamp, SessionId, view, pageTitle, action, buttonPressed, targetType
, tenantId, subscriptionId
, adsVersion, OSVersion, Properties
* Adding migration service to sql migrations
* enabling auto flush log
* Adding support for env variable
* Adding TDE Migration service
* code cleanup
* updating service downloader
* Removing custom output channel
* remove unnecessary await
* Updated service version to get latest code
* Consolidate TDE into migration service
* Sync to latest main
* Update sql-migration package version
* Fix merge conflict error
* Fixing all merge conflicts
* Fixing stuff
* removing extra whitespace
* Cleaning up
---------
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP
* Always get latest current connection
* Update more references
* Clean up
* Clean up
* vbump
* Update comments
* Address PR feedback
* Separate into helper methods
This PR fixes a regression for migration login for MI instances that was introduced in https://github.com/microsoft/azuredatastudio/pull/21776/files#diff-93c1a62583fa32d99f775b71ad27922cf31f660d10717ecc6966784306de1b6f.
After that change, support for MI would fail as MI server types were going into the Sql VM path in sqlutils because the underlying logic for isSqlServerVM() was returning wrong results.
The new approach uses the targetType set in StateMachine to extract the correct serverName for connection string based on the targetType.
Testing:
- Tested SQL VM login migration end to end
- Tested SQL MI login migration end to end
This change also bumps the sql-migration version to 1.3.0
This PR adds various login migration improvements:
- Enabled windows login by prompting user for AAD domain name if a windows login is selected
image
- Adds new login details dialog which gives granular status on each step of the login migration for each login
image
- Checks if windows login migration is supported for selected target type, and only collections source windows logins accordingly
- Perf optimization by source and target login in background of step 1 in order to significantly speed up loading of page 2
* Disable IR scenario and add info box for source < 2014
* Update text and link
* Clean up
* Fix issue where switching to another target platform wouldn't clear restriction
* Remove locale from documentation URL
* Refactor
* Clean up
* Autoselect blob scenario
* Refactor
* Add page blog check
* Clean up
* Update UI logic
Adding collation validation in target database selection page.
collecting source database info including state, size, collation etc in the step 1 (select databases to assess and migrate)
comparing source database collation and target database collation in target selection page.
image
* Add TrustServerCertificate to request body
* Preselect all dbs for migration
* Make disabled checkbox not auto selected
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Revert "Clarify assessment results in card"
This reverts commit e8b83f3c19a20ba29133aaa68c4644b04d4154fe.
* Revert "Fix incorrect number of dbs ready for migration without issues to MI"
This reverts commit d4e10875d132dd218d95be91ae7d46672e247706.
* Revert "Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues"
This reverts commit e2a7dcd7352d1c215052a2f6f3f6130fc710eff8.
* Add new fields
* Fix null reference exception in SKU rec with save and close
* Remove unused files
* Warnings for in progress migrations in list view
* Fix unscrollable assessment results
* Fix updating SKU parameters before recommendations are ready
* Remove checksum info box
* Address PR feedback
* Clarify assessment results in card
* Fix incorrect number of dbs ready for migration without issues to MI
* Fix SQL DB assessment results incorrectly greying out dbs with MI blocking issues
* Update error banner for blocked databases
* Reword error message
* WIP - show error message for failed SKU recommendation
* WIP - run query to get correct instance name
* WIP - integrate elastic model recommendation
* Remove private endpoint restriction text
* Add feature switch for elastic recommendation
* Clean up
* Clean up
* Misc UI fixes
* Update package.json with updated azdata dependency
* Remove unused lines
* Fix broken next button
* Vbump extension to 1.0.6
* Update SQL DB card to show number of recommendations for correct model
* sql db wizard with target selection
* add database table selection
* add sqldb to service and IR page
* Code complete
* navigation bug fixes
* fix target db selection
* improve sqldb error and status reporting
* fix error count bug
* remove table status inference
* address review feedback
* update resource strings and content
* fix migraton status string, use localized value
* fix ux navigation issues
* fix back/fwd w/o changes from changing data
* WIP
* WIP
* WIP
* Fix location dropdown not working properly
* Clean up comments
* Switch button order in selectMigrationServiceDialog
* Vbump to 1.0.1
* Refactor to avoid duplicate API calls
* Add null checks
* Fix migration status dialog not sorting migrations properly
* Address comments, remove unnecessary code
* Address comments - separate util methods by resource type, use logError instead of console.log
* Remove unused methods
* Fix DMS creation on newly created resource group
* Fix stale account behavior
* Address comments - remove telemetry context from util method calls
* Clean up imports
* Fix dashboard service monitoring not working
* Fix null reference on database backup page, and resources not updating properly when location is changed
* Fix dashboard not auto selecting DMS after migration started
* Add null checks
* WIP - implemented logic to show resource groups as derived from list of resources, instead of directly listing all resource groups
* Remove comments
* Remove getResourceGroupByName and craft resource group object manually instead
* Update subscription and location list when tenant is changed
* Define Azure resource types locally instead of modifying azurecore
* Add SQL VM scenario
* Split getAzureResourceGroupDropdownValues into four separate functions
* Refresh only subscription list when tenant is changed
* Create new DMS dialog should show all resource groups
* Remove unnecessary async code
* Add MI ready state check and error message
* Fix a typo
* Update error message logic
* Update '(Unavailable)' prefix to be localized string
* Show error messsage when non-Ready MI is initially selected (not just on Next button)
* Update error message with appropriate casing and actionable step
