Anthony Dresser
ea5f9be441
Properly expose errors in ads and tests ( #8692 )
...
* add code to expose errors outside zone
* remove unexpect error hiding
* remove uncessary code
* fix tests
* trying to catch more errros
* revert for testing
* wip
* wip
* figured out what was going on
* wip
* fix tests
* fix tests
2019-12-17 12:06:36 -08:00
Anthony Dresser
8e4d0ad446
remove unnecessary info from problem svgs ( #8712 )
2019-12-17 10:13:06 -08:00
Aditya Bist
ef8c0e91e6
fix provider dropdown option for cms dialog ( #8711 )
2019-12-16 18:50:50 -08:00
rajeshka
73b9849dd5
Toggle Trusted Button ( #8569 )
...
* Toggle Trusted Button
* Persist Trusted information to Cache
* Trusted toggle unit test fixed
* Updated test comment
2019-12-16 13:32:56 -08:00
Alan Ren
64e217eac2
change order of tasks ( #8703 )
2019-12-16 13:21:03 -08:00
Chris LaFreniere
826e069b63
Fix passing in connection profile ( #8689 )
2019-12-16 13:20:43 -08:00
Chris LaFreniere
6e8a08c27a
Fix Notebook Scrolling by Setting alwaysConsumeMouseWheel to False ( #8686 )
...
* flip alwaysConsumeMouseWheel to false for nb
* remove semicolon
2019-12-16 13:17:02 -08:00
Charles Gagnon
a42407b81a
Fix missing action buttons with single view ( #8694 )
2019-12-16 10:33:21 -08:00
Charles Gagnon
a622e4ac40
Fix options dropdown arrow alignment in options dialog ( #8695 )
2019-12-16 09:58:57 -08:00
Charles Gagnon
01b9754c80
Fix alignment of select dropdown in modal dialogs ( #8683 )
2019-12-13 16:23:25 -08:00
Charles Gagnon
b650168704
Add de viewlet tests back ( #8673 )
2019-12-13 14:08:01 -08:00
Anthony Dresser
642920504a
Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12 ( #8670 )
...
* Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12
* fix null strict checks
2019-12-13 00:50:37 -08:00
Charles Gagnon
5bf85a2855
Add tests for refresh scripting action ( #8648 )
...
* Add tests for refresh action
* Revert changes to make tree public
* Move tests into subsuite
2019-12-12 16:04:28 -08:00
Cory Rivera
866bfc61ba
Add more unit tests for NotebookInput ( #8654 )
2019-12-12 14:59:56 -08:00
BranislavGrbicMDCS
6638db1f35
Brgrbic/code cleanup issue8158 ( #8655 )
...
* Removing engine edition specific condition from displaying error message
* Removing unused import
2019-12-12 13:24:31 -08:00
Anthony Dresser
f0dde491be
fix edit data close ( #8657 )
2019-12-12 13:18:33 -08:00
Chris LaFreniere
d1c594cfd0
Change deploy string from connections viewlet/welcome page ( #8646 )
...
* Change deploy string from connections viewlet
* Also change welcome page
2019-12-12 10:25:22 -08:00
Anthony Dresser
4ba6a979ba
Merge from vscode a4177f50c475fc0fa278a78235e3bee9ffdec781 ( #8649 )
...
* Merge from vscode a4177f50c475fc0fa278a78235e3bee9ffdec781
* distro
* fix tests
2019-12-11 22:42:23 -08:00
Alex Ma
7ec516d851
Change typo for monaco-pane-view ( #8644 )
...
* changed monaco-panel to pane (typo in classname)
* removed headervisible
2019-12-11 16:56:37 -08:00
Charles Gagnon
7e970d04ca
Fix tree refresh ( #8625 )
...
* first part
* remove another refresh collapse expand
* Fix scriptable nodes
* Fix test
2019-12-11 16:34:03 -08:00
Chris LaFreniere
302e8305ef
add titles to collapse expand button ( #8607 )
2019-12-10 21:08:28 -08:00
Anthony Dresser
659f392196
add readonly method to editors ( #8630 )
2019-12-10 18:16:16 -08:00
Chris LaFreniere
bceb766d28
Notebooks: Fix Cancel for Connection Dialog to Actually Close Window ( #8626 )
...
* Fix connection dialog not going away on cancel
* Remove unnecessary change
2019-12-10 16:59:15 -08:00
Charles Gagnon
99c473cdf6
Fix shift + enter to go to previous find entry in profiler ( #8615 )
2019-12-10 07:33:49 -08:00
Cory Rivera
184d4bbe27
Add units tests for Notebook Actions ( #8595 )
2019-12-09 15:37:40 -08:00
Maddy
4fc6f4a13e
unescape the encoded chars in tablename uri ( #8446 )
...
* unesacpe the encoded chars in tablename uri
* unescape special characters
2019-12-09 14:40:21 -08:00
Chris LaFreniere
62565e0577
Notebooks: Only have One Connection in Attach To Dropdown ( #8582 )
...
* Have only one connection in attach to dropdown
* LGTM fixes
* Test fixes not unnecessarily changing context 2x
* PR Feedback
2019-12-08 11:03:51 -08:00
Anthony Dresser
d614116b63
Merge from vscode a416c77e56ef0314ae00633faa04878151610de8 ( #8600 )
...
* Merge from vscode a416c77e56ef0314ae00633faa04878151610de8
* distro
* fix tests
* fix tests
2019-12-07 17:19:16 -08:00
Charles Gagnon
6e8cc3aaca
Fix accessibility issues with Manage Access dialog ( #8586 )
...
* Fix accessibility issues with Manage Access dialog
* implement more property interfaces
* Fix lgtm errors
* Simplify condition
2019-12-06 15:09:42 -08:00
Charles Gagnon
d1c7370f1c
Make links more descriptive ( #8591 )
2019-12-06 13:06:49 -08:00
Alan Ren
7cd2a6d6aa
fix radio card group rendering error ( #8587 )
...
* fix rendering error
* remove extra $ sign
2019-12-06 10:20:37 -08:00
Anthony Dresser
4787d7ba5c
fix notebookinput matches function to work with replacement ( #8585 )
2019-12-05 16:53:36 -08:00
swjain23
0bf4790a64
Add changes for flavor selection ( #8419 )
...
* Add changes for flavor selection
* Use getDefaultProviderId method
* Update default engine user setting description
* Add back check for codeEditor
* Add test for multiple providers
* Removing extra merge line
* Add an attribute to ConnectionProviderProperties for language flavor
Adding a boolean property to ConnectionProviderProperties for providers that are language flavors. When it is set to true, the provider will be part of drop down for changing SQL language flavor.
* Update variable name
* Put logic for removing CMS at one place and remove flag for flavor provider
* Using keys instead of entries
Using Object.keys instead of entries as doing [0] can be error prone if no provider matches.
* Adding logic to check from params
* Updating variable names
* Rename dedup map
* Fix action
2019-12-05 15:28:35 -08:00
Leila Lali
0d9353d99e
Manage Package Dialog Refactor ( #8473 )
...
* Refactoring Manage Packages dialog so that other extensions can contribute to it by registering package mange providers for different location and package type
2019-12-05 10:26:50 -08:00
Anthony Dresser
f5ce7fb2a5
Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c ( #8525 )
...
* Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c
* remove files we don't want
* fix hygiene
* update distro
* update distro
* fix hygiene
* fix strict nulls
* distro
* distro
* fix tests
* fix tests
* add another edit
* fix viewlet icon
* fix azure dialog
* fix some padding
* fix more padding issues
2019-12-04 19:28:22 -08:00
Cory Rivera
9691fab917
Add code coverage tests for cell.ts ( #8564 )
2019-12-04 14:45:48 -08:00
Alan Ren
ab94b9785e
deprecate the card component ( #8552 )
...
* deprecate the card component
* add deprecated tag
2019-12-04 10:48:08 -08:00
Charles Gagnon
6cce532ca4
Fix wizard not displaying error messages ( #8545 )
2019-12-03 17:40:19 -08:00
Charles Gagnon
7f16a4d857
Fix refresh action ( #8519 )
...
* Fix refresh action
* Refactor to async
* Fix missing bracket
* Remove unused error level
* Add back in error message
* Fix missing service
2019-12-03 17:40:02 -08:00
Alan Ren
b38b53b658
accessible radio card ( #8514 )
...
* accessible radio card group
* set radio card group width
* address comments
* address comments 2
* fix the profile card not being focused issue
2019-12-03 13:26:00 -08:00
Anthony Dresser
c93ea20b75
fix uri string for converting inputs ( #8530 )
2019-12-03 10:09:20 -08:00
Charles Gagnon
d358cdac1e
Add tests for declarative table component ( #8499 )
2019-12-03 09:04:33 -08:00
Charles Gagnon
4f8ced1f6b
More dangling promise cleanup ( #8518 )
...
* More dangling promise cleanup
* return void
* Function to async
* Fix a couple missed promises
2019-12-02 15:54:33 -08:00
Cory Rivera
8cc60fde90
Add code coverage tests for notebookUtils ( #8524 )
2019-12-02 14:19:37 -08:00
Charles Gagnon
b8bc629970
Add aria labels and consolidate loc strings ( #8494 )
2019-12-02 13:33:24 -08:00
Anthony Dresser
d08fb1aee2
fix upgrade path for new serialization model ( #8489 )
2019-11-27 12:48:54 -08:00
Amir Omidi
5235a1d029
New azure authentication experience ( #8483 )
...
* Changes
* Work in progress
* Authenticate with azure
* enbable national clouds and initialization
* Add support for tenants
* Finish up account work
* Finish up azure auth
* Don't allow prompt if we're not initialized
* Shut down server
* Remove trailing comma
* encode uri component
* ignore errors
* Address comments on github
* Fix issues and disable feature without env var
* Don't encode the nonce
* Only use env variables to disable the new sign in
* Show more user friendly messages to users
2019-11-27 12:33:08 -08:00
Charles Gagnon
3135b8525b
Add styling and component column type to declarative table ( #8476 )
...
* Initial wip
* wip
* Working implementation
* Make widths a bit nicer and remove sqlops addition
* Add sqlops back in
* Fix timing issue with tables
* Undo change to sql.bat and remove loading component when done
2019-11-27 08:06:41 -08:00
Charles Gagnon
0e9797c394
Fix more floating promises ( #8460 )
2019-11-27 08:04:51 -08:00
Anthony Dresser
4145ecfb32
default to using extension of the file for editor replacement ( #8482 )
2019-11-26 14:28:27 -08:00