Alex Ma
ef8164e5c2
Changed connection title generation to use getConnections (including recent and saved). ( #22954 )
...
* remove advanced options for table designer and notebook Actions title (unnecessary in usage context)
* Revert "remove advanced options for table designer and notebook Actions title (unnecessary in usage context)"
This reverts commit e30aee5151319863aebbb4738fb30354c179c2c5.
* added changes based on feedback
* added null check and updated tests
* WIP change to connection title generation
* WIP connection management service update
* fix to connectionManagementService test
* fix editorConnectionTitles
* renamed nondefault to distinguishing options
* use stored connections for options
* removed erroneous connection name set to null
* added title by ID search for title generation
* Add recent connection title
* added fix for stub bug
* added child title options appended
* WIP rework of getEditorTitle
* more work done
* WIP changes for 5-2-2023
* moved server info to generate titles.
* added reworked title generation
* added working active connection title generation and cleanup
* added comments to argument
* remove unnecessary spaces
* added id fix assign
* added fromEditor save
* Revert "Revert new connection string format (#22997 )"
This reverts commit 898bb73a34cmalhotra@microsoft.com >
2023-06-21 09:59:58 -07:00
Vsevolod Kukol
e0d5cd18b9
Support for MongoDB clusters / vCore ( #22512 )
...
* Initial support for MongoDB clusters / vCore
* Get cluster connection string from arm
* Preserve Azure account for any auth type
When a service has been selected through the Azure
browser, we want to preserve the Azure account
information even if a different authentication has
been selected. This allows doing ARM operations
using the signed in Azure account for any resources
including those with a different login types such
as clusters.
2023-06-07 15:38:35 -07:00
Cheena Malhotra
85dcec51ac
Handle error cases properly ( #23322 )
2023-06-06 08:18:49 -07:00
Alan Ren
5356cd7748
fix normal dialog vertical scrolling issue ( #23177 )
2023-05-19 16:51:55 -07:00
Aasim Khan
2beba9ac08
Adding inline actions to OE ( #23101 )
2023-05-13 09:24:49 -07:00
Alex Ma
142a3aaf7c
Added back fix for duplicate edits ( #23003 )
2023-05-11 17:56:42 -07:00
Alan Ren
718b149e84
introduce fieldset component ( #23005 )
2023-05-06 21:36:08 -07:00
Cheena Malhotra
77c8b3bda1
Validate MSAL library is enabled ( #23000 )
2023-05-05 16:44:04 -07:00
Alex Ma
898bb73a34
Revert new connection string format ( #22997 )
2023-05-05 13:41:40 -07:00
Cheena Malhotra
0dc05a6a4c
Hide tenant dropdown from Connection Dialog ( #22973 )
2023-05-05 10:40:00 -07:00
Alan Ren
70e756b82d
fix duplicate required indicator ( #22976 )
2023-05-04 21:53:42 -07:00
Cheena Malhotra
7b2a07befd
Respect 'showDashboard' disabled by default ( #22907 )
2023-05-01 11:55:38 -07:00
Cheena Malhotra
ea6bb41f45
Allow 'ApplicationName' to be specified for MSSQL connections ( #22890 )
2023-05-01 10:55:05 -07:00
Cheena Malhotra
f4952c76b8
Handle no matching account scenario ( #22908 )
2023-05-01 10:54:42 -07:00
Cheena Malhotra
24af5db4a2
Fix resetting tenant when dropdown is not visible ( #22845 )
2023-04-25 12:53:58 -07:00
Cheena Malhotra
a887bb199e
Fix username to respect existing values ( #22837 )
2023-04-24 15:28:44 -07:00
Cheena Malhotra
2247d5de88
Prevent reconnects for mssql provider ( #22825 )
2023-04-21 16:56:40 -07:00
Karl Burtram
e7d3d047ec
Merge from vscode merge-base ( #22780 )
...
* Revert "Revert "Merge from vscode merge-base (#22769 )" (#22779 )"
This reverts commit 47a1745180
2023-04-19 21:48:46 -07:00
Karl Burtram
47a1745180
Revert "Merge from vscode merge-base ( #22769 )" ( #22779 )
...
This reverts commit 6bd0a17d3c
2023-04-18 21:44:05 -07:00
Lewis Sanchez
6bd0a17d3c
Merge from vscode merge-base ( #22769 )
...
* Merge from vscode merge-base
* Turn off basic checks
* Enable compilation, unit, and integration tests
2023-04-18 18:28:58 -07:00
Alex Ma
b69e87df15
Connection URI with complete options (finalized) ( #22735 )
...
* Connection URI made to include every option available instead of basic details (#22045 )
* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"
This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.
* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""
This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.
* Added changes and fixes for feat connectionuri (#22706 )
* add title generation at start
* added await to refreshConnectionTreeTitles
2023-04-18 11:08:48 -07:00
Cheena Malhotra
87571b2706
Support placeholder text for connection dialog options ( #22693 )
2023-04-13 15:08:12 -07:00
Charles Gagnon
df88d881c5
Remove disposable from connection ( #22687 )
...
* Remove disposable from connection
* Remove from group
2023-04-11 15:27:01 -07:00
Aasim Khan
d49ff85afc
Fixing connection without saved password not connecting in Async Server Tree ( #22535 )
2023-03-31 09:19:01 -07:00
Aasim Khan
2a9705c495
Fixing async server tree ( #22511 )
...
* Changing look of new OE
* Fixing styling
* Fixing moving of connected profile
* Fixing drag and drop where treenodes delete connection nodes
* Fixing Deleting and disconnecting in AsyncServerTree
* Adding constant for OE timeout
* Updated interfaces
* Removing test compilation errors
* Fixing most events in async server tree
* Fixing connection pane styling
* Fixing find node function
* Fixing some more operations
* Fixing some ops
* All operations done
* Fixed active connections
* Fixed data source
* Adding support for setting parents
* code cleanup
* Fixing icon styling issues
* Fix errors
* Fixing comment
* Fixing spacing
* Adding explanation to OE service.
* Reverting server delegate changes
* Reverting styling
* reverting more styling change
* reverting more styling
* Fixing has children
* Fixing drag and drop to tree nodes
* fixing drag and drop
* reverting timing
* fixing drag and drop
* cleaning some code
* Fixed server and group moving
* spell check
* consolidating some logic
* Fixed whitespace
* fixing moving to root group
2023-03-29 13:59:35 -07:00
Cheena Malhotra
d5c495f05a
Address Secure enclaves feedback to show required indicator optionally ( #22428 )
2023-03-24 09:57:32 -07:00
Charles Gagnon
ed37ad315f
Clean up buildConnectionInfo ( #22407 )
...
* Clean up buildConnectionInfo
* Add test and cleanup
2023-03-22 12:54:29 -07:00
Cheena Malhotra
a3e77c674c
Address console warnings with new connection dialog ( #22293 )
2023-03-22 12:31:25 -07:00
Vsevolod Kukol
e3135aca4c
Preserve name and group when using Connection String ( #22341 )
2023-03-22 07:55:18 -07:00
Aasim Khan
f9e72b0d93
Fixing connection group change for connections ( #22379 )
2023-03-20 15:37:47 -07:00
Aasim Khan
d3f4f0daa4
Adding light contrast theme ( #22028 )
...
* Adding light contrast theme
* fixing oe icons
* Fixing more files
* Converting ep files to support hc light
* Revert "Copy Headers for Selected Columns (#21622 )"
This reverts commit f74d6f6d9b
2023-03-06 17:31:27 -08:00
Cheena Malhotra
07eb964c32
Fix AuthLibrary detection and use MSAL by default ( #22140 )
2023-03-03 14:33:29 -08:00
Cheena Malhotra
aa350f7e49
Enable SQL Auth Provider support ( #21903 )
2023-03-03 12:49:01 -08:00
Cheena Malhotra
0ac6f40559
Fixes clearing of username/password on auth type change ( #22138 )
2023-03-03 12:45:09 -08:00
Cheena Malhotra
19d77f02dd
Pre-populate username for selected user account (AzureMFAAndUser) ( #22126 )
2023-03-03 12:11:52 -08:00
Christopher Suh
20c290aa91
Better error messages from connection failures in MSAL ( #22065 )
...
* better error messages from connection failures in MSAL\, fix typo
* cleanup
* pr comments
* rename error interface
* address pr comments
* update api
* fix typings
* change one more typing
* fix build
* fix tests
2023-03-02 15:38:12 -08:00
Cheena Malhotra
35f7736b96
Add Secure Enclaves dropdown with customizable Advanced options ( #22019 )
2023-03-01 11:01:50 -08:00
Christopher Suh
6231df85e0
Handle undefined error when opening connection dialog ( #21980 )
...
* handle undefined error when opening connection dialog
* combine into else if
* change log
* update log message
2023-02-17 15:22:51 -08:00
Lewis Sanchez
7c47aea06e
Fix set authenticationType of undefined error ( #21982 )
2023-02-17 15:04:59 -08:00
Cheena Malhotra
66053f5152
Fix missing null ref check causing extension issues ( #21974 )
2023-02-17 09:45:23 -08:00
Cory Rivera
f7fa9bece3
Add a check for an undefined model when creating the connection dialog model. ( #21953 )
2023-02-15 14:23:15 -08:00
Lewis Sanchez
d9b24522e5
Fix missing password in Connection pane for Server connections with remembered passwords ( #21813 )
...
* Fix missing password in Connection pane
* Get saved password for SQL login default auth type
* Clean up
* Fix build hygiene errors
* Captures input
* Add timeout waiting for all promises to resolve
* Add missing semicolon
* Code review feedback
* Minor clean up
* Code review feedback
* Improved error messaging
* Update src/sql/workbench/services/connection/browser/connectionDialogService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Improves UX around loading passwords
* Remove unused import
* Uses await instead of promise chaining.
* Removes async
* Revert back to resolving password promise.
* Asserts controller map and model have values.
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-02-14 20:49:55 -08:00
Cheena Malhotra
3fb8d57d25
Add support for Encrypt=Strict for TDS 8.0 connections with SQL Server 2022 ( #21256 )
2023-02-10 10:34:36 -08:00
Alan Ren
514d599e62
remove client side sorting for db list ( #21899 )
...
* remove client side sorting for db list
* update sts
2023-02-10 09:15:41 -08:00
Cheena Malhotra
66410edf02
Migrate cert validation error handling to mssql extension ( #21829 )
2023-02-07 09:21:35 -08:00
Alex Ma
298402647d
Added error handling service for providers ( #21627 )
...
* added prototype errorHandlerService
* added initial contracts
* Added WIP client sent request function
* added WIP signature for handleOtherError to resourceProviderService
* made some small fixes
* removed unnecessary resourceProviderId
* added updates to contracts and resourceProvider
* moved error codes to azdata proposed
* added connection type instead of profile
* added WIP handleOtherError code
* added fix for send
* added WIP change password function in resource provider
* added work in progress error handling thread
* added errorHandler interface
* added result error check
* renamed errorHandling namespace to diagnostics
* WIP rename of errorhandler
* light cleanup
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/machine-learning (#21514 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437 )
* Debounces second invocation while expanding OE tree items
* Minor clean up
* Adjusts debounce time
* Adding temp trace comments
* Adds missing semicolon
* Removes debouncer to stop 2nd newSession calls
* Removes temp trace comments
* Updates comment
Co-authored-by: Alan Ren <alanren@microsoft.com >
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/admin-tool-ext-win (#21546 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix resource endpoints to end with slash (#21540 )
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/azcli (#21543 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/arc (#21544 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renamed diagnostics service slightly
* registered service
* added work in progress diagnostics implementation
* small changes
* added new diagnostics exe
* Changes for Diagnostics Service (#21583 )
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
* WIP provider changes
* added changes for errorDiagnosticsService
* removed stuff from mssql.
* made fix to connectionManagementService
* added error catch
* added small changes
* more small changes made
* added small changes to handleOtherError
* moved changePassword to CMS
* added testErrorDiagnosticsService
* Added provider-based handling for change password/generic error handling. (#21662 )
* WIP rework for error connection change
* added connectionProfileDuringError
* added working password reset
* added comments
* consolidated connection profile conversion
* added additionalObjects parameter.
* removed unnecessary error profile grab
* added comments
* added changes to parameters and comments
* added changes and params
* added handleConnectionErrorParam
* added more changes
* added async
* added params and more
* added many fixes
* added updated documentation
* added WIP password change dialog with await
* added error handling
* added comment
* added options as parameters
* cleaned up parameters
* added async
* added check fixes
* Added username to title
* added server name to dialog
* Added dialog changes
* Revert "Added dialog changes"
This reverts commit c2bdcd16f4a0dffdc643ef9cae1c1a20642ac512.
* Revert "added server name to dialog"
This reverts commit dbd22e80461b5a068643f0c2d6728adce4010978.
* Revert "Added username to title"
This reverts commit 6d936b4d5f97f9345f8ec2fdbbcf6b52df18820a.
* Revert "added check fixes"
This reverts commit f58081a5af3276766e2042b4d671455b18add9a7.
* Revert "added async"
This reverts commit dd1198e26ec7542ec51add0628f588361d674299.
* Revert "cleaned up parameters"
This reverts commit 51135c9f9db452104697483779d8df15b6430717.
* Revert "added options as parameters"
This reverts commit b167804a2410558bbe60042e017ae2c77af7697f.
* Revert "added comment"
This reverts commit 0ad37326a3e025e88f715e3f2547be6825597a8d.
* Revert "added error handling"
This reverts commit 69340980d2c84056a2bcf126ea77f4b5ed4cddf3.
* Revert "added WIP password change dialog with await"
This reverts commit 9e43113e07b10421b39575f6c7dd14287662b90d.
* added a fix to check
* added fixes
* added back in change password changes
* added in comment
* added suggested changes
* removed param colons
* Update extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* fixed conversion and provider dialog
* altered comments
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* renamed Id
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Improvements for Change password dialog + logs added (#21794 )
* Improvements for Change password dialog + logs added
* Include server
* fixed tab space
* added comment
---------
Co-authored-by: Alex Ma <alma1@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* added fix to id to extHostErrorDiagnostics
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com >
Co-authored-by: Alan Ren <alanren@microsoft.com >
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com >
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-01-31 14:31:12 -08:00
Cheena Malhotra
f43afff8d1
Show tenant dropdown when selecting 'AzureMFA' for first time ( #21763 )
2023-01-27 16:08:11 -08:00
Cheena Malhotra
895b43f36a
Fix account and tenant selection behavior ( #21749 )
2023-01-27 11:47:24 -08:00
Cheena Malhotra
b3acef3124
Add Azure Resource 'Sql' to MSSQL extension. ( #21600 )
2023-01-20 13:08:38 -08:00
Cheena Malhotra
3239bb429f
Null Check for errorNumber ( #21586 )
2023-01-12 18:27:10 -08:00
