Commit Graph

15 Commits

Author SHA1 Message Date
Lewis Sanchez
f51e5c370b Registers all disposable items for query execution plans (#20851) 2022-10-14 14:50:25 -07:00
Aasim Khan
9f5ee32825 Adding new filter icon (#20762) 2022-10-06 21:34:21 -07:00
Lewis Sanchez
f046129515 Adds not equal operator and expands unequal collapsed header rows (#20737)
* Adds not equal operator and expands unequal collapsed prop rows

* Minor clean up.
2022-10-06 13:45:04 -07:00
Lewis Sanchez
65a3bd7491 Shows not equal operator when comparing non-null props to null props (#20740) 2022-10-05 18:49:06 -07:00
Lewis Sanchez
6ea75bb538 Removes summary section from plan comparison properties view (#20735) 2022-10-05 18:48:53 -07:00
Lewis Sanchez
5e48cb99e1 Fixes bug around sorting equal and unequal properties (#20702)
* Fixes bug around sorting equal and unequal properties

* Uses deepClone to deepCopy objects

* Code review changes

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-10-03 23:10:45 -07:00
Lewis Sanchez
7c83739c25 Reorganized Execution Plan Comparison Properties View (#20673)
* Adds summary view to comparison properties view

* Equal rows are collapsed at the bottom of the properties view window

* Variable rename

* Variable rename

* Adds row header for equal properties.

* Adds middle column with diff icon to comparison properties table

* Resolves hygiene issue

* Code review changes

* Fixes undefined error bug

* Adds styles to less than and greater than codicon's

* Changes equivalent properties collapsed header

* Removes unnecessary check

* Integrates alphabetical and importance sorting to equivalency sorting
2022-09-29 13:53:10 -07:00
Aasim Khan
fd8993134f Execution Plan Filtering and UI improvements (#20631)
* Fixing execution plan stuff

* Adding filter to top operations

* Flipped custom zoom icon

* changing keys

* Moving constants to a file

* Search properties

* Making logic concise
2022-09-23 12:57:30 -07:00
Lewis Sanchez
12c5aa0f80 Fixes incorrect operation label when plans are oriented vertically and node selection changes. (#20630)
* Fixes incorrect label when plans are vertical

* Code review changes.

* Adds helper methods to get localized strings

* Helper functions moved to module level

* Renames fields from top and bottom to primary and secondary
2022-09-21 10:40:09 -07:00
Aasim Khan
3f6f6ed07b Changing property header row styling for execution plan properties (#20594) 2022-09-12 17:20:16 -07:00
Aasim Khan
a7a337f063 Adding properties grid enhancements in execution plan (#20208)
* init push

* Fixing properties in plan comparison

* Add long Text Cell viewer

* Disabling auto edit by default

* Removing text editor
2022-08-11 11:22:12 -07:00
Lewis Sanchez
5fbea7a39c Property view labels update when execution plan orientation changes (#19924)
* Updates properties view title when the orientation changes

* Property orientation labels change when the plan orientation changes.

* Renames top and bottom containers to secondary and primary

* Minor clean up

* Removes unnecessary class members

* Promotes constants to module level

* Moves function to module level

* Renames value1 and value2 to primary and secondary

* Replaces orientation string literal type with enum

* Resolves undefined orientation bug

* Removes unused orientation getter

* Updates property table columns only

* Uses orientation enum in editor view and properties view

* Clean up
2022-07-07 13:26:08 -07:00
Aasim Khan
b1d8e43569 Changing plan comparison properties table logic and icons (#19700)
* Changing plan comparison logic and icons

* Removing empty class ref
2022-06-09 14:15:35 -07:00
Aasim Khan
b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Aasim Khan
8bb6b5fc1a Redoing Execution Plan Comparison Editor (#19375)
* Adding code for execution plan comparison editor

* Handling floating promises and fixing a loc string

* Fixing some polygon stuff

* Fixing azdatagraph null check bug

* Adding progress notification for similar areas

* Removing some floating promises

* Fixing button enabled state
2022-05-23 14:33:18 -07:00