Commit Graph

8 Commits

Author SHA1 Message Date
Maddy
b82942a030 show find in notebook when opening from searchResults view (#14447)
* initial changes

* open notebook through our command

* address comments
2021-03-05 10:49:09 -08:00
Charles Gagnon
2d182fcd03 Remove calls to DOM.addClass and DOM.removeClass (#13063) 2020-10-23 14:42:22 -07:00
Arvind Ranasaria
c2ef27cd68 Second batch of tests for notebookEditor class (#10999)
* first few notebookEditor tests

* formating fixes

* unstash previous unfinished work

* saving

* PR feedback

* PR feedback

* copyright fixes

* improve test names and assertion messages

* saving

* PR feedback

* improve test names.

* test name change

* test name change

* remove unneeded cast

* remove spurious comment

* fix misplaced paranthesis - thanks hygiene checker!

* remove unused code

* remove deferredPromise

* createEditor test and dispose fixes

* remove unneeded import

* rempve unnecessary mock usage in dispose test

* use getContainer() for ['parent']

* use getContainer for ['parent']

* remove launch.json edits

* notebookService needs 9th constructor argument

* Add uploading debugging step

* minor changes

* remove changes to ci.yml

* working version

* formatting fixes

* pr fixes

* hygiene and exception path fixes

* remove minor debug changes

* pr feedback

* pr feedback

Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-24 13:19:12 -07:00
Alan Ren
3500ce08cc fix profiler not launch issue (#10757) 2020-06-05 15:41:29 -07:00
Anthony Dresser
8b0b0a029e fix compile 2020-06-01 12:36:41 -07:00
Anthony Dresser
874717fee5 fix testing issues 2020-06-01 12:15:14 -07:00
Maddy
4a87a12ac2 added more tests (#10161)
* added more tests

* typo fixes

* removed unused func

* added an extra assert

* fix typo
2020-04-26 23:34:53 -07:00
ADS Merger
1868a7d370 Merge from vscode 10492ba146318412cbee8b76a8c630f226914734 2020-04-08 06:33:38 +00:00