Lucy Zhang
f96fd911c1
Notebooks: Remove result set summary from saved metadata ( #13616 )
...
* remove result set summary from metadata
* remove batchId and id from celloutputmetadata
* remove extra line
2020-12-07 12:28:07 -08:00
Monica Gupta
4092b6493b
Fix issue with pasting results in Teams ( #13673 )
...
* Fix issue with pasting results in Teams
* Addressed comment to change header tag to th
Co-authored-by: Monica Gupta <mogupt@microsoft.com >
2020-12-04 15:41:53 -08:00
Chris LaFreniere
6349f1bd49
Prevent Table from Disappearing due to exception when looking for tHead ( #13680 )
...
* Prevent exception when tHead doesn't exist at node
* Add test for no thead
2020-12-04 14:42:24 -08:00
Vasu Bhog
048f85d918
Fix notebook unordered grid values after papermill execution ( #13614 )
...
* Fix unordered table
* check entire first row schema:
* SQL Notebooks should not get affected
* delete unused variable and edit comments
* refactor for efficient table ordering
* nit naming
2020-12-03 19:37:22 -06:00
Barbara Valdez
08735c9434
add right padding to notebook toolbar action item ( #13640 )
...
* add right padding to action item
* remove extra line and add space
2020-12-03 10:23:20 -08:00
Monica Gupta
f748a8c7bb
Fix empty column issue ( #13641 )
...
Co-authored-by: Monica Gupta <mogupt@microsoft.com >
2020-12-03 09:32:15 -08:00
Chris LaFreniere
d86e1eec10
WYSIWYG Improvements to highlight ( #13032 )
...
* Improvements to highlight
* wip
* Tests pass
* Leverage escaping mechanism
* Tweak highlight logic
* PR comments
2020-12-02 15:51:40 -08:00
Monica Gupta
397354ebc3
Copy clipboard command in ADS (html/plain text supported) ( #13527 )
...
* draft commit
* few changes
* Changes to copy query with results in plain and html formatting
* undo changes
* undo unintended change
* remove comments
* Addressed comments
* Some clean up
Co-authored-by: Monica Gupta <mogupt@microsoft.com >
2020-11-25 21:08:29 -08:00
Vasu Bhog
2a7b90fd70
Fix WYSIWYG text + image paste ( #13542 )
...
* Fix WYSIWYG text + image paste
* add test for a link and text
2020-11-25 12:42:07 -06:00
Maddy
4b7baa652f
update css to remove extra padding ( #13491 )
2020-11-24 10:47:52 -08:00
Lucy Zhang
aa30b52d03
Notebooks: Fix query results not displaying table rows ( #13488 )
...
* fix PQSQL queries not displaying rows
* comment
* change comment and fix unit test
2020-11-20 15:31:01 -08:00
Justin M
271fe62344
12567 Fixed Notebooks not adding to recent connections ( #13113 )
...
* 12567 Changed tryAddActiveConnection to always add recent connection
* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel
* 12567 Simplified conditional in connectionDialogService
2020-11-16 11:27:09 -08:00
Alan Ren
99e3da5b48
Editable dropdown component improvement ( #13389 )
...
* replace Tree with List
* comments
2020-11-13 13:36:54 -08:00
Charles Gagnon
cbe2ba0901
Add some more logging to ModelView components ( #13387 )
...
* Add some more logging to ModelView components
* Remove catch
* remove unused
2020-11-13 10:30:40 -08:00
Lucy Zhang
32a6385fef
Notebooks: Save cell connection name in cell metadata ( #13208 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* save/read cell connection name to/from metadata
* get started on toggling multi connection mode
* add activeConnection property to cell model
* add changeContext method for cell
* add comments
* add unit test for reading connection name
* save connection mode in metadata
* clean up code
* address PR comments
2020-11-12 10:44:34 -08:00
Lucy Zhang
b397150264
Notebooks: Add smoke test ( #13196 )
...
* add new smoketest
* change repro
* rename methods
* add waitforallresults method
* pr comment
2020-11-10 17:31:17 -08:00
Chris LaFreniere
8c6a966bb9
Re-enable notebook editor unit tests ( #13328 )
...
* wip
* Re-enable notebook editor tests
* PR Feedback
2020-11-10 17:04:30 -08:00
Aditya Bist
8bbcfff119
fix agent types ( #13340 )
2020-11-10 13:38:57 -08:00
Vasu Bhog
7cd4964f35
Fix for < > (non HTML) tags disappearing in WYSIWYG ( #13267 )
...
* Push the latest update for WYSIWYG bug
* Improvements to nested lists
* OL tests and PR feedback
* Fixed all toolbar options for tags
* Address PR comments
* Ensure style is kept and not escaped
* Add all markdown toolbar action tests
* Style text edge case fix
* Address repeat function and type comment
* add more clarifying test
2020-11-09 20:26:28 -06:00
Aditya Bist
9d766198b5
fix connection and notebook icons not highlighting ( #13314 )
2020-11-09 13:12:34 -08:00
Barbara Valdez
3f76d343a5
Table with no headings gets corrupted when editing ( #13293 )
...
* fix data loss issue when modifying table with no headings
* fix comment
* Add tests and extra empty space to empty header format
2020-11-09 09:42:42 -08:00
Aditya Bist
fa9a38d74a
Update/agent ( #13298 )
...
* Revert "Fix Agent not working (#13126 )"
This reverts commit a0ee8b00fb .
* agent fix and bump
2020-11-09 09:00:03 -08:00
Charles Gagnon
8b73391845
Call ModelView base init after view init ( #13261 )
...
* Call ModelView base init after view init
* baseInit to end
2020-11-07 09:41:49 -08:00
Karl Burtram
5e00dcb78c
Update welcome page icon ( #13296 )
2020-11-06 17:06:29 -08:00
Barbara Valdez
e83d3ba57f
Remove button property setter causing exception ( #13284 )
...
* Fix navigation buttons
* Remove icon set in welcome page
2020-11-06 14:49:14 -08:00
Chris LaFreniere
e4390db779
WYSIWYG fix list nesting ( #13251 )
...
* Improvements to nested lists
* OL tests and PR feedback
2020-11-05 18:21:33 -08:00
Maddy
6c37ac56b7
fix delete behavior on text cells. ( #13153 )
...
* remove default <p> text and add css instead
* remove the top/bottom padding on preview markdown
2020-11-05 14:19:11 -08:00
Chris LaFreniere
8877d74034
Check for clientSession before property ( #13198 )
2020-11-04 16:28:59 -08:00
Charles Gagnon
fd8f88db4b
Only show resource viewer on insiders and dev ( #13238 )
2020-11-04 14:34:13 -08:00
Charles Gagnon
a0ee8b00fb
Fix Agent not working ( #13126 )
...
* Fix Agent display
* more fixes
* cleanup
2020-11-04 09:23:16 -08:00
Charles Gagnon
eeb7da4ace
Fix resource viewer grid resizing ( #13197 )
...
* Fix resource viewer grid resizing
* keep height
2020-11-04 08:34:30 -08:00
Lucy Zhang
7bdb7c328a
add unit test for data conversion ( #13190 )
2020-11-03 15:05:57 -08:00
Chris LaFreniere
7559d8463f
Ensure trusted action is enabled ( #13174 )
2020-11-02 10:48:13 -08:00
Charles Gagnon
d7767c7d91
Resource viewer cleanup ( #13168 )
...
* Resource viewer cleanup
* uneeded
* Only show in insiders
2020-10-30 16:48:50 -07:00
Charles Gagnon
3015845093
Add title property for data grid providers ( #13155 )
2020-10-30 15:37:11 -07:00
Charles Gagnon
341f7aa7ad
Enable script to notebook actions under preview flag ( #13164 )
2020-10-30 15:24:35 -07:00
Lucy Zhang
69527f91b0
Notebooks: Save connection information in metadata ( #13060 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
2020-10-30 13:56:33 -07:00
Charles Gagnon
76625012dd
Add Loading Spinner plugin for SlickGrid table ( #13152 )
...
* Add Loading Spinner plugin for SlickGrid table
* better comment
* add aria
* remove
2020-10-30 11:42:22 -07:00
Alan Ren
82d5fe3821
put feature behind preview flag ( #13147 )
...
* put feature behind preview flag
* remove unused import
2020-10-30 10:17:54 -07:00
Amir Omidi
680dc1b5da
Fix #13108 ( #13145 )
2020-10-30 08:19:08 -07:00
Charles Gagnon
7857e8aeb9
Fix filtering for resource viewer ( #13141 )
2020-10-29 17:47:17 -07:00
Charles Gagnon
66da2a46c5
Add support for "More Actions" column in Resource Viewer ( #13093 )
...
* Add support for "More Actions" column in resource viewer
* update provider
* remove import
* Use menu contribution and make actions column always show
* cleanup
* move context menu anchor
* Comments
2020-10-29 10:50:27 -07:00
BranislavGrbicMDCS
9fcd85e640
Adjusting ADS to support new changes for CloudServerType for SQLOD ( #12824 )
...
* Add CodeQL Analysis workflow (#10195 )
* Add CodeQL Analysis workflow
* Fix path
* Adjusting ADS to support new changes for CloudServerType for SQLOD
* Using existing constants instead of hardcoded values
* Updating STS version
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com >
2020-10-29 01:37:42 +01:00
Chris LaFreniere
31817c5494
Fix plotly responsiveness ( #13119 )
2020-10-28 15:40:46 -07:00
v-bbrady
9d776863a1
updates copy ( #13079 )
...
* updates copy
* localizes copy
2020-10-28 14:10:37 -07:00
Lucy Zhang
86357b45b0
Notebooks: re-factor grid streaming ( #12937 )
...
* refactor grid streaming (convert to data first)
* change convertRowsToHtml method to return value
* remove griddataconversioncomplete checks
* send row data from STS to gridoutput component
* clean up code
* send data updates to cell model
* serialize cell output at the end of cell execution
* remove unused parameters
* update output contents instead of output reference
* remove unnecessary promise
* move azdata changes to proposed
* update comment
2020-10-28 09:08:15 -07:00
Aasim Khan
f9d34cb18b
Changed the welcome screen text for deploy ( #13086 )
2020-10-27 08:26:37 -07:00
Charles Gagnon
c2bd11fa9e
Add error logging when fetching account provider accounts ( #13082 )
...
* Add error logging when fetching account provider accounts
* fix test
* fix tests #2
2020-10-26 16:06:55 -07:00
Charles Gagnon
791dee1457
Update query editor taskbar on language flavor change ( #13057 )
2020-10-26 15:29:34 -07:00
Charles Gagnon
ff45bdd072
Add hyperlink support to DataGrid columns ( #13061 )
...
* Add hyperlink support to DataGrid columns
* pr feedback
* Remove unused aria label
* fix error message display
* fix compile
2020-10-26 08:43:09 -07:00