ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-25 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,514 Commits 1 Branch 152 Tags
ffdde0209ba67f7f67f3d4c05ecaea17c936b80e
Commit Graph

276 Commits

Author SHA1 Message Date
Maddy
b8ad7e3072 Updates to package.json to show books on stable (#7836) 
* Updates to package.json to show books on stable

* remove notebookQuality context key

* renamed untitiled to unsaved
 2019-10-21 14:26:59 -07:00
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837) 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
 2019-10-21 12:02:30 -07:00
Chris LaFreniere
2ee3840650 First improvements for SQL Cell Looping (#7733) 
* First improvements

* clear results

* cleanup

* error handling
 2019-10-18 17:12:10 -07:00
Amir Omidi
74396c1558 Rename icon to codicon #7709 (#7710) 2019-10-13 22:24:52 -07:00
Charles Gagnon
2aa7a145d4 Fix connection group input not correctly selecting nested groups (#7625) 2019-10-10 11:21:13 -07:00
Charles Gagnon
e4e71af597 Fix all await-promise tslint errors (#7530) 
* Fix all await-promise tslint errors

* Remove unnecessary await
 2019-10-07 17:52:01 -07:00
Amir Omidi
857c658888 cleanup promises and async (#7169) 2019-10-07 15:30:38 -07:00
Euler
ac87346507 Prevent connections from moving on click (#7528) 2019-10-07 08:49:05 -07:00
Anthony Dresser
07109617b5 Merge from vscode e0762af258c0b20320ed03f3871a41967acc4421 (#7404) 
* Merge from vscode e0762af258c0b20320ed03f3871a41967acc4421

* readd svgs
 2019-09-27 11:13:19 -07:00
Anthony Dresser
db498db0a8 Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f (#7282) 
* Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f

* fix various icon issues

* fix preview features
 2019-09-19 21:50:52 -07:00
Anthony Dresser
aad9c0f965 Add more areas to strict null (#7243) 
* add more areas to strict null

* fix compile errors

* fix tests

* fix checks

* address PR comments
 2019-09-18 12:27:19 -07:00
Cory Rivera
094d6f2339 Update python packages to use sparkmagic 0.12.9 (#7240) 2019-09-17 15:05:59 -07:00
Anthony Dresser
ea0f9e6ce9 Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 (#7206) 
* Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463

* fix config changes

* fix strictnull checks
 2019-09-15 22:38:26 -07:00
Anthony Dresser
d9c5b7ea9e Clean up some more disposable usage (#7190) 
* clean up some more disposable usage

* fix a bug

* add more to register
 2019-09-13 12:28:33 -07:00
Anthony Dresser
823d136a00 No browser from common (#7178) 
* no browser from common

* clean up some imports
 2019-09-12 14:52:42 -07:00
Anthony Dresser
02f497712d clean up some promise use in cms (#7004) 2019-09-06 15:58:47 -07:00
Amir Omidi
33a7fe38e1 Revert "Revert "OE clicking and awaiting the expansion calls"" (#6923) 
* Revert "Revert "OE clicking and awaiting the expansion calls" (#6921)"

This reverts commit b9e3a468ae.

* Handle edge cases better

* Polling for OE load time
 2019-09-03 10:31:29 -07:00
Chris LaFreniere
84b3e876d7 Notebook Performance Improvements to Cell Editing/Output Changes/Execution Count Changes (#6867) 
* edit perf

* Save multiline source in notebooks

* More merges

* Single, multi line works needs work

* Works with single + multi and recomputes active

* Actual perf improvements this time

* code cleanup

* Calculating output position on the fly

* Hmm can we use brackets to make this simpler?

* monday progress

* output working. lots of improvements.

* First tests working

* 10 tests now, fixed bugs

* Cleanup, add output test

* More fixes

* Need to still fix execution count bug

* Tests pass, added comments

* Cleanup

* PR comments round 1

* Deal with merge issues from master, layering

* Deleting duplicate file

* More PR Comments

* PR Comments
 2019-08-26 10:17:58 -07:00
Charles Gagnon
b9e3a468ae Revert "OE clicking and awaiting the expansion calls" (#6921) 2019-08-23 15:27:05 -07:00
Anthony Dresser
5b9a08359d remove circular dependency between server group and connection management (#6916) 2019-08-23 14:53:54 -07:00
Alan Ren
9b7a7bd9dc Alanren/extension install (#6918) 
* fix extension install

* fix azure account open url issue
 2019-08-23 14:50:08 -07:00
Anthony Dresser
26a22fa00e fix off by 1 error (#6886) 2019-08-22 16:07:02 -07:00
Amir Omidi
ab9c4e0cbd Revert "Revert "OE clicking and awaiting the expansion calls (#6761)" (#6866)" (#6875) 
This reverts commit a8d831d32e.
 2019-08-22 13:16:39 -07:00
Anthony Dresser
8e070454c3 Global object linting (#6857) 
* add more linting

* fix linting issues
 2019-08-22 10:51:59 -07:00
Amir Omidi
a8d831d32e Revert "OE clicking and awaiting the expansion calls (#6761)" (#6866) 
This reverts commit b731c56076.
 2019-08-21 22:21:54 -07:00
Anthony Dresser
985bfae8a0 Merge from vscode e558dc6ea73a75bd69d7a0b485f0e7e4194c66bf (#6864) 2019-08-21 20:44:59 -07:00
Amir Omidi
b731c56076 OE clicking and awaiting the expansion calls (#6761) 
* Server selection with proper awaits

* Handle keyboard clicks immedietely.

* Clean up the event a little more

* Eat the event if its not mouse or keyboard
 2019-08-21 10:25:52 -07:00
Chris LaFreniere
54cf062737 Fix Notebook Connection Issues (#6831) 2019-08-20 13:40:15 -07:00
Udeesha Gautam
c513204501 Bug/accessibility 1 (#6774) 
* fixing simple name changes

* Fixing button color and tabbing on tabs

* removing some extra lines of code

* Adding some null checks

* Updating as per PR comments
 2019-08-20 10:11:34 -07:00
Benjin Dubishar
77bf228809 Improve narration for backup and dacpac UIs (#6783) 
* Added ability to specify aria-rowcount and -colcount to tables.

* Cleanup

* Adds aria role to table container so that screen-readers ignore it
 2019-08-19 16:51:38 -07:00
Anthony Dresser
7f6839d38e change how we detect if a untitled query is valid (#6776) 2019-08-17 14:44:16 -07:00
Anthony Dresser
4966ed8b42 Strict Null Checks on platform/accounts (#6735) 
* add some patches for strict null

* renable strict null checks

* wip

* finish adding account to strict nulls

* fix backup component

* wip

* fix tests
 2019-08-14 20:26:21 -07:00
Kevin Cunnane
fdac1d5382 Re-add AD auth for SQL big data cluster (#6759) 
* Revert "Revert "Initial AD support for BDCs (#6741)" as it breaks linux (#6758)"

This reverts commit 51660b25ef.

* Install kerberos package on linux
 2019-08-14 20:19:31 -07:00
Kevin Cunnane
51660b25ef Revert "Initial AD support for BDCs (#6741)" as it breaks linux (#6758) 
This reverts commit 52f8984a99.
 2019-08-14 19:16:52 -07:00
Kevin Cunnane
52f8984a99 Initial AD support for BDCs (#6741) 
Partially working AD support for BDCs with some known issues
- Plumbed through kerberos support to Notebooks.
  - Using "gateway-0" for service temporarily as service endpoints API doesn't yet return correct DNS name. Will update in separate PR once available
- Plumbed kerberos auth to HDFS, Spark. Only partially working as we use same token on each call 
  - Will fix in separate PR, as this requires a refactor of WebHDFS library. Will need to either get new token every time or set a cookie, both of which require refactors
- Fixed error when Data Service node expansion failed and blocked all OE expansion
- Support for SqlToolsService change to use new cluster endpoints DMV
  -  Updated API to add new endpoints field to replace IP + port
  - Added logic to handle case where endpoints for Yarn, Grafana etc. are in the list
  - Sort list and use expected new localized strings

- Updated SqlToolsService to include support for new DMV
- Add "gateway-0" handling in Jupyter session as workaround for lack of domain names in endpoints list
 2019-08-14 18:09:41 -07:00
Anthony Dresser
66adfb6524 Revert "Remove references to query model service in query code (#6513)" (#6591) 
This reverts commit 674351dc75.
 2019-08-05 11:42:54 -07:00
Charles Gagnon
8a6dc02e5b Change double-quote hygiene rule to tslint rule (#6514) 2019-08-05 09:46:22 -07:00
Anthony Dresser
674351dc75 Remove references to query model service in query code (#6513) 
* remove references of query model service from query code

* fix tests

* clean up the code
 2019-08-03 01:26:58 -07:00
Chris LaFreniere
402b50c03b Notebooks: Use much faster json parser when loading notebook initially (#6552) 
* Use much faster json parser

* fallback to old json parser
 2019-08-02 17:23:49 -07:00
Anthony Dresser
9bfe8813b1 More layering (#6541) 
* layer unlayered code; fix layering

* readd os

* fix definition of recommended extensions

* protect against tests
 2019-07-31 22:20:39 -07:00
Anthony Dresser
c1acf6ae93 More work around isolating node imports (#6512) 
* more work around isolating node imports

* rewrite query plan input

* fix hygiene errors

* fix tests

* address feedback

* remove welcome page changes
 2019-07-30 14:01:37 -07:00
Anthony Dresser
c99ce4de07 Move command line parsing to be a workbench contribution (#6524) 
* move command line parsing to be a workbench contribution

* move to electron-browser

* update variable names
 2019-07-30 12:44:15 -07:00
Anthony Dresser
6db84eefa3 Merge from vscode 6268feb42ba4f2e2fa15484e88c9af60d254998c (#6530) 2019-07-29 21:03:02 -07:00
Charles Gagnon
86cde4c511 Fix some connection listener leaks (#6357) 
* Fix some connection listener leaks

* More descriptive name and update summary

* Dispose some more connections and fix a few spelling errors
 2019-07-29 11:00:11 -07:00
Anthony Dresser
371504358d refactor notebook to be fileservice based (#6459) 2019-07-26 22:19:13 -07:00
Chris LaFreniere
d51bdbd094 Save multiline source in notebooks (#6445) 
* Save multiline source in notebooks

* Stop demultiline localContentManager unnecessarily
 2019-07-26 10:30:52 -07:00
Charles Gagnon
b2b2840990 Add double quotes for localize hygiene check (#6492) 
* Add localize single quote hygiene task

* Update localize calls

* Update comment

* Fix build failures and remove test code
 2019-07-25 10:35:14 -07:00
Anthony Dresser
c23738f935 Inital platform relayering (#6385) 
* moving test files and inital refactoring

* relayer extension host code

* fix imports

* make insights work

* relayer dashboard

* relayer notebooks

* moveing more code around

* formatting

* accept angular as browser

* fix serializer

* add missing files

* remove declarations from extensions

* fix build errors

* more relayering

* change urls to relative to help code relayering

* remove layering to prep for merge

* fix hygiene errors

* fix hygiene errors

* fix tests
 2019-07-18 17:29:17 -07:00
Lucy Zhang
45c13116de Move books to insiders (#6428) 
* move books to insiders

* move to insiders

* changed context key for nav buttons

* fixed nav buttons

* check product.quality
 2019-07-18 16:35:28 -07:00
Lucy Zhang
43bd7268e8 hide nav buttons for non-book notebooks (#6377) 
* hide nav buttons for non-book notebooks

* updated buttons for all themes

* changed foregroundColor to buttonForegroundColor
 2019-07-16 16:26:03 -07:00