Bump SQL Tools to 1.5.0-alpha.52

* fix input to chart that was causes scales to not auto size

* formatting

* formatting

* added comments

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,10 +1,6 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
-labels: ''
-assignees: ''
-
 ---
 
 <!-- Please search existing issues to avoid creating duplicates. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: ''
-labels: feature request
-assignees: ''
-
----
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution or feature you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.

.travis.yml

@@ -0,0 +1,58 @@
+sudo: false
+language: cpp
+
+os:
+  - linux
+  - osx
+
+cache:
+  directories:
+    - $HOME/.cache/yarn
+
+notifications:
+  email: false
+  webhooks:
+    - http://vscode-probot.westus.cloudapp.azure.com:3450/travis/notifications
+    - http://vscode-test-probot.westus.cloudapp.azure.com:3450/travis/notifications
+
+addons:
+  apt:
+    sources:
+      - ubuntu-toolchain-r-test
+    packages:
+      - gcc-4.9
+      - g++-4.9
+      - gcc-4.9-multilib
+      - g++-4.9-multilib
+      - zip
+      - libgtk2.0-0
+      - libx11-dev
+      - libxkbfile-dev
+      - libsecret-1-dev
+
+before_install:
+  - git submodule update --init --recursive
+  - nvm install 8.9.1
+  - nvm use 8.9.1
+  - npm i -g yarn
+  # - npm config set python `which python`
+  - if [ $TRAVIS_OS_NAME == "linux" ]; then
+      export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0;
+      sh -e /etc/init.d/xvfb start;
+      sleep 3;
+    fi
+  # Make npm logs less verbose
+  # - npm config set depth 0
+  # - npm config set loglevel warn
+
+install:
+  - yarn
+
+script:
+  - node_modules/.bin/gulp electron --silent
+  - node_modules/.bin/gulp compile --silent --max_old_space_size=4096
+  - node_modules/.bin/gulp optimize-vscode --silent --max_old_space_size=4096
+  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then ./scripts/test.sh --coverage --reporter dot; else ./scripts/test.sh --reporter dot; fi
+
+after_success:
+  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then node_modules/.bin/coveralls < .build/coverage/lcov.info; fi

.vscode/launch.json

@@ -92,30 +92,6 @@
 			"webRoot": "${workspaceFolder}",
 			"timeout": 45000
 		},
-		{
-			"type": "chrome",
-			"request": "launch",
-			"name": "Launch azuredatastudio with new notebook command",
-			"windows": {
-				"runtimeExecutable": "${workspaceFolder}/scripts/sql.bat"
-			},
-			"osx": {
-				"runtimeExecutable": "${workspaceFolder}/scripts/sql.sh"
-			},
-			"linux": {
-				"runtimeExecutable": "${workspaceFolder}/scripts/sql.sh"
-			},
-			"urlFilter": "*index.html*",
-			"runtimeArgs": [
-				"--inspect=5875",
-				"--command=notebook.command.new"
-			],
-			"skipFiles": [
-				"**/winjs*.js"
-			],
-			"webRoot": "${workspaceFolder}",
-			"timeout": 45000
-		},
 		{
 			"type": "node",
 			"request": "launch",

CHANGELOG.md

@@ -1,50 +1,5 @@
 # Change Log
 
-## Version 1.3.8
-* Release date: January 9, 2019
-* Release status: General Availability
-
-## What's new in this version
-* #13 Feature Request: Azure Active Directory Authentication
-* #1040 Stream initial query results as they become available
-* #3298 Сan't add an azure account.
-* #2387 Support Per-User Installer
-* SQL Server Import updates for DACPAC\BACPAC
-* SQL Server Profiler UI and UX improvements
-* Updates to [SQL Server 2019 extension](https://docs.microsoft.com/sql/azure-data-studio/sql-server-2019-extension?view=sql-server-ver15)
-* **sp_executesql to SQL** and **New Database** extensions
-
-## Contributions and "thank you"
-We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
-
-* Tarig0  for `Add Routine_Type to CreateStoredProc fixes #3257 (#3286)`
-* oltruong  for `typo fix #3025'`
-* Thomas-S-B for `Removed unnecessary IErrorDetectionStrategy #749`
-* Thomas-S-B for `Simplified code #750`
-
-## Version 1.2.4
-* Release date: November 6, 2018
-* Release status: General Availability
-
-## What's new in this version
-* Update to the SQL Server 2019 Preview extension
-* Introducing Paste the Plan extension
-* Introducing High Color queries extension, including SSMS editor theme
-* Fixes in SQL Server Agent, Profiler, and Import extensions
-* Fix .Net Core Socket KeepAlive issue causing dropped inactive connections on macOS
-* Upgrade SQL Tools Service to .Net Core 2.2 Preview 3 (for eventual AAD support)
-* Fix customer reported GitHub issues
-
-## Contributions and "thank you"
-We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
-
-* rdaniels6813  for `Add query plan theme support #3031`
-* Ruturaj123 for `Fixed some typos and grammatical errors #3027`
-* PromoFaux for `Use emoji shortcodes in CONTRIBUTING.md instead of <20> #3009`
-* ckaczor for `Fix: DATETIMEOFFSET data types should be ISO formatted #714`
-* hi-im-T0dd for `Fixed sync issue with my forked master so this commit is correct #2948`
-* hi-im-T0dd for `Fixed when right clicking and selecting Manage-correct name displays #2794`
-
 ## Version 1.1.3
 * Release date: October 18, 2018
 * Release status: General Availability

README.md

@@ -1,7 +1,6 @@
 # Azure Data Studio
 
 [![Join the chat at https://gitter.im/Microsoft/sqlopsstudio](https://badges.gitter.im/Microsoft/sqlopsstudio.svg)](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![Build Status](https://dev.azure.com/ms/azuredatastudio/_apis/build/status/Microsoft.azuredatastudio)](https://dev.azure.com/ms/azuredatastudio/_build/latest?definitionId=4)
 
 Azure Data Studio is a data management tool that enables you to work with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.
 
@@ -9,13 +8,12 @@ Azure Data Studio is a data management tool that enables you to work with SQL Se
 
 Platform | Link
 -- | --
-Windows User Installer | https://go.microsoft.com/fwlink/?linkid=2049972
-Windows System Installer | https://go.microsoft.com/fwlink/?linkid=2049975
-Windows ZIP | https://go.microsoft.com/fwlink/?linkid=2050146
-macOS ZIP | https://go.microsoft.com/fwlink/?linkid=2049981
-Linux TAR.GZ | https://go.microsoft.com/fwlink/?linkid=2049986
-Linux RPM | https://go.microsoft.com/fwlink/?linkid=2049989
-Linux DEB | https://go.microsoft.com/fwlink/?linkid=2050157
+Windows Setup Installer | https://go.microsoft.com/fwlink/?linkid=2030731
+Windows ZIP | https://go.microsoft.com/fwlink/?linkid=2030736
+macOS ZIP | https://go.microsoft.com/fwlink/?linkid=2030738
+Linux TAR.GZ | https://go.microsoft.com/fwlink/?linkid=2030741
+Linux RPM | https://go.microsoft.com/fwlink/?linkid=2030746
+Linux DEB | https://go.microsoft.com/fwlink/?linkid=2030750
 
 Go to our [download page](https://aka.ms/azuredatastudio) for more specific instructions.
 
@@ -63,16 +61,6 @@ The [Microsoft Enterprise and Developer Privacy Statement](https://privacy.micro
 ## Contributions and "Thank You"
 We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
 
-* Tarig0  for `Add Routine_Type to CreateStoredProc fixes #3257 (#3286)`
-* oltruong  for `typo fix #3025'`
-* Thomas-S-B for `Removed unnecessary IErrorDetectionStrategy #749`
-* Thomas-S-B for `Simplified code #750`
-* rdaniels6813  for `Add query plan theme support #3031`
-* Ruturaj123 for `Fixed some typos and grammatical errors #3027`
-* PromoFaux for `Use emoji shortcodes in CONTRIBUTING.md instead of <20> #3009`
-* ckaczor for `Fix: DATETIMEOFFSET data types should be ISO formatted #714`
-* hi-im-T0dd for `Fixed sync issue with my forked master so this commit is correct #2948`
-* hi-im-T0dd for `Fixed when right clicking and selecting Manage-correct name displays #2794`
 * philoushka  for `center the icon #2760`
 * anthonypants for `Typo #2775`
 * kstolte for `Fix Invalid Configuration in Launch.json #2789`
@@ -115,6 +103,7 @@ We would like to thank all our users who raised issues, and in particular the fo
   * Russian: Andrey Veselov, Anton Fontanov, Anton Savin, Elena Ostrovskaia, Igor Babichev, Maxim Zelensky, Rodion Fedechkin, Tasha T, Vladimir Zyryanov
   * Portuguese Brazil: Daniel de Sousa, Diogo Duarte, Douglas Correa, Douglas Eccker, José Emanuel Mendes, Marcelo Fernandes, Marcondes Alexandre, Roberto Fonseca, Rodrigo Crespi
 
+
 And of course, we'd like to thank the authors of all upstream dependencies.  Please see a full list in the [ThirdPartyNotices.txt](https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/ThirdPartyNotices.txt)
 
 ## License

ThirdPartyNotices.txt

@@ -34,7 +34,6 @@ expressly granted herein, whether by implication, estoppel or otherwise.
     jquery-ui: https://github.com/jquery/jquery-ui
     jquery.event.drag: https://github.com/devongovett/jquery.event.drag
     jschardet: https://github.com/aadsm/jschardet
-    JupyterLab: https://github.com/jupyterlab/jupyterlab
     make-error: https://github.com/JsCommunity/make-error
     minimist: https://github.com/substack/minimist
     moment: https://github.com/moment/moment
@@ -1167,43 +1166,6 @@ That's all there is to it!
 =========================================
 END OF jschardet NOTICES AND INFORMATION
 
-%% JupyterLab NOTICES AND INFORMATION BEGIN HERE
-Copyright (c) 2015 Project Jupyter Contributors
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this
-   list of conditions and the following disclaimer.
-
-2. Redistributions in binary form must reproduce the above copyright notice,
-   this list of conditions and the following disclaimer in the documentation
-   and/or other materials provided with the distribution.
-
-3. Neither the name of the copyright holder nor the names of its
-   contributors may be used to endorse or promote products derived from
-   this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
-SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-Semver File License
-===================
-
-The semver.py file is from https://github.com/podhmo/python-semver
-which is licensed under the "MIT" license.  See the semver.py file for details.
-
-END OF JupyterLab NOTICES AND INFORMATION
-
 %% make-error NOTICES AND INFORMATION BEGIN HERE
 =========================================
 ISC © Julien Fontanet

appveyor.yml

@@ -0,0 +1,19 @@
+environment:
+  ELECTRON_RUN_AS_NODE: 1
+  VSCODE_BUILD_VERBOSE: true
+
+cache:
+  - '%LOCALAPPDATA%\Yarn\cache'
+
+install:
+  - ps: Install-Product node 8.9.1 x64
+
+build_script:
+  - yarn
+  - .\node_modules\.bin\gulp electron
+  - npm run compile
+
+test_script:
+  - node --version
+  - .\scripts\test.bat
+  - .\scripts\test-integration.bat

azure-pipelines-linux-mac.yml

@@ -1,42 +0,0 @@
-steps:
-- task: NodeTool@0
-  inputs:
-    versionSpec: '8.x'
-  displayName: 'Install Node.js'
-
-- script: |
-    git submodule update --init --recursive
-    nvm install 8.9.1
-    nvm use 8.9.1
-    npm i -g yarn
-  displayName: 'preinstall'
-
-- script: |
-    export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
-    sh -e /etc/init.d/xvfb start
-    sleep 3
-  displayName: 'Linux preinstall'
-  condition: eq(variables['Agent.OS'], 'Linux')
-
-- script: |
-    yarn
-  displayName:  'Install'
-
-- script: |
-    node_modules/.bin/gulp electron --silent
-    node_modules/.bin/gulp compile --silent --max_old_space_size=4096
-    node_modules/.bin/gulp optimize-vscode --silent --max_old_space_size=4096
-  displayName: 'Scripts'
-
-- script: |
-    ./scripts/test.sh --reporter mocha-junit-reporter
-  displayName: 'Tests'
-
-- task: PublishTestResults@2
-  inputs:
-    testResultsFiles: '**/test-results.xml'
-  condition: succeededOrFailed()
-
-- script: |
-    yarn run tslint
-  displayName: 'Run TSLint'

azure-pipelines-windows.yml

@@ -1,30 +0,0 @@
-steps:
-- task: NodeTool@0
-  inputs:
-    versionSpec: '8.9'
-  displayName: 'Install Node.js'
-
-- script: |
-    yarn
-  displayName: 'Yarn Install'
-
-- script: |
-    .\node_modules\.bin\gulp electron
-  displayName: 'Electron'
-
-- script: |
-    npm run compile
-  displayName: 'Compile'
-
-- script: |
-    .\scripts\test.bat --reporter mocha-junit-reporter
-  displayName: 'Test'
-
-- task: PublishTestResults@2
-  inputs:
-    testResultsFiles: 'test-results.xml'
-  condition: succeededOrFailed()
-
-- script: |
-    yarn run tslint
-  displayName: 'Run TSLint'

azure-pipelines.yml

@@ -1,29 +0,0 @@
-trigger:
-- master
-- releases/*
-
-jobs:
-
-# All tasks on Windows
-- job: build_all_windows
-  displayName: Build all tasks (Windows)
-  pool:
-    vmImage: vs2017-win2016
-  steps:
-  - template: azure-pipelines-windows.yml
-
-# All tasks on Linux
-- job: build_all_linux
-  displayName: Build all tasks (Linux)
-  pool:
-    vmImage: 'Ubuntu 16.04'
-  steps:
-  - template: azure-pipelines-linux-mac.yml
-
-# All tasks on macOS
-- job: build_all_darwin
-  displayName: Build all tasks (macOS)
-  pool:
-    vmImage: macos-10.13
-  steps:
-  - template: azure-pipelines-linux-mac.yml

build/gulpfile.vscode.js

@@ -129,7 +129,6 @@ const vscodeResources = [
 	'out-build/sql/parts/jobManagement/common/media/*.svg',
 	'out-build/sql/media/objectTypes/*.svg',
 	'out-build/sql/media/icons/*.svg',
-	'out-build/sql/parts/notebook/media/**/*.svg',
 	'!**/test/**'
 ];
 

build/package.json

@@ -9,21 +9,20 @@
     "@types/mime": "0.0.29",
     "@types/minimatch": "^3.0.3",
     "@types/node": "8.0.33",
-    "@types/request": "^2.47.0",
     "@types/xml2js": "0.0.33",
+    "@types/request": "^2.47.0",
     "azure-storage": "^2.1.0",
     "decompress": "^4.2.0",
-    "del": "^3.0.0",
     "documentdb": "1.13.0",
+    "service-downloader": "github:anthonydresser/service-downloader#0.1.5",
     "fs-extra-promise": "^1.0.1",
-    "github-releases": "^0.4.1",
     "mime": "^1.3.4",
     "minimist": "^1.2.0",
-    "request": "^2.85.0",
-    "service-downloader": "github:anthonydresser/service-downloader#0.1.5",
     "typescript": "2.9.2",
     "vscode": "^1.0.1",
-    "xml2js": "^0.4.17"
+    "xml2js": "^0.4.17",
+    "github-releases": "^0.4.1",
+    "request": "^2.85.0"
   },
   "scripts": {
     "compile": "tsc -p tsconfig.build.json",
@@ -31,4 +30,4 @@
     "postinstall": "npm run compile",
     "npmCheckJs": "tsc --noEmit"
   }
-}
+}

build/win32/code.iss

@@ -91,17 +91,17 @@ Filename: "{app}\{#ExeBasename}.exe"; Description: "{cm:LaunchProgram,{#NameLong
 #else
 #define SoftwareClassesRootKey "HKLM"
 #endif
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}SourceFile"; ValueType: string; ValueName: ""; ValueData: "{cm:SourceFile,{#NameLong}}"; Flags: uninsdeletekey
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}SourceFile\DefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}\resources\app\resources\win32\code_file.ico"
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}SourceFile\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#ExeBasename}.exe"" ""%1"""
+Root: HKCR; Subkey: "{#RegValueName}SourceFile"; ValueType: string; ValueName: ""; ValueData: "{cm:SourceFile,{#NameLong}}"; Flags: uninsdeletekey
+Root: HKCR; Subkey: "{#RegValueName}SourceFile\DefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}\resources\app\resources\win32\code_file.ico"
+Root: HKCR; Subkey: "{#RegValueName}SourceFile\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#ExeBasename}.exe"" ""%1"""
 Root: HKCU; Subkey: "Environment"; ValueType: expandsz; ValueName: "Path"; ValueData: "{olddata};{app}\bin"; Tasks: addtopath; Check: NeedsAddPath(ExpandConstant('{app}\bin'))
 
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\.sql\OpenWithProgids"; ValueType: none; ValueName: "{#RegValueName}"; Flags: deletevalue uninsdeletevalue; Tasks: associatewithfiles
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\.sql\OpenWithProgids"; ValueType: string; ValueName: "{#RegValueName}.sql"; ValueData: ""; Flags: uninsdeletevalue; Tasks: associatewithfiles
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}.sql"; ValueType: string; ValueName: ""; ValueData: "{cm:SourceFile,SQL}"; Flags: uninsdeletekey; Tasks: associatewithfiles
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}.sql"; ValueType: string; ValueName: "AppUserModelID"; ValueData: "{#AppUserId}"; Flags: uninsdeletekey; Tasks: associatewithfiles
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}.sql\DefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}\resources\app\resources\win32\code_file.ico"; Tasks: associatewithfiles
-Root: {#SoftwareClassesRootKey}; Subkey: "Software\Classes\{#RegValueName}.sql\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#ExeBasename}.exe"" ""%1"""; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\.sql\OpenWithProgids"; ValueType: none; ValueName: "{#RegValueName}"; Flags: deletevalue uninsdeletevalue; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\.sql\OpenWithProgids"; ValueType: string; ValueName: "{#RegValueName}.sql"; ValueData: ""; Flags: uninsdeletevalue; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\{#RegValueName}.sql"; ValueType: string; ValueName: ""; ValueData: "{cm:SourceFile,SQL}"; Flags: uninsdeletekey; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\{#RegValueName}.sql"; ValueType: string; ValueName: "AppUserModelID"; ValueData: "{#AppUserId}"; Flags: uninsdeletekey; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\{#RegValueName}.sql\DefaultIcon"; ValueType: string; ValueName: ""; ValueData: "{app}\resources\app\resources\win32\code_file.ico"; Tasks: associatewithfiles
+Root: HKCU; Subkey: "Software\Classes\{#RegValueName}.sql\shell\open\command"; ValueType: string; ValueName: ""; ValueData: """{app}\{#ExeBasename}.exe"" ""%1"""; Tasks: associatewithfiles
 ; Environment
 #if "user" == InstallTarget
 #define EnvironmentRootKey "HKCU"

build/yarn.lock

@@ -46,7 +46,6 @@
 "@types/minimatch@^3.0.3":
   version "3.0.3"
   resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.3.tgz#3dca0e3f33b200fc7d1139c0cd96c1268cadfd9d"
-  integrity sha512-tHq6qdbT9U1IRSGf14CL0pUlULksvY9OZ+5eEgl1N7t+OA3tGvNpxJCzuKQlsNgCVwbAs670L1vcVQi8j9HjnA==
 
 "@types/node@*":
   version "8.0.51"
@@ -571,18 +570,6 @@ deep-assign@^1.0.0:
   dependencies:
     is-obj "^1.0.0"
 
-del@^3.0.0:
-  version "3.0.0"
-  resolved "https://registry.yarnpkg.com/del/-/del-3.0.0.tgz#53ecf699ffcbcb39637691ab13baf160819766e5"
-  integrity sha1-U+z2mf/LyzljdpGrE7rxYIGXZuU=
-  dependencies:
-    globby "^6.1.0"
-    is-path-cwd "^1.0.0"
-    is-path-in-cwd "^1.0.0"
-    p-map "^1.1.1"
-    pify "^3.0.0"
-    rimraf "^2.2.8"
-
 delayed-stream@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619"
@@ -954,29 +941,6 @@ glob@^5.0.3:
     once "^1.3.0"
     path-is-absolute "^1.0.0"
 
-glob@^7.0.3:
-  version "7.1.3"
-  resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.3.tgz#3960832d3f1574108342dafd3a67b332c0969df1"
-  integrity sha512-vcfuiIxogLV4DlGBHIUOwI0IbrJ8HWPc4MU7HzviGeNho/UJDfi6B5p3sHeWIQ0KGIU0Jpxi5ZHxemQfLkkAwQ==
-  dependencies:
-    fs.realpath "^1.0.0"
-    inflight "^1.0.4"
-    inherits "2"
-    minimatch "^3.0.4"
-    once "^1.3.0"
-    path-is-absolute "^1.0.0"
-
-globby@^6.1.0:
-  version "6.1.0"
-  resolved "https://registry.yarnpkg.com/globby/-/globby-6.1.0.tgz#f5a6d70e8395e21c858fb0489d64df02424d506c"
-  integrity sha1-9abXDoOV4hyFj7BInWTfAkJNUGw=
-  dependencies:
-    array-union "^1.0.1"
-    glob "^7.0.3"
-    object-assign "^4.0.1"
-    pify "^2.0.0"
-    pinkie-promise "^2.0.0"
-
 glogg@^1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/glogg/-/glogg-1.0.1.tgz#dcf758e44789cc3f3d32c1f3562a3676e6a34810"
@@ -1348,25 +1312,6 @@ is-obj@^1.0.0:
   resolved "https://registry.yarnpkg.com/is-obj/-/is-obj-1.0.1.tgz#3e4729ac1f5fde025cd7d83a896dab9f4f67db0f"
   integrity sha1-PkcprB9f3gJc19g6iW2rn09n2w8=
 
-is-path-cwd@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/is-path-cwd/-/is-path-cwd-1.0.0.tgz#d225ec23132e89edd38fda767472e62e65f1106d"
-  integrity sha1-0iXsIxMuie3Tj9p2dHLmLmXxEG0=
-
-is-path-in-cwd@^1.0.0:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/is-path-in-cwd/-/is-path-in-cwd-1.0.1.tgz#5ac48b345ef675339bd6c7a48a912110b241cf52"
-  integrity sha512-FjV1RTW48E7CWM7eE/J2NJvAEEVektecDBVBE5Hh3nM1Jd0kvhHtX68Pr3xsDf857xt3Y4AkwVULK1Vku62aaQ==
-  dependencies:
-    is-path-inside "^1.0.0"
-
-is-path-inside@^1.0.0:
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-1.0.1.tgz#8ef5b7de50437a3fdca6b4e865ef7aa55cb48036"
-  integrity sha1-jvW33lBDej/cprToZe96pVy0gDY=
-  dependencies:
-    path-is-inside "^1.0.1"
-
 is-posix-bracket@^0.1.0:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/is-posix-bracket/-/is-posix-bracket-0.1.1.tgz#3334dc79774368e92f016e6fbc0a88f5cd6e6bc4"
@@ -1832,11 +1777,6 @@ os-tmpdir@~1.0.2:
   resolved "https://registry.yarnpkg.com/os-tmpdir/-/os-tmpdir-1.0.2.tgz#bbe67406c79aa85c5cfec766fe5734555dfa1274"
   integrity sha1-u+Z0BseaqFxc/sdm/lc0VV36EnQ=
 
-p-map@^1.1.1:
-  version "1.2.0"
-  resolved "https://registry.yarnpkg.com/p-map/-/p-map-1.2.0.tgz#e4e94f311eabbc8633a1e79908165fca26241b6b"
-  integrity sha512-r6zKACMNhjPJMTl8KcFH4li//gkrXWfbD6feV8l6doRHlzljFWGJ2AP6iKaCJXyZmAUMOPtvbW7EXkbWO/pLEA==
-
 parse-glob@^3.0.4:
   version "3.0.4"
   resolved "https://registry.yarnpkg.com/parse-glob/-/parse-glob-3.0.4.tgz#b2c376cfb11f35513badd173ef0bb6e3a388391c"
@@ -1857,11 +1797,6 @@ path-is-absolute@^1.0.0:
   resolved "https://registry.yarnpkg.com/path-is-absolute/-/path-is-absolute-1.0.1.tgz#174b9268735534ffbc7ace6bf53a5a9e1b5c5f5f"
   integrity sha1-F0uSaHNVNP+8es5r9TpanhtcX18=
 
-path-is-inside@^1.0.1:
-  version "1.0.2"
-  resolved "https://registry.yarnpkg.com/path-is-inside/-/path-is-inside-1.0.2.tgz#365417dede44430d1c11af61027facf074bdfc53"
-  integrity sha1-NlQX3t5EQw0cEa9hAn+s8HS9/FM=
-
 pause-stream@0.0.11:
   version "0.0.11"
   resolved "https://registry.yarnpkg.com/pause-stream/-/pause-stream-0.0.11.tgz#fe5a34b0cbce12b5aa6a2b403ee2e73b602f1445"
@@ -1884,7 +1819,7 @@ performance-now@^2.1.0:
   resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-2.1.0.tgz#6309f4e0e5fa913ec1c69307ae364b4b377c9e7b"
   integrity sha1-Ywn04OX6kT7BxpMHrjZLSzd8nns=
 
-pify@^2.0.0, pify@^2.3.0:
+pify@^2.3.0:
   version "2.3.0"
   resolved "https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c"
   integrity sha1-7RQaasBDqEnqWISY59yosVMw6Qw=
@@ -2182,7 +2117,7 @@ requires-port@~1.0.0:
   resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff"
   integrity sha1-kl0mAdOaxIXgkc8NpcbmlNw9yv8=
 
-rimraf@2, rimraf@^2.2.8:
+rimraf@2:
   version "2.6.2"
   resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.2.tgz#2ed8150d24a16ea8651e6d6ef0f47c4158ce7a36"
   integrity sha512-lreewLK/BlghmxtfH36YYVg1i8IAce4TI7oao75I1g245+6BctqTVQiBP3YUJ9C6DQOXJmkYR9X9fCLtCOJc5w==

docs/UX-Design-Guidelines.md

@@ -1 +0,0 @@
-

extensions/agent/package.json

@@ -2,7 +2,7 @@
   "name": "agent",
   "displayName": "SQL Server Agent",
   "description": "Manage and troubleshoot SQL Server Agent jobs",
-  "version": "0.35.2",
+  "version": "0.34.0",
   "publisher": "Microsoft",
   "preview": true,
   "license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/LICENSE.txt",

extensions/agent/src/data/alertData.ts

@@ -69,7 +69,7 @@ export class AlertData implements IAgentDialogData {
 			this.eventDescriptionKeyword = alertInfo.eventDescriptionKeyword;
 			this.eventSource = alertInfo.eventSource;
 			this.hasNotification = alertInfo.hasNotification;
-			this.includeEventDescription = alertInfo.includeEventDescription ? alertInfo.includeEventDescription.toString() : null;
+			this.includeEventDescription = alertInfo.includeEventDescription.toString();
 			this.isEnabled = alertInfo.isEnabled;
 			this.jobId = alertInfo.jobId;
 			this.lastOccurrenceDate = alertInfo.lastOccurrenceDate;
@@ -82,7 +82,7 @@ export class AlertData implements IAgentDialogData {
 			this.databaseName = alertInfo.databaseName;
 			this.countResetDate = alertInfo.countResetDate;
 			this.categoryName = alertInfo.categoryName;
-			this.alertType = alertInfo.alertType ? alertInfo.alertType.toString() : null;
+			this.alertType = alertInfo.alertType.toString();
 			this.wmiEventNamespace = alertInfo.wmiEventNamespace;
 			this.wmiEventQuery = alertInfo.wmiEventQuery;
 		}

extensions/agent/src/data/jobData.ts

@@ -45,7 +45,6 @@ export class JobData implements IAgentDialogData {
 	public jobSchedules: sqlops.AgentJobScheduleInfo[];
 	public alerts: sqlops.AgentAlertInfo[];
 	public jobId: string;
-	public startStepId: number;
 
 	constructor(
 		ownerUri: string,
@@ -61,11 +60,10 @@ export class JobData implements IAgentDialogData {
 			this.category = jobInfo.category;
 			this.description = jobInfo.description;
 			this.enabled = jobInfo.enabled;
-			this.jobSteps = jobInfo.jobSteps;
-			this.jobSchedules = jobInfo.jobSchedules;
-			this.alerts = jobInfo.alerts;
+			this.jobSteps = jobInfo.JobSteps;
+			this.jobSchedules = jobInfo.JobSchedules;
+			this.alerts = jobInfo.Alerts;
 			this.jobId = jobInfo.jobId;
-			this.startStepId = jobInfo.startStepId;
 		}
 	}
 
@@ -143,17 +141,17 @@ export class JobData implements IAgentDialogData {
 			name: this.name,
 			owner: this.owner,
 			description: this.description,
-			emailLevel: this.emailLevel,
-			pageLevel: this.pageLevel,
-			eventLogLevel: this.eventLogLevel,
-			deleteLevel: this.deleteLevel,
-			operatorToEmail: this.operatorToEmail,
-			operatorToPage: this.operatorToPage,
+			EmailLevel: this.emailLevel,
+			PageLevel: this.pageLevel,
+			EventLogLevel: this.eventLogLevel,
+			DeleteLevel: this.deleteLevel,
+			OperatorToEmail: this.operatorToEmail,
+			OperatorToPage: this.operatorToPage,
 			enabled: this.enabled,
 			category: this.category,
-			alerts: this.alerts,
-			jobSchedules: this.jobSchedules,
-			jobSteps: this.jobSteps,
+			Alerts: this.alerts,
+			JobSchedules: this.jobSchedules,
+			JobSteps: this.jobSteps,
 			// The properties below are not collected from UI
 			// We could consider using a seperate class for create job request
 			//
@@ -168,8 +166,7 @@ export class JobData implements IAgentDialogData {
 			categoryType: 1, // LocalJob, hard-coding the value, corresponds to the target tab in SSMS
 			lastRun: '',
 			nextRun: '',
-			jobId: this.jobId,
-			startStepId: this.startStepId
+			jobId: this.jobId
 		};
 	}
 }

extensions/agent/src/data/jobStepData.ts

@@ -123,7 +123,6 @@ export class JobStepData implements IAgentDialogData {
 		stepData.retryInterval = jobStepInfo.retryInterval,
 		stepData.proxyName = jobStepInfo.proxyName;
 		stepData.dialogMode = AgentDialogMode.EDIT;
-		stepData.viaJobDialog = true;
 		return stepData;
 	}
 

extensions/agent/src/dialogs/agentDialog.ts

@@ -20,9 +20,6 @@ export abstract class AgentDialog<T extends IAgentDialogData> {
 	public readonly onSuccess: vscode.Event<T> = this._onSuccess.event;
 	public dialog: sqlops.window.modelviewdialog.Dialog;
 
-	// Dialog Name for Telemetry
-	public dialogName: string;
-
 	constructor(public ownerUri: string, public model: T, public title: string) {
 	}
 
@@ -34,9 +31,8 @@ export abstract class AgentDialog<T extends IAgentDialogData> {
 
 	protected abstract async initializeDialog(dialog: sqlops.window.modelviewdialog.Dialog);
 
-	public async openDialog(dialogName?: string) {
-		let event = dialogName ? dialogName : null;
-		this.dialog = sqlops.window.modelviewdialog.createDialog(this.title, event);
+	public async openDialog() {
+		this.dialog = sqlops.window.modelviewdialog.createDialog(this.title);
 
 		await this.model.initialize();
 

extensions/agent/src/dialogs/alertDialog.ts

@@ -116,10 +116,6 @@ export class AlertDialog extends AgentDialog<AlertData> {
 	private static readonly DelayMinutesTextBoxLabel: string =  localize('alertDialog.DelayMinutes', 'Delay Minutes');
 	private static readonly DelaySecondsTextBoxLabel: string =  localize('alertDialog.DelaySeconds', 'Delay Seconds');
 
-	// Event Name strings
-	private readonly NewAlertDialog = 'NewAlertDialogOpen';
-	private readonly EditAlertDialog = 'EditAlertDialogOpened';
-
 	// UI Components
 	private generalTab: sqlops.window.modelviewdialog.DialogTab;
 	private responseTab: sqlops.window.modelviewdialog.DialogTab;
@@ -153,7 +149,6 @@ export class AlertDialog extends AgentDialog<AlertData> {
 	private delayMinutesTextBox: sqlops.InputBoxComponent;
 	private delaySecondsTextBox: sqlops.InputBoxComponent;
 
-	private isEdit: boolean = false;
 	private databases: string[];
 	private jobModel: JobData;
 	public jobId: string;
@@ -171,8 +166,6 @@ export class AlertDialog extends AgentDialog<AlertData> {
 		this.jobModel = jobModel;
 		this.jobId = this.jobId ? this.jobId : this.jobModel.jobId;
 		this.jobName = this.jobName ? this.jobName : this.jobModel.name;
-		this.isEdit = alertInfo ? true : false;
-		this.dialogName = this.isEdit ? this.EditAlertDialog : this.NewAlertDialog;
 	}
 
 	protected async initializeDialog(dialog: sqlops.window.modelviewdialog.Dialog) {

extensions/agent/src/dialogs/jobDialog.ts

@@ -42,12 +42,11 @@ export class JobDialog extends AgentDialog<JobData>  {
 	private readonly StepsTable_TypeColumnString: string = localize('jobDialog.type', 'Type');
 	private readonly StepsTable_SuccessColumnString: string = localize('jobDialog.onSuccess', 'On Success');
 	private readonly StepsTable_FailureColumnString: string = localize('jobDialog.onFailure', 'On Failure');
-	private readonly NewStepButtonString: string = localize('jobDialog.new', 'New Step');
-	private readonly EditStepButtonString: string = localize('jobDialog.edit', 'Edit Step');
-	private readonly DeleteStepButtonString: string = localize('jobDialog.delete', 'Delete Step');
+	private readonly NewStepButtonString: string = localize('jobDialog.new', 'New...');
+	private readonly EditStepButtonString: string = localize('jobDialog.edit', 'Edit');
+	private readonly DeleteStepButtonString: string = localize('jobDialog.delete', 'Delete');
 	private readonly MoveStepUpButtonString: string = localize('jobDialog.moveUp', 'Move Step Up');
-	private readonly MoveStepDownButtonString: string = localize('jobDialog.moveDown', 'Move Step Down');
-	private readonly StartStepDropdownString: string = localize('jobDialog.startStepAt', 'Start step');
+	private readonly MoveStepDownButtonString: string = localize('jobDialog.moveDown', 'Move Step Up');
 
 	// Notifications tab strings
 	private readonly NotificationsTabTopLabelString: string = localize('jobDialog.notificationsTabTop', 'Actions to perform when the job completes');
@@ -68,10 +67,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 	private readonly AlertEnabledLabelString: string = localize('jobDialog.alertEnabledLabel', 'Enabled');
 	private readonly AlertTypeLabelString: string = localize('jobDialog.alertTypeLabel', 'Type');
 
-	// Event Name strings
-	private readonly NewJobDialogEvent: string = 'NewJobDialogOpened';
-	private readonly EditJobDialogEvent: string  = 'EditJobDialogOpened';
-
 	// UI Components
 	private generalTab: sqlops.window.modelviewdialog.DialogTab;
 	private stepsTab: sqlops.window.modelviewdialog.DialogTab;
@@ -106,7 +101,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 	private eventLogConditionDropdown: sqlops.DropDownComponent;
 	private deleteJobCheckBox: sqlops.CheckBoxComponent;
 	private deleteJobConditionDropdown: sqlops.DropDownComponent;
-	private startStepDropdown: sqlops.DropDownComponent;
 
 	// Schedule tab controls
 	private schedulesTable: sqlops.TableComponent;
@@ -121,7 +115,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 	private steps: sqlops.AgentJobStepInfo[];
 	private schedules: sqlops.AgentJobScheduleInfo[];
 	private alerts: sqlops.AgentAlertInfo[] = [];
-	private startStepDropdownValues: sqlops.CategoryValue[] = [];
 
 	constructor(ownerUri: string, jobInfo: sqlops.AgentJobInfo = undefined) {
 		super(
@@ -132,7 +125,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 		this.schedules = this.model.jobSchedules ? this.model.jobSchedules : [];
 		this.alerts = this.model.alerts ? this.model.alerts : [];
 		this.isEdit = jobInfo ? true : false;
-		this.dialogName = this.isEdit ? this.EditJobDialogEvent : this.NewJobDialogEvent;
 	}
 
 	protected async initializeDialog() {
@@ -226,26 +218,19 @@ export class JobDialog extends AgentDialog<JobData>  {
 						this.StepsTable_FailureColumnString
 					],
 					data: data,
-					height: 650
+					height: 750
 				}).component();
 
-			this.startStepDropdown = view.modelBuilder.dropDown().withProperties({ width: 180 }).component();
-			this.startStepDropdown.enabled = this.steps.length > 1 ? true : false;
-			this.steps.forEach((step) => {
-				this.startStepDropdownValues.push({ displayName: step.id + ': ' + step.stepName, name: step.id.toString() });
-			});
-			this.startStepDropdown.values = this.startStepDropdownValues;
-
 			this.moveStepUpButton = view.modelBuilder.button()
 				.withProperties({
 					label: this.MoveStepUpButtonString,
-					width: 120
+					width: 80
 				}).component();
 
 			this.moveStepDownButton = view.modelBuilder.button()
 				.withProperties({
 					label: this.MoveStepDownButtonString,
-					width: 120
+					width: 80
 				}).component();
 
 			this.moveStepUpButton.enabled = false;
@@ -253,7 +238,7 @@ export class JobDialog extends AgentDialog<JobData>  {
 
 			this.newStepButton = view.modelBuilder.button().withProperties({
 				label: this.NewStepButtonString,
-				width: 140
+				width: 80
 			}).component();
 
 			let stepDialog = new JobStepDialog(this.model.ownerUri, '' , this.model, null, true);
@@ -261,11 +246,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 				let stepInfo = JobStepData.convertToAgentJobStepInfo(step);
 				this.steps.push(stepInfo);
 				this.stepsTable.data = this.convertStepsToData(this.steps);
-				this.startStepDropdownValues = [];
-				this.steps.forEach((step) => {
-					this.startStepDropdownValues.push({ displayName: step.id + ': ' + step.stepName, name: step.id.toString() });
-				});
-				this.startStepDropdown.values = this.startStepDropdownValues;
 			});
 			this.newStepButton.onDidClick((e)=>{
 				if (this.nameTextBox.value && this.nameTextBox.value.length > 0) {
@@ -278,127 +258,53 @@ export class JobDialog extends AgentDialog<JobData>  {
 
 			this.editStepButton = view.modelBuilder.button().withProperties({
 				label: this.EditStepButtonString,
-				width: 140
+				width: 80
 			}).component();
 
 			this.deleteStepButton = view.modelBuilder.button().withProperties({
 				label: this.DeleteStepButtonString,
-				width: 140
+				width: 80
 			}).component();
 
 			this.stepsTable.enabled = false;
 			this.editStepButton.enabled = false;
 			this.deleteStepButton.enabled = false;
 
-			this.moveStepUpButton.onDidClick(() => {
-                let rowNumber = this.stepsTable.selectedRows[0];
-				let previousRow = rowNumber - 1;
-				let previousStep = this.steps[previousRow];
-				let previousStepId = this.steps[previousRow].id;
-				let currentStep = this.steps[rowNumber];
-				let currentStepId = this.steps[rowNumber].id;
-				this.steps[previousRow] = currentStep;
-				this.steps[rowNumber] = previousStep;
-				this.stepsTable.data = this.convertStepsToData(this.steps);
-				this.steps[previousRow].id = previousStepId;
-				this.steps[rowNumber].id = currentStepId;
-			});
-
-			this.moveStepDownButton.onDidClick(() => {
-				let rowNumber = this.stepsTable.selectedRows[0];
-				let nextRow = rowNumber + 1;
-				let nextStep = this.steps[nextRow];
-				let nextStepId = this.steps[nextRow].id;
-				let currentStep = this.steps[rowNumber];
-				let currentStepId = this.steps[rowNumber].id;
-				this.steps[nextRow] = currentStep;
-				this.steps[rowNumber] = nextStep;
-				this.stepsTable.data = this.convertStepsToData(this.steps);
-				this.steps[nextRow].id = nextStepId;
-				this.steps[rowNumber].id = currentStepId;
-			});
-
-			this.editStepButton.onDidClick(() => {
-				if (this.stepsTable.selectedRows.length === 1) {
-					let rowNumber = this.stepsTable.selectedRows[0];
-					let stepData = this.model.jobSteps[rowNumber];
-					let editStepDialog = new JobStepDialog(this.model.ownerUri, '' , this.model, stepData, true);
-					editStepDialog.onSuccess((step) => {
-						let stepInfo = JobStepData.convertToAgentJobStepInfo(step);
-						for (let i = 0; i < this.steps.length; i++) {
-							if (this.steps[i].id === stepInfo.id) {
-								this.steps[i] = stepInfo;
-							}
-						}
-						this.stepsTable.data = this.convertStepsToData(this.steps);
-						this.startStepDropdownValues = [];
-						this.steps.forEach((step) => {
-							this.startStepDropdownValues.push({ displayName: step.id + ': ' + step.stepName, name: step.id.toString() });
-						});
-						this.startStepDropdown.values = this.startStepDropdownValues;
-
-					});
-					editStepDialog.openDialog();
-				}
-			});
-
-			this.deleteStepButton.onDidClick(() => {
-				if (this.stepsTable.selectedRows.length === 1) {
-					let rowNumber = this.stepsTable.selectedRows[0];
-					AgentUtils.getAgentService().then((agentService) => {
-						let steps = this.model.jobSteps ? this.model.jobSteps : [];
-						let stepData = this.model.jobSteps[rowNumber];
-						agentService.deleteJobStep(this.ownerUri, stepData).then((result) => {
-							if (result && result.success) {
-								delete steps[rowNumber];
-								let data = this.convertStepsToData(steps);
-								this.stepsTable.data = data;
-								this.startStepDropdownValues = [];
-								this.steps.forEach((step) => {
-									this.startStepDropdownValues.push({ displayName: step.id + ': ' + step.stepName, name: step.id.toString() });
-								});
-								this.startStepDropdown.values = this.startStepDropdownValues;
-							}
-						});
-					});
-				}
-			});
-
-			this.stepsTable.onRowSelected((row) => {
+			this.stepsTable.onRowSelected(() => {
 				// only let edit or delete steps if there's
 				// one step selection
 				if (this.stepsTable.selectedRows.length === 1) {
 					let rowNumber = this.stepsTable.selectedRows[0];
-					// if it's not the last step
-					if (this.steps.length !== rowNumber + 1) {
-						this.moveStepDownButton.enabled = true;
-					}
-					// if it's not the first step
-					if (rowNumber !== 0) {
-						this.moveStepUpButton.enabled = true;
-					}
+					let stepData = this.model.jobSteps[rowNumber];
 					this.deleteStepButton.enabled = true;
 					this.editStepButton.enabled = true;
+					this.editStepButton.onDidClick(() => {
+						let stepDialog = new JobStepDialog(this.model.ownerUri, '' , this.model, stepData, true);
+						stepDialog.openDialog();
+					});
+
+					this.deleteStepButton.onDidClick(() => {
+						AgentUtils.getAgentService().then((agentService) => {
+							let steps = this.model.jobSteps ? this.model.jobSteps : [];
+							agentService.deleteJobStep(this.ownerUri, stepData).then((result) => {
+								if (result && result.success) {
+									delete steps[rowNumber];
+									let data = this.convertStepsToData(steps);
+									this.stepsTable.data = data;
+								}
+							});
+						});
+					});
 				}
 			});
-			let stepMoveContainer = this.createRowContainer(view).withItems([this.startStepDropdown, this.moveStepUpButton, this.moveStepDownButton]).component();
-			let stepsDialogContainer = this.createRowContainer(view).withItems([this.newStepButton, this.editStepButton, this.deleteStepButton]).component();
-			let formModel = view.modelBuilder.formContainer().withFormItems([
-				{
+
+			let formModel = view.modelBuilder.formContainer()
+				.withFormItems([{
 					component: this.stepsTable,
-					title: this.JobStepsTopLabelString
-				},
-				{
-					component: stepMoveContainer,
-					title: this.StartStepDropdownString
-				},
-				{
-					component: stepsDialogContainer,
-					title: ''
-				}
-			]).withLayout({ width: '100%' }).component();
+					title: this.JobStepsTopLabelString,
+					actions: [this.moveStepUpButton, this.moveStepDownButton, this.newStepButton, this.editStepButton, this.deleteStepButton]
+				}]).withLayout({ width: '100%' }).component();
 			await view.initializeModel(formModel);
-			this.setConditionDropdownSelectedValue(this.startStepDropdown, this.model.startStepId);
 		});
 	}
 
@@ -661,7 +567,6 @@ export class JobDialog extends AgentDialog<JobData>  {
 		this.model.pageLevel = this.getActualConditionValue(this.pagerCheckBox, this.pagerConditionDropdown);
 		this.model.eventLogLevel = this.getActualConditionValue(this.eventLogCheckBox, this.eventLogConditionDropdown);
 		this.model.deleteLevel = this.getActualConditionValue(this.deleteJobCheckBox, this.deleteJobConditionDropdown);
-		this.model.startStepId = +this.getDropdownValue(this.startStepDropdown);
 		if (!this.model.jobSteps) {
 			this.model.jobSteps = [];
 		}

extensions/agent/src/dialogs/jobStepDialog.ts

@@ -67,9 +67,6 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
 	private readonly QuitJobReportingSuccess: string = localize('jobStepDialog.quitJobSuccess', 'Quit the job reporting success');
 	private readonly QuitJobReportingFailure: string = localize('jobStepDialog.quitJobFailure', 'Quit the job reporting failure');
 
-	// Event Name strings
-	private readonly NewStepDialog = 'NewStepDialogOpened';
-	private readonly EditStepDialog = 'EditStepDialogOpened';
 	// UI Components
 
 	// Dialogs
@@ -134,7 +131,6 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
 		this.jobModel = jobModel;
 		this.jobName = this.jobName ?  this.jobName : this.jobModel.name;
 		this.server = server;
-		this.dialogName = this.isEdit ? this.EditStepDialog : this.NewStepDialog;
 	}
 
 	private initializeUIComponents() {
@@ -523,7 +519,6 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
 		this.model.failureAction = this.failureActionDropdown.value as string;
 		this.model.outputFileName = this.outputFileNameBox.value;
 		this.model.appendToLogFile = this.appendToExistingFileCheckbox.checked;
-		this.model.command = this.commandTextBox.value ? this.commandTextBox.value : '';
 	}
 
 	public async initializeDialog() {

extensions/agent/src/dialogs/operatorDialog.ts

@@ -35,7 +35,7 @@ export class OperatorDialog extends AgentDialog<OperatorData> {
 	private static readonly PagerSundayCheckBoxLabel: string = localize('createOperator.PagerSundayCheckBox', 'Sunday');
 	private static readonly WorkdayBeginLabel: string = localize('createOperator.workdayBegin', 'Workday begin');
 	private static readonly WorkdayEndLabel: string = localize('createOperator.workdayEnd', 'Workday end');
-	private static readonly PagerDutyScheduleLabel: string = localize('createOperator.PagerDutySchedule', 'Pager on duty schedule');
+	private static readonly PagerDutyScheduleLabel: string = localize('createOperator.PagerDutySchedule', 'Pager on duty schdule');
 
 	// Notifications tab strings
 	private static readonly AlertsTableLabel: string = localize('createOperator.AlertListHeading', 'Alert list');
@@ -43,10 +43,6 @@ export class OperatorDialog extends AgentDialog<OperatorData> {
 	private static readonly AlertEmailColumnLabel: string = localize('createOperator.AlertEmailColumnLabel', 'E-mail');
 	private static readonly AlertPagerColumnLabel: string = localize('createOperator.AlertPagerColumnLabel', 'Pager');
 
-	// Event strings
-	private readonly NewOperatorDialog = 'NewOperatorDialogOpened';
-	private readonly EditOperatorDialog = 'EditOperatorDialogOpened';
-
 	// UI Components
 	private generalTab: sqlops.window.modelviewdialog.DialogTab;
 	private notificationsTab: sqlops.window.modelviewdialog.DialogTab;
@@ -72,15 +68,12 @@ export class OperatorDialog extends AgentDialog<OperatorData> {
 
 	// Notification tab controls
 	private alertsTable: sqlops.TableComponent;
-	private isEdit: boolean = false;
 
 	constructor(ownerUri: string, operatorInfo: sqlops.AgentOperatorInfo = undefined) {
 		super(
 			ownerUri,
 			new OperatorData(ownerUri, operatorInfo),
 			operatorInfo ? OperatorDialog.EditDialogTitle : OperatorDialog.CreateDialogTitle);
-		this.isEdit = operatorInfo ? true : false;
-		this.dialogName = this.isEdit ? this.EditOperatorDialog : this.NewOperatorDialog;
 	}
 
 	protected async initializeDialog(dialog: sqlops.window.modelviewdialog.Dialog) {

extensions/agent/src/dialogs/proxyDialog.ts

@@ -36,9 +36,6 @@ export class ProxyDialog extends AgentDialog<ProxyData>  {
 	private static readonly PowerShellLabel: string = localize('createProxy.PowerShell', 'PowerShell');
 	private static readonly SubSystemHeadingLabel: string = localize('createProxy.subSystemHeading', 'Active to the following subsytems');
 
-	private readonly NewProxyDialog = 'NewProxyDialogOpened';
-	private readonly EditProxyDialog = 'EditProxyDialogOpened';
-
 	// UI Components
 	private generalTab: sqlops.window.modelviewdialog.DialogTab;
 
@@ -59,7 +56,6 @@ export class ProxyDialog extends AgentDialog<ProxyData>  {
 	private powershellCheckBox: sqlops.CheckBoxComponent;
 
 	private credentials: sqlops.CredentialInfo[];
-	private isEdit: boolean = false;
 
 	constructor(ownerUri: string, proxyInfo: sqlops.AgentProxyInfo = undefined, credentials: sqlops.CredentialInfo[]) {
 		super(
@@ -67,8 +63,6 @@ export class ProxyDialog extends AgentDialog<ProxyData>  {
 			new ProxyData(ownerUri, proxyInfo),
 			proxyInfo ? ProxyDialog.EditDialogTitle : ProxyDialog.CreateDialogTitle);
 		this.credentials = credentials;
-		this.isEdit = proxyInfo ? true : false;
-		this.dialogName = this.isEdit ? this.EditProxyDialog : this.NewProxyDialog;
 	}
 
 	protected async initializeDialog(dialog: sqlops.window.modelviewdialog.Dialog) {

extensions/agent/src/mainController.ts

@@ -40,13 +40,13 @@ export class MainController {
     public activate(): void {
         vscode.commands.registerCommand('agent.openJobDialog', (ownerUri: string, jobInfo: sqlops.AgentJobInfo) => {
             let dialog = new JobDialog(ownerUri, jobInfo);
-            dialog.dialogName ? dialog.openDialog(dialog.dialogName) : dialog.openDialog();
+            dialog.openDialog();
         });
         vscode.commands.registerCommand('agent.openNewStepDialog', (ownerUri: string, server: string, jobInfo: sqlops.AgentJobInfo, jobStepInfo: sqlops.AgentJobStepInfo) => {
             AgentUtils.getAgentService().then((agentService) => {
                 let jobData: JobData = new JobData(ownerUri, jobInfo, agentService);
                 let dialog = new JobStepDialog(ownerUri, server, jobData, jobStepInfo, false);
-                dialog.dialogName ? dialog.openDialog(dialog.dialogName) : dialog.openDialog();
+                dialog.openDialog();
             });
         });
         vscode.commands.registerCommand('agent.openPickScheduleDialog', (ownerUri: string, jobName: string) => {
@@ -57,16 +57,17 @@ export class MainController {
             AgentUtils.getAgentService().then((agentService) => {
                 let jobData: JobData = new JobData(ownerUri, jobInfo, agentService);
                 let dialog = new AlertDialog(ownerUri, jobData, alertInfo, false);
-                dialog.dialogName ? dialog.openDialog(dialog.dialogName) : dialog.openDialog();
+                dialog.openDialog();
             });
         });
         vscode.commands.registerCommand('agent.openOperatorDialog', (ownerUri: string, operatorInfo: sqlops.AgentOperatorInfo) => {
             let dialog = new OperatorDialog(ownerUri, operatorInfo);
-            dialog.dialogName ? dialog.openDialog(dialog.dialogName) : dialog.openDialog();
+            dialog.openDialog();
         });
         vscode.commands.registerCommand('agent.openProxyDialog', (ownerUri: string, proxyInfo: sqlops.AgentProxyInfo, credentials: sqlops.CredentialInfo[]) => {
             let dialog = new ProxyDialog(ownerUri, proxyInfo, credentials);
-            dialog.dialogName ? dialog.openDialog(dialog.dialogName) : dialog.openDialog();
+            dialog.openDialog();
+            MainController.showNotYetImplemented();
         });
     }
 

extensions/azurecore/package.json

@@ -17,12 +17,12 @@
 		"configuration": [
 			{
 				"type": "object",
-				"title": "%azure.resource.config.title%",
+				"title": "%azure.config.title%",
 				"properties": {
-					"azure.resource.config.filter": {
+					"azureResource.resourceFilter": {
 						"type": "array",
 						"default": null,
-						"description": "%azure.resource.config.filter.description%"
+						"description": "%azure.resourceFilter.description%"
 					}
 				}
 			},
@@ -61,48 +61,40 @@
 				"category": "Azure Accounts"
 			},
 			{
-				"command": "azure.resource.refreshall",
-				"title": "%azure.resource.refreshall.title%",
+				"command": "azureresource.refreshall",
+				"title": "%azureresource.refreshall%",
 				"icon": {
 					"dark": "resources/dark/refresh_inverse.svg",
 					"light": "resources/light/refresh.svg"
 				}
 			},
 			{
-				"command": "azure.resource.refresh",
-				"title": "%azure.resource.refresh.title%",
+				"command": "azureresource.refresh",
+				"title": "%azureresource.refresh%",
 				"icon": {
 					"dark": "resources/dark/refresh_inverse.svg",
 					"light": "resources/light/refresh.svg"
 				}
 			},
 			{
-				"command": "azure.resource.signin",
-				"title": "%azure.resource.signin.title%"
+				"command": "azureresource.signin",
+				"title": "%azureresource.signin%"
 			},
 			{
-				"command": "azure.resource.selectsubscriptions",
-				"title": "%azure.resource.selectsubscriptions.title%",
+				"command": "azureresource.connectsqldb",
+				"title": "%azureresource.connectsqldb%",
+				"icon": {
+					"dark": "resources/dark/connect_to_inverse.svg",
+					"light": "resources/light/connect_to.svg"
+				}
+			},
+			{
+				"command": "azureresource.selectsubscriptions",
+				"title": "%azureresource.selectsubscriptions%",
 				"icon": {
 					"dark": "resources/dark/filter_inverse.svg",
 					"light": "resources/light/filter.svg"
 				}
-			},
-			{
-				"command": "azure.resource.connectsqlserver",
-				"title": "%azure.resource.connectsqlserver.title%",
-				"icon": {
-					"dark": "resources/dark/connect_to_inverse.svg",
-					"light": "resources/light/connect_to.svg"
-				}
-			},
-			{
-				"command": "azure.resource.connectsqldb",
-				"title": "%azure.resource.connectsqldb.title%",
-				"icon": {
-					"dark": "resources/dark/connect_to_inverse.svg",
-					"light": "resources/light/connect_to.svg"
-				}
 			}
 		],
 		"viewsContainers": {
@@ -118,47 +110,46 @@
 			"azureResource": [
 				{
 					"id": "azureResourceExplorer",
-					"name": "%azure.resource.explorer.title%"
+					"name": "%azure.resourceExplorer.title%"
 				}
 			]
 		},
 		"menus": {
 			"view/title": [
 				{
-					"command": "azure.resource.refreshall",
+					"command": "azureresource.refreshall",
 					"when": "view == azureResourceExplorer",
 					"group": "navigation@1"
 				}
 			],
 			"view/item/context": [
 				{
-					"command": "azure.resource.selectsubscriptions",
-					"when": "viewItem == azure.resource.itemType.account",
+					"command": "azureresource.connectsqldb",
+					"when": "viewItem =~ /^azureResource\\.itemType\\.database(?:Server){0,1}$/",
+					"group": "1azureresource@1"
+				},
+				{
+					"command": "azureresource.connectsqldb",
+					"when": "viewItem =~ /^azureResource\\.itemType\\.database(?:Server){0,1}$/",
 					"group": "inline"
 				},
 				{
-					"command": "azure.resource.refresh",
-					"when": "viewItem =~ /^azure\\.resource\\.itemType\\.(?:account|subscription|databaseContainer|databaseServerContainer)$/",
+					"command": "azureresource.selectsubscriptions",
+					"when": "viewItem == azureResource.itemType.account",
 					"group": "inline"
 				},
 				{
-					"command": "azure.resource.connectsqlserver",
-					"when": "viewItem == azure.resource.itemType.databaseServer",
-					"group": "inline"
-				},
-				{
-					"command": "azure.resource.connectsqldb",
-					"when": "viewItem == azure.resource.itemType.database",
+					"command": "azureresource.refresh",
+					"when": "viewItem =~ /^azureResource\\.itemType\\.(?:account|subscription|databaseContainer|databaseServerContainer)$/",
 					"group": "inline"
 				}
 			]
-		},
-		"hasAzureResourceProviders": true
+		}
 	},
 	"dependencies": {
+		"request": "2.63.0",
 		"azure-arm-resource": "^7.0.0",
 		"azure-arm-sql": "^5.0.1",
-		"request": "2.88.0",
 		"vscode-nls": "^4.0.0"
 	},
 	"devDependencies": {
@@ -166,7 +157,6 @@
 		"@types/node": "^8.0.24",
 		"mocha": "^5.2.0",
 		"should": "^13.2.1",
-		"vscode": "^1.1.26",
 		"typemoq": "^2.1.0"
 	}
-}
+}

extensions/azurecore/package.nls.json

@@ -1,20 +1,16 @@
 {
 	"azure.displayName": "Azure (Core)",
 	"azure.description": "Browse and work with Azure resources",
+	"azure.config.title": "Azure Resource Configuration",
+	"azure.resourceFilter.description": "The resource filter, each element is an account id, a subscription id and name separated by a slash",
+	"azureresource.refreshall": "Refresh All",
+	"azureresource.refresh": "Refresh",
+	"azureresource.signin": "Sign In",
+	"azureresource.connectsqldb": "Connect",
+	"azureresource.selectsubscriptions": "Select Subscriptions",
 	"azure.title": "Azure",
-
-	"azure.resource.config.title": "Azure Resource Configuration",
-	"azure.resource.config.filter.description": "The resource filter, each element is an account id, a subscription id and name separated by a slash",
-	"azure.resource.explorer.title": "Resource Explorer",
-	"azure.resource.refreshall.title": "Refresh All",
-	"azure.resource.refresh.title": "Refresh",
-	"azure.resource.signin.title": "Sign In",
-	"azure.resource.selectsubscriptions.title": "Select Subscriptions",
-	"azure.resource.connectsqlserver.title": "Connect",
-	"azure.resource.connectsqldb.title": "Connect",
-
+	"azure.resourceExplorer.title": "Resource Explorer",
 	"accounts.clearTokenCache": "Clear Azure Account Token Cache",
-
 	"config.enablePublicCloudDescription": "Should Azure public cloud integration be enabled",
 	"config.enableUsGovCloudDescription": "Should US Government Azure cloud (Fairfax) integration be enabled",
 	"config.enableChinaCloudDescription": "Should Azure China integration be enabled",

extensions/azurecore/src/account-provider/azureAccountProvider.ts

@@ -69,8 +69,8 @@ export class AzureAccountProvider implements sqlops.AccountProvider {
 		return this._tokenCache.clear();
 	}
 
-	public getSecurityToken(account: AzureAccount, resource: sqlops.AzureResource): Thenable<AzureAccountSecurityTokenCollection> {
-		return this.doIfInitialized(() => this.getAccessTokens(account, resource));
+	public getSecurityToken(account: AzureAccount): Thenable<AzureAccountSecurityTokenCollection> {
+		return this.doIfInitialized(() => this.getAccessTokens(account));
 	}
 
 	public initialize(restoredAccounts: sqlops.Account[]): Thenable<sqlops.Account[]> {
@@ -90,7 +90,7 @@ export class AzureAccountProvider implements sqlops.AccountProvider {
 
 			// Attempt to get fresh tokens. If this fails then the account is stale.
 			// NOTE: Based on ADAL implementation, getting tokens should use the refresh token if necessary
-			let task = this.getAccessTokens(account, sqlops.AzureResource.ResourceManagement)
+			let task = this.getAccessTokens(account)
 				.then(
 				() => {
 					return account;
@@ -161,14 +161,9 @@ export class AzureAccountProvider implements sqlops.AccountProvider {
 			: Promise.reject(localize('accountProviderNotInitialized', 'Account provider not initialized, cannot perform action'));
 	}
 
-	private getAccessTokens(account: AzureAccount, resource: sqlops.AzureResource): Thenable<AzureAccountSecurityTokenCollection> {
+	private getAccessTokens(account: AzureAccount): Thenable<AzureAccountSecurityTokenCollection> {
 		let self = this;
 
-		const resourceIdMap = new Map<sqlops.AzureResource, string>([
-			[sqlops.AzureResource.ResourceManagement, self._metadata.settings.armResource.id],
-			[sqlops.AzureResource.Sql, self._metadata.settings.sqlResource.id]
-		]);
-
 		let accessTokenPromises: Thenable<void>[] = [];
 		let tokenCollection: AzureAccountSecurityTokenCollection = {};
 		for (let tenant of account.properties.tenants) {
@@ -177,7 +172,7 @@ export class AzureAccountProvider implements sqlops.AccountProvider {
 				let context = new adal.AuthenticationContext(authorityUrl, null, self._tokenCache);
 
 				context.acquireToken(
-					resourceIdMap.get(resource),
+					self._metadata.settings.armResource.id,
 					tenant.userId,
 					self._metadata.settings.clientId,
 					(error: Error, response: adal.TokenResponse | adal.ErrorResponse) => {

extensions/azurecore/src/account-provider/interfaces.ts

@@ -81,11 +81,6 @@ export interface Settings {
 	 */
 	armResource?: Resource;
 
-	/**
-	 * Information that describes the SQL Azure resource
-	 */
-	sqlResource?: Resource;
-
 	/**
 	 * A list of tenant IDs to authenticate against. If defined, then these IDs will be used
 	 * instead of querying the tenants endpoint of the armResource

extensions/azurecore/src/account-provider/providerSettings.ts

@@ -27,10 +27,6 @@ const publicAzureSettings: ProviderSettings = {
 				id: 'https://management.core.windows.net/',
 				endpoint: 'https://management.azure.com'
 			},
-			sqlResource: {
-				id: 'https://database.windows.net/',
-				endpoint: 'https://database.windows.net'
-			},
 			redirectUri: 'http://localhost/redirect'
 		}
 	}

extensions/azurecore/src/account-provider/tokenCache.ts

@@ -223,16 +223,22 @@ export default class TokenCache implements adal.TokenCache {
 		return this.getOrCreateEncryptionParams()
 			.then(encryptionParams => {
 				try {
-					return self.decryptCache('utf8', encryptionParams);
-				} catch (e) {
-					try {
-						// try to parse using 'binary' encoding and rewrite cache as UTF8
-						let response = self.decryptCache('binary', encryptionParams);
-						self.writeCache(response);
-						return response;
-					} catch (e) {
-						throw e;
+					let cacheCipher = fs.readFileSync(self._cacheSerializationPath, TokenCache.FsOptions);
+
+					let decipher = crypto.createDecipheriv(TokenCache.CipherAlgorithm, encryptionParams.key, encryptionParams.initializationVector);
+					let cacheJson = decipher.update(cacheCipher, 'hex', 'binary');
+					cacheJson += decipher.final('binary');
+
+					// Deserialize the JSON into the array of tokens
+					let cacheObj = <adal.TokenResponse[]>JSON.parse(cacheJson);
+					for (let objIndex in cacheObj) {
+						// Rehydrate Date objects since they will always serialize as a string
+						cacheObj[objIndex].expiresOn = new Date(<string>cacheObj[objIndex].expiresOn);
 					}
+
+					return cacheObj;
+				} catch (e) {
+					throw e;
 				}
 			})
 			.then(null, err => {
@@ -242,22 +248,6 @@ export default class TokenCache implements adal.TokenCache {
 			});
 	}
 
-	private decryptCache(encoding: crypto.Utf8AsciiBinaryEncoding, encryptionParams: EncryptionParams): adal.TokenResponse[] {
-		let cacheCipher = fs.readFileSync(this._cacheSerializationPath, TokenCache.FsOptions);
-		let decipher = crypto.createDecipheriv(TokenCache.CipherAlgorithm, encryptionParams.key, encryptionParams.initializationVector);
-		let cacheJson = decipher.update(cacheCipher, 'hex', encoding);
-		cacheJson += decipher.final(encoding);
-
-		// Deserialize the JSON into the array of tokens
-		let cacheObj = <adal.TokenResponse[]>JSON.parse(cacheJson);
-		for (let objIndex in cacheObj) {
-			// Rehydrate Date objects since they will always serialize as a string
-			cacheObj[objIndex].expiresOn = new Date(<string>cacheObj[objIndex].expiresOn);
-		}
-
-		return cacheObj;
-	}
-
 	private removeFromCache(cache: adal.TokenResponse[], entries: adal.TokenResponse[]): adal.TokenResponse[] {
 		entries.forEach((entry: adal.TokenResponse) => {
 			// Check to see if the entry exists
@@ -284,7 +274,7 @@ export default class TokenCache implements adal.TokenCache {
 					let cacheJson = JSON.stringify(cache);
 
 					let cipher = crypto.createCipheriv(TokenCache.CipherAlgorithm, encryptionParams.key, encryptionParams.initializationVector);
-					let cacheCipher = cipher.update(cacheJson, 'utf8', 'hex');
+					let cacheCipher = cipher.update(cacheJson, 'binary', 'hex');
 					cacheCipher += cipher.final('hex');
 
 					fs.writeFileSync(self._cacheSerializationPath, cacheCipher, TokenCache.FsOptions);

extensions/azurecore/src/apiWrapper.ts

@@ -212,8 +212,8 @@ export class ApiWrapper {
 		return sqlops.accounts.getAllAccounts();
 	}
 
-	public getSecurityToken(account: sqlops.Account, resource: sqlops.AzureResource): Thenable<{}> {
-		return sqlops.accounts.getSecurityToken(account, resource);
+	public getSecurityToken(account: sqlops.Account): Thenable<{}> {
+		return sqlops.accounts.getSecurityToken(account);
 	}
 
 	public readonly onDidChangeAccounts = sqlops.accounts.onDidChangeAccounts;

extensions/azurecore/src/azureResource/azure-resource.d.ts

@@ -1,28 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-import { TreeDataProvider, TreeItem } from 'vscode';
-import { DataProvider, Account } from 'sqlops';
-
-export namespace azureResource {
-	export interface IAzureResourceProvider extends DataProvider {
-		getTreeDataProvider(): IAzureResourceTreeDataProvider;
-	}
-
-	export interface IAzureResourceTreeDataProvider extends TreeDataProvider<IAzureResourceNode> {
-	}
-
-	export interface IAzureResourceNode {
-		readonly account: Account;
-		readonly subscription: AzureResourceSubscription;
-		readonly tenantId: string;
-		readonly treeItem: TreeItem;
-	}
-
-	export interface AzureResourceSubscription {
-		id: string;
-		name: string;
-	}
-}

extensions/azurecore/src/azureResource/commands.ts

@@ -6,48 +6,35 @@
 'use strict';
 
 import { window, QuickPickItem } from 'vscode';
-import { AzureResource } from 'sqlops';
-import { TokenCredentials } from 'ms-rest';
-import { AppContext } from '../appContext';
-import * as nls from 'vscode-nls';
-const localize = nls.loadMessageBundle();
+import { IConnectionProfile } from 'sqlops';
+import { generateGuid } from './utils';
+import { ApiWrapper } from '../apiWrapper';
+import { TreeNode } from '../treeNodes';
 
-import { azureResource } from './azure-resource';
-import { TreeNode } from './treeNode';
-import { AzureResourceCredentialError } from './errors';
 import { AzureResourceTreeProvider } from './tree/treeProvider';
+import { AzureResourceDatabaseServerTreeNode } from './tree/databaseServerTreeNode';
+import { AzureResourceDatabaseTreeNode } from './tree/databaseTreeNode';
 import { AzureResourceAccountTreeNode } from './tree/accountTreeNode';
-import { IAzureResourceSubscriptionService, IAzureResourceSubscriptionFilterService } from '../azureResource/interfaces';
-import { AzureResourceServiceNames } from './constants';
+import { AzureResourceServicePool } from './servicePool';
+import { AzureResourceSubscription } from './models';
 
-export function registerAzureResourceCommands(appContext: AppContext, tree: AzureResourceTreeProvider): void {
-	appContext.apiWrapper.registerCommand('azure.resource.selectsubscriptions', async (node?: TreeNode) => {
+export function registerAzureResourceCommands(apiWrapper: ApiWrapper, tree: AzureResourceTreeProvider): void {
+	apiWrapper.registerCommand('azureresource.selectsubscriptions', async (node?: TreeNode) => {
 		if (!(node instanceof AzureResourceAccountTreeNode)) {
 			return;
 		}
 
-		const subscriptionService = appContext.getService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService);
-		const subscriptionFilterService = appContext.getService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService);
-
 		const accountNode = node as AzureResourceAccountTreeNode;
 
-		const subscriptions = (await accountNode.getCachedSubscriptions()) || <azureResource.AzureResourceSubscription[]>[];
-		if (subscriptions.length === 0) {
-			try {
-				const tokens = await this.servicePool.apiWrapper.getSecurityToken(this.account, AzureResource.ResourceManagement);
+		const servicePool = AzureResourceServicePool.getInstance();
 
-				for (const tenant of this.account.properties.tenants) {
-					const token = tokens[tenant.id].token;
-					const tokenType = tokens[tenant.id].tokenType;
-
-					subscriptions.push(...await subscriptionService.getSubscriptions(accountNode.account, new TokenCredentials(token, tokenType)));
-				}
-			} catch (error) {
-				throw new AzureResourceCredentialError(localize('azure.resource.selectsubscriptions.credentialError', 'Failed to get credential for account {0}. Please refresh the account.', this.account.key.accountId), error);
-			}
+		let subscriptions = await accountNode.getCachedSubscriptions();
+		if (!subscriptions || subscriptions.length === 0) {
+			const credentials = await servicePool.credentialService.getCredentials(accountNode.account);
+			subscriptions = await servicePool.subscriptionService.getSubscriptions(accountNode.account, credentials);
 		}
 
-		let selectedSubscriptions = (await subscriptionFilterService.getSelectedSubscriptions(accountNode.account)) || <azureResource.AzureResourceSubscription[]>[];
+		const selectedSubscriptions = (await servicePool.subscriptionFilterService.getSelectedSubscriptions(accountNode.account)) || <AzureResourceSubscription[]>[];
 		const selectedSubscriptionIds: string[] = [];
 		if (selectedSubscriptions.length > 0) {
 			selectedSubscriptionIds.push(...selectedSubscriptions.map((subscription) => subscription.id));
@@ -56,11 +43,11 @@ export function registerAzureResourceCommands(appContext: AppContext, tree: Azur
 			selectedSubscriptionIds.push(...subscriptions.map((subscription) => subscription.id));
 		}
 
-		interface AzureResourceSubscriptionQuickPickItem extends QuickPickItem {
-			subscription: azureResource.AzureResourceSubscription;
+		interface SubscriptionQuickPickItem extends QuickPickItem {
+			subscription: AzureResourceSubscription;
 		}
 
-		const subscriptionQuickPickItems: AzureResourceSubscriptionQuickPickItem[] = subscriptions.map((subscription) => {
+		const subscriptionItems: SubscriptionQuickPickItem[] = subscriptions.map((subscription) => {
 			return {
 				label: subscription.name,
 				picked: selectedSubscriptionIds.indexOf(subscription.id) !== -1,
@@ -68,22 +55,66 @@ export function registerAzureResourceCommands(appContext: AppContext, tree: Azur
 			};
 		});
 
-		const selectedSubscriptionQuickPickItems = (await window.showQuickPick(subscriptionQuickPickItems, { canPickMany: true }));
-		if (selectedSubscriptionQuickPickItems && selectedSubscriptionQuickPickItems.length > 0) {
+		const pickedSubscriptionItems = (await window.showQuickPick(subscriptionItems, { canPickMany: true }));
+		if (pickedSubscriptionItems && pickedSubscriptionItems.length > 0) {
 			tree.refresh(node, false);
 
-			selectedSubscriptions = selectedSubscriptionQuickPickItems.map((subscriptionItem) => subscriptionItem.subscription);
-			await subscriptionFilterService.saveSelectedSubscriptions(accountNode.account, selectedSubscriptions);
+			const pickedSubscriptions = pickedSubscriptionItems.map((subscriptionItem) => subscriptionItem.subscription);
+			await servicePool.subscriptionFilterService.saveSelectedSubscriptions(accountNode.account, pickedSubscriptions);
 		}
 	});
 
-	appContext.apiWrapper.registerCommand('azure.resource.refreshall', () => tree.notifyNodeChanged(undefined));
+	apiWrapper.registerCommand('azureresource.refreshall', () => tree.notifyNodeChanged(undefined));
 
-	appContext.apiWrapper.registerCommand('azure.resource.refresh', async (node?: TreeNode) => {
+	apiWrapper.registerCommand('azureresource.refresh', async (node?: TreeNode) => {
 		tree.refresh(node, true);
 	});
 
-	appContext.apiWrapper.registerCommand('azure.resource.signin', async (node?: TreeNode) => {
-		appContext.apiWrapper.executeCommand('sql.action.accounts.manageLinkedAccount');
+	apiWrapper.registerCommand('azureresource.connectsqldb', async (node?: TreeNode) => {
+		let connectionProfile: IConnectionProfile = {
+			id: generateGuid(),
+			connectionName: undefined,
+			serverName: undefined,
+			databaseName: undefined,
+			userName: undefined,
+			password: '',
+			authenticationType: undefined,
+			savePassword: true,
+			groupFullName: '',
+			groupId: '',
+			providerName: undefined,
+			saveProfile: true,
+			options: {
+			}
+		};
+
+		if (node instanceof AzureResourceDatabaseServerTreeNode) {
+			let databaseServer = node.databaseServer;
+			connectionProfile.connectionName = `connection to '${databaseServer.defaultDatabaseName}' on '${databaseServer.fullName}'`;
+			connectionProfile.serverName = databaseServer.fullName;
+			connectionProfile.databaseName = databaseServer.defaultDatabaseName;
+			connectionProfile.userName = databaseServer.loginName;
+			connectionProfile.authenticationType = 'SqlLogin';
+			connectionProfile.providerName = 'MSSQL';
+		}
+
+		if (node instanceof AzureResourceDatabaseTreeNode) {
+			let database = node.database;
+			connectionProfile.connectionName = `connection to '${database.name}' on '${database.serverFullName}'`;
+			connectionProfile.serverName = database.serverFullName;
+			connectionProfile.databaseName = database.name;
+			connectionProfile.userName = database.loginName;
+			connectionProfile.authenticationType = 'SqlLogin';
+			connectionProfile.providerName = 'MSSQL';
+		}
+
+		const conn = await apiWrapper.openConnectionDialog(undefined, connectionProfile, { saveConnection: true, showDashboard: true });
+		if (conn) {
+			apiWrapper.executeCommand('workbench.view.connections');
+		}
+	});
+
+	apiWrapper.registerCommand('azureresource.signin', async (node?: TreeNode) => {
+		apiWrapper.executeCommand('sql.action.accounts.manageLinkedAccount');
 	});
 }

extensions/azurecore/src/azureResource/constants.ts

@@ -6,19 +6,11 @@
 'use strict';
 
 export enum AzureResourceItemType {
-	account = 'azure.resource.itemType.account',
-	subscription = 'azure.resource.itemType.subscription',
-	databaseContainer = 'azure.resource.itemType.databaseContainer',
-	database = 'azure.resource.itemType.database',
-	databaseServerContainer = 'azure.resource.itemType.databaseServerContainer',
-	databaseServer = 'azure.resource.itemType.databaseServer',
-	message = 'azure.resource.itemType.message'
+	account = 'azureResource.itemType.account',
+	subscription = 'azureResource.itemType.subscription',
+	databaseContainer = 'azureResource.itemType.databaseContainer',
+	database = 'azureResource.itemType.database',
+	databaseServerContainer = 'azureResource.itemType.databaseServerContainer',
+	databaseServer = 'azureResource.itemType.databaseServer',
+	message = 'azureResource.itemType.message'
 }
-
-export enum AzureResourceServiceNames {
-	cacheService = 'AzureResourceCacheService',
-	accountService = 'AzureResourceAccountService',
-	subscriptionService = 'AzureResourceSubscriptionService',
-	subscriptionFilterService = 'AzureResourceSubscriptionFilterService',
-	tenantService = 'AzureResourceTenantService'
-}

extensions/azurecore/src/azureResource/errors.ts

@@ -8,7 +8,7 @@
 export class AzureResourceCredentialError extends Error {
 	constructor(
 		message: string,
-		public readonly innerError: Error
+		public innerError: Error
 	) {
 		super(message);
 	}

extensions/azurecore/src/azureResource/interfaces.ts

@@ -9,7 +9,7 @@ import { ServiceClientCredentials } from 'ms-rest';
 import { Account, DidChangeAccountsParams } from 'sqlops';
 import { Event } from 'vscode';
 
-import { azureResource } from './azure-resource';
+import { AzureResourceSubscription, AzureResourceDatabaseServer, AzureResourceDatabase } from './models';
 
 export interface IAzureResourceAccountService {
 	getAccounts(): Promise<Account[]>;
@@ -17,29 +17,38 @@ export interface IAzureResourceAccountService {
 	readonly onDidChangeAccounts: Event<DidChangeAccountsParams>;
 }
 
+export interface IAzureResourceCredentialService {
+	getCredentials(account: Account): Promise<ServiceClientCredentials[]>;
+}
+
 export interface IAzureResourceSubscriptionService {
-	getSubscriptions(account: Account, credential: ServiceClientCredentials): Promise<azureResource.AzureResourceSubscription[]>;
+	getSubscriptions(account: Account, credentials: ServiceClientCredentials[]): Promise<AzureResourceSubscription[]>;
 }
 
 export interface IAzureResourceSubscriptionFilterService {
-	getSelectedSubscriptions(account: Account): Promise<azureResource.AzureResourceSubscription[]>;
+	getSelectedSubscriptions(account: Account): Promise<AzureResourceSubscription[]>;
 
-	saveSelectedSubscriptions(account: Account, selectedSubscriptions: azureResource.AzureResourceSubscription[]): Promise<void>;
+	saveSelectedSubscriptions(account: Account, selectedSubscriptions: AzureResourceSubscription[]): Promise<void>;
+}
+
+export interface IAzureResourceDatabaseServerService {
+	getDatabaseServers(subscription: AzureResourceSubscription, credentials: ServiceClientCredentials[]): Promise<AzureResourceDatabaseServer[]>;
+}
+
+export interface IAzureResourceDatabaseService {
+	getDatabases(subscription: AzureResourceSubscription, credentials: ServiceClientCredentials[]): Promise<AzureResourceDatabase[]>;
 }
 
 export interface IAzureResourceCacheService {
-	generateKey(id: string): string;
-
 	get<T>(key: string): T | undefined;
 
 	update<T>(key: string, value: T): void;
 }
 
-export interface IAzureResourceTenantService {
-	getTenantId(subscription: azureResource.AzureResourceSubscription): Promise<string>;
-}
+export interface IAzureResourceContextService {
+	getAbsolutePath(relativePath: string): string;
 
-export interface IAzureResourceNodeWithProviderId {
-	resourceProviderId: string;
-	resourceNode: azureResource.IAzureResourceNode;
-}
+	executeCommand(commandId: string, ...args: any[]): void;
+
+	showErrorMessage(errorMessage: string): void;
+}

extensions/azurecore/src/azureResource/models.ts

@@ -5,9 +5,21 @@
 
 'use strict';
 
+export interface AzureResourceSubscription {
+	id: string;
+	name: string;
+}
+
 export interface AzureResourceDatabaseServer {
 	name: string;
 	fullName: string;
 	loginName: string;
 	defaultDatabaseName: string;
-}
+}
+
+export interface AzureResourceDatabase {
+	name: string;
+	serverName: string;
+	serverFullName: string;
+	loginName: string;
+}

extensions/azurecore/src/azureResource/providers/database/commands.ts

@@ -1,53 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { IConnectionProfile } from 'sqlops';
-import { AppContext } from '../../../appContext';
-
-import { TreeNode } from '../../treeNode';
-import { generateGuid } from '../../utils';
-import { AzureResourceItemType } from '../../constants';
-import { IAzureResourceDatabaseNode } from './interfaces';
-import { AzureResourceResourceTreeNode } from '../../resourceTreeNode';
-
-export function registerAzureResourceDatabaseCommands(appContext: AppContext): void {
-	appContext.apiWrapper.registerCommand('azure.resource.connectsqldb', async (node?: TreeNode) => {
-		if (!node)
-		{
-			return;
-		}
-
-		const treeItem = await node.getTreeItem();
-		if (treeItem.contextValue !== AzureResourceItemType.database) {
-			return;
-		}
-
-		const resourceNode = (node as AzureResourceResourceTreeNode).resourceNodeWithProviderId.resourceNode;
-		const database = (resourceNode as IAzureResourceDatabaseNode).database;
-
-		let connectionProfile: IConnectionProfile = {
-			id: generateGuid(),
-			connectionName: undefined,
-			serverName: database.serverFullName,
-			databaseName: database.name,
-			userName: database.loginName,
-			password: '',
-			authenticationType: 'SqlLogin',
-			savePassword: true,
-			groupFullName: '',
-			groupId: '',
-			providerName: 'MSSQL',
-			saveProfile: true,
-			options: {}
-		};
-
-		const conn = await appContext.apiWrapper.openConnectionDialog(undefined, connectionProfile, { saveConnection: true, showDashboard: true });
-		if (conn) {
-			appContext.apiWrapper.executeCommand('workbench.view.connections');
-		}
-	});
-}

extensions/azurecore/src/azureResource/providers/database/databaseProvider.ts

@@ -1,37 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ExtensionContext } from 'vscode';
-import { ApiWrapper } from '../../../apiWrapper';
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseService } from './interfaces';
-import { AzureResourceDatabaseTreeDataProvider } from './databaseTreeDataProvider';
-
-export class AzureResourceDatabaseProvider implements azureResource.IAzureResourceProvider {
-	public constructor(
-		databaseService: IAzureResourceDatabaseService,
-		apiWrapper: ApiWrapper,
-		extensionContext: ExtensionContext
-	) {
-		this._databaseService = databaseService;
-		this._apiWrapper = apiWrapper;
-		this._extensionContext = extensionContext;
-	}
-
-	public getTreeDataProvider(): azureResource.IAzureResourceTreeDataProvider {
-		return new AzureResourceDatabaseTreeDataProvider(this._databaseService, this._apiWrapper, this._extensionContext);
-	}
-
-	public get providerId(): string {
-		return 'azure.resource.providers.database';
-	}
-
-	private _databaseService: IAzureResourceDatabaseService = undefined;
-	private _apiWrapper: ApiWrapper = undefined;
-	private _extensionContext: ExtensionContext = undefined;
-}

extensions/azurecore/src/azureResource/providers/database/databaseService.ts

@@ -1,41 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ServiceClientCredentials } from 'ms-rest';
-import { SqlManagementClient } from 'azure-arm-sql';
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseService } from './interfaces';
-import { AzureResourceDatabase } from './models';
-
-export class AzureResourceDatabaseService implements IAzureResourceDatabaseService {
-	public async getDatabases(subscription: azureResource.AzureResourceSubscription, credential: ServiceClientCredentials): Promise<AzureResourceDatabase[]> {
-		const databases: AzureResourceDatabase[] = [];
-		const sqlManagementClient = new SqlManagementClient(credential, subscription.id);
-		const svrs = await sqlManagementClient.servers.list();
-		for (const svr of svrs) {
-			// Extract resource group name from svr.id
-			const svrIdRegExp = new RegExp(`\/subscriptions\/${subscription.id}\/resourceGroups\/(.+)\/providers\/Microsoft\.Sql\/servers\/${svr.name}`);
-			if (!svrIdRegExp.test(svr.id)) {
-				continue;
-			}
-
-			const founds = svrIdRegExp.exec(svr.id);
-			const resouceGroup = founds[1];
-
-			const dbs = await sqlManagementClient.databases.listByServer(resouceGroup, svr.name);
-			dbs.forEach((db) => databases.push({
-				name: db.name,
-				serverName: svr.name,
-				serverFullName: svr.fullyQualifiedDomainName,
-				loginName: svr.administratorLogin
-			}));
-		}
-
-		return databases;
-	}
-}

extensions/azurecore/src/azureResource/providers/database/databaseTreeDataProvider.ts

@@ -1,87 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { AzureResource } from 'sqlops';
-import { TreeItem, TreeItemCollapsibleState, ExtensionContext } from 'vscode';
-import { TokenCredentials } from 'ms-rest';
-import * as nls from 'vscode-nls';
-const localize = nls.loadMessageBundle();
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseService, IAzureResourceDatabaseNode } from './interfaces';
-import { AzureResourceDatabase } from './models';
-import { AzureResourceItemType } from '../../../azureResource/constants';
-import { ApiWrapper } from '../../../apiWrapper';
-
-export class AzureResourceDatabaseTreeDataProvider implements azureResource.IAzureResourceTreeDataProvider {
-	public constructor(
-		databaseService: IAzureResourceDatabaseService,
-		apiWrapper: ApiWrapper,
-		extensionContext: ExtensionContext
-	) {
-		this._databaseService = databaseService;
-		this._apiWrapper = apiWrapper;
-		this._extensionContext = extensionContext;
-	}
-
-	public getTreeItem(element: azureResource.IAzureResourceNode): TreeItem | Thenable<TreeItem> {
-		return element.treeItem;
-	}
-
-	public async getChildren(element?: azureResource.IAzureResourceNode): Promise<azureResource.IAzureResourceNode[]> {
-		if (!element) {
-			return [this.createContainerNode()];
-		}
-
-		const tokens = await this._apiWrapper.getSecurityToken(element.account, AzureResource.ResourceManagement);
-		const credential = new TokenCredentials(tokens[element.tenantId].token, tokens[element.tenantId].tokenType);
-
-		const databases: AzureResourceDatabase[] = (await this._databaseService.getDatabases(element.subscription, credential)) || <AzureResourceDatabase[]>[];
-
-		return databases.map((database) => <IAzureResourceDatabaseNode>{
-			account: element.account,
-			subscription: element.subscription,
-			tenantId: element.tenantId,
-			database: database,
-			treeItem: {
-				id: `databaseServer_${database.serverFullName}.database_${database.name}`,
-				label: `${database.name} (${database.serverName})`,
-				iconPath: {
-					dark: this._extensionContext.asAbsolutePath('resources/dark/sql_database_inverse.svg'),
-					light: this._extensionContext.asAbsolutePath('resources/light/sql_database.svg')
-				},
-				collapsibleState: TreeItemCollapsibleState.None,
-				contextValue: AzureResourceItemType.database
-			}
-		});
-	}
-
-	private createContainerNode(): azureResource.IAzureResourceNode {
-		return {
-			account: undefined,
-			subscription: undefined,
-			tenantId: undefined,
-			treeItem: {
-				id: AzureResourceDatabaseTreeDataProvider.containerId,
-				label: AzureResourceDatabaseTreeDataProvider.containerLabel,
-				iconPath: {
-					dark: this._extensionContext.asAbsolutePath('resources/dark/folder_inverse.svg'),
-					light: this._extensionContext.asAbsolutePath('resources/light/folder.svg')
-				},
-				collapsibleState: TreeItemCollapsibleState.Collapsed,
-				contextValue: AzureResourceItemType.databaseContainer
-			}
-		};
-	}
-
-	private _databaseService: IAzureResourceDatabaseService = undefined;
-	private _apiWrapper: ApiWrapper = undefined;
-	private _extensionContext: ExtensionContext = undefined;
-
-	private static readonly containerId = 'azure.resource.providers.database.treeDataProvider.databaseContainer';
-	private static readonly containerLabel = localize('azure.resource.providers.database.treeDataProvider.databaseContainerLabel', 'SQL Databases');
-}

extensions/azurecore/src/azureResource/providers/database/interfaces.ts

@@ -1,19 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ServiceClientCredentials } from 'ms-rest';
-
-import { azureResource } from '../../azure-resource';
-import { AzureResourceDatabase } from './models';
-
-export interface IAzureResourceDatabaseService {
-	getDatabases(subscription: azureResource.AzureResourceSubscription, credential: ServiceClientCredentials): Promise<AzureResourceDatabase[]>;
-}
-
-export interface IAzureResourceDatabaseNode extends azureResource.IAzureResourceNode {
-	readonly database: AzureResourceDatabase;
-}

extensions/azurecore/src/azureResource/providers/database/models.ts

@@ -1,13 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-export interface AzureResourceDatabase {
-	name: string;
-	serverName: string;
-	serverFullName: string;
-	loginName: string;
-}

extensions/azurecore/src/azureResource/providers/databaseServer/commands.ts

@@ -1,53 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { IConnectionProfile } from 'sqlops';
-import { AppContext } from '../../../appContext';
-
-import { TreeNode } from '../../treeNode';
-import { generateGuid } from '../../utils';
-import { AzureResourceItemType } from '../../constants';
-import { IAzureResourceDatabaseServerNode } from './interfaces';
-import { AzureResourceResourceTreeNode } from '../../resourceTreeNode';
-
-export function registerAzureResourceDatabaseServerCommands(appContext: AppContext): void {
-	appContext.apiWrapper.registerCommand('azure.resource.connectsqlserver', async (node?: TreeNode) => {
-		if (!node)
-		{
-			return;
-		}
-
-		const treeItem = await node.getTreeItem();
-		if (treeItem.contextValue !== AzureResourceItemType.databaseServer) {
-			return;
-		}
-
-		const resourceNode = (node as AzureResourceResourceTreeNode).resourceNodeWithProviderId.resourceNode;
-		const databaseServer = (resourceNode as IAzureResourceDatabaseServerNode).databaseServer;
-
-		let connectionProfile: IConnectionProfile = {
-			id: generateGuid(),
-			connectionName: undefined,
-			serverName: databaseServer.fullName,
-			databaseName: databaseServer.defaultDatabaseName,
-			userName: databaseServer.loginName,
-			password: '',
-			authenticationType: 'SqlLogin',
-			savePassword: true,
-			groupFullName: '',
-			groupId: '',
-			providerName: 'MSSQL',
-			saveProfile: true,
-			options: {}
-		};
-
-		const conn = await appContext.apiWrapper.openConnectionDialog(undefined, connectionProfile, { saveConnection: true, showDashboard: true });
-		if (conn) {
-			appContext.apiWrapper.executeCommand('workbench.view.connections');
-		}
-	});
-}

extensions/azurecore/src/azureResource/providers/databaseServer/databaseServerProvider.ts

@@ -1,37 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ExtensionContext } from 'vscode';
-import { ApiWrapper } from '../../../apiWrapper';
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseServerService } from './interfaces';
-import { AzureResourceDatabaseServerTreeDataProvider } from './databaseServerTreeDataProvider';
-
-export class AzureResourceDatabaseServerProvider implements azureResource.IAzureResourceProvider {
-	public constructor(
-		databaseServerService: IAzureResourceDatabaseServerService,
-		apiWrapper: ApiWrapper,
-		extensionContext: ExtensionContext
-	) {
-		this._databaseServerService = databaseServerService;
-		this._apiWrapper = apiWrapper;
-		this._extensionContext = extensionContext;
-	}
-
-	public getTreeDataProvider(): azureResource.IAzureResourceTreeDataProvider {
-		return new AzureResourceDatabaseServerTreeDataProvider(this._databaseServerService, this._apiWrapper, this._extensionContext);
-	}
-
-	public get providerId(): string {
-		return 'azure.resource.providers.databaseServer';
-	}
-
-	private _databaseServerService: IAzureResourceDatabaseServerService = undefined;
-	private _apiWrapper: ApiWrapper = undefined;
-	private _extensionContext: ExtensionContext = undefined;
-}

extensions/azurecore/src/azureResource/providers/databaseServer/databaseServerService.ts

@@ -1,31 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ServiceClientCredentials } from 'ms-rest';
-import { SqlManagementClient } from 'azure-arm-sql';
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseServerService } from './interfaces';
-import { AzureResourceDatabaseServer } from './models';
-
-export class AzureResourceDatabaseServerService implements IAzureResourceDatabaseServerService {
-	public async getDatabaseServers(subscription: azureResource.AzureResourceSubscription, credential: ServiceClientCredentials): Promise<AzureResourceDatabaseServer[]> {
-		const databaseServers: AzureResourceDatabaseServer[] = [];
-
-		const sqlManagementClient = new SqlManagementClient(credential, subscription.id);
-		const svrs = await sqlManagementClient.servers.list();
-
-		svrs.forEach((svr) => databaseServers.push({
-			name: svr.name,
-			 fullName: svr.fullyQualifiedDomainName,
-			 loginName: svr.administratorLogin,
-			 defaultDatabaseName: 'master'
-		}));
-
-		return databaseServers;
-	}
-}

extensions/azurecore/src/azureResource/providers/databaseServer/databaseServerTreeDataProvider.ts

@@ -1,87 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { AzureResource } from 'sqlops';
-import { TreeItem, TreeItemCollapsibleState, ExtensionContext } from 'vscode';
-import { TokenCredentials } from 'ms-rest';
-import * as nls from 'vscode-nls';
-const localize = nls.loadMessageBundle();
-
-import { azureResource } from '../../azure-resource';
-import { IAzureResourceDatabaseServerService, IAzureResourceDatabaseServerNode } from './interfaces';
-import { AzureResourceDatabaseServer } from './models';
-import { AzureResourceItemType } from '../../../azureResource/constants';
-import { ApiWrapper } from '../../../apiWrapper';
-
-export class AzureResourceDatabaseServerTreeDataProvider implements azureResource.IAzureResourceTreeDataProvider {
-	public constructor(
-		databaseServerService: IAzureResourceDatabaseServerService,
-		apiWrapper: ApiWrapper,
-		extensionContext: ExtensionContext
-	) {
-		this._databaseServerService = databaseServerService;
-		this._apiWrapper = apiWrapper;
-		this._extensionContext = extensionContext;
-	}
-
-	public getTreeItem(element: azureResource.IAzureResourceNode): TreeItem | Thenable<TreeItem> {
-		return element.treeItem;
-	}
-
-	public async getChildren(element?: azureResource.IAzureResourceNode): Promise<azureResource.IAzureResourceNode[]> {
-		if (!element) {
-			return [this.createContainerNode()];
-		}
-
-		const tokens = await this._apiWrapper.getSecurityToken(element.account, AzureResource.ResourceManagement);
-		const credential = new TokenCredentials(tokens[element.tenantId].token, tokens[element.tenantId].tokenType);
-
-		const databaseServers: AzureResourceDatabaseServer[] = (await this._databaseServerService.getDatabaseServers(element.subscription, credential)) || <AzureResourceDatabaseServer[]>[];
-
-		return databaseServers.map((databaseServer) => <IAzureResourceDatabaseServerNode>{
-			account: element.account,
-			subscription: element.subscription,
-			tenantId: element.tenantId,
-			databaseServer: databaseServer,
-			treeItem: {
-				id: `databaseServer_${databaseServer.name}`,
-				label: databaseServer.name,
-				iconPath: {
-					dark: this._extensionContext.asAbsolutePath('resources/dark/sql_server_inverse.svg'),
-					light: this._extensionContext.asAbsolutePath('resources/light/sql_server.svg')
-				},
-				collapsibleState: TreeItemCollapsibleState.None,
-				contextValue: AzureResourceItemType.databaseServer
-			}
-		});
-	}
-
-	private createContainerNode(): azureResource.IAzureResourceNode {
-		return {
-			account: undefined,
-			subscription: undefined,
-			tenantId: undefined,
-			treeItem: {
-				id: AzureResourceDatabaseServerTreeDataProvider.containerId,
-				label: AzureResourceDatabaseServerTreeDataProvider.containerLabel,
-				iconPath: {
-					dark: this._extensionContext.asAbsolutePath('resources/dark/folder_inverse.svg'),
-					light: this._extensionContext.asAbsolutePath('resources/light/folder.svg')
-				},
-				collapsibleState: TreeItemCollapsibleState.Collapsed,
-				contextValue: AzureResourceItemType.databaseServerContainer
-			}
-		};
-	}
-
-	private _databaseServerService: IAzureResourceDatabaseServerService = undefined;
-	private _apiWrapper: ApiWrapper = undefined;
-	private _extensionContext: ExtensionContext = undefined;
-
-	private static readonly containerId = 'azure.resource.providers.databaseServer.treeDataProvider.databaseServerContainer';
-	private static readonly containerLabel = localize('azure.resource.providers.databaseServer.treeDataProvider.databaseServerContainerLabel', 'SQL Servers');
-}

extensions/azurecore/src/azureResource/providers/databaseServer/interfaces.ts

@@ -1,19 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { ServiceClientCredentials }  from 'ms-rest';
-
-import { azureResource } from '../../azure-resource';
-import { AzureResourceDatabaseServer } from './models';
-
-export interface IAzureResourceDatabaseServerService {
-	getDatabaseServers(subscription: azureResource.AzureResourceSubscription, credentials: ServiceClientCredentials): Promise<AzureResourceDatabaseServer[]>;
-}
-
-export interface IAzureResourceDatabaseServerNode extends azureResource.IAzureResourceNode {
-	readonly databaseServer: AzureResourceDatabaseServer;
-}

extensions/azurecore/src/azureResource/resourceService.ts

@@ -1,129 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { extensions, TreeItem } from 'vscode';
-import { Account } from 'sqlops';
-
-import { azureResource } from './azure-resource';
-import { IAzureResourceNodeWithProviderId } from './interfaces';
-
-export class AzureResourceService {
-	private constructor() {
-	}
-
-	public static getInstance(): AzureResourceService {
-		return AzureResourceService._instance;
-	}
-
-	public async listResourceProviderIds(): Promise<string[]> {
-		await this.ensureResourceProvidersRegistered();
-
-		return Object.keys(this._resourceProviders);
-	}
-
-	public registerResourceProvider(resourceProvider: azureResource.IAzureResourceProvider): void {
-		this.doRegisterResourceProvider(resourceProvider);
-	}
-
-	public clearResourceProviders(): void {
-		this._resourceProviders = {};
-		this._treeDataProviders = {};
-		this._areResourceProvidersLoaded = false;
-	}
-
-	public async getRootChildren(resourceProviderId: string, account: Account, subscription: azureResource.AzureResourceSubscription, tenatId: string): Promise<IAzureResourceNodeWithProviderId[]> {
-		await this.ensureResourceProvidersRegistered();
-
-		if (!(resourceProviderId in this._resourceProviders)) {
-			throw new Error(`Azure resource provider doesn't exist. Id: ${resourceProviderId}`);
-		}
-
-		const treeDataProvider = this._treeDataProviders[resourceProviderId];
-		const children = await treeDataProvider.getChildren();
-
-		return children.map((child) => <IAzureResourceNodeWithProviderId>{
-			resourceProviderId: resourceProviderId,
-			resourceNode: <azureResource.IAzureResourceNode>{
-				account: account,
-				subscription: subscription,
-				tenantId: tenatId,
-				treeItem: child.treeItem
-			}
-		});
-	}
-
-	public async getChildren(resourceProviderId: string, element: azureResource.IAzureResourceNode): Promise<IAzureResourceNodeWithProviderId[]> {
-		await this.ensureResourceProvidersRegistered();
-
-		if (!(resourceProviderId in this._resourceProviders)) {
-			throw new Error(`Azure resource provider doesn't exist. Id: ${resourceProviderId}`);
-		}
-
-		const treeDataProvider = this._treeDataProviders[resourceProviderId];
-		const children = await treeDataProvider.getChildren(element);
-
-		return children.map((child) => <IAzureResourceNodeWithProviderId>{
-			resourceProviderId: resourceProviderId,
-			resourceNode: child
-		});
-	}
-
-	public async getTreeItem(resourceProviderId: string, element?: azureResource.IAzureResourceNode): Promise<TreeItem> {
-		await this.ensureResourceProvidersRegistered();
-
-		if (!(resourceProviderId in this._resourceProviders)) {
-			throw new Error(`Azure resource provider doesn't exist. Id: ${resourceProviderId}`);
-		}
-
-		const treeDataProvider = this._treeDataProviders[resourceProviderId];
-		return treeDataProvider.getTreeItem(element);
-	}
-
-	public get areResourceProvidersLoaded(): boolean {
-		return this._areResourceProvidersLoaded;
-	}
-
-	public set areResourceProvidersLoaded(value: boolean) {
-		this._areResourceProvidersLoaded = value;
-	}
-
-	private async ensureResourceProvidersRegistered(): Promise<void> {
-		if (this._areResourceProvidersLoaded) {
-			return;
-		}
-
-		for (const extension of extensions.all) {
-			const contributes = extension.packageJSON && extension.packageJSON.contributes;
-			if (!contributes) {
-				continue;
-			}
-
-			if (contributes['hasAzureResourceProviders']) {
-				await extension.activate();
-
-				if (extension.exports && extension.exports.provideResources) {
-					for (const resourceProvider of <azureResource.IAzureResourceProvider[]>extension.exports.provideResources()) {
-						this.doRegisterResourceProvider(resourceProvider);
-					}
-				}
-			}
-		}
-
-		this._areResourceProvidersLoaded = true;
-	}
-
-	private doRegisterResourceProvider(resourceProvider: azureResource.IAzureResourceProvider): void {
-		this._resourceProviders[resourceProvider.providerId] = resourceProvider;
-		this._treeDataProviders[resourceProvider.providerId] = resourceProvider.getTreeDataProvider();
-	}
-
-	private _areResourceProvidersLoaded: boolean = false;
-	private _resourceProviders: { [resourceProviderId: string]: azureResource.IAzureResourceProvider } = {};
-	private _treeDataProviders: { [resourceProviderId: string]: azureResource.IAzureResourceTreeDataProvider } = {};
-
-	private static readonly _instance = new AzureResourceService();
-}

extensions/azurecore/src/azureResource/resourceTreeNode.ts

@@ -1,79 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import { NodeInfo } from 'sqlops';
-import { TreeItem, TreeItemCollapsibleState } from 'vscode';
-import * as nls from 'vscode-nls';
-const localize = nls.loadMessageBundle();
-
-import { TreeNode } from './treeNode';
-import { AzureResourceService } from './resourceService';
-import { IAzureResourceNodeWithProviderId } from './interfaces';
-import { AzureResourceMessageTreeNode } from './messageTreeNode';
-import { AzureResourceErrorMessageUtil } from './utils';
-
-export class AzureResourceResourceTreeNode extends TreeNode {
-	public constructor(
-		public readonly resourceNodeWithProviderId: IAzureResourceNodeWithProviderId,
-		parent: TreeNode
-	) {
-		super();
-
-		this.parent = parent;
-	}
-
-	public async getChildren(): Promise<TreeNode[]> {
-		// It is a leaf node.
-		if (this.resourceNodeWithProviderId.resourceNode.treeItem.collapsibleState === TreeItemCollapsibleState.None) {
-			return <TreeNode[]>[];
-		}
-
-		try {
-			const children = await this._resourceService.getChildren(this.resourceNodeWithProviderId.resourceProviderId, this.resourceNodeWithProviderId.resourceNode);
-
-			if (children.length === 0) {
-				return [AzureResourceMessageTreeNode.create(AzureResourceResourceTreeNode.noResourcesLabel, this)];
-			} else {
-				return children.map((child) => {
-					// To make tree node's id unique, otherwise, treeModel.js would complain 'item already registered'
-					child.resourceNode.treeItem.id = `${this.resourceNodeWithProviderId.resourceNode.treeItem.id}.${child.resourceNode.treeItem.id}`;
-					return new AzureResourceResourceTreeNode(child, this);
-				});
-			}
-		} catch (error) {
-			return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
-		}
-	}
-
-	public getTreeItem(): TreeItem | Promise<TreeItem> {
-		return this._resourceService.getTreeItem(this.resourceNodeWithProviderId.resourceProviderId, this.resourceNodeWithProviderId.resourceNode);
-	}
-
-	public getNodeInfo(): NodeInfo {
-		const treeItem = this.resourceNodeWithProviderId.resourceNode.treeItem;
-
-		return {
-			label: treeItem.label,
-			isLeaf: treeItem.collapsibleState === TreeItemCollapsibleState.None ? true : false,
-			errorMessage: undefined,
-			metadata: undefined,
-			nodePath: this.generateNodePath(),
-			nodeStatus: undefined,
-			nodeType: treeItem.contextValue,
-			nodeSubType: undefined,
-			iconType: treeItem.contextValue
-		};
-	}
-
-	public get nodePathValue(): string {
-		return this.resourceNodeWithProviderId.resourceNode.treeItem.id;
-	}
-
-	private _resourceService = AzureResourceService.getInstance();
-
-	private static readonly noResourcesLabel = localize('azure.resource.resourceTreeNode.noResourcesLabel', 'No Resources found.');
-}

extensions/azurecore/src/azureResource/servicePool.ts

@@ -0,0 +1,35 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import {
+	IAzureResourceAccountService,
+	IAzureResourceCredentialService,
+	IAzureResourceSubscriptionService,
+	IAzureResourceSubscriptionFilterService,
+	IAzureResourceDatabaseService,
+	IAzureResourceDatabaseServerService,
+	IAzureResourceCacheService,
+	IAzureResourceContextService } from './interfaces';
+
+export class AzureResourceServicePool {
+	private constructor() { }
+
+	public static getInstance(): AzureResourceServicePool {
+		return AzureResourceServicePool._instance;
+	}
+
+	public contextService: IAzureResourceContextService;
+	public cacheService: IAzureResourceCacheService;
+	public accountService: IAzureResourceAccountService;
+	public credentialService: IAzureResourceCredentialService;
+	public subscriptionService: IAzureResourceSubscriptionService;
+	public subscriptionFilterService: IAzureResourceSubscriptionFilterService;
+	public databaseService: IAzureResourceDatabaseService;
+	public databaseServerService: IAzureResourceDatabaseServerService;
+
+	private static readonly _instance = new AzureResourceServicePool();
+}

extensions/azurecore/src/azureResource/services/cacheService.ts

@@ -5,30 +5,21 @@
 
 'use strict';
 
-import { ExtensionContext } from 'vscode';
+import { ExtensionContext } from "vscode";
 
-import { IAzureResourceCacheService } from '../interfaces';
+import { IAzureResourceCacheService } from "../interfaces";
 
 export class AzureResourceCacheService implements IAzureResourceCacheService {
 	public constructor(
-		context: ExtensionContext
+		public readonly context: ExtensionContext
 	) {
-		this._context = context;
 	}
 
-	public generateKey(id: string): string {
-        return `${AzureResourceCacheService.cacheKeyPrefix}.${id}`;
-    }
-
-    public get<T>(key: string): T | undefined {
-		return this._context.workspaceState.get(key);
+	public get<T>(key: string): T | undefined {
+		return this.context.workspaceState.get(key);
 	}
 
 	public update<T>(key: string, value: T): void {
-		this._context.workspaceState.update(key, value);
+		this.context.workspaceState.update(key, value);
 	}
-
-	private _context: ExtensionContext = undefined;
-
-	private static readonly cacheKeyPrefix = 'azure.resource.cache';
 }

extensions/azurecore/src/azureResource/services/contextService.ts

@@ -0,0 +1,36 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { ExtensionContext } from "vscode";
+import { ApiWrapper } from "../../apiWrapper";
+
+import { IAzureResourceContextService } from "../interfaces";
+
+export class AzureResourceContextService implements IAzureResourceContextService {
+	public constructor(
+		context: ExtensionContext,
+		apiWrapper: ApiWrapper
+	) {
+		this._context = context;
+		this._apiWrapper = apiWrapper;
+	}
+
+	public getAbsolutePath(relativePath: string): string {
+		return this._context.asAbsolutePath(relativePath);
+	}
+
+	public executeCommand(commandId: string, ...args: any[]): void {
+		this._apiWrapper.executeCommand(commandId, args);
+	}
+
+	public showErrorMessage(errorMessage: string): void {
+		this._apiWrapper.showErrorMessage(errorMessage);
+	}
+
+	private _context: ExtensionContext = undefined;
+	private _apiWrapper: ApiWrapper = undefined;
+}

extensions/azurecore/src/azureResource/services/credentialService.ts

@@ -0,0 +1,43 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { Account } from 'sqlops';
+import { TokenCredentials, ServiceClientCredentials } from 'ms-rest';
+import { ApiWrapper } from '../../apiWrapper';
+import * as nls from 'vscode-nls';
+const localize = nls.loadMessageBundle();
+
+import { IAzureResourceCredentialService } from '../interfaces';
+import { AzureResourceCredentialError } from '../errors';
+
+export class AzureResourceCredentialService implements IAzureResourceCredentialService {
+	public constructor(
+		apiWrapper: ApiWrapper
+	) {
+		this._apiWrapper = apiWrapper;
+	}
+
+	public async getCredentials(account: Account): Promise<ServiceClientCredentials[]> {
+		try {
+			let credentials: TokenCredentials[] = [];
+			let tokens = await this._apiWrapper.getSecurityToken(account);
+
+			for (let tenant of account.properties.tenants) {
+				let token = tokens[tenant.id].token;
+				let tokenType = tokens[tenant.id].tokenType;
+
+				credentials.push(new TokenCredentials(token, tokenType));
+			}
+
+			return credentials;
+		} catch (error) {
+			throw new AzureResourceCredentialError(localize('azureResource.services.credentialService.credentialError', 'Failed to get credential for account {0}. Please refresh the account.', account.key.accountId), error);
+		}
+	}
+
+	private _apiWrapper: ApiWrapper = undefined;
+}

extensions/azurecore/src/azureResource/services/databaseServerService.ts

@@ -0,0 +1,39 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { ServiceClientCredentials } from 'ms-rest';
+import { SqlManagementClient } from 'azure-arm-sql';
+
+import { IAzureResourceDatabaseServerService } from '../interfaces';
+import { AzureResourceSubscription, AzureResourceDatabaseServer } from '../models';
+
+export class AzureResourceDatabaseServerService implements IAzureResourceDatabaseServerService {
+	public async getDatabaseServers(subscription: AzureResourceSubscription, credentials: ServiceClientCredentials[]): Promise<AzureResourceDatabaseServer[]> {
+		let databaseServers: AzureResourceDatabaseServer[] = [];
+		for (let cred of credentials) {
+			let sqlManagementClient = new SqlManagementClient(cred, subscription.id);
+			try {
+				let svrs = await sqlManagementClient.servers.list();
+				svrs.forEach((svr) => databaseServers.push({
+					name: svr.name,
+					fullName: svr.fullyQualifiedDomainName,
+					loginName: svr.administratorLogin,
+					defaultDatabaseName: 'master'
+				}));
+			} catch (error) {
+				if (error.code === 'InvalidAuthenticationTokenTenant' && error.statusCode === 401) {
+					/**
+					 * There may be multiple tenants for an account and it may throw exceptions like following. Just swallow the exception here.
+					 *   The access token is from the wrong issuer. It must match one of the tenants associated with this subscription.
+					 */
+				}
+			}
+		}
+
+		return databaseServers;
+	}
+}

extensions/azurecore/src/azureResource/services/databaseService.ts

@@ -0,0 +1,51 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { ServiceClientCredentials } from 'ms-rest';
+import { SqlManagementClient } from 'azure-arm-sql';
+
+import { IAzureResourceDatabaseService } from '../interfaces';
+import { AzureResourceSubscription, AzureResourceDatabase } from '../models';
+
+export class AzureResourceDatabaseService implements IAzureResourceDatabaseService {
+	public async getDatabases(subscription: AzureResourceSubscription, credentials: ServiceClientCredentials[]): Promise<AzureResourceDatabase[]> {
+		let databases: AzureResourceDatabase[] = [];
+		for (let cred of credentials) {
+			let sqlManagementClient = new SqlManagementClient(cred, subscription.id);
+			try {
+				let svrs = await sqlManagementClient.servers.list();
+				for (let svr of svrs) {
+					// Extract resource group name from svr.id
+					let svrIdRegExp = new RegExp(`\/subscriptions\/${subscription.id}\/resourceGroups\/(.+)\/providers\/Microsoft\.Sql\/servers\/${svr.name}`);
+					if (!svrIdRegExp.test(svr.id)) {
+						continue;
+					}
+
+					let founds = svrIdRegExp.exec(svr.id);
+					let resouceGroup = founds[1];
+
+					let dbs = await sqlManagementClient.databases.listByServer(resouceGroup, svr.name);
+					dbs.forEach((db) => databases.push({
+						name: db.name,
+						serverName: svr.name,
+						serverFullName: svr.fullyQualifiedDomainName,
+						loginName: svr.administratorLogin
+					}));
+				}
+			} catch (error) {
+				if (error.code === 'InvalidAuthenticationTokenTenant' && error.statusCode === 401) {
+					/**
+					 * There may be multiple tenants for an account and it may throw exceptions like following. Just swallow the exception here.
+					 *   The access token is from the wrong issuer. It must match one of the tenants associated with this subscription.
+					 */
+				}
+			}
+		}
+
+		return databases;
+	}
+}

extensions/azurecore/src/azureResource/services/subscriptionFilterService.ts

@@ -8,11 +8,11 @@
 import { WorkspaceConfiguration, ConfigurationTarget } from 'vscode';
 import { Account } from 'sqlops';
 
-import { azureResource } from '../azure-resource';
 import { IAzureResourceSubscriptionFilterService, IAzureResourceCacheService } from '../interfaces';
+import { AzureResourceSubscription } from '../models';
 
 interface AzureResourceSelectedSubscriptionsCache {
-	selectedSubscriptions: { [accountId: string]: azureResource.AzureResourceSubscription[]};
+	selectedSubscriptions: { [accountId: string]: AzureResourceSubscription[]};
 }
 
 export class AzureResourceSubscriptionFilterService implements IAzureResourceSubscriptionFilterService {
@@ -20,14 +20,12 @@ export class AzureResourceSubscriptionFilterService implements IAzureResourceSub
 		cacheService: IAzureResourceCacheService
 	) {
 		this._cacheService = cacheService;
-
-		this._cacheKey = this._cacheService.generateKey('selectedSubscriptions');
 	}
 
-	public async getSelectedSubscriptions(account: Account): Promise<azureResource.AzureResourceSubscription[]> {
-		let selectedSubscriptions: azureResource.AzureResourceSubscription[] = [];
+	public async getSelectedSubscriptions(account: Account): Promise<AzureResourceSubscription[]> {
+		let selectedSubscriptions: AzureResourceSubscription[] = [];
 
-		const cache = this._cacheService.get<AzureResourceSelectedSubscriptionsCache>(this._cacheKey);
+		const cache = this._cacheService.get<AzureResourceSelectedSubscriptionsCache>(AzureResourceSubscriptionFilterService.CacheKey);
 		if (cache) {
 			selectedSubscriptions = cache.selectedSubscriptions[account.key.accountId];
 		}
@@ -35,10 +33,10 @@ export class AzureResourceSubscriptionFilterService implements IAzureResourceSub
 		return selectedSubscriptions;
 	}
 
-	public async saveSelectedSubscriptions(account: Account, selectedSubscriptions: azureResource.AzureResourceSubscription[]): Promise<void> {
-		let selectedSubscriptionsCache: { [accountId: string]: azureResource.AzureResourceSubscription[]} = {};
+	public async saveSelectedSubscriptions(account: Account, selectedSubscriptions: AzureResourceSubscription[]): Promise<void> {
+		let selectedSubscriptionsCache: { [accountId: string]: AzureResourceSubscription[]} = {};
 
-		const cache = this._cacheService.get<AzureResourceSelectedSubscriptionsCache>(this._cacheKey);
+		const cache = this._cacheService.get<AzureResourceSelectedSubscriptionsCache>(AzureResourceSubscriptionFilterService.CacheKey);
 		if (cache) {
 			selectedSubscriptionsCache = cache.selectedSubscriptions;
 		}
@@ -49,14 +47,14 @@ export class AzureResourceSubscriptionFilterService implements IAzureResourceSub
 
 		selectedSubscriptionsCache[account.key.accountId] = selectedSubscriptions;
 
-		this._cacheService.update<AzureResourceSelectedSubscriptionsCache>(this._cacheKey, { selectedSubscriptions: selectedSubscriptionsCache });
+		this._cacheService.update<AzureResourceSelectedSubscriptionsCache>(AzureResourceSubscriptionFilterService.CacheKey, { selectedSubscriptions: selectedSubscriptionsCache });
 
 		const filters: string[] = [];
 		for (const accountId in selectedSubscriptionsCache) {
 			filters.push(...selectedSubscriptionsCache[accountId].map((subcription) => `${accountId}/${subcription.id}/${subcription.name}`));
 		}
 
-		const resourceFilterConfig = this._config.inspect<string[]>(AzureResourceSubscriptionFilterService.filterConfigName);
+		const resourceFilterConfig = this._config.inspect<string[]>(AzureResourceSubscriptionFilterService.FilterConfigName);
 		let configTarget = ConfigurationTarget.Global;
 		if (resourceFilterConfig) {
 			if (resourceFilterConfig.workspaceFolderValue) {
@@ -68,12 +66,12 @@ export class AzureResourceSubscriptionFilterService implements IAzureResourceSub
 			}
 		}
 
-		await this._config.update(AzureResourceSubscriptionFilterService.filterConfigName, filters, configTarget);
+		await this._config.update(AzureResourceSubscriptionFilterService.FilterConfigName, filters, configTarget);
 	}
 
 	private _config: WorkspaceConfiguration = undefined;
 	private _cacheService: IAzureResourceCacheService = undefined;
-	private _cacheKey: string = undefined;
 
-	private static readonly filterConfigName = 'azure.resource.config.filter';
+	private static readonly FilterConfigName = 'resourceFilter';
+	private static readonly CacheKey = 'azureResource.cache.selectedSubscriptions';
 }

extensions/azurecore/src/azureResource/services/subscriptionService.ts

@@ -9,19 +9,24 @@ import { Account } from 'sqlops';
 import { ServiceClientCredentials } from 'ms-rest';
 import { SubscriptionClient } from 'azure-arm-resource';
 
-import { azureResource } from '../azure-resource';
 import { IAzureResourceSubscriptionService } from '../interfaces';
+import { AzureResourceSubscription } from '../models';
 
 export class AzureResourceSubscriptionService implements IAzureResourceSubscriptionService {
-	public async getSubscriptions(account: Account, credential: ServiceClientCredentials): Promise<azureResource.AzureResourceSubscription[]> {
-		const subscriptions: azureResource.AzureResourceSubscription[] = [];
-
-		const subClient = new SubscriptionClient.SubscriptionClient(credential);
-		const subs = await subClient.subscriptions.list();
-		subs.forEach((sub) => subscriptions.push({
-			id: sub.subscriptionId,
-			name: sub.displayName
-		}));
+	public async getSubscriptions(account: Account, credentials: ServiceClientCredentials[]): Promise<AzureResourceSubscription[]> {
+		let subscriptions: AzureResourceSubscription[] = [];
+		for (let cred of credentials) {
+			let subClient = new SubscriptionClient.SubscriptionClient(cred);
+			try {
+				let subs = await subClient.subscriptions.list();
+				subs.forEach((sub) => subscriptions.push({
+					id: sub.subscriptionId,
+					name: sub.displayName
+				}));
+			} catch (error) {
+				// Swallow the exception here.
+			}
+		}
 
 		return subscriptions;
 	}

extensions/azurecore/src/azureResource/services/tenantService.ts

@@ -1,32 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import * as request from 'request';
-
-import { azureResource } from '../azure-resource';
-import { IAzureResourceTenantService } from '../interfaces';
-
-export class AzureResourceTenantService implements IAzureResourceTenantService {
-	public async getTenantId(subscription: azureResource.AzureResourceSubscription): Promise<string> {
-		const requestPromisified = new Promise<string>((resolve, reject) => {
-			const url = `https://management.azure.com/subscriptions/${subscription.id}?api-version=2014-04-01`;
-			request(url, function (error, response, body) {
-				if (response.statusCode === 401) {
-					const tenantIdRegEx = /authorization_uri="https:\/\/login\.windows\.net\/([0-9a-fA-F]{8}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{12})"/;
-					const teantIdString = response.headers['www-authenticate'];
-					if (tenantIdRegEx.test(teantIdString)) {
-						resolve(tenantIdRegEx.exec(teantIdString)[1]);
-					} else {
-						reject();
-					}
-				}
-			});
-		});
-
-		return await requestPromisified;
-	}
-}

extensions/azurecore/src/azureResource/tree/accountNotSignedInTreeNode.ts

@@ -7,10 +7,10 @@
 
 import { TreeItem, TreeItemCollapsibleState } from 'vscode';
 import { NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
 import * as nls from 'vscode-nls';
 const localize = nls.loadMessageBundle();
 
-import { TreeNode } from '../treeNode';
 import { AzureResourceItemType } from '../constants';
 
 export class AzureResourceAccountNotSignedInTreeNode extends TreeNode {
@@ -19,11 +19,11 @@ export class AzureResourceAccountNotSignedInTreeNode extends TreeNode {
 	}
 
 	public getTreeItem(): TreeItem | Promise<TreeItem> {
-		let item = new TreeItem(AzureResourceAccountNotSignedInTreeNode.signInLabel, TreeItemCollapsibleState.None);
+		let item = new TreeItem(AzureResourceAccountNotSignedInTreeNode.SignInLabel, TreeItemCollapsibleState.None);
 		item.contextValue = AzureResourceItemType.message;
 		item.command = {
-			title: AzureResourceAccountNotSignedInTreeNode.signInLabel,
-			command: 'azure.resource.signin',
+			title: AzureResourceAccountNotSignedInTreeNode.SignInLabel,
+			command: 'azureresource.signin',
 			arguments: [this]
 		};
 		return item;
@@ -31,7 +31,7 @@ export class AzureResourceAccountNotSignedInTreeNode extends TreeNode {
 
 	public getNodeInfo(): NodeInfo {
 		return {
-			label: AzureResourceAccountNotSignedInTreeNode.signInLabel,
+			label: AzureResourceAccountNotSignedInTreeNode.SignInLabel,
 			isLeaf: true,
 			errorMessage: undefined,
 			metadata: undefined,
@@ -47,5 +47,5 @@ export class AzureResourceAccountNotSignedInTreeNode extends TreeNode {
 		return 'message_accountNotSignedIn';
 	}
 
-	private static readonly signInLabel = localize('azure.resource.tree.accountNotSignedInTreeNode.signInLabel', 'Sign in to Azure ...');
+	private static readonly SignInLabel = localize('azureResource.tree.accountNotSignedInTreeNode.signIn', 'Sign in to Azure ...');
 }

extensions/azurecore/src/azureResource/tree/accountTreeNode.ts

@@ -6,59 +6,44 @@
 'use strict';
 
 import { TreeItem, TreeItemCollapsibleState } from 'vscode';
-import { Account, NodeInfo, AzureResource } from 'sqlops';
-import { TokenCredentials } from 'ms-rest';
-import { AppContext } from '../../appContext';
+import { Account, NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
 import * as nls from 'vscode-nls';
 const localize = nls.loadMessageBundle();
 
-import { azureResource } from '../azure-resource';
-import { TreeNode } from '../treeNode';
-import { AzureResourceCredentialError } from '../errors';
 import { AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
-import { AzureResourceItemType, AzureResourceServiceNames } from '../constants';
+import { AzureResourceItemType } from '../constants';
 import { AzureResourceSubscriptionTreeNode } from './subscriptionTreeNode';
-import { AzureResourceMessageTreeNode } from '../messageTreeNode';
+import { AzureResourceMessageTreeNode } from './messageTreeNode';
 import { AzureResourceErrorMessageUtil } from '../utils';
-import { IAzureResourceTreeChangeHandler } from './treeChangeHandler';
-import { IAzureResourceSubscriptionService, IAzureResourceSubscriptionFilterService, IAzureResourceTenantService } from '../../azureResource/interfaces';
+import { AzureResourceSubscription } from '../models';
+import { IAzureResourceTreeChangeHandler } from './treeProvider';
 
 export class AzureResourceAccountTreeNode extends AzureResourceContainerTreeNodeBase {
 	public constructor(
-		public readonly account: Account,
-		appContext: AppContext,
+		account: Account,
 		treeChangeHandler: IAzureResourceTreeChangeHandler
 	) {
-		super(appContext, treeChangeHandler, undefined);
-
-		this._subscriptionService = this.appContext.getService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService);
-		this._subscriptionFilterService = this.appContext.getService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService);
-		this._tenantService = this.appContext.getService<IAzureResourceTenantService>(AzureResourceServiceNames.tenantService);
+		super(account, treeChangeHandler, undefined);
 
 		this._id = `account_${this.account.key.accountId}`;
-		this.setCacheKey(`${this._id}.subscriptions`);
 		this._label = this.generateLabel();
 	}
 
 	public async getChildren(): Promise<TreeNode[]> {
 		try {
-			let subscriptions: azureResource.AzureResourceSubscription[] = [];
+			let subscriptions: AzureResourceSubscription[] = [];
 
 			if (this._isClearingCache) {
-				try {
-				    const tokens = await this.appContext.apiWrapper.getSecurityToken(this.account, AzureResource.ResourceManagement);
+				const credentials = await this.getCredentials();
+				subscriptions = (await this.servicePool.subscriptionService.getSubscriptions(this.account, credentials)) || <AzureResourceSubscription[]>[];
 
-					for (const tenant of this.account.properties.tenants) {
-						const token = tokens[tenant.id].token;
-						const tokenType = tokens[tenant.id].tokenType;
-
-						subscriptions.push(...(await this._subscriptionService.getSubscriptions(this.account, new TokenCredentials(token, tokenType)) || <azureResource.AzureResourceSubscription[]>[]));
-					}
-				} catch (error) {
-					throw new AzureResourceCredentialError(localize('azure.resource.tree.accountTreeNode.credentialError', 'Failed to get credential for account {0}. Please refresh the account.', this.account.key.accountId), error);
+				let cache = this.getCache<AzureResourceSubscriptionsCache>();
+				if (!cache) {
+					cache = { subscriptions: { } };
 				}
-
-				this.updateCache<azureResource.AzureResourceSubscription[]>(subscriptions);
+				cache.subscriptions[this.account.key.accountId] = subscriptions;
+				this.updateCache<AzureResourceSubscriptionsCache>(cache);
 
 				this._isClearingCache = false;
 			} else {
@@ -67,8 +52,8 @@ export class AzureResourceAccountTreeNode extends AzureResourceContainerTreeNode
 
 			this._totalSubscriptionCount = subscriptions.length;
 
-			const selectedSubscriptions = await this._subscriptionFilterService.getSelectedSubscriptions(this.account);
-			const selectedSubscriptionIds = (selectedSubscriptions || <azureResource.AzureResourceSubscription[]>[]).map((subscription) => subscription.id);
+			let selectedSubscriptions = await this.servicePool.subscriptionFilterService.getSelectedSubscriptions(this.account);
+			let selectedSubscriptionIds = (selectedSubscriptions || <AzureResourceSubscription[]>[]).map((subscription) => subscription.id);
 			if (selectedSubscriptionIds.length > 0) {
 				subscriptions = subscriptions.filter((subscription) => selectedSubscriptionIds.indexOf(subscription.id) !== -1);
 				this._selectedSubscriptionCount = selectedSubscriptionIds.length;
@@ -80,36 +65,31 @@ export class AzureResourceAccountTreeNode extends AzureResourceContainerTreeNode
 			this.refreshLabel();
 
 			if (subscriptions.length === 0) {
-				return [AzureResourceMessageTreeNode.create(AzureResourceAccountTreeNode.noSubscriptionsLabel, this)];
+				return [AzureResourceMessageTreeNode.create(AzureResourceAccountTreeNode.NoSubscriptions, this)];
 			} else {
-				return await Promise.all(subscriptions.map(async (subscription) => {
-					const tenantId = await this._tenantService.getTenantId(subscription);
-
-					return new AzureResourceSubscriptionTreeNode(this.account, subscription, tenantId, this.appContext, this.treeChangeHandler, this);
-				}));
+				return subscriptions.map((subscription) => new AzureResourceSubscriptionTreeNode(subscription, this.account, this.treeChangeHandler, this));
 			}
 		} catch (error) {
-			if (error instanceof AzureResourceCredentialError) {
-				this.appContext.apiWrapper.showErrorMessage(error.message);
-
-				this.appContext.apiWrapper.executeCommand('azure.resource.signin');
-			} else {
-				return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
-			}
+			return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
 		}
 	}
 
-	public async getCachedSubscriptions(): Promise<azureResource.AzureResourceSubscription[]> {
-		return this.getCache<azureResource.AzureResourceSubscription[]>();
+	public async getCachedSubscriptions(): Promise<AzureResourceSubscription[]> {
+		const subscriptions: AzureResourceSubscription[] = [];
+		const cache = this.getCache<AzureResourceSubscriptionsCache>();
+		if (cache) {
+			subscriptions.push(...cache.subscriptions[this.account.key.accountId]);
+		}
+		return subscriptions;
 	}
 
 	public getTreeItem(): TreeItem | Promise<TreeItem> {
-		const item = new TreeItem(this._label, TreeItemCollapsibleState.Collapsed);
+		let item = new TreeItem(this._label, TreeItemCollapsibleState.Collapsed);
 		item.id = this._id;
 		item.contextValue = AzureResourceItemType.account;
 		item.iconPath = {
-			dark: this.appContext.extensionContext.asAbsolutePath('resources/dark/account_inverse.svg'),
-			light: this.appContext.extensionContext.asAbsolutePath('resources/light/account.svg')
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/account_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/account.svg')
 		};
 		return item;
 	}
@@ -148,6 +128,10 @@ export class AzureResourceAccountTreeNode extends AzureResourceContainerTreeNode
 		}
 	}
 
+	protected get cacheKey(): string {
+		return 'azureResource.cache.subscriptions';
+	}
+
 	private generateLabel(): string {
 		let label = `${this.account.displayInfo.displayName} (${this.account.key.accountId})`;
 
@@ -158,14 +142,14 @@ export class AzureResourceAccountTreeNode extends AzureResourceContainerTreeNode
 		return label;
 	}
 
-	private _subscriptionService: IAzureResourceSubscriptionService = undefined;
-	private _subscriptionFilterService: IAzureResourceSubscriptionFilterService = undefined;
-	private _tenantService: IAzureResourceTenantService = undefined;
-
 	private _id: string = undefined;
 	private _label: string = undefined;
 	private _totalSubscriptionCount = 0;
 	private _selectedSubscriptionCount = 0;
 
-	private static readonly noSubscriptionsLabel = localize('azure.resource.tree.accountTreeNode.noSubscriptionsLabel', 'No Subscriptions found.');
-}
+	private static readonly NoSubscriptions = localize('azureResource.tree.accountTreeNode.noSubscriptions', 'No Subscriptions found.');
+}
+
+interface AzureResourceSubscriptionsCache {
+	subscriptions: { [accountId: string]: AzureResourceSubscription[] };
+}

extensions/azurecore/src/azureResource/tree/baseTreeNodes.ts

@@ -5,16 +5,16 @@
 
 'use strict';
 
-import { AppContext } from '../../appContext';
+import { Account } from 'sqlops';
+import { ServiceClientCredentials } from 'ms-rest';
+import { TreeNode } from '../../treeNodes';
 
-import { TreeNode } from '../treeNode';
+import { AzureResourceServicePool } from '../servicePool';
+import { AzureResourceCredentialError } from '../errors';
 import { IAzureResourceTreeChangeHandler } from './treeChangeHandler';
-import { IAzureResourceCacheService } from '../../azureResource/interfaces';
-import { AzureResourceServiceNames } from '../constants';
 
 export abstract class AzureResourceTreeNodeBase extends TreeNode {
 	public constructor(
-		public readonly appContext: AppContext,
 		public readonly treeChangeHandler: IAzureResourceTreeChangeHandler,
 		parent: TreeNode
 	) {
@@ -22,17 +22,17 @@ export abstract class AzureResourceTreeNodeBase extends TreeNode {
 
 		this.parent = parent;
 	}
+
+	public readonly servicePool = AzureResourceServicePool.getInstance();
 }
 
 export abstract class AzureResourceContainerTreeNodeBase extends AzureResourceTreeNodeBase {
 	public constructor(
-		appContext: AppContext,
+		public readonly account: Account,
 		treeChangeHandler: IAzureResourceTreeChangeHandler,
 		parent: TreeNode
 	) {
-		super(appContext, treeChangeHandler, parent);
-
-		this._cacheService = this.appContext.getService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService);
+		super(treeChangeHandler, parent);
 	}
 
 	public clearCache(): void {
@@ -43,19 +43,29 @@ export abstract class AzureResourceContainerTreeNodeBase extends AzureResourceTr
 		return this._isClearingCache;
 	}
 
-	protected setCacheKey(id: string): void {
-        this._cacheKey = this._cacheService.generateKey(id);
-    }
+	protected async getCredentials(): Promise<ServiceClientCredentials[]> {
+		try {
+			return await this.servicePool.credentialService.getCredentials(this.account);
+		} catch (error) {
+			if (error instanceof AzureResourceCredentialError) {
+				this.servicePool.contextService.showErrorMessage(error.message);
+
+				this.servicePool.contextService.executeCommand('azureresource.signin');
+			} else {
+				throw error;
+			}
+		}
+	}
 
 	protected updateCache<T>(cache: T): void {
-		this._cacheService.update<T>(this._cacheKey, cache);
+		this.servicePool.cacheService.update<T>(this.cacheKey, cache);
 	}
 
 	protected getCache<T>(): T {
-		return this._cacheService.get<T>(this._cacheKey);
+		return this.servicePool.cacheService.get<T>(this.cacheKey);
 	}
 
+	protected abstract get cacheKey(): string;
+
 	protected _isClearingCache = true;
-	private _cacheService: IAzureResourceCacheService = undefined;
-	private _cacheKey: string = undefined;
 }

extensions/azurecore/src/azureResource/tree/databaseContainerTreeNode.ts

@@ -0,0 +1,103 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { TreeItem, TreeItemCollapsibleState } from 'vscode';
+import { Account, NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
+import * as nls from 'vscode-nls';
+const localize = nls.loadMessageBundle();
+
+import { AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceItemType } from '../constants';
+import { AzureResourceErrorMessageUtil } from '../utils';
+import { AzureResourceDatabaseTreeNode } from './databaseTreeNode';
+import { AzureResourceMessageTreeNode } from './messageTreeNode';
+import { AzureResourceSubscription, AzureResourceDatabase } from '../models';
+import { IAzureResourceTreeChangeHandler } from './treeProvider';
+
+export class AzureResourceDatabaseContainerTreeNode extends AzureResourceContainerTreeNodeBase {
+	public constructor(
+		public readonly subscription: AzureResourceSubscription,
+		account: Account,
+		treeChangeHandler: IAzureResourceTreeChangeHandler,
+		parent: TreeNode
+	) {
+		super(account, treeChangeHandler, parent);
+	}
+
+	public async getChildren(): Promise<TreeNode[]> {
+		try {
+			let databases: AzureResourceDatabase[] = [];
+
+			if (this._isClearingCache) {
+				let credentials = await this.getCredentials();
+				databases = (await this.servicePool.databaseService.getDatabases(this.subscription, credentials)) || <AzureResourceDatabase[]>[];
+
+				let cache = this.getCache<AzureResourceDatabasesCache>();
+				if (!cache) {
+					cache = { databases: { } };
+				}
+				cache.databases[this.subscription.id] = databases;
+				this.updateCache(cache);
+
+				this._isClearingCache = false;
+			} else {
+				const cache = this.getCache<AzureResourceDatabasesCache>();
+				if (cache) {
+					databases = cache.databases[this.subscription.id] || <AzureResourceDatabase[]>[];
+				}
+			}
+
+			if (databases.length === 0) {
+				return [AzureResourceMessageTreeNode.create(AzureResourceDatabaseContainerTreeNode.NoDatabases, this)];
+			} else {
+				return databases.map((database) => new AzureResourceDatabaseTreeNode(database, this.treeChangeHandler, this));
+			}
+		} catch (error) {
+			return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
+		}
+	}
+
+	public getTreeItem(): TreeItem | Promise<TreeItem> {
+		let item = new TreeItem(AzureResourceDatabaseContainerTreeNode.Label, TreeItemCollapsibleState.Collapsed);
+		item.contextValue = AzureResourceItemType.databaseContainer;
+		item.iconPath = {
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/folder_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/folder.svg')
+		};
+		return item;
+	}
+
+	public getNodeInfo(): NodeInfo {
+		return {
+			label: AzureResourceDatabaseContainerTreeNode.Label,
+			isLeaf: false,
+			errorMessage: undefined,
+			metadata: undefined,
+			nodePath: this.generateNodePath(),
+			nodeStatus: undefined,
+			nodeType: AzureResourceItemType.databaseContainer,
+			nodeSubType: undefined,
+			iconType: AzureResourceItemType.databaseContainer
+		};
+	}
+
+	public get nodePathValue(): string {
+		return 'databaseContainer';
+	}
+
+	protected get cacheKey(): string {
+		return 'azureResource.cache.databases';
+	}
+
+	private static readonly Label = localize('azureResource.tree.databaseContainerTreeNode.label', 'SQL Databases');
+	private static readonly NoDatabases = localize('azureResource.tree.databaseContainerTreeNode.noDatabases', 'No SQL Databases found.');
+}
+
+interface AzureResourceDatabasesCache {
+	databases: { [subscriptionId: string]: AzureResourceDatabase[] };
+}

extensions/azurecore/src/azureResource/tree/databaseServerContainerTreeNode.ts

@@ -0,0 +1,103 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { TreeItem, TreeItemCollapsibleState } from 'vscode';
+import { Account, NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
+import * as nls from 'vscode-nls';
+const localize = nls.loadMessageBundle();
+
+import { AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceItemType } from '../constants';
+import { AzureResourceMessageTreeNode } from './messageTreeNode';
+import { AzureResourceErrorMessageUtil } from '../utils';
+import { AzureResourceSubscription, AzureResourceDatabaseServer } from '../models';
+import { AzureResourceDatabaseServerTreeNode } from './databaseServerTreeNode';
+import { IAzureResourceTreeChangeHandler } from './treeProvider';
+
+export class AzureResourceDatabaseServerContainerTreeNode extends AzureResourceContainerTreeNodeBase {
+	public constructor(
+		public readonly subscription: AzureResourceSubscription,
+		account: Account,
+		treeChangeHandler: IAzureResourceTreeChangeHandler,
+		parent: TreeNode
+	) {
+		super(account, treeChangeHandler, parent);
+	}
+
+	public async getChildren(): Promise<TreeNode[]> {
+		try {
+			let databaseServers: AzureResourceDatabaseServer[] = [];
+
+			if (this._isClearingCache) {
+				let credentials = await this.getCredentials();
+				databaseServers = (await this.servicePool.databaseServerService.getDatabaseServers(this.subscription, credentials)) || <AzureResourceDatabaseServer[]>[];
+
+				let cache = this.getCache<AzureResourceDatabaseServersCache>();
+				if (!cache) {
+					cache = { databaseServers: { } };
+				}
+				cache.databaseServers[this.subscription.id] = databaseServers;
+				this.updateCache<AzureResourceDatabaseServersCache>(cache);
+
+				this._isClearingCache = false;
+			} else {
+				const cache = this.getCache<AzureResourceDatabaseServersCache>();
+				if (cache) {
+					databaseServers = cache.databaseServers[this.subscription.id] || <AzureResourceDatabaseServer[]>[];
+				}
+			}
+
+			if (databaseServers.length === 0) {
+				return [AzureResourceMessageTreeNode.create(AzureResourceDatabaseServerContainerTreeNode.NoDatabaseServers, this)];
+			} else {
+				return databaseServers.map((server) => new AzureResourceDatabaseServerTreeNode(server, this.treeChangeHandler, this));
+			}
+		} catch (error) {
+			return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
+		}
+	}
+
+	public getTreeItem(): TreeItem | Promise<TreeItem> {
+		let item = new TreeItem(AzureResourceDatabaseServerContainerTreeNode.Label, TreeItemCollapsibleState.Collapsed);
+		item.contextValue = AzureResourceItemType.databaseServerContainer;
+		item.iconPath = {
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/folder_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/folder.svg')
+		};
+		return item;
+	}
+
+	public getNodeInfo(): NodeInfo {
+		return {
+			label: AzureResourceDatabaseServerContainerTreeNode.Label,
+			isLeaf: false,
+			errorMessage: undefined,
+			metadata: undefined,
+			nodePath: this.generateNodePath(),
+			nodeStatus: undefined,
+			nodeType: AzureResourceItemType.databaseServerContainer,
+			nodeSubType: undefined,
+			iconType: AzureResourceItemType.databaseServerContainer
+		};
+	}
+
+	public get nodePathValue(): string {
+		return 'databaseServerContainer';
+	}
+
+	protected get cacheKey(): string {
+		return 'azureResource.cache.databaseServers';
+	}
+
+	private static readonly Label = localize('azureResource.tree.databaseServerContainerTreeNode.label', 'SQL Servers');
+	private static readonly NoDatabaseServers = localize('azureResource.tree.databaseContainerTreeNode.noDatabaseServers', 'No SQL Servers found.');
+}
+
+interface AzureResourceDatabaseServersCache {
+	databaseServers: { [subscriptionId: string]: AzureResourceDatabaseServer[] };
+}

extensions/azurecore/src/azureResource/tree/databaseServerTreeNode.ts

@@ -0,0 +1,57 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { TreeItem, TreeItemCollapsibleState } from 'vscode';
+import { NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
+
+import { AzureResourceTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceItemType } from '../constants';
+import { AzureResourceDatabaseServer } from '../models';
+import { IAzureResourceTreeChangeHandler } from './treeProvider';
+
+export class AzureResourceDatabaseServerTreeNode extends AzureResourceTreeNodeBase {
+	public constructor(
+		public readonly databaseServer: AzureResourceDatabaseServer,
+		treeChangeHandler: IAzureResourceTreeChangeHandler,
+		parent: TreeNode
+	) {
+		super(treeChangeHandler, parent);
+	}
+
+	public async getChildren(): Promise<TreeNode[]> {
+		return [];
+	}
+
+	public getTreeItem(): TreeItem | Promise<TreeItem> {
+		let item = new TreeItem(this.databaseServer.name, TreeItemCollapsibleState.None);
+		item.contextValue = AzureResourceItemType.databaseServer;
+		item.iconPath = {
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/sql_server_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/sql_server.svg')
+		};
+		return item;
+	}
+
+	public getNodeInfo(): NodeInfo {
+		return {
+			label: this.databaseServer.name,
+			isLeaf: true,
+			errorMessage: undefined,
+			metadata: undefined,
+			nodePath: this.generateNodePath(),
+			nodeStatus: undefined,
+			nodeType: AzureResourceItemType.databaseServer,
+			nodeSubType: undefined,
+			iconType: AzureResourceItemType.databaseServer
+		};
+	}
+
+	public get nodePathValue(): string {
+		return `databaseServer_${this.databaseServer.name}`;
+	}
+}

extensions/azurecore/src/azureResource/tree/databaseTreeNode.ts

@@ -0,0 +1,61 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import { TreeItem, TreeItemCollapsibleState } from 'vscode';
+import { NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
+
+import { AzureResourceTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceItemType } from '../constants';
+import { AzureResourceDatabase } from '../models';
+import { IAzureResourceTreeChangeHandler } from './treeProvider';
+
+export class AzureResourceDatabaseTreeNode extends AzureResourceTreeNodeBase {
+	public constructor(
+		public readonly database: AzureResourceDatabase,
+		treeChangeHandler: IAzureResourceTreeChangeHandler,
+		parent: TreeNode
+	) {
+		super(treeChangeHandler, parent);
+
+		this._label = `${this.database.name} (${this.database.serverName})`;
+	}
+
+	public async getChildren(): Promise<TreeNode[]> {
+		return [];
+	}
+
+	public getTreeItem(): TreeItem | Promise<TreeItem> {
+		let item = new TreeItem(this._label, TreeItemCollapsibleState.None);
+		item.contextValue = AzureResourceItemType.database;
+		item.iconPath = {
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/sql_database_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/sql_database.svg')
+		};
+		return item;
+	}
+
+	public getNodeInfo(): NodeInfo {
+		return {
+			label: this._label,
+			isLeaf: true,
+			errorMessage: undefined,
+			metadata: undefined,
+			nodePath: this.generateNodePath(),
+			nodeStatus: undefined,
+			nodeType: AzureResourceItemType.database,
+			nodeSubType: undefined,
+			iconType: AzureResourceItemType.database
+		};
+	}
+
+	public get nodePathValue(): string {
+		return `database_${this.database.name}`;
+	}
+
+	private _label: string = undefined;
+}

extensions/azurecore/src/azureResource/tree/messageTreeNode.ts

@@ -7,9 +7,9 @@
 
 import { TreeItem, TreeItemCollapsibleState } from 'vscode';
 import { NodeInfo } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
 
-import { TreeNode } from './treeNode';
-import { AzureResourceItemType } from './constants';
+import { AzureResourceItemType } from '../constants';
 
 export class AzureResourceMessageTreeNode extends TreeNode {
 	public constructor(

extensions/azurecore/src/azureResource/tree/subscriptionTreeNode.ts

@@ -7,66 +7,38 @@
 
 import { TreeItem, TreeItemCollapsibleState } from 'vscode';
 import { Account, NodeInfo } from 'sqlops';
-import { AppContext } from '../../appContext';
-import * as nls from 'vscode-nls';
-const localize = nls.loadMessageBundle();
+import { TreeNode } from '../../treeNodes';
 
-import { azureResource } from '../azure-resource';
-import { TreeNode } from '../treeNode';
-import { IAzureResourceNodeWithProviderId } from '../interfaces';
-import { AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceTreeNodeBase, AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
 import { AzureResourceItemType } from '../constants';
+import { AzureResourceDatabaseContainerTreeNode } from './databaseContainerTreeNode';
+import { AzureResourceDatabaseServerContainerTreeNode } from './databaseServerContainerTreeNode';
+import { AzureResourceSubscription } from '../models';
 import { IAzureResourceTreeChangeHandler } from './treeChangeHandler';
-import { AzureResourceMessageTreeNode } from '../messageTreeNode';
-import { AzureResourceErrorMessageUtil } from '../utils';
-import { AzureResourceService } from '../resourceService';
-import { AzureResourceResourceTreeNode } from '../resourceTreeNode';
 
-export class AzureResourceSubscriptionTreeNode extends AzureResourceContainerTreeNodeBase {
+export class AzureResourceSubscriptionTreeNode extends AzureResourceTreeNodeBase {
 	public constructor(
-		public readonly account: Account,
-		public readonly subscription: azureResource.AzureResourceSubscription,
-		public readonly tenatId: string,
-		appContext: AppContext,
+		public readonly subscription: AzureResourceSubscription,
+		account: Account,
 		treeChangeHandler: IAzureResourceTreeChangeHandler,
 		parent: TreeNode
 	) {
-		super(appContext, treeChangeHandler, parent);
+		super(treeChangeHandler, parent);
 
-		this._id = `account_${this.account.key.accountId}.subscription_${this.subscription.id}.tenant_${this.tenatId}`;
-		this.setCacheKey(`${this._id}.resources`);
+		this._children.push(new AzureResourceDatabaseContainerTreeNode(subscription, account, treeChangeHandler, this));
+		this._children.push(new AzureResourceDatabaseServerContainerTreeNode(subscription, account, treeChangeHandler, this));
 	}
 
 	public async getChildren(): Promise<TreeNode[]> {
-		try {
-			const resourceService = AzureResourceService.getInstance();
-
-			const children: IAzureResourceNodeWithProviderId[] = [];
-
-			for (const resourceProviderId of await resourceService.listResourceProviderIds()) {
-				children.push(...await resourceService.getRootChildren(resourceProviderId, this.account, this.subscription, this.tenatId));
-			}
-
-			if (children.length === 0) {
-				return [AzureResourceMessageTreeNode.create(AzureResourceSubscriptionTreeNode.noResourcesLabel, this)];
-			} else {
-				return children.map((child) => {
-					// To make tree node's id unique, otherwise, treeModel.js would complain 'item already registered'
-					child.resourceNode.treeItem.id = `${this._id}.${child.resourceNode.treeItem.id}`;
-					return new AzureResourceResourceTreeNode(child, this);
-				});
-			}
-		} catch (error) {
-			return [AzureResourceMessageTreeNode.create(AzureResourceErrorMessageUtil.getErrorMessage(error), this)];
-		}
+		return this._children;
 	}
 
 	public getTreeItem(): TreeItem | Promise<TreeItem> {
-		const item = new TreeItem(this.subscription.name, TreeItemCollapsibleState.Collapsed);
+		let item = new TreeItem(this.subscription.name, TreeItemCollapsibleState.Collapsed);
 		item.contextValue = AzureResourceItemType.subscription;
 		item.iconPath = {
-			dark: this.appContext.extensionContext.asAbsolutePath('resources/dark/subscription_inverse.svg'),
-			light: this.appContext.extensionContext.asAbsolutePath('resources/light/subscription.svg')
+			dark: this.servicePool.contextService.getAbsolutePath('resources/dark/subscription_inverse.svg'),
+			light: this.servicePool.contextService.getAbsolutePath('resources/light/subscription.svg')
 		};
 		return item;
 	}
@@ -86,10 +58,8 @@ export class AzureResourceSubscriptionTreeNode extends AzureResourceContainerTre
 	}
 
 	public get nodePathValue(): string {
-        return this._id;
+		return `subscription_${this.subscription.id}`;
 	}
 
-	private _id: string = undefined;
-
-	private static readonly noResourcesLabel = localize('azure.resource.tree.subscriptionTreeNode.noResourcesLabel', 'No Resources found.');
+	private _children: AzureResourceContainerTreeNodeBase[] = [];
 }

extensions/azurecore/src/azureResource/tree/treeChangeHandler.ts

@@ -5,7 +5,7 @@
 
 'use strict';
 
-import { TreeNode } from '../treeNode';
+import { TreeNode } from '../../treeNodes';
 
 export interface IAzureResourceTreeChangeHandler {
 	notifyNodeChanged(node: TreeNode): void;

extensions/azurecore/src/azureResource/tree/treeProvider.ts

@@ -6,25 +6,26 @@
 'use strict';
 
 import { TreeDataProvider, EventEmitter, Event, TreeItem } from 'vscode';
+import { DidChangeAccountsParams } from 'sqlops';
+import { TreeNode } from '../../treeNodes';
 import { setInterval, clearInterval } from 'timers';
-import { AppContext } from '../../appContext';
 import * as nls from 'vscode-nls';
 const localize = nls.loadMessageBundle();
 
-import { TreeNode } from '../treeNode';
+import { AzureResourceServicePool } from '../servicePool';
 import { AzureResourceAccountTreeNode } from './accountTreeNode';
 import { AzureResourceAccountNotSignedInTreeNode } from './accountNotSignedInTreeNode';
-import { AzureResourceMessageTreeNode } from '../messageTreeNode';
-import { AzureResourceContainerTreeNodeBase } from './baseTreeNodes';
+import { AzureResourceMessageTreeNode } from './messageTreeNode';
+import { AzureResourceContainerTreeNodeBase, AzureResourceTreeNodeBase } from './baseTreeNodes';
 import { AzureResourceErrorMessageUtil } from '../utils';
-import { IAzureResourceTreeChangeHandler } from './treeChangeHandler';
-import { IAzureResourceAccountService } from '../../azureResource/interfaces';
-import { AzureResourceServiceNames } from '../constants';
+
+export interface IAzureResourceTreeChangeHandler {
+	notifyNodeChanged(node: TreeNode): void;
+}
 
 export class AzureResourceTreeProvider implements TreeDataProvider<TreeNode>, IAzureResourceTreeChangeHandler {
-	public constructor(
-		public readonly appContext: AppContext
-	) {
+	public constructor() {
+		AzureResourceServicePool.getInstance().accountService.onDidChangeAccounts((e: DidChangeAccountsParams) => { this._onDidChangeTreeData.fire(undefined); });
 	}
 
 	public async getChildren(element?: TreeNode): Promise<TreeNode[]> {
@@ -36,7 +37,7 @@ export class AzureResourceTreeProvider implements TreeDataProvider<TreeNode>, IA
 			this._loadingTimer = setInterval(async () => {
 				try {
 					// Call sqlops.accounts.getAllAccounts() to determine whether the system has been initialized.
-					await this.appContext.getService<IAzureResourceAccountService>(AzureResourceServiceNames.accountService).getAccounts();
+					await AzureResourceServicePool.getInstance().accountService.getAccounts();
 
 					// System has been initialized
 					this.isSystemInitialized = true;
@@ -50,16 +51,16 @@ export class AzureResourceTreeProvider implements TreeDataProvider<TreeNode>, IA
 					// System not initialized yet
 					this.isSystemInitialized = false;
 				}
-			}, AzureResourceTreeProvider.loadingTimerInterval);
+			}, AzureResourceTreeProvider.LoadingTimerInterval);
 
-			return [AzureResourceMessageTreeNode.create(AzureResourceTreeProvider.loadingLabel, undefined)];
+			return [AzureResourceMessageTreeNode.create(AzureResourceTreeProvider.Loading, undefined)];
 		}
 
 		try {
-			const accounts = await this.appContext.getService<IAzureResourceAccountService>(AzureResourceServiceNames.accountService).getAccounts();
+			const accounts = await AzureResourceServicePool.getInstance().accountService.getAccounts();
 
 			if (accounts && accounts.length > 0) {
-				return accounts.map((account) => new AzureResourceAccountTreeNode(account, this.appContext, this));
+				return accounts.map((account) => new AzureResourceAccountTreeNode(account, this));
 			} else {
 				return [new AzureResourceAccountNotSignedInTreeNode()];
 			}
@@ -95,6 +96,6 @@ export class AzureResourceTreeProvider implements TreeDataProvider<TreeNode>, IA
 	private _loadingTimer: NodeJS.Timer = undefined;
 	private _onDidChangeTreeData = new EventEmitter<TreeNode>();
 
-	private static readonly loadingLabel = localize('azure.resource.tree.treeProvider.loadingLabel', 'Loading ...');
-	private static readonly loadingTimerInterval = 5000;
+	private static readonly Loading = localize('azureResource.tree.treeProvider.loading', 'Loading ...');
+	private static readonly LoadingTimerInterval = 5000;
 }

extensions/azurecore/src/azureResource/utils.ts

@@ -12,9 +12,10 @@ export function getErrorMessage(error: Error | string): string {
     return (error instanceof Error) ? error.message : error;
 }
 
+
 export class AzureResourceErrorMessageUtil {
 	public static getErrorMessage(error: Error | string): string {
-		return localize('azure.resource.error', 'Error: {0}', getErrorMessage(error));
+		return localize('azureResource.error', 'Error: {0}', getErrorMessage(error));
 	}
 }
 

extensions/azurecore/src/controllers/azureResourceController.ts

@@ -1,53 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import ControllerBase from './controllerBase';
-import { DidChangeAccountsParams } from 'sqlops';
-
-import {
-	IAzureResourceCacheService,
-	IAzureResourceAccountService,
-	IAzureResourceSubscriptionService,
-	IAzureResourceSubscriptionFilterService,
-	IAzureResourceTenantService } from '../azureResource/interfaces';
-import { AzureResourceServiceNames } from '../azureResource/constants';
-import { AzureResourceTreeProvider } from '../azureResource/tree/treeProvider';
-import { registerAzureResourceCommands } from '../azureResource/commands';
-import { AzureResourceAccountService } from '../azureResource/services/accountService';
-import { AzureResourceSubscriptionService } from '../azureResource/services/subscriptionService';
-import { AzureResourceSubscriptionFilterService } from '../azureResource/services/subscriptionFilterService';
-import { AzureResourceCacheService } from '../azureResource/services/cacheService';
-import { AzureResourceTenantService } from '../azureResource/services/tenantService';
-
-import { registerAzureResourceDatabaseServerCommands } from '../azureResource/providers/databaseServer/commands';
-import { registerAzureResourceDatabaseCommands } from '../azureResource/providers/database/commands';
-
-export default class AzureResourceController extends ControllerBase {
-	public activate(): Promise<boolean> {
-		this.appContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, new AzureResourceCacheService(this.extensionContext));
-		this.appContext.registerService<IAzureResourceAccountService>(AzureResourceServiceNames.accountService, new AzureResourceAccountService(this.apiWrapper));
-		this.appContext.registerService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService, new AzureResourceSubscriptionService());
-		this.appContext.registerService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService, new AzureResourceSubscriptionFilterService(new AzureResourceCacheService(this.extensionContext)));
-		this.appContext.registerService<IAzureResourceTenantService>(AzureResourceServiceNames.tenantService, new AzureResourceTenantService());
-
-		const azureResourceTree = new AzureResourceTreeProvider(this.appContext);
-		this.extensionContext.subscriptions.push(this.apiWrapper.registerTreeDataProvider('azureResourceExplorer', azureResourceTree));
-
-		this.appContext.getService<IAzureResourceAccountService>(AzureResourceServiceNames.accountService).onDidChangeAccounts((e: DidChangeAccountsParams) => { azureResourceTree.notifyNodeChanged(undefined); });
-
-		registerAzureResourceCommands(this.appContext, azureResourceTree);
-
-		registerAzureResourceDatabaseServerCommands(this.appContext);
-
-		registerAzureResourceDatabaseCommands(this.appContext);
-
-		return Promise.resolve(true);
-	}
-
-	public deactivate(): void {
-	}
-}

extensions/azurecore/src/controllers/mainController.ts

@@ -0,0 +1,54 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import ControllerBase from './controllerBase';
+
+import { AzureResourceTreeProvider } from '../azureResource/tree/treeProvider';
+import { registerAzureResourceCommands } from '../azureResource/commands';
+import { AzureResourceServicePool } from '../azureResource/servicePool';
+import { AzureResourceCredentialService } from '../azureResource/services/credentialService';
+import { AzureResourceAccountService } from '../azureResource/services/accountService';
+import { AzureResourceSubscriptionService } from '../azureResource/services/subscriptionService';
+import { AzureResourceSubscriptionFilterService } from '../azureResource/services/subscriptionFilterService';
+import { AzureResourceDatabaseServerService } from '../azureResource/services/databaseServerService';
+import { AzureResourceDatabaseService } from '../azureResource/services/databaseService';
+import { AzureResourceCacheService } from '../azureResource/services/cacheService';
+import { AzureResourceContextService } from '../azureResource/services/contextService';
+
+/**
+ * The main controller class that initializes the extension
+ */
+export default class MainController extends ControllerBase {
+	// PUBLIC METHODS //////////////////////////////////////////////////////
+	/**
+	 * Deactivates the extension
+	 */
+	public deactivate(): void {
+	}
+
+	public activate(): Promise<boolean> {
+		this.configureAzureResource();
+		return Promise.resolve(true);
+	}
+
+	private configureAzureResource(): void {
+		let servicePool = AzureResourceServicePool.getInstance();
+		servicePool.cacheService = new AzureResourceCacheService(this.extensionContext);
+		servicePool.contextService = new AzureResourceContextService(this.extensionContext, this.apiWrapper);
+		servicePool.accountService = new AzureResourceAccountService(this.apiWrapper);
+		servicePool.credentialService = new AzureResourceCredentialService(this.apiWrapper);
+		servicePool.subscriptionService = new AzureResourceSubscriptionService();
+		servicePool.subscriptionFilterService = new AzureResourceSubscriptionFilterService(new AzureResourceCacheService(this.extensionContext));
+		servicePool.databaseService = new AzureResourceDatabaseService();
+		servicePool.databaseServerService = new AzureResourceDatabaseServerService();
+
+		let azureResourceTree = new AzureResourceTreeProvider();
+		this.extensionContext.subscriptions.push(this.apiWrapper.registerTreeDataProvider('azureResourceExplorer', azureResourceTree));
+
+		registerAzureResourceCommands(this.apiWrapper, azureResourceTree);
+	}
+}

extensions/azurecore/src/extension.ts

@@ -6,17 +6,12 @@ import * as path from 'path';
 import * as os from 'os';
 import * as constants from './constants';
 
-import AzureResourceController from './controllers/azureResourceController';
+import MainController from './controllers/mainController';
 import { AppContext } from './appContext';
 import ControllerBase from './controllers/controllerBase';
 import { ApiWrapper } from './apiWrapper';
 import { AzureAccountProviderService } from './account-provider/azureAccountProviderService';
 
-import { AzureResourceDatabaseServerProvider } from './azureResource/providers/databaseServer/databaseServerProvider';
-import { AzureResourceDatabaseServerService } from './azureResource/providers/databaseServer/databaseServerService';
-import { AzureResourceDatabaseProvider } from './azureResource/providers/database/databaseProvider';
-import { AzureResourceDatabaseService } from './azureResource/providers/database/databaseService';
-
 let controllers: ControllerBase[] = [];
 
 
@@ -40,8 +35,7 @@ export function getDefaultLogLocation() {
 // this method is called when your extension is activated
 // your extension is activated the very first time the command is executed
 export function activate(extensionContext: vscode.ExtensionContext) {
-	const apiWrapper = new ApiWrapper();
-	let appContext = new AppContext(extensionContext, apiWrapper);
+	let appContext = new AppContext(extensionContext, new ApiWrapper());
 	let activations: Thenable<boolean>[] = [];
 
 	// Create the folder for storing the token caches
@@ -62,19 +56,21 @@ export function activate(extensionContext: vscode.ExtensionContext) {
 	extensionContext.subscriptions.push(accountProviderService);
 	accountProviderService.activate();
 
-	const azureResourceController = new AzureResourceController(appContext);
-	controllers.push(azureResourceController);
-	extensionContext.subscriptions.push(azureResourceController);
-	activations.push(azureResourceController.activate());
+	// Start the main controller
+	let mainController = new MainController(appContext);
+	controllers.push(mainController);
+	extensionContext.subscriptions.push(mainController);
+	activations.push(mainController.activate());
 
-	return {
-		provideResources() {
-			return [
-				new AzureResourceDatabaseServerProvider(new AzureResourceDatabaseServerService(), apiWrapper, extensionContext),
-				new AzureResourceDatabaseProvider(new AzureResourceDatabaseService(), apiWrapper, extensionContext)
-			];
-		}
-	};
+	return Promise.all(activations)
+		.then((results: boolean[]) => {
+			for (let result of results) {
+				if (!result) {
+					return false;
+				}
+			}
+			return true;
+		});
 }
 
 // this method is called when your extension is deactivated

extensions/azurecore/src/test/azureResource/providers/database/databaseTreeDataProvider.test.ts

@@ -1,150 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import * as should from 'should';
-import * as TypeMoq from 'typemoq';
-import * as sqlops from 'sqlops';
-import * as vscode from 'vscode';
-import 'mocha';
-
-import { azureResource } from '../../../../azureResource/azure-resource';
-import { ApiWrapper } from '../../../../apiWrapper';
-import { IAzureResourceDatabaseService } from '../../../../azureResource/providers/database/interfaces';
-import { AzureResourceDatabaseTreeDataProvider } from '../../../../azureResource/providers/database/databaseTreeDataProvider';
-import { AzureResourceDatabase } from '../../../../azureResource/providers/database/models';
-import { AzureResourceItemType } from '../../../../azureResource/constants';
-
-// Mock services
-let mockDatabaseService: TypeMoq.IMock<IAzureResourceDatabaseService>;
-let mockApiWrapper: TypeMoq.IMock<ApiWrapper>;
-let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
-
-// Mock test data
-const mockAccount: sqlops.Account = {
-	key: {
-		accountId: 'mock_account',
-		providerId: 'mock_provider'
-	},
-	displayInfo: {
-		displayName: 'mock_account@test.com',
-		accountType: 'Microsoft',
-		contextualDisplayName: 'test'
-	},
-	properties: undefined,
-	isStale: false
-};
-
-const mockSubscription: azureResource.AzureResourceSubscription = {
-	id: 'mock_subscription',
-	name: 'mock subscription'
-};
-
-const mockTenantId: string = 'mock_tenant';
-
-const mockResourceRootNode: azureResource.IAzureResourceNode = {
-	account: mockAccount,
-	subscription: mockSubscription,
-	tenantId: mockTenantId,
-	treeItem: {
-		id: 'mock_resource_root_node',
-		label: 'mock resource root node',
-		iconPath: undefined,
-		collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
-		contextValue: 'mock_resource_root_node'
-	}
-};
-
-const mockTokens = {};
-mockTokens[mockTenantId] = {
-	token: 'mock_token',
-	tokenType: 'Bearer'
-};
-
-const mockDatabases: AzureResourceDatabase[] = [
-	{
-		name: 'mock database 1',
-		serverName: 'mock database server 1',
-		serverFullName: 'mock database server full name 1',
-		loginName: 'mock login'
-	},
-	{
-		name: 'mock database 2',
-		serverName: 'mock database server 2',
-		serverFullName: 'mock database server full name 2',
-		loginName: 'mock login'
-	}
-];
-
-describe('AzureResourceDatabaseTreeDataProvider.info', function(): void {
-	beforeEach(() => {
-		mockDatabaseService = TypeMoq.Mock.ofType<IAzureResourceDatabaseService>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-	});
-
-	it('Should be correct when created.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseTreeDataProvider(mockDatabaseService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const treeItem = await treeDataProvider.getTreeItem(mockResourceRootNode);
-		should(treeItem.id).equal(mockResourceRootNode.treeItem.id);
-		should(treeItem.label).equal(mockResourceRootNode.treeItem.label);
-		should(treeItem.collapsibleState).equal(mockResourceRootNode.treeItem.collapsibleState);
-		should(treeItem.contextValue).equal(mockResourceRootNode.treeItem.contextValue);
-	});
-});
-
-describe('AzureResourceDatabaseTreeDataProvider.getChildren', function(): void {
-	beforeEach(() => {
-		mockDatabaseService = TypeMoq.Mock.ofType<IAzureResourceDatabaseService>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-
-		mockApiWrapper.setup((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement)).returns(() => Promise.resolve(mockTokens));
-		mockDatabaseService.setup((o) => o.getDatabases(mockSubscription, TypeMoq.It.isAny())).returns(() => Promise.resolve(mockDatabases));
-		mockExtensionContext.setup((o) => o.asAbsolutePath(TypeMoq.It.isAnyString())).returns(() => TypeMoq.It.isAnyString());
-	});
-
-	it('Should return container node when element is undefined.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseTreeDataProvider(mockDatabaseService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const children = await treeDataProvider.getChildren();
-
-		should(children).Array();
-		should(children.length).equal(1);
-
-		const child = children[0];
-		should(child.account).undefined();
-		should(child.subscription).undefined();
-		should(child.tenantId).undefined();
-		should(child.treeItem.id).equal('azure.resource.providers.database.treeDataProvider.databaseContainer');
-		should(child.treeItem.label).equal('SQL Databases');
-		should(child.treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.Collapsed);
-		should(child.treeItem.contextValue).equal('azure.resource.itemType.databaseContainer');
-	});
-
-	it('Should return resource nodes when it is container node.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseTreeDataProvider(mockDatabaseService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const children = await treeDataProvider.getChildren(mockResourceRootNode);
-
-		should(children).Array();
-		should(children.length).equal(mockDatabases.length);
-
-		for (let ix = 0; ix < children.length; ix++) {
-			const child = children[ix];
-			const database = mockDatabases[ix];
-
-			should(child.account).equal(mockAccount);
-			should(child.subscription).equal(mockSubscription);
-			should(child.tenantId).equal(mockTenantId);
-			should(child.treeItem.id).equal(`databaseServer_${database.serverFullName}.database_${database.name}`);
-			should(child.treeItem.label).equal(`${database.name} (${database.serverName})`);
-			should(child.treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.None);
-			should(child.treeItem.contextValue).equal(AzureResourceItemType.database);
-		}
-	});
-});

extensions/azurecore/src/test/azureResource/providers/databaseServer/databaseServerTreeDataProvider.test.ts

@@ -1,150 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import * as should from 'should';
-import * as TypeMoq from 'typemoq';
-import * as sqlops from 'sqlops';
-import * as vscode from 'vscode';
-import 'mocha';
-
-import { azureResource } from '../../../../azureResource/azure-resource';
-import { ApiWrapper } from '../../../../apiWrapper';
-import { IAzureResourceDatabaseServerService } from '../../../../azureResource/providers/databaseServer/interfaces';
-import { AzureResourceDatabaseServerTreeDataProvider } from '../../../../azureResource/providers/databaseServer/databaseServerTreeDataProvider';
-import { AzureResourceDatabaseServer } from '../../../../azureResource/providers/databaseServer/models';
-import { AzureResourceItemType } from '../../../../azureResource/constants';
-
-// Mock services
-let mockDatabaseServerService: TypeMoq.IMock<IAzureResourceDatabaseServerService>;
-let mockApiWrapper: TypeMoq.IMock<ApiWrapper>;
-let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
-
-// Mock test data
-const mockAccount: sqlops.Account = {
-	key: {
-		accountId: 'mock_account',
-		providerId: 'mock_provider'
-	},
-	displayInfo: {
-		displayName: 'mock_account@test.com',
-		accountType: 'Microsoft',
-		contextualDisplayName: 'test'
-	},
-	properties: undefined,
-	isStale: false
-};
-
-const mockSubscription: azureResource.AzureResourceSubscription = {
-	id: 'mock_subscription',
-	name: 'mock subscription'
-};
-
-const mockTenantId: string = 'mock_tenant';
-
-const mockResourceRootNode: azureResource.IAzureResourceNode = {
-	account: mockAccount,
-	subscription: mockSubscription,
-	tenantId: mockTenantId,
-	treeItem: {
-		id: 'mock_resource_root_node',
-		label: 'mock resource root node',
-		iconPath: undefined,
-		collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
-		contextValue: 'mock_resource_root_node'
-	}
-};
-
-const mockTokens = {};
-mockTokens[mockTenantId] = {
-	token: 'mock_token',
-	tokenType: 'Bearer'
-};
-
-const mockDatabaseServers: AzureResourceDatabaseServer[] = [
-	{
-		name: 'mock database server 1',
-		fullName: 'mock database server full name 1',
-		loginName: 'mock login',
-		defaultDatabaseName: 'master'
-	},
-	{
-		name: 'mock database server 2',
-		fullName: 'mock database server full name 2',
-		loginName: 'mock login',
-		defaultDatabaseName: 'master'
-	}
-];
-
-describe('AzureResourceDatabaseServerTreeDataProvider.info', function(): void {
-	beforeEach(() => {
-		mockDatabaseServerService = TypeMoq.Mock.ofType<IAzureResourceDatabaseServerService>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-	});
-
-	it('Should be correct when created.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseServerTreeDataProvider(mockDatabaseServerService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const treeItem = await treeDataProvider.getTreeItem(mockResourceRootNode);
-		should(treeItem.id).equal(mockResourceRootNode.treeItem.id);
-		should(treeItem.label).equal(mockResourceRootNode.treeItem.label);
-		should(treeItem.collapsibleState).equal(mockResourceRootNode.treeItem.collapsibleState);
-		should(treeItem.contextValue).equal(mockResourceRootNode.treeItem.contextValue);
-	});
-});
-
-describe('AzureResourceDatabaseServerTreeDataProvider.getChildren', function(): void {
-	beforeEach(() => {
-		mockDatabaseServerService = TypeMoq.Mock.ofType<IAzureResourceDatabaseServerService>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-
-		mockApiWrapper.setup((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement)).returns(() => Promise.resolve(mockTokens));
-		mockDatabaseServerService.setup((o) => o.getDatabaseServers(mockSubscription, TypeMoq.It.isAny())).returns(() => Promise.resolve(mockDatabaseServers));
-		mockExtensionContext.setup((o) => o.asAbsolutePath(TypeMoq.It.isAnyString())).returns(() => TypeMoq.It.isAnyString());
-	});
-
-	it('Should return container node when element is undefined.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseServerTreeDataProvider(mockDatabaseServerService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const children = await treeDataProvider.getChildren();
-
-		should(children).Array();
-		should(children.length).equal(1);
-
-		const child = children[0];
-		should(child.account).undefined();
-		should(child.subscription).undefined();
-		should(child.tenantId).undefined();
-		should(child.treeItem.id).equal('azure.resource.providers.databaseServer.treeDataProvider.databaseServerContainer');
-		should(child.treeItem.label).equal('SQL Servers');
-		should(child.treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.Collapsed);
-		should(child.treeItem.contextValue).equal('azure.resource.itemType.databaseServerContainer');
-	});
-
-	it('Should return resource nodes when it is container node.', async function(): Promise<void> {
-		const treeDataProvider = new AzureResourceDatabaseServerTreeDataProvider(mockDatabaseServerService.object, mockApiWrapper.object, mockExtensionContext.object);
-
-		const children = await treeDataProvider.getChildren(mockResourceRootNode);
-
-		should(children).Array();
-		should(children.length).equal(mockDatabaseServers.length);
-
-		for (let ix = 0; ix < children.length; ix++) {
-			const child = children[ix];
-			const databaseServer = mockDatabaseServers[ix];
-
-			should(child.account).equal(mockAccount);
-			should(child.subscription).equal(mockSubscription);
-			should(child.tenantId).equal(mockTenantId);
-			should(child.treeItem.id).equal(`databaseServer_${databaseServer.name}`);
-			should(child.treeItem.label).equal(databaseServer.name);
-			should(child.treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.None);
-			should(child.treeItem.contextValue).equal(AzureResourceItemType.databaseServer);
-		}
-	});
-});

extensions/azurecore/src/test/azureResource/resourceService.test.ts

@@ -1,180 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import * as should from 'should';
-import * as TypeMoq from 'typemoq';
-import * as sqlops from 'sqlops';
-import 'mocha';
-import { fail } from 'assert';
-
-import { azureResource } from '../../azureResource/azure-resource';
-import { AzureResourceService } from '../../azureResource/resourceService';
-
-// Mock test data
-const mockAccount: sqlops.Account = {
-	key: {
-		accountId: 'mock_account',
-		providerId: 'mock_provider'
-	},
-	displayInfo: {
-		displayName: 'mock_account@test.com',
-		accountType: 'Microsoft',
-		contextualDisplayName: 'test'
-	},
-	properties: undefined,
-	isStale: false
-};
-
-const mockSubscription: azureResource.AzureResourceSubscription = {
-	id: 'mock_subscription',
-	name: 'mock subscription'
-};
-
-const mockTenantId: string = 'mock_tenant';
-
-let mockResourceTreeDataProvider1: TypeMoq.IMock<azureResource.IAzureResourceTreeDataProvider>;
-let mockResourceProvider1: TypeMoq.IMock<azureResource.IAzureResourceProvider>;
-
-let mockResourceTreeDataProvider2: TypeMoq.IMock<azureResource.IAzureResourceTreeDataProvider>;
-let mockResourceProvider2: TypeMoq.IMock<azureResource.IAzureResourceProvider>;
-
-const resourceService: AzureResourceService = AzureResourceService.getInstance();
-
-describe('AzureResourceService.listResourceProviderIds', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		mockResourceTreeDataProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider2.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider2.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider2.setup((o) => o.providerId).returns(() => 'mockResourceProvider2');
-		mockResourceProvider2.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider2.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should be correct when registering providers.', async function(): Promise<void> {
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		let providerIds = await resourceService.listResourceProviderIds();
-		should(providerIds).Array();
-		should(providerIds.length).equal(1);
-		should(providerIds[0]).equal(mockResourceProvider1.object.providerId);
-
-		resourceService.registerResourceProvider(mockResourceProvider2.object);
-		providerIds = await resourceService.listResourceProviderIds();
-		should(providerIds).Array();
-		should(providerIds.length).equal(2);
-		should(providerIds[0]).equal(mockResourceProvider1.object.providerId);
-		should(providerIds[1]).equal(mockResourceProvider2.object.providerId);
-	});
-});
-
-describe('AzureResourceService.getRootChildren', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should be correct when provider id is correct.', async function(): Promise<void> {
-		const children = await resourceService.getRootChildren(mockResourceProvider1.object.providerId, mockAccount, mockSubscription, mockTenantId);
-
-		should(children).Array();
-	});
-
-	it('Should throw exceptions when provider id is incorrect.', async function(): Promise<void> {
-		const providerId = 'non_existent_provider_id';
-		try {
-			await resourceService.getRootChildren(providerId, mockAccount, mockSubscription, mockTenantId);
-		} catch (error) {
-			should(error.message).equal(`Azure resource provider doesn't exist. Id: ${providerId}`);
-			return;
-		}
-
-		fail();
-	});
-});
-
-describe('AzureResourceService.getChildren', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren(TypeMoq.It.isAny())).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should be correct when provider id is correct.', async function(): Promise<void> {
-		const children = await resourceService.getChildren(mockResourceProvider1.object.providerId, TypeMoq.It.isAny());
-		should(children).Array();
-	});
-
-	it('Should throw exceptions when provider id is incorrect.', async function(): Promise<void> {
-		const providerId = 'non_existent_provider_id';
-		try {
-			await resourceService.getRootChildren(providerId, mockAccount, mockSubscription, mockTenantId);
-		} catch (error) {
-			should(error.message).equal(`Azure resource provider doesn't exist. Id: ${providerId}`);
-			return;
-		}
-
-		fail();
-	});
-});
-
-describe('AzureResourceService.getTreeItem', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren(TypeMoq.It.isAny())).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should be correct when provider id is correct.', async function(): Promise<void> {
-		const treeItem = await resourceService.getTreeItem(mockResourceProvider1.object.providerId, TypeMoq.It.isAny());
-		should(treeItem).Object();
-	});
-
-	it('Should throw exceptions when provider id is incorrect.', async function(): Promise<void> {
-		const providerId = 'non_existent_provider_id';
-		try {
-			await resourceService.getRootChildren(providerId, mockAccount, mockSubscription, mockTenantId);
-		} catch (error) {
-			should(error.message).equal(`Azure resource provider doesn't exist. Id: ${providerId}`);
-			return;
-		}
-
-		fail();
-	});
-});

extensions/azurecore/src/test/azureResource/resourceTreeNode.test.ts

@@ -1,184 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-'use strict';
-
-import * as should from 'should';
-import * as TypeMoq from 'typemoq';
-import * as sqlops from 'sqlops';
-import * as vscode from 'vscode';
-import 'mocha';
-
-import { azureResource } from '../../azureResource/azure-resource';
-import { AzureResourceService } from '../../azureResource/resourceService';
-import { AzureResourceResourceTreeNode } from '../../azureResource/resourceTreeNode';
-
-const resourceService = AzureResourceService.getInstance();
-
-// Mock test data
-const mockAccount: sqlops.Account = {
-	key: {
-		accountId: 'mock_account',
-		providerId: 'mock_provider'
-	},
-	displayInfo: {
-		displayName: 'mock_account@test.com',
-		accountType: 'Microsoft',
-		contextualDisplayName: 'test'
-	},
-	properties: undefined,
-	isStale: false
-};
-
-const mockSubscription: azureResource.AzureResourceSubscription = {
-	id: 'mock_subscription',
-	name: 'mock subscription'
-};
-
-const mockTenantId: string = 'mock_tenant';
-
-const mockResourceProviderId: string = 'mock_resource_provider';
-
-const mockResourceRootNode: azureResource.IAzureResourceNode = {
-	account: mockAccount,
-	subscription: mockSubscription,
-	tenantId: mockTenantId,
-	treeItem: {
-		id: 'mock_resource_root_node',
-		label: 'mock resource root node',
-		iconPath: undefined,
-		collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
-		contextValue: 'mock_resource_root_node'
-	}
-};
-
-const mockResourceNode1: azureResource.IAzureResourceNode = {
-	account: mockAccount,
-	subscription: mockSubscription,
-	tenantId: mockTenantId,
-	treeItem: {
-		id: 'mock_resource_node_1',
-		label: 'mock resource node 1',
-		iconPath: undefined,
-		collapsibleState: vscode.TreeItemCollapsibleState.None,
-		contextValue: 'mock_resource_node'
-	}
-};
-
-const mockResourceNode2: azureResource.IAzureResourceNode = {
-	account: mockAccount,
-	subscription: mockSubscription,
-	tenantId: mockTenantId,
-	treeItem: {
-		id: 'mock_resource_node_2',
-		label: 'mock resource node 2',
-		iconPath: undefined,
-		collapsibleState: vscode.TreeItemCollapsibleState.None,
-		contextValue: 'mock_resource_node'
-	}
-};
-
-const mockResourceNodes: azureResource.IAzureResourceNode[] = [mockResourceNode1, mockResourceNode2];
-
-let mockResourceTreeDataProvider: TypeMoq.IMock<azureResource.IAzureResourceTreeDataProvider>;
-let mockResourceProvider: TypeMoq.IMock<azureResource.IAzureResourceProvider>;
-
-describe('AzureResourceResourceTreeNode.info', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider.setup((o) => o.getTreeItem(mockResourceRootNode)).returns(() => mockResourceRootNode.treeItem);
-		mockResourceTreeDataProvider.setup((o) => o.getChildren(mockResourceRootNode)).returns(() => Promise.resolve(mockResourceNodes));
-
-		mockResourceProvider = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider.setup((o) => o.providerId).returns(() => mockResourceProviderId);
-		mockResourceProvider.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider.object);
-
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should be correct when created.', async function(): Promise<void> {
-		const resourceTreeNode = new AzureResourceResourceTreeNode({
-			resourceProviderId: mockResourceProviderId,
-			resourceNode: mockResourceRootNode
-		}, undefined);
-
-		should(resourceTreeNode.nodePathValue).equal(mockResourceRootNode.treeItem.id);
-
-		const treeItem = await resourceTreeNode.getTreeItem();
-		should(treeItem.id).equal(mockResourceRootNode.treeItem.id);
-		should(treeItem.label).equal(mockResourceRootNode.treeItem.label);
-		should(treeItem.collapsibleState).equal(mockResourceRootNode.treeItem.collapsibleState);
-		should(treeItem.contextValue).equal(mockResourceRootNode.treeItem.contextValue);
-
-		const nodeInfo = resourceTreeNode.getNodeInfo();
-		should(nodeInfo.label).equal(mockResourceRootNode.treeItem.label);
-		should(nodeInfo.isLeaf).equal(mockResourceRootNode.treeItem.collapsibleState === vscode.TreeItemCollapsibleState.None);
-		should(nodeInfo.nodeType).equal(mockResourceRootNode.treeItem.contextValue);
-		should(nodeInfo.iconType).equal(mockResourceRootNode.treeItem.contextValue);
-	});
-});
-
-describe('AzureResourceResourceTreeNode.getChildren', function(): void {
-	beforeEach(() => {
-		mockResourceTreeDataProvider = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider.setup((o) => o.getChildren(mockResourceRootNode)).returns(() => Promise.resolve(mockResourceNodes));
-
-		mockResourceProvider = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider.setup((o) => o.providerId).returns(() => mockResourceProviderId);
-		mockResourceProvider.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider.object);
-
-		resourceService.areResourceProvidersLoaded = true;
-	});
-
-	it('Should return resource nodes when it is container node.', async function(): Promise<void> {
-		const resourceTreeNode = new AzureResourceResourceTreeNode({
-			resourceProviderId: mockResourceProviderId,
-			resourceNode: mockResourceRootNode
-		}, undefined);
-
-		const children = await resourceTreeNode.getChildren();
-
-		mockResourceTreeDataProvider.verify((o) => o.getChildren(mockResourceRootNode), TypeMoq.Times.once());
-
-		should(children).Array();
-		should(children.length).equal(mockResourceNodes.length);
-
-		for (let ix = 0; ix < children.length; ix++) {
-			const child = children[ix];
-
-			should(child).instanceOf(AzureResourceResourceTreeNode);
-
-			const childNode = (child as AzureResourceResourceTreeNode).resourceNodeWithProviderId;
-			should(childNode.resourceProviderId).equal(mockResourceProviderId);
-			should(childNode.resourceNode.account).equal(mockAccount);
-			should(childNode.resourceNode.subscription).equal(mockSubscription);
-			should(childNode.resourceNode.tenantId).equal(mockTenantId);
-			should(childNode.resourceNode.treeItem.id).equal(mockResourceNodes[ix].treeItem.id);
-			should(childNode.resourceNode.treeItem.label).equal(mockResourceNodes[ix].treeItem.label);
-			should(childNode.resourceNode.treeItem.collapsibleState).equal(mockResourceNodes[ix].treeItem.collapsibleState);
-			should(childNode.resourceNode.treeItem.contextValue).equal(mockResourceNodes[ix].treeItem.contextValue);
-		}
-	});
-
-	it('Should return empty when it is leaf node.', async function(): Promise<void> {
-		const resourceTreeNode = new AzureResourceResourceTreeNode({
-			resourceProviderId: mockResourceProviderId,
-			resourceNode: mockResourceNode1
-		}, undefined);
-
-		const children = await resourceTreeNode.getChildren();
-
-		mockResourceTreeDataProvider.verify((o) => o.getChildren(), TypeMoq.Times.exactly(0));
-
-		should(children).Array();
-		should(children.length).equal(0);
-	});
-});

extensions/azurecore/src/test/azureResource/tree/accountNotSignedInTreeNode.test.ts

@@ -26,7 +26,7 @@ describe('AzureResourceAccountNotSignedInTreeNode.info', function(): void {
 		should(treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.None);
 		should(treeItem.command).not.undefined();
 		should(treeItem.command.title).equal(label);
-		should(treeItem.command.command).equal('azure.resource.signin');
+		should(treeItem.command.command).equal('azureresource.signin');
 
 		const nodeInfo = treeNode.getNodeInfo();
 		should(nodeInfo.isLeaf).true();

extensions/azurecore/src/test/azureResource/tree/accountTreeNode.test.ts

@@ -10,38 +10,35 @@ import * as TypeMoq from 'typemoq';
 import * as sqlops from 'sqlops';
 import * as vscode from 'vscode';
 import 'mocha';
-import { TokenCredentials } from 'ms-rest';
-import { AppContext } from '../../../appContext';
+import { ServiceClientCredentials } from 'ms-rest';
 
-import { azureResource } from '../../../azureResource/azure-resource';
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
 import {
 	IAzureResourceCacheService,
+	IAzureResourceContextService,
+	IAzureResourceCredentialService,
 	IAzureResourceSubscriptionService,
-	IAzureResourceSubscriptionFilterService,
-	IAzureResourceTenantService
+	IAzureResourceSubscriptionFilterService
 } from '../../../azureResource/interfaces';
 import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
 import { AzureResourceAccountTreeNode } from '../../../azureResource/tree/accountTreeNode';
+import { AzureResourceSubscription } from '../../../azureResource/models';
 import { AzureResourceSubscriptionTreeNode } from '../../../azureResource/tree/subscriptionTreeNode';
-import { AzureResourceItemType, AzureResourceServiceNames } from '../../../azureResource/constants';
-import { AzureResourceMessageTreeNode } from '../../../azureResource/messageTreeNode';
-import { ApiWrapper } from '../../../apiWrapper';
-import { generateGuid } from '../../../azureResource/utils';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceMessageTreeNode } from '../../../azureResource/tree/messageTreeNode';
 
 // Mock services
-let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
-let mockApiWrapper: TypeMoq.IMock<ApiWrapper>;
+const mockServicePool = AzureResourceServicePool.getInstance();
+
 let mockCacheService: TypeMoq.IMock<IAzureResourceCacheService>;
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
+let mockCredentialService: TypeMoq.IMock<IAzureResourceCredentialService>;
 let mockSubscriptionService: TypeMoq.IMock<IAzureResourceSubscriptionService>;
 let mockSubscriptionFilterService: TypeMoq.IMock<IAzureResourceSubscriptionFilterService>;
-let mockTenantService: TypeMoq.IMock<IAzureResourceTenantService>;
-let mockAppContext: AppContext;
 
 let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
 
 // Mock test data
-const mockTenantId = 'mock_tenant_id';
-
 const mockAccount: sqlops.Account = {
 	key: {
 		accountId: 'mock_account',
@@ -52,68 +49,51 @@ const mockAccount: sqlops.Account = {
 		accountType: 'Microsoft',
 		contextualDisplayName: 'test'
 	},
-	properties: {
-		tenants: [
-			{
-				id: mockTenantId
-			}
-		]
-	},
+	properties: undefined,
 	isStale: false
 };
 
-const mockSubscription1: azureResource.AzureResourceSubscription = {
+const mockCredential = TypeMoq.Mock.ofType<ServiceClientCredentials>().object;
+const mockCredentials = [mockCredential];
+
+const mockSubscription1: AzureResourceSubscription = {
 	id: 'mock_subscription_1',
 	name: 'mock subscription 1'
 };
-
-const mockSubscription2: azureResource.AzureResourceSubscription = {
+const mockSubscription2: AzureResourceSubscription = {
 	id: 'mock_subscription_2',
 	name: 'mock subscription 2'
 };
-
 const mockSubscriptions = [mockSubscription1, mockSubscription2];
-
 const mockFilteredSubscriptions = [mockSubscription1];
 
-const mockTokens = {};
-mockTokens[mockTenantId] = {
-	token: 'mock_token',
-	tokenType: 'Bearer'
-};
-
-const mockCredential = new TokenCredentials(mockTokens[mockTenantId].token, mockTokens[mockTenantId].tokenType);
-
-let mockSubscriptionCache: azureResource.AzureResourceSubscription[] = [];
+let mockSubscriptionCache: { subscriptions: { [accountId: string]: AzureResourceSubscription[]} };
 
 describe('AzureResourceAccountTreeNode.info', function(): void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
 		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
+		mockCredentialService = TypeMoq.Mock.ofType<IAzureResourceCredentialService>();
 		mockSubscriptionService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionService>();
 		mockSubscriptionFilterService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionFilterService>();
-		mockTenantService = TypeMoq.Mock.ofType<IAzureResourceTenantService>();
 
 		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
 
-		mockSubscriptionCache = [];
+		mockSubscriptionCache = { subscriptions: {} };
 
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService, mockSubscriptionService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService, mockSubscriptionFilterService.object);
-		mockAppContext.registerService<IAzureResourceTenantService>(AzureResourceServiceNames.tenantService, mockTenantService.object);
+		mockServicePool.contextService = mockContextService.object;
+		mockServicePool.cacheService = mockCacheService.object;
+		mockServicePool.credentialService = mockCredentialService.object;
+		mockServicePool.subscriptionService = mockSubscriptionService.object;
+		mockServicePool.subscriptionFilterService = mockSubscriptionFilterService.object;
 
-		mockApiWrapper.setup((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement)).returns(() => Promise.resolve(mockTokens));
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
+		mockCredentialService.setup((o) => o.getCredentials(mockAccount)).returns(() => Promise.resolve(mockCredentials));
 		mockCacheService.setup((o) => o.get(TypeMoq.It.isAnyString())).returns(() => mockSubscriptionCache);
-		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockSubscriptionCache = mockSubscriptions);
-		mockTenantService.setup((o) => o.getTenantId(TypeMoq.It.isAny())).returns(() => Promise.resolve(mockTenantId));
+		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockSubscriptionCache.subscriptions[mockAccount.key.accountId] = mockSubscriptions);
 	});
 
 	it('Should be correct when created.', async function(): Promise<void> {
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		const accountTreeNodeId = `account_${mockAccount.key.accountId}`;
 		const accountTreeNodeLabel = `${mockAccount.displayInfo.displayName} (${mockAccount.key.accountId})`;
@@ -134,17 +114,14 @@ describe('AzureResourceAccountTreeNode.info', function(): void {
 	});
 
 	it('Should be correct when there are subscriptions listed.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(mockSubscriptions));
 		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve(undefined));
 
 		const accountTreeNodeLabel = `${mockAccount.displayInfo.displayName} (${mockAccount.key.accountId}) (${mockSubscriptions.length} / ${mockSubscriptions.length} subscriptions)`;
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
-		const subscriptionNodes = await accountTreeNode.getChildren();
-
-		should(subscriptionNodes).Array();
-		should(subscriptionNodes.length).equal(mockSubscriptions.length);
+		await accountTreeNode.getChildren();
 
 		const treeItem = await accountTreeNode.getTreeItem();
 		should(treeItem.label).equal(accountTreeNodeLabel);
@@ -154,17 +131,14 @@ describe('AzureResourceAccountTreeNode.info', function(): void {
 	});
 
 	it('Should be correct when there are subscriptions filtered.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(mockSubscriptions));
 		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve(mockFilteredSubscriptions));
 
 		const accountTreeNodeLabel = `${mockAccount.displayInfo.displayName} (${mockAccount.key.accountId}) (${mockFilteredSubscriptions.length} / ${mockSubscriptions.length} subscriptions)`;
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
-		const subscriptionNodes = await accountTreeNode.getChildren();
-
-		should(subscriptionNodes).Array();
-		should(subscriptionNodes.length).equal(mockFilteredSubscriptions.length);
+		await accountTreeNode.getChildren();
 
 		const treeItem = await accountTreeNode.getTreeItem();
 		should(treeItem.label).equal(accountTreeNodeLabel);
@@ -176,41 +150,36 @@ describe('AzureResourceAccountTreeNode.info', function(): void {
 
 describe('AzureResourceAccountTreeNode.getChildren', function(): void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
 		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
+		mockCredentialService = TypeMoq.Mock.ofType<IAzureResourceCredentialService>();
 		mockSubscriptionService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionService>();
 		mockSubscriptionFilterService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionFilterService>();
-		mockTenantService = TypeMoq.Mock.ofType<IAzureResourceTenantService>();
 
 		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
 
-		mockSubscriptionCache = [];
+		mockSubscriptionCache = { subscriptions: {} };
 
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService, mockSubscriptionService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService, mockSubscriptionFilterService.object);
-		mockAppContext.registerService<IAzureResourceTenantService>(AzureResourceServiceNames.tenantService, mockTenantService.object);
+		mockServicePool.cacheService = mockCacheService.object;
+		mockServicePool.credentialService = mockCredentialService.object;
+		mockServicePool.subscriptionService = mockSubscriptionService.object;
+		mockServicePool.subscriptionFilterService = mockSubscriptionFilterService.object;
 
-		mockApiWrapper.setup((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement)).returns(() => Promise.resolve(mockTokens));
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
+		mockCredentialService.setup((o) => o.getCredentials(mockAccount)).returns(() => Promise.resolve(mockCredentials));
 		mockCacheService.setup((o) => o.get(TypeMoq.It.isAnyString())).returns(() => mockSubscriptionCache);
-		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockSubscriptionCache = mockSubscriptions);
-		mockTenantService.setup((o) => o.getTenantId(TypeMoq.It.isAny())).returns(() => Promise.resolve(mockTenantId));
+		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockSubscriptionCache.subscriptions[mockAccount.key.accountId] = mockSubscriptions);
 	});
 
 	it('Should load subscriptions from scratch and update cache when it is clearing cache.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
-		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve([]));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(mockSubscriptions));
+		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve(undefined));
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		const children = await accountTreeNode.getChildren();
 
-		mockApiWrapper.verify((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement), TypeMoq.Times.once());
-		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredential), TypeMoq.Times.once());
-		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.exactly(0));
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredentials), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
 		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.once());
 		mockSubscriptionFilterService.verify((o) => o.getSelectedSubscriptions(mockAccount), TypeMoq.Times.once());
 
@@ -223,42 +192,43 @@ describe('AzureResourceAccountTreeNode.getChildren', function(): void {
 		should(children).Array();
 		should(children.length).equal(mockSubscriptions.length);
 
-		should(mockSubscriptionCache).deepEqual(mockSubscriptions);
+		should(Object.keys(mockSubscriptionCache.subscriptions)).deepEqual([mockAccount.key.accountId]);
+		should(mockSubscriptionCache.subscriptions[mockAccount.key.accountId]).deepEqual(mockSubscriptions);
 
 		for (let ix = 0; ix < mockSubscriptions.length; ix++) {
 			const child = children[ix];
 			const subscription = mockSubscriptions[ix];
 
 			should(child).instanceof(AzureResourceSubscriptionTreeNode);
-			should(child.nodePathValue).equal(`account_${mockAccount.key.accountId}.subscription_${subscription.id}.tenant_${mockTenantId}`);
+			should(child.nodePathValue).equal(`subscription_${subscription.id}`);
 		}
 	});
 
 	it('Should load subscriptions from cache when it is not clearing cache.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(mockSubscriptions));
 		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve(undefined));
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		await accountTreeNode.getChildren();
 		const children = await accountTreeNode.getChildren();
 
-		mockApiWrapper.verify((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement), TypeMoq.Times.once());
-		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredential), TypeMoq.Times.once());
-		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
-		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.once());
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.exactly(1));
+		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredentials), TypeMoq.Times.exactly(1));
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.exactly(2));
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.exactly(1));
 
-		should(children.length).equal(mockSubscriptionCache.length);
+		should(children.length).equal(mockSubscriptionCache.subscriptions[mockAccount.key.accountId].length);
 
-		for (let ix = 0; ix < mockSubscriptionCache.length; ix++) {
-			should(children[ix].nodePathValue).equal(`account_${mockAccount.key.accountId}.subscription_${mockSubscriptionCache[ix].id}.tenant_${mockTenantId}`);
+		for (let ix = 0; ix < mockSubscriptionCache.subscriptions[mockAccount.key.accountId].length; ix++) {
+			should(children[ix].nodePathValue).equal(`subscription_${mockSubscriptionCache.subscriptions[mockAccount.key.accountId][ix].id}`);
 		}
 	});
 
 	it('Should handle when there is no subscriptions.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(undefined));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(undefined));
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		const children = await accountTreeNode.getChildren();
 
@@ -272,10 +242,10 @@ describe('AzureResourceAccountTreeNode.getChildren', function(): void {
 	});
 
 	it('Should honor subscription filtering.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => Promise.resolve(mockSubscriptions));
 		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => Promise.resolve(mockFilteredSubscriptions));
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		const children = await accountTreeNode.getChildren();
 
@@ -285,25 +255,23 @@ describe('AzureResourceAccountTreeNode.getChildren', function(): void {
 		should(children.length).equal(mockFilteredSubscriptions.length);
 
 		for (let ix = 0; ix < mockFilteredSubscriptions.length; ix++) {
-			should(children[ix].nodePathValue).equal(`account_${mockAccount.key.accountId}.subscription_${mockFilteredSubscriptions[ix].id}.tenant_${mockTenantId}`);
+			should(children[ix].nodePathValue).equal(`subscription_${mockFilteredSubscriptions[ix].id}`);
 		}
 	});
 
 	it('Should handle errors.', async function(): Promise<void> {
-		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredential)).returns(() => Promise.resolve(mockSubscriptions));
-
 		const mockError = 'Test error';
-		mockSubscriptionFilterService.setup((o) => o.getSelectedSubscriptions(mockAccount)).returns(() => { throw new Error(mockError); });
+		mockSubscriptionService.setup((o) => o.getSubscriptions(mockAccount, mockCredentials)).returns(() => { throw new Error(mockError); });
 
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 
 		const children = await accountTreeNode.getChildren();
 
-		mockApiWrapper.verify((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement), TypeMoq.Times.once());
-		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredential), TypeMoq.Times.once());
-		mockSubscriptionFilterService.verify((o) => o.getSelectedSubscriptions(mockAccount), TypeMoq.Times.once());
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockSubscriptionService.verify((o) => o.getSubscriptions(mockAccount, mockCredentials), TypeMoq.Times.once());
 		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.never());
-		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.never());
+		mockSubscriptionFilterService.verify((o) => o.getSelectedSubscriptions(mockAccount), TypeMoq.Times.never());
 
 		should(children).Array();
 		should(children.length).equal(1);
@@ -315,33 +283,12 @@ describe('AzureResourceAccountTreeNode.getChildren', function(): void {
 
 describe('AzureResourceAccountTreeNode.clearCache', function() : void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
-		mockSubscriptionService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionService>();
-		mockSubscriptionFilterService = TypeMoq.Mock.ofType<IAzureResourceSubscriptionFilterService>();
-		mockTenantService = TypeMoq.Mock.ofType<IAzureResourceTenantService>();
-
 		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
-
-		mockSubscriptionCache = [];
-
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionService>(AzureResourceServiceNames.subscriptionService, mockSubscriptionService.object);
-		mockAppContext.registerService<IAzureResourceSubscriptionFilterService>(AzureResourceServiceNames.subscriptionFilterService, mockSubscriptionFilterService.object);
-		mockAppContext.registerService<IAzureResourceTenantService>(AzureResourceServiceNames.tenantService, mockTenantService.object);
-
-		mockApiWrapper.setup((o) => o.getSecurityToken(mockAccount, sqlops.AzureResource.ResourceManagement)).returns(() => Promise.resolve(mockTokens));
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
-		mockCacheService.setup((o) => o.get(TypeMoq.It.isAnyString())).returns(() => mockSubscriptionCache);
-		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockSubscriptionCache = mockSubscriptions);
-		mockTenantService.setup((o) => o.getTenantId(TypeMoq.It.isAny())).returns(() => Promise.resolve(mockTenantId));
 	});
 
 	it('Should clear cache.', async function(): Promise<void> {
-		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockAppContext, mockTreeChangeHandler.object);
+		const accountTreeNode = new AzureResourceAccountTreeNode(mockAccount, mockTreeChangeHandler.object);
 		accountTreeNode.clearCache();
 		should(accountTreeNode.isClearingCache).true();
 	});
-});
+});

extensions/azurecore/src/test/azureResource/tree/databaseContainerTreeNode.test.ts

@@ -0,0 +1,219 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import * as should from 'should';
+import * as TypeMoq from 'typemoq';
+import * as sqlops from 'sqlops';
+import * as vscode from 'vscode';
+import 'mocha';
+import { ServiceClientCredentials } from 'ms-rest';
+
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import {
+	IAzureResourceCacheService,
+	IAzureResourceContextService,
+	IAzureResourceCredentialService,
+	IAzureResourceDatabaseService
+} from '../../../azureResource/interfaces';
+import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
+import { AzureResourceSubscription, AzureResourceDatabase } from '../../../azureResource/models';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceMessageTreeNode } from '../../../azureResource/tree/messageTreeNode';
+import { AzureResourceDatabaseContainerTreeNode } from '../../../azureResource/tree/databaseContainerTreeNode';
+import { AzureResourceDatabaseTreeNode } from '../../../azureResource/tree/databaseTreeNode';
+
+// Mock services
+const mockServicePool = AzureResourceServicePool.getInstance();
+
+let mockCacheService: TypeMoq.IMock<IAzureResourceCacheService>;
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
+let mockCredentialService: TypeMoq.IMock<IAzureResourceCredentialService>;
+let mockDatabaseService: TypeMoq.IMock<IAzureResourceDatabaseService>;
+
+let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
+
+// Mock test data
+const mockAccount: sqlops.Account = {
+	key: {
+		accountId: 'mock_account',
+		providerId: 'mock_provider'
+	},
+	displayInfo: {
+		displayName: 'mock_account@test.com',
+		accountType: 'Microsoft',
+		contextualDisplayName: 'test'
+	},
+	properties: undefined,
+	isStale: false
+};
+
+const mockCredential = TypeMoq.Mock.ofType<ServiceClientCredentials>().object;
+const mockCredentials = [mockCredential];
+
+const mockSubscription: AzureResourceSubscription = {
+	id: 'mock_subscription',
+	name: 'mock subscription'
+};
+
+const mockDatabase1: AzureResourceDatabase = {
+	name: 'mock database 1',
+	serverName: 'mock server 1',
+	serverFullName: 'mock server 1',
+	loginName: 'mock user 1'
+};
+const mockDatabase2: AzureResourceDatabase = {
+	name: 'mock database 2',
+	serverName: 'mock server 2',
+	serverFullName: 'mock server 2',
+	loginName: 'mock user 2'
+};
+const mockDatabases = [mockDatabase1, mockDatabase2];
+
+let mockDatabaseContainerCache: { databases: { [subscriptionId: string]: AzureResourceDatabase[] } };
+
+describe('AzureResourceDatabaseContainerTreeNode.info', function(): void {
+	beforeEach(() => {
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockServicePool.contextService = mockContextService.object;
+	});
+
+	it('Should be correct when created.', async function(): Promise<void> {
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const databaseContainerTreeNodeLabel = 'SQL Databases';
+
+		should(databaseContainerTreeNode.nodePathValue).equal('databaseContainer');
+
+		const treeItem = await databaseContainerTreeNode.getTreeItem();
+		should(treeItem.label).equal(databaseContainerTreeNodeLabel);
+		should(treeItem.contextValue).equal(AzureResourceItemType.databaseContainer);
+		should(treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.Collapsed);
+
+		const nodeInfo = databaseContainerTreeNode.getNodeInfo();
+		should(nodeInfo.isLeaf).false();
+		should(nodeInfo.label).equal(databaseContainerTreeNodeLabel);
+		should(nodeInfo.nodeType).equal(AzureResourceItemType.databaseContainer);
+		should(nodeInfo.iconType).equal(AzureResourceItemType.databaseContainer);
+	});
+});
+
+describe('AzureResourceDatabaseContainerTreeNode.getChildren', function(): void {
+	beforeEach(() => {
+		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
+		mockCredentialService = TypeMoq.Mock.ofType<IAzureResourceCredentialService>();
+		mockDatabaseService = TypeMoq.Mock.ofType<IAzureResourceDatabaseService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockDatabaseContainerCache = { databases: {} };
+
+		mockServicePool.cacheService = mockCacheService.object;
+		mockServicePool.credentialService = mockCredentialService.object;
+		mockServicePool.databaseService = mockDatabaseService.object;
+
+		mockCredentialService.setup((o) => o.getCredentials(mockAccount)).returns(() => Promise.resolve(mockCredentials));
+		mockCacheService.setup((o) => o.get(TypeMoq.It.isAnyString())).returns(() => mockDatabaseContainerCache);
+		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockDatabaseContainerCache.databases[mockSubscription.id] = mockDatabases);
+	});
+
+	it('Should load databases from scratch and update cache when it is clearing cache.', async function(): Promise<void> {
+		mockDatabaseService.setup((o) => o.getDatabases(mockSubscription, mockCredentials)).returns(() => Promise.resolve(mockDatabases));
+
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const children = await databaseContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockDatabaseService.verify((o) => o.getDatabases(mockSubscription, mockCredentials), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.once());
+
+		should(databaseContainerTreeNode.isClearingCache).false();
+
+		should(children).Array();
+		should(children.length).equal(mockDatabases.length);
+
+		should(Object.keys(mockDatabaseContainerCache.databases)).deepEqual([mockSubscription.id]);
+		should(mockDatabaseContainerCache.databases[mockSubscription.id]).deepEqual(mockDatabases);
+
+		for (let ix = 0; ix < mockDatabases.length; ix++) {
+			const child = children[ix];
+			const database = mockDatabases[ix];
+
+			should(child).instanceof(AzureResourceDatabaseTreeNode);
+			should(child.nodePathValue).equal(`database_${database.name}`);
+		}
+	});
+
+	it('Should load databases from cache when it is not clearing cache.', async function(): Promise<void> {
+		mockDatabaseService.setup((o) => o.getDatabases(mockSubscription, mockCredentials)).returns(() => Promise.resolve(mockDatabases));
+
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		await databaseContainerTreeNode.getChildren();
+		const children = await databaseContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.exactly(1));
+		mockDatabaseService.verify((o) => o.getDatabases(mockSubscription, mockCredentials), TypeMoq.Times.exactly(1));
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.exactly(2));
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.exactly(1));
+
+		should(children.length).equal(mockDatabaseContainerCache.databases[mockSubscription.id].length);
+
+		for (let ix = 0; ix < mockDatabaseContainerCache.databases[mockSubscription.id].length; ix++) {
+			should(children[ix].nodePathValue).equal(`database_${mockDatabaseContainerCache.databases[mockSubscription.id][ix].name}`);
+		}
+	});
+
+	it('Should handle when there is no databases.', async function(): Promise<void> {
+		mockDatabaseService.setup((o) => o.getDatabases(mockSubscription, mockCredentials)).returns(() => Promise.resolve(undefined));
+
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const children = await databaseContainerTreeNode.getChildren();
+
+		should(children).Array();
+		should(children.length).equal(1);
+		should(children[0]).instanceof(AzureResourceMessageTreeNode);
+		should(children[0].nodePathValue).startWith('message_');
+		should(children[0].getNodeInfo().label).equal('No SQL Databases found.');
+	});
+
+	it('Should handle errors.', async function(): Promise<void> {
+		const mockError = 'Test error';
+		mockDatabaseService.setup((o) => o.getDatabases(mockSubscription, mockCredentials)).returns(() => { throw new Error(mockError); });
+
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+		const children = await databaseContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockDatabaseService.verify((o) => o.getDatabases(mockSubscription, mockCredentials), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.never());
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.never());
+
+		should(children).Array();
+		should(children.length).equal(1);
+		should(children[0]).instanceof(AzureResourceMessageTreeNode);
+		should(children[0].nodePathValue).startWith('message_');
+		should(children[0].getNodeInfo().label).equal(`Error: ${mockError}`);
+	});
+});
+
+describe('AzureResourceDatabaseContainerTreeNode.clearCache', function() : void {
+	beforeEach(() => {
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+	});
+
+	it('Should clear cache.', async function(): Promise<void> {
+		const databaseContainerTreeNode = new AzureResourceDatabaseContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+		databaseContainerTreeNode.clearCache();
+		should(databaseContainerTreeNode.isClearingCache).true();
+	});
+});

extensions/azurecore/src/test/azureResource/tree/databaseServerContainerTreeNode.test.ts

@@ -0,0 +1,219 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import * as should from 'should';
+import * as TypeMoq from 'typemoq';
+import * as sqlops from 'sqlops';
+import * as vscode from 'vscode';
+import 'mocha';
+import { ServiceClientCredentials } from 'ms-rest';
+
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import {
+	IAzureResourceCacheService,
+	IAzureResourceContextService,
+	IAzureResourceCredentialService,
+	IAzureResourceDatabaseServerService
+} from '../../../azureResource/interfaces';
+import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
+import { AzureResourceSubscription, AzureResourceDatabaseServer } from '../../../azureResource/models';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceMessageTreeNode } from '../../../azureResource/tree/messageTreeNode';
+import { AzureResourceDatabaseServerContainerTreeNode } from '../../../azureResource/tree/databaseServerContainerTreeNode';
+import { AzureResourceDatabaseServerTreeNode } from '../../../azureResource/tree/databaseServerTreeNode';
+
+// Mock services
+const mockServicePool = AzureResourceServicePool.getInstance();
+
+let mockCacheService: TypeMoq.IMock<IAzureResourceCacheService>;
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
+let mockCredentialService: TypeMoq.IMock<IAzureResourceCredentialService>;
+let mockDatabaseServerService: TypeMoq.IMock<IAzureResourceDatabaseServerService>;
+
+let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
+
+// Mock test data
+const mockAccount: sqlops.Account = {
+	key: {
+		accountId: 'mock_account',
+		providerId: 'mock_provider'
+	},
+	displayInfo: {
+		displayName: 'mock_account@test.com',
+		accountType: 'Microsoft',
+		contextualDisplayName: 'test'
+	},
+	properties: undefined,
+	isStale: false
+};
+
+const mockCredential = TypeMoq.Mock.ofType<ServiceClientCredentials>().object;
+const mockCredentials = [mockCredential];
+
+const mockSubscription: AzureResourceSubscription = {
+	id: 'mock_subscription',
+	name: 'mock subscription'
+};
+
+const mockDatabaseServer1: AzureResourceDatabaseServer = {
+	name: 'mock server 1',
+	fullName: 'mock server 1',
+	loginName: 'mock user 1',
+	defaultDatabaseName: 'master'
+};
+const mockDatabaseServer2: AzureResourceDatabaseServer = {
+	name: 'mock server 2',
+	fullName: 'mock server 2',
+	loginName: 'mock user 2',
+	defaultDatabaseName: 'master'
+};
+const mockDatabaseServers = [mockDatabaseServer1, mockDatabaseServer2];
+
+let mockDatabaseServerContainerCache: { databaseServers: { [subscriptionId: string]: AzureResourceDatabaseServer[] } };
+
+describe('AzureResourceDatabaseServerContainerTreeNode.info', function(): void {
+	beforeEach(() => {
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockServicePool.contextService = mockContextService.object;
+	});
+
+	it('Should be correct when created.', async function(): Promise<void> {
+		const databaseServerContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const databaseServerContainerTreeNodeLabel = 'SQL Servers';
+
+		should(databaseServerContainerTreeNode.nodePathValue).equal('databaseServerContainer');
+
+		const treeItem = await databaseServerContainerTreeNode.getTreeItem();
+		should(treeItem.label).equal(databaseServerContainerTreeNodeLabel);
+		should(treeItem.contextValue).equal(AzureResourceItemType.databaseServerContainer);
+		should(treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.Collapsed);
+
+		const nodeInfo = databaseServerContainerTreeNode.getNodeInfo();
+		should(nodeInfo.isLeaf).false();
+		should(nodeInfo.label).equal(databaseServerContainerTreeNodeLabel);
+		should(nodeInfo.nodeType).equal(AzureResourceItemType.databaseServerContainer);
+		should(nodeInfo.iconType).equal(AzureResourceItemType.databaseServerContainer);
+	});
+});
+
+describe('AzureResourceDatabaseServerContainerTreeNode.getChildren', function(): void {
+	beforeEach(() => {
+		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
+		mockCredentialService = TypeMoq.Mock.ofType<IAzureResourceCredentialService>();
+		mockDatabaseServerService = TypeMoq.Mock.ofType<IAzureResourceDatabaseServerService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockDatabaseServerContainerCache = { databaseServers: {} };
+
+		mockServicePool.cacheService = mockCacheService.object;
+		mockServicePool.credentialService = mockCredentialService.object;
+		mockServicePool.databaseServerService = mockDatabaseServerService.object;
+
+		mockCredentialService.setup((o) => o.getCredentials(mockAccount)).returns(() => Promise.resolve(mockCredentials));
+		mockCacheService.setup((o) => o.get(TypeMoq.It.isAnyString())).returns(() => mockDatabaseServerContainerCache);
+		mockCacheService.setup((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny())).returns(() => mockDatabaseServerContainerCache.databaseServers[mockSubscription.id] = mockDatabaseServers);
+	});
+
+	it('Should load database servers from scratch and update cache when it is clearing cache.', async function(): Promise<void> {
+		mockDatabaseServerService.setup((o) => o.getDatabaseServers(mockSubscription, mockCredentials)).returns(() => Promise.resolve(mockDatabaseServers));
+
+		const databaseServerContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const children = await databaseServerContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockDatabaseServerService.verify((o) => o.getDatabaseServers(mockSubscription, mockCredentials), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.once());
+
+		should(databaseServerContainerTreeNode.isClearingCache).false();
+
+		should(children).Array();
+		should(children.length).equal(mockDatabaseServers.length);
+
+		should(Object.keys(mockDatabaseServerContainerCache.databaseServers)).deepEqual([mockSubscription.id]);
+		should(mockDatabaseServerContainerCache.databaseServers[mockSubscription.id]).deepEqual(mockDatabaseServers);
+
+		for (let ix = 0; ix < mockDatabaseServers.length; ix++) {
+			const child = children[ix];
+			const databaseServer = mockDatabaseServers[ix];
+
+			should(child).instanceof(AzureResourceDatabaseServerTreeNode);
+			should(child.nodePathValue).equal(`databaseServer_${databaseServer.name}`);
+		}
+	});
+
+	it('Should load database servers from cache when it is not clearing cache.', async function(): Promise<void> {
+		mockDatabaseServerService.setup((o) => o.getDatabaseServers(mockSubscription, mockCredentials)).returns(() => Promise.resolve(mockDatabaseServers));
+
+		const databaseServerContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		await databaseServerContainerTreeNode.getChildren();
+		const children = await databaseServerContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.exactly(1));
+		mockDatabaseServerService.verify((o) => o.getDatabaseServers(mockSubscription, mockCredentials), TypeMoq.Times.exactly(1));
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.exactly(2));
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.exactly(1));
+
+		should(children.length).equal(mockDatabaseServerContainerCache.databaseServers[mockSubscription.id].length);
+
+		for (let ix = 0; ix < mockDatabaseServerContainerCache.databaseServers[mockSubscription.id].length; ix++) {
+			should(children[ix].nodePathValue).equal(`databaseServer_${mockDatabaseServerContainerCache.databaseServers[mockSubscription.id][ix].name}`);
+		}
+	});
+
+	it('Should handle when there is no database servers.', async function(): Promise<void> {
+		mockDatabaseServerService.setup((o) => o.getDatabaseServers(mockSubscription, mockCredentials)).returns(() => Promise.resolve(undefined));
+
+		const databaseContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+
+		const children = await databaseContainerTreeNode.getChildren();
+
+		should(children).Array();
+		should(children.length).equal(1);
+		should(children[0]).instanceof(AzureResourceMessageTreeNode);
+		should(children[0].nodePathValue).startWith('message_');
+		should(children[0].getNodeInfo().label).equal('No SQL Servers found.');
+	});
+
+	it('Should handle errors.', async function(): Promise<void> {
+		const mockError = 'Test error';
+		mockDatabaseServerService.setup((o) => o.getDatabaseServers(mockSubscription, mockCredentials)).returns(() => { throw new Error(mockError); });
+
+		const databaseServerContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+		const children = await databaseServerContainerTreeNode.getChildren();
+
+		mockCredentialService.verify((o) => o.getCredentials(mockAccount), TypeMoq.Times.once());
+		mockDatabaseServerService.verify((o) => o.getDatabaseServers(mockSubscription, mockCredentials), TypeMoq.Times.once());
+		mockCacheService.verify((o) => o.get(TypeMoq.It.isAnyString()), TypeMoq.Times.never());
+		mockCacheService.verify((o) => o.update(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()), TypeMoq.Times.never());
+
+		should(children).Array();
+		should(children.length).equal(1);
+		should(children[0]).instanceof(AzureResourceMessageTreeNode);
+		should(children[0].nodePathValue).startWith('message_');
+		should(children[0].getNodeInfo().label).equal(`Error: ${mockError}`);
+	});
+});
+
+describe('AzureResourceDatabaseServerContainerTreeNode.clearCache', function() : void {
+	beforeEach(() => {
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+	});
+
+	it('Should clear cache.', async function(): Promise<void> {
+		const databaseServerContainerTreeNode = new AzureResourceDatabaseServerContainerTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
+		databaseServerContainerTreeNode.clearCache();
+		should(databaseServerContainerTreeNode.isClearingCache).true();
+	});
+});

extensions/azurecore/src/test/azureResource/tree/databaseServerTreeNode.test.ts

@@ -0,0 +1,62 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import * as should from 'should';
+import * as TypeMoq from 'typemoq';
+import * as vscode from 'vscode';
+import 'mocha';
+
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import { IAzureResourceContextService } from '../../../azureResource/interfaces';
+import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
+import { AzureResourceDatabaseServer } from '../../../azureResource/models';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceDatabaseServerTreeNode } from '../../../azureResource/tree/databaseServerTreeNode';
+
+// Mock services
+const mockServicePool = AzureResourceServicePool.getInstance();
+
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
+
+let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
+
+// Mock test data
+const mockDatabaseServer: AzureResourceDatabaseServer = {
+	name: 'mock database 1',
+	fullName: 'mock server 1',
+	loginName: 'mock user 1',
+	defaultDatabaseName: 'master'
+};
+
+describe('AzureResourceDatabaseServerTreeNode.info', function(): void {
+	beforeEach(() => {
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockServicePool.contextService = mockContextService.object;
+	});
+
+	it('Should be correct when created.', async function(): Promise<void> {
+		const databaseServerTreeNode = new AzureResourceDatabaseServerTreeNode(mockDatabaseServer, mockTreeChangeHandler.object, undefined);
+
+		const databaseServerTreeNodeLabel = mockDatabaseServer.name;
+
+		should(databaseServerTreeNode.nodePathValue).equal(`databaseServer_${mockDatabaseServer.name}`);
+
+		const treeItem = await databaseServerTreeNode.getTreeItem();
+		should(treeItem.label).equal(databaseServerTreeNodeLabel);
+		should(treeItem.contextValue).equal(AzureResourceItemType.databaseServer);
+		should(treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.None);
+
+		const nodeInfo = databaseServerTreeNode.getNodeInfo();
+		should(nodeInfo.isLeaf).true();
+		should(nodeInfo.label).equal(databaseServerTreeNodeLabel);
+		should(nodeInfo.nodeType).equal(AzureResourceItemType.databaseServer);
+		should(nodeInfo.iconType).equal(AzureResourceItemType.databaseServer);
+	});
+});

extensions/azurecore/src/test/azureResource/tree/databaseTreeNode.test.ts

@@ -0,0 +1,62 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import * as should from 'should';
+import * as TypeMoq from 'typemoq';
+import * as vscode from 'vscode';
+import 'mocha';
+
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import { IAzureResourceContextService } from '../../../azureResource/interfaces';
+import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
+import { AzureResourceDatabase } from '../../../azureResource/models';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceDatabaseTreeNode } from '../../../azureResource/tree/databaseTreeNode';
+
+// Mock services
+const mockServicePool = AzureResourceServicePool.getInstance();
+
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
+
+let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
+
+// Mock test data
+const mockDatabase: AzureResourceDatabase = {
+	name: 'mock database 1',
+	serverName: 'mock server 1',
+	serverFullName: 'mock server 1',
+	loginName: 'mock user 1'
+};
+
+describe('AzureResourceDatabaseTreeNode.info', function(): void {
+	beforeEach(() => {
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
+
+		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
+
+		mockServicePool.contextService = mockContextService.object;
+	});
+
+	it('Should be correct.', async function(): Promise<void> {
+		const databaseTreeNode = new AzureResourceDatabaseTreeNode(mockDatabase, mockTreeChangeHandler.object, undefined);
+
+		const databaseTreeNodeLabel = `${mockDatabase.name} (${mockDatabase.serverName})`;
+
+		should(databaseTreeNode.nodePathValue).equal(`database_${mockDatabase.name}`);
+
+		const treeItem = await databaseTreeNode.getTreeItem();
+		should(treeItem.label).equal(databaseTreeNodeLabel);
+		should(treeItem.contextValue).equal(AzureResourceItemType.database);
+		should(treeItem.collapsibleState).equal(vscode.TreeItemCollapsibleState.None);
+
+		const nodeInfo = databaseTreeNode.getNodeInfo();
+		should(nodeInfo.isLeaf).true();
+		should(nodeInfo.label).equal(databaseTreeNodeLabel);
+		should(nodeInfo.nodeType).equal(AzureResourceItemType.database);
+		should(nodeInfo.iconType).equal(AzureResourceItemType.database);
+	});
+});

extensions/azurecore/src/test/azureResource/tree/messageTreeNode.test.ts

@@ -9,8 +9,8 @@ import * as should from 'should';
 import * as vscode from 'vscode';
 import 'mocha';
 
-import { AzureResourceItemType } from '../../azureResource/constants';
-import { AzureResourceMessageTreeNode } from '../../azureResource/messageTreeNode';
+import { AzureResourceItemType } from '../../../azureResource/constants';
+import { AzureResourceMessageTreeNode } from '../../../azureResource/tree/messageTreeNode';
 
 describe('AzureResourceMessageTreeNode.info', function(): void {
 	it('Should be correct when created.', async function(): Promise<void> {

extensions/azurecore/src/test/azureResource/tree/subscriptionTreeNode.test.ts

@@ -10,24 +10,20 @@ import * as TypeMoq from 'typemoq';
 import * as sqlops from 'sqlops';
 import * as vscode from 'vscode';
 import 'mocha';
-import { AppContext } from '../../../appContext';
-import { ApiWrapper } from '../../../apiWrapper';
 
-import { azureResource } from '../../../azureResource/azure-resource';
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import { IAzureResourceContextService } from '../../../azureResource/interfaces';
 import { IAzureResourceTreeChangeHandler } from '../../../azureResource/tree/treeChangeHandler';
+import { AzureResourceSubscription } from '../../../azureResource/models';
 import { AzureResourceSubscriptionTreeNode } from '../../../azureResource/tree/subscriptionTreeNode';
-import { AzureResourceItemType, AzureResourceServiceNames } from '../../../azureResource/constants';
-import { AzureResourceService } from '../../../azureResource/resourceService';
-import { AzureResourceResourceTreeNode } from '../../../azureResource/resourceTreeNode';
-import { IAzureResourceCacheService } from '../../../azureResource/interfaces';
-import { generateGuid } from '../../../azureResource/utils';
+import { AzureResourceDatabaseContainerTreeNode } from '../../../azureResource/tree/databaseContainerTreeNode';
+import { AzureResourceDatabaseServerContainerTreeNode } from '../../../azureResource/tree/databaseServerContainerTreeNode';
+import { AzureResourceItemType } from '../../../azureResource/constants';
 
 // Mock services
-let mockAppContext: AppContext;
+const mockServicePool = AzureResourceServicePool.getInstance();
 
-let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
-let mockApiWrapper: TypeMoq.IMock<ApiWrapper>;
-let mockCacheService: TypeMoq.IMock<IAzureResourceCacheService>;
+let mockContextService: TypeMoq.IMock<IAzureResourceContextService>;
 
 let mockTreeChangeHandler: TypeMoq.IMock<IAzureResourceTreeChangeHandler>;
 
@@ -46,60 +42,24 @@ const mockAccount: sqlops.Account = {
 	isStale: false
 };
 
-const mockSubscription: azureResource.AzureResourceSubscription = {
+const mockSubscription: AzureResourceSubscription = {
 	id: 'mock_subscription',
 	name: 'mock subscription'
 };
 
-const mockTenantId: string = 'mock_tenant';
-
-let mockResourceTreeDataProvider1: TypeMoq.IMock<azureResource.IAzureResourceTreeDataProvider>;
-let mockResourceProvider1: TypeMoq.IMock<azureResource.IAzureResourceProvider>;
-
-let mockResourceTreeDataProvider2: TypeMoq.IMock<azureResource.IAzureResourceTreeDataProvider>;
-let mockResourceProvider2: TypeMoq.IMock<azureResource.IAzureResourceProvider>;
-
-const resourceService: AzureResourceService = AzureResourceService.getInstance();
-
 describe('AzureResourceSubscriptionTreeNode.info', function(): void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
-
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
+		mockContextService = TypeMoq.Mock.ofType<IAzureResourceContextService>();
 
 		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
 
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		mockResourceTreeDataProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider2.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider2.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider2.setup((o) => o.providerId).returns(() => 'mockResourceProvider2');
-		mockResourceProvider2.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider2.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		resourceService.registerResourceProvider(mockResourceProvider2.object);
-
-		resourceService.areResourceProvidersLoaded = true;
+		mockServicePool.contextService = mockContextService.object;
 	});
 
 	it('Should be correct when created.', async function(): Promise<void> {
-		const subscriptionTreeNode = new AzureResourceSubscriptionTreeNode(mockAccount, mockSubscription, mockTenantId, mockAppContext, mockTreeChangeHandler.object, undefined);
+		const subscriptionTreeNode = new AzureResourceSubscriptionTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
 
-		should(subscriptionTreeNode.nodePathValue).equal(`account_${mockAccount.key.accountId}.subscription_${mockSubscription.id}.tenant_${mockTenantId}`);
+		should(subscriptionTreeNode.nodePathValue).equal(`subscription_${mockSubscription.id}`);
 
 		const treeItem = await subscriptionTreeNode.getTreeItem();
 		should(treeItem.label).equal(mockSubscription.name);
@@ -116,52 +76,16 @@ describe('AzureResourceSubscriptionTreeNode.info', function(): void {
 
 describe('AzureResourceSubscriptionTreeNode.getChildren', function(): void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
-
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
-
 		mockTreeChangeHandler = TypeMoq.Mock.ofType<IAzureResourceTreeChangeHandler>();
-
-		mockResourceTreeDataProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider1.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider1.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider1 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider1.setup((o) => o.providerId).returns(() => 'mockResourceProvider1');
-		mockResourceProvider1.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider1.object);
-
-		mockResourceTreeDataProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceTreeDataProvider>();
-		mockResourceTreeDataProvider2.setup((o) => o.getChildren()).returns(() => Promise.resolve([TypeMoq.Mock.ofType<azureResource.IAzureResourceNode>().object]));
-		mockResourceTreeDataProvider2.setup((o) => o.getTreeItem(TypeMoq.It.isAny())).returns(() => Promise.resolve(TypeMoq.It.isAny()));
-		mockResourceProvider2 = TypeMoq.Mock.ofType<azureResource.IAzureResourceProvider>();
-		mockResourceProvider2.setup((o) => o.providerId).returns(() => 'mockResourceProvider2');
-		mockResourceProvider2.setup((o) => o.getTreeDataProvider()).returns(() => mockResourceTreeDataProvider2.object);
-
-		resourceService.clearResourceProviders();
-		resourceService.registerResourceProvider(mockResourceProvider1.object);
-		resourceService.registerResourceProvider(mockResourceProvider2.object);
-
-		resourceService.areResourceProvidersLoaded = true;
 	});
 
-	it('Should return resource containers.', async function(): Promise<void> {
-		const subscriptionTreeNode = new AzureResourceSubscriptionTreeNode(mockAccount, mockSubscription, mockTenantId, mockAppContext, mockTreeChangeHandler.object, undefined);
+	it('Should load database containers.', async function(): Promise<void> {
+		const subscriptionTreeNode = new AzureResourceSubscriptionTreeNode(mockSubscription, mockAccount, mockTreeChangeHandler.object, undefined);
 		const children = await subscriptionTreeNode.getChildren();
 
-		mockResourceTreeDataProvider1.verify((o) => o.getChildren(), TypeMoq.Times.once());
-
-		mockResourceTreeDataProvider2.verify((o) => o.getChildren(), TypeMoq.Times.once());
-
-		const expectedChildren = await resourceService.listResourceProviderIds();
-
 		should(children).Array();
-		should(children.length).equal(expectedChildren.length);
-		for (const child of children) {
-			should(child).instanceOf(AzureResourceResourceTreeNode);
-		}
+		should(children.length).equal(2);
+		should(children[0]).instanceof(AzureResourceDatabaseContainerTreeNode);
+		should(children[1]).instanceof(AzureResourceDatabaseServerContainerTreeNode);
 	});
 });

extensions/azurecore/src/test/azureResource/tree/treeProvider.test.ts

@@ -5,28 +5,21 @@
 
 'use strict';
 
-import * as vscode from 'vscode';
 import * as should from 'should';
 import * as TypeMoq from 'typemoq';
 import * as sqlops from 'sqlops';
 import 'mocha';
-import { AppContext } from '../../../appContext';
-import { ApiWrapper } from '../../../apiWrapper';
 
-import { IAzureResourceCacheService, IAzureResourceAccountService } from '../../../azureResource/interfaces';
+import { AzureResourceServicePool } from '../../../azureResource/servicePool';
+import { IAzureResourceAccountService } from '../../../azureResource/interfaces';
 import { AzureResourceTreeProvider } from '../../../azureResource/tree/treeProvider';
 import { AzureResourceAccountTreeNode } from '../../../azureResource/tree/accountTreeNode';
 import { AzureResourceAccountNotSignedInTreeNode } from '../../../azureResource/tree/accountNotSignedInTreeNode';
-import { AzureResourceMessageTreeNode } from '../../../azureResource/messageTreeNode';
-import { AzureResourceServiceNames } from '../../../azureResource/constants';
-import { generateGuid } from '../../../azureResource/utils';
+import { AzureResourceMessageTreeNode } from '../../../azureResource/tree/messageTreeNode';
 
 // Mock services
-let mockAppContext: AppContext;
+const mockServicePool = AzureResourceServicePool.getInstance();
 
-let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
-let mockApiWrapper: TypeMoq.IMock<ApiWrapper>;
-let mockCacheService: TypeMoq.IMock<IAzureResourceCacheService>;
 let mockAccountService: TypeMoq.IMock<IAzureResourceAccountService>;
 
 // Mock test data
@@ -60,23 +53,15 @@ const mockAccounts = [mockAccount1, mockAccount2];
 
 describe('AzureResourceTreeProvider.getChildren', function(): void {
 	beforeEach(() => {
-		mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
-		mockApiWrapper = TypeMoq.Mock.ofType<ApiWrapper>();
-		mockCacheService = TypeMoq.Mock.ofType<IAzureResourceCacheService>();
 		mockAccountService = TypeMoq.Mock.ofType<IAzureResourceAccountService>();
 
-		mockAppContext = new AppContext(mockExtensionContext.object, mockApiWrapper.object);
-
-		mockAppContext.registerService<IAzureResourceCacheService>(AzureResourceServiceNames.cacheService, mockCacheService.object);
-		mockAppContext.registerService<IAzureResourceAccountService>(AzureResourceServiceNames.accountService, mockAccountService.object);
-
-		mockCacheService.setup((o) => o.generateKey(TypeMoq.It.isAnyString())).returns(() => generateGuid());
+		mockServicePool.accountService = mockAccountService.object;
 	});
 
 	it('Should load accounts.', async function(): Promise<void> {
 		mockAccountService.setup((o) => o.getAccounts()).returns(() => Promise.resolve(mockAccounts));
 
-		const treeProvider = new AzureResourceTreeProvider(mockAppContext);
+		const treeProvider = new AzureResourceTreeProvider();
 		treeProvider.isSystemInitialized = true;
 
 		const children = await treeProvider.getChildren(undefined);
@@ -98,7 +83,7 @@ describe('AzureResourceTreeProvider.getChildren', function(): void {
 	it('Should handle when there is no accounts.', async function(): Promise<void> {
 		mockAccountService.setup((o) => o.getAccounts()).returns(() => Promise.resolve(undefined));
 
-		const treeProvider = new AzureResourceTreeProvider(mockAppContext);
+		const treeProvider = new AzureResourceTreeProvider();
 		treeProvider.isSystemInitialized = true;
 
 		const children = await treeProvider.getChildren(undefined);
@@ -112,7 +97,7 @@ describe('AzureResourceTreeProvider.getChildren', function(): void {
 		const mockAccountError = 'Test account error';
 		mockAccountService.setup((o) => o.getAccounts()).returns(() => { throw new Error(mockAccountError); });
 
-		const treeProvider = new AzureResourceTreeProvider(mockAppContext);
+		const treeProvider = new AzureResourceTreeProvider();
 		treeProvider.isSystemInitialized = true;
 
 		const children = await treeProvider.getChildren(undefined);

extensions/azurecore/src/treeNodes.ts

@@ -11,6 +11,16 @@ import * as vscode from 'vscode';
 type TreeNodePredicate = (node: TreeNode) => boolean;
 
 export abstract class TreeNode {
+	private _parent: TreeNode = undefined;
+
+	public get parent(): TreeNode {
+		return this._parent;
+	}
+
+	public set parent(node: TreeNode) {
+		this._parent = node;
+	}
+
 	public generateNodePath(): string {
 		let path = undefined;
 		if (this.parent) {
@@ -55,23 +65,13 @@ export abstract class TreeNode {
 		return undefined;
 	}
 
-	public get parent(): TreeNode {
-		return this._parent;
-	}
-
-	public set parent(node: TreeNode) {
-		this._parent = node;
-	}
-
-	public abstract getChildren(refreshChildren: boolean): TreeNode[] | Promise<TreeNode[]>;
-	public abstract getTreeItem(): vscode.TreeItem | Promise<vscode.TreeItem>;
-
-	public abstract getNodeInfo(): sqlops.NodeInfo;
-
 	/**
 	 * The value to use for this node in the node path
 	 */
 	public abstract get nodePathValue(): string;
 
-	private _parent: TreeNode = undefined;
+	abstract getChildren(refreshChildren: boolean): TreeNode[] | Promise<TreeNode[]>;
+	abstract getTreeItem(): vscode.TreeItem | Promise<vscode.TreeItem>;
+
+	abstract getNodeInfo(): sqlops.NodeInfo;
 }

extensions/import/README.md

@@ -1,50 +1,9 @@
 # Microsoft SQL Server Import for Azure Data Studio
 
-Microsoft SQL Server Import for Azure Data Studio includes two wizards: 
-- [Import Flat File Wizard](#import-flat-file-wizard-preview)
-- [Data-tier Application Wizard.](#data-tier-application-wizard-preview)
-
-## Import Flat File Wizard *(preview)*
-**The Import Flat File Wizard** is a simple way to copy data from a flat file (.csv, .txt, .json) to a SQL Server table. Checkout below the reasons for using the Import Flat File wizard, how to find this wizard, and a simple example.
-
-This experience is currently in its initial preview. Please report issues and feature requests [here.](https://github.com/microsoft/azuredatastudio/issues)
+Microsoft SQL Server Import for Azure Data Studio is a simple way to copy data from a flat file (.csv, .txt, .json) to a SQL Server table. Checkout below the reasons for using the Import Flat File wizard, how to find this wizard, and a simple example.
 
 <img src="https://user-images.githubusercontent.com/30873802/43433347-c958ed28-942b-11e8-8bbc-f4f2529c3978.png" width="800px" />
 
- ### Requirements
- * This wizard requires an active connection to a SQL Server instance to start.
- * This wizard only works on .txt and .csv files.
-
- ### How do I start the Import Flat File wizard?
- * The main entry point for the wizard is to right click a database in the Object Explorer, and click **Import wizard**.
- * If a user is connected to a SQL Server instance, the user can also press **Ctrl**+**I** to start the wizard.
-
- ### Why would I use the Import Flat File wizard?
-This wizard was created to improve the current import experience leveraging an intelligent framework known as Program Synthesis using Examples ([PROSE](https://microsoft.github.io/prose/)). For a user without specialized domain knowledge, importing data can often be a complex, error prone, and tedious task. This wizard streamlines the import process as simple as selecting an input file and unique table name, and the PROSE framework handles the rest.
-
- PROSE analyzes data patterns in your input file to infer column names, types, delimiters, and more. This framework learns the structure of the file and does all of the hard work so users don't have to.
-
- Please note that the PROSE binary components used by this extension are licensed under the [MICROSOFT SQL TOOLS IMPORT FLAT FILE  EULA](https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/extensions/import/Microsoft_SQL_Server_Import_Extension_and_Tools_Import_Flat_File_Preview.docx).
- 
-## Data-tier Application Wizard *(preview)*
-**The Data-tier Application Wizard** provides an easy to use experience to deploy and extract .dacpac files and import and export .bacpac files. 
-
-This experience is currently in its initial preview. Please report issues and feature requests [here.](https://github.com/microsoft/azuredatastudio/issues)
-
-<img src="https://user-images.githubusercontent.com/30873802/49676289-f2df6880-fa2d-11e8-8bfa-6213b7734075.png" width="800px" />
-
- ### Requirements
- * This wizard requires an active connection to a SQL Server instance to start.
-
- ### How do I start the Data-tier Application wizard?
- * The main entry point for the wizard is to right click a database in the Object Explorer, and click **Data-tier Application wizard**.
- * If a user is connected to a SQL Server instance, the user can also start the wizard from the command palette (Ctrl+Shift+P) by searching for **Data-tier Application wizard.**
-
- ### Why would I use the Data-tier Application wizard?
- This wizard was created to add the ability to extract and deploy .dacpac files and import and export .bacpac files in Azure Data Studio.
- 
-To learn more about Data-Tier Applications and working with dacpac and bacpac files, [you can read more here.](https://docs.microsoft.com/en-us/sql/relational-databases/data-tier-applications/data-tier-applications?view=sql-server-2017)
-
 ## License
 
 Copyright (c) Microsoft Corporation. All rights reserved.
@@ -53,6 +12,21 @@ Licensed under the [MICROSOFT SQL SERVER IMPORT EXTENSION EULA](https://raw.gith
 
 > Note: Microsoft SQL Server Import for Azure Data Studio extension contains the Microsoft SQL Tools Import Flat File component which is also licensed under the above EULA.
 
+ ## Requirements
+ * This wizard requires an active connection to a SQL Server instance to start.
+ * This wizard only works on .txt and .csv files.
+
+ ## How do I start the Flat File Import wizard?
+ * The main entry point for the wizard is to right click a database in the Object Explorer, and click **Import wizard**.
+ * If a user is connected to a SQL Server instance, the user can also press **Ctrl**+**I** to start the wizard.
+
+ ## Why would I use the Flat File Import wizard?
+ This wizard was created to improve the current import experience leveraging an intelligent framework known as Program Synthesis using Examples ([PROSE](https://microsoft.github.io/prose/)). For a user without specialized domain knowledge, importing data can often be a complex, error prone, and tedious task. This wizard streamlines the import process as simple as selecting an input file and unique table name, and the PROSE framework handles the rest.
+
+ PROSE analyzes data patterns in your input file to infer column names, types, delimiters, and more. This framework learns the structure of the file and does all of the hard work so users don't have to.
+
+ Please note that the PROSE binary components used by this extension are licensed under the [MICROSOFT SQL TOOLS IMPORT FLAT FILE  EULA](https://raw.githubusercontent.com/Microsoft/azuredatastudio/master/extensions/import/Microsoft_SQL_Server_Import_Extension_and_Tools_Import_Flat_File_Preview.docx).
+
 ## Code of Conduct
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

extensions/import/package.json

@@ -2,7 +2,7 @@
   "name": "import",
   "displayName": "SQL Server Import",
   "description": "SQL Server Import for Azure Data Studio supports importing CSV or JSON files into SQL Server.",
-  "version": "0.5.0",
+  "version": "0.3.0",
   "publisher": "Microsoft",
   "preview": true,
   "engines": {
@@ -33,15 +33,6 @@
           "light": "./images/light_icon.svg",
           "dark": "./images/dark_icon.svg"
         }
-      },
-      {
-        "command": "dacFx.start",
-        "title": "Data-tier Application Wizard",
-        "category": "Data-tier Application",
-        "icon": {
-          "light": "./images/light_icon.svg",
-          "dark": "./images/dark_icon.svg"
-        }
       }
     ],
     "keybindings": [
@@ -57,17 +48,12 @@
           "command": "flatFileImport.start",
           "when": "connectionProvider == MSSQL && nodeType && nodeType == Database",
           "group": "import"
-        },
-        {
-          "command": "dacFx.start",
-          "when": "connectionProvider == MSSQL && nodeType && nodeType == Database",
-          "group": "export"
         }
       ]
     }
   },
   "dependencies": {
-    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#0.2.11",
+    "dataprotocol-client": "github:Microsoft/sqlops-dataprotocolclient#0.2.7",
     "opener": "^1.4.3",
     "service-downloader": "github:anthonydresser/service-downloader#0.1.5",
     "vscode-extension-telemetry": "0.0.18",

extensions/import/src/controllers/mainController.ts

@@ -13,7 +13,6 @@ import { FlatFileWizard } from '../wizard/flatFileWizard';
 import { ServiceClient } from '../services/serviceClient';
 import { ApiType, managerInstance } from '../services/serviceApiManager';
 import { FlatFileProvider } from '../services/contracts';
-import { DataTierApplicationWizard } from '../wizard/dataTierApplicationWizard';
 
 /**
  * The main controller class that initializes the extension
@@ -36,15 +35,10 @@ export default class MainController extends ControllerBase {
 			this.initializeFlatFileProvider(provider);
 		});
 
-		this.initializeDacFxWizard();
 		return Promise.resolve(true);
 	}
 
 	private initializeFlatFileProvider(provider: FlatFileProvider) {
 		sqlops.tasks.registerTask('flatFileImport.start', (profile: sqlops.IConnectionProfile, ...args: any[]) => new FlatFileWizard(provider).start(profile, args));
 	}
-
-	private initializeDacFxWizard() {
-		sqlops.tasks.registerTask('dacFx.start', (profile: sqlops.IConnectionProfile, ...args: any[]) => new DataTierApplicationWizard().start(profile, args));
-	}
 }

extensions/import/src/wizard/api/basePage.ts

@@ -1,139 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-'use strict';
-
-import * as sqlops from 'sqlops';
-import { BaseDataModel } from './models';
-
-export abstract class BasePage {
-
-	protected readonly wizardPage: sqlops.window.modelviewdialog.WizardPage;
-	protected readonly model: BaseDataModel;
-	protected readonly view: sqlops.ModelView;
-
-	/**
-	 * This method constructs all the elements of the page.
-	 * @returns {Promise<boolean>}
-	 */
-	public async abstract start(): Promise<boolean>;
-
-	/**
-	 * This method is called when the user is entering the page.
-	 * @returns {Promise<boolean>}
-	 */
-	public async abstract onPageEnter(): Promise<boolean>;
-
-	/**
-	 * This method is called when the user is leaving the page.
-	 * @returns {Promise<boolean>}
-	 */
-	async onPageLeave(): Promise<boolean> {
-		return true;
-	}
-
-	/**
-	 * Override this method to cleanup what you don't need cached in the page.
-	 * @returns {Promise<boolean>}
-	 */
-	public async cleanup(): Promise<boolean> {
-		return true;
-	}
-
-	/**
-	 * Sets up a navigation validator.
-	 * This will be called right before onPageEnter().
-	 */
-	public abstract setupNavigationValidator();
-
-	protected async getServerValues(): Promise<{ connection, displayName, name }[]> {
-		let cons = await sqlops.connection.getActiveConnections();
-		// This user has no active connections ABORT MISSION
-		if (!cons || cons.length === 0) {
-			return undefined;
-		}
-
-		let count = -1;
-		let idx = -1;
-
-
-		let values = cons.map(c => {
-			// Handle the code to remember what the user's choice was from before
-			count++;
-			if (idx === -1) {
-				if (this.model.server && c.connectionId === this.model.server.connectionId) {
-					idx = count;
-				} else if (this.model.serverId && c.connectionId === this.model.serverId) {
-					idx = count;
-				}
-			}
-
-			let db = c.options.databaseDisplayName;
-			let usr = c.options.user;
-			let srv = c.options.server;
-
-			if (!db) {
-				db = '<default>';
-			}
-
-			if (!usr) {
-				usr = 'default';
-			}
-
-			let finalName = `${srv}, ${db} (${usr})`;
-			return {
-				connection: c,
-				displayName: finalName,
-				name: c.connectionId
-			};
-		});
-
-		if (idx >= 0) {
-			let tmp = values[0];
-			values[0] = values[idx];
-			values[idx] = tmp;
-		} else {
-			this.deleteServerValues();
-		}
-
-		return values;
-	}
-
-	protected async getDatabaseValues(): Promise<{ displayName, name }[]> {
-		let idx = -1;
-		let count = -1;
-		let values = (await sqlops.connection.listDatabases(this.model.server.connectionId)).map(db => {
-			count++;
-			if (this.model.database && db === this.model.database) {
-				idx = count;
-			}
-
-			return {
-				displayName: db,
-				name: db
-			};
-		});
-
-		if (idx >= 0) {
-			let tmp = values[0];
-			values[0] = values[idx];
-			values[idx] = tmp;
-		} else {
-			this.deleteDatabaseValues();
-		}
-
-		return values;
-	}
-
-	protected deleteServerValues() {
-		delete this.model.server;
-		delete this.model.serverId;
-		delete this.model.database;
-	}
-
-	protected deleteDatabaseValues() {
-		return;
-	}
-}
-

extensions/import/src/wizard/api/dacFxConfigPage.ts

@@ -1,158 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-'use strict';
-
-import * as sqlops from 'sqlops';
-import * as nls from 'vscode-nls';
-import * as os from 'os';
-import * as path from 'path';
-import { DataTierApplicationWizard } from '../dataTierApplicationWizard';
-import { DacFxDataModel } from './models';
-import { BasePage } from './basePage';
-
-const localize = nls.loadMessageBundle();
-
-export abstract class DacFxConfigPage extends BasePage {
-
-	protected readonly wizardPage: sqlops.window.modelviewdialog.WizardPage;
-	protected readonly instance: DataTierApplicationWizard;
-	protected readonly model: DacFxDataModel;
-	protected readonly view: sqlops.ModelView;
-	protected serverDropdown: sqlops.DropDownComponent;
-	protected databaseTextBox: sqlops.InputBoxComponent;
-	protected databaseDropdown: sqlops.DropDownComponent;
-	protected databaseLoader: sqlops.LoadingComponent;
-	protected fileTextBox: sqlops.InputBoxComponent;
-	protected fileButton: sqlops.ButtonComponent;
-	protected fileExtension: string;
-
-	protected constructor(instance: DataTierApplicationWizard, wizardPage: sqlops.window.modelviewdialog.WizardPage, model: DacFxDataModel, view: sqlops.ModelView) {
-		super();
-		this.instance = instance;
-		this.wizardPage = wizardPage;
-		this.model = model;
-		this.view = view;
-	}
-
-	public setupNavigationValidator() {
-		this.instance.registerNavigationValidator(() => {
-			return true;
-		});
-	}
-
-	protected async createServerDropdown(isTargetServer: boolean): Promise<sqlops.FormComponent> {
-		this.serverDropdown = this.view.modelBuilder.dropDown().withProperties({
-			required: true
-		}).component();
-
-		// Handle server changes
-		this.serverDropdown.onValueChanged(async () => {
-			this.model.server = (this.serverDropdown.value as ConnectionDropdownValue).connection;
-			this.model.serverName = (this.serverDropdown.value as ConnectionDropdownValue).displayName;
-			await this.populateDatabaseDropdown();
-		});
-
-		let targetServerTitle = localize('dacFx.targetServerDropdownTitle', 'Target Server');
-		let sourceServerTitle = localize('dacFx.sourceServerDropdownTitle', 'Source Server');
-
-		return {
-			component: this.serverDropdown,
-			title: isTargetServer ? targetServerTitle : sourceServerTitle
-		};
-	}
-
-	protected async populateServerDropdown(): Promise<boolean> {
-		let values = await this.getServerValues();
-		if (values === undefined) {
-			return false;
-		}
-
-		this.model.server = values[0].connection;
-		this.model.serverName = values[0].displayName;
-
-		this.serverDropdown.updateProperties({
-			values: values
-		});
-		return true;
-	}
-
-	protected async createDatabaseTextBox(): Promise<sqlops.FormComponent> {
-		this.databaseTextBox = this.view.modelBuilder.inputBox().withProperties({
-			required: true
-		}).component();
-
-		this.databaseTextBox.onTextChanged(async () => {
-			this.model.database = this.databaseTextBox.value;
-		});
-
-		return {
-			component: this.databaseTextBox,
-			title: localize('dacFx.databaseNameTextBox', 'Target Database')
-		};
-	}
-
-	protected async createDatabaseDropdown(): Promise<sqlops.FormComponent> {
-		this.databaseDropdown = this.view.modelBuilder.dropDown().withProperties({
-			required: true
-		}).component();
-
-		// Handle database changes
-		this.databaseDropdown.onValueChanged(async () => {
-			this.model.database = (<sqlops.CategoryValue>this.databaseDropdown.value).name;
-			this.fileTextBox.value = this.generateFilePath();
-			this.model.filePath = this.fileTextBox.value;
-		});
-
-		this.databaseLoader = this.view.modelBuilder.loadingComponent().withItem(this.databaseDropdown).component();
-
-		return {
-			component: this.databaseLoader,
-			title: localize('dacFx.sourceDatabaseDropdownTitle', 'Source Database')
-		};
-	}
-
-	protected async populateDatabaseDropdown(): Promise<boolean> {
-		this.databaseLoader.loading = true;
-		this.databaseDropdown.updateProperties({ values: [] });
-
-		if (!this.model.server) {
-			this.databaseLoader.loading = false;
-			return false;
-		}
-
-		let values = await this.getDatabaseValues();
-		this.model.database = values[0].name;
-		this.model.filePath = this.generateFilePath();
-		this.fileTextBox.value = this.model.filePath;
-
-		this.databaseDropdown.updateProperties({
-			values: values
-		});
-		this.databaseLoader.loading = false;
-
-		return true;
-	}
-
-	protected async createFileBrowserParts() {
-		this.fileTextBox = this.view.modelBuilder.inputBox().withProperties({
-			required: true
-		}).component();
-
-		this.fileButton = this.view.modelBuilder.button().withProperties({
-			label: '•••',
-		}).component();
-	}
-
-	protected generateFilePath(): string {
-		let now = new Date();
-		let datetime = now.getFullYear() + '-' + (now.getMonth() + 1) + '-' + now.getDate() + '-' + now.getHours() + '-' + now.getMinutes();
-		return path.join(os.homedir(), this.model.database + '-' + datetime + this.fileExtension);
-	}
-}
-
-interface ConnectionDropdownValue extends sqlops.CategoryValue {
-	connection: sqlops.connection.Connection;
-}
-

extensions/import/src/wizard/api/importPage.ts

@@ -8,9 +8,8 @@ import { ImportDataModel } from './models';
 import * as sqlops from 'sqlops';
 import { FlatFileProvider } from '../../services/contracts';
 import { FlatFileWizard } from '../flatFileWizard';
-import { BasePage } from './basePage';
 
-export abstract class ImportPage extends BasePage {
+export abstract class ImportPage {
 
 	protected readonly wizardPage: sqlops.window.modelviewdialog.WizardPage;
 	protected readonly instance: FlatFileWizard;
@@ -19,11 +18,42 @@ export abstract class ImportPage extends BasePage {
 	protected readonly provider: FlatFileProvider;
 
 	protected constructor(instance: FlatFileWizard, wizardPage: sqlops.window.modelviewdialog.WizardPage, model: ImportDataModel, view: sqlops.ModelView, provider: FlatFileProvider) {
-		super();
 		this.instance = instance;
 		this.wizardPage = wizardPage;
 		this.model = model;
 		this.view = view;
 		this.provider = provider;
 	}
+
+	/**
+	 * This method constructs all the elements of the page.
+	 * @returns {Promise<boolean>}
+	 */
+	public async abstract start(): Promise<boolean>;
+
+	/**
+	 * This method is called when the user is entering the page.
+	 * @returns {Promise<boolean>}
+	 */
+	public async abstract onPageEnter(): Promise<boolean>;
+
+	/**
+	 * This method is called when the user is leaving the page.
+	 * @returns {Promise<boolean>}
+	 */
+	public async abstract onPageLeave(): Promise<boolean>;
+
+	/**
+	 * Sets up a navigation validator.
+	 * This will be called right before onPageEnter().
+	 */
+	public abstract setupNavigationValidator();
+
+	/**
+	 * Override this method to cleanup what you don't need cached in the page.
+	 * @returns {Promise<boolean>}
+	 */
+	public async cleanup(): Promise<boolean> {
+		return true;
+	}
 }

extensions/import/src/wizard/api/models.ts

@@ -6,19 +6,15 @@
 
 import * as sqlops from 'sqlops';
 
-export interface BaseDataModel {
-	server: sqlops.connection.Connection;
-	serverId: string;
-	database: string;
-}
-
 /**
  * The main data model that communicates between the pages.
  */
-export interface ImportDataModel extends BaseDataModel {
+export interface ImportDataModel {
 	ownerUri: string;
 	proseColumns: ColumnMetadata[];
 	proseDataPreview: string[][];
+	server: sqlops.connection.Connection;
+	serverId: string;
 	database: string;
 	table: string;
 	schema: string;
@@ -35,14 +31,3 @@ export interface ColumnMetadata {
 	primaryKey: boolean;
 	nullable: boolean;
 }
-
-/**
- * Data model to communicate between DacFx pages
- */
-export interface DacFxDataModel extends BaseDataModel {
-	serverName: string;
-	serverId: string;
-	filePath: string;
-	version: string;
-	upgradeExisting: boolean;
-}

extensions/import/src/wizard/dataTierApplicationWizard.ts

@@ -1,252 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the Source EULA. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-'use strict';
-import * as vscode from 'vscode';
-import * as nls from 'vscode-nls';
-import * as sqlops from 'sqlops';
-import { SelectOperationPage } from './pages/selectOperationpage';
-import { DeployConfigPage } from './pages/deployConfigPage';
-import { DacFxSummaryPage } from './pages/dacFxSummaryPage';
-import { ExportConfigPage } from './pages/exportConfigPage';
-import { ExtractConfigPage } from './pages/extractConfigPage';
-import { ImportConfigPage } from './pages/importConfigPage';
-import { DacFxDataModel } from './api/models';
-import { BasePage } from './api/basePage';
-
-const localize = nls.loadMessageBundle();
-
-class Page {
-	wizardPage: sqlops.window.modelviewdialog.WizardPage;
-	dacFxPage: BasePage;
-
-	constructor(wizardPage: sqlops.window.modelviewdialog.WizardPage) {
-		this.wizardPage = wizardPage;
-	}
-}
-
-export enum Operation {
-	deploy,
-	extract,
-	import,
-	export
-}
-
-export class DataTierApplicationWizard {
-	public wizard: sqlops.window.modelviewdialog.Wizard;
-	private connection: sqlops.connection.Connection;
-	private model: DacFxDataModel;
-	public pages: Map<string, Page> = new Map<string, Page>();
-	public selectedOperation: Operation;
-
-	constructor() {
-	}
-
-	public async start(p: any, ...args: any[]) {
-		this.model = <DacFxDataModel>{};
-
-		let profile = p ? <sqlops.IConnectionProfile>p.connectionProfile : undefined;
-		if (profile) {
-			this.model.serverId = profile.id;
-			this.model.database = profile.databaseName;
-		}
-
-		this.connection = await sqlops.connection.getCurrentConnection();
-		if (!this.connection) {
-			this.connection = await sqlops.connection.openConnectionDialog();
-		}
-
-		this.wizard = sqlops.window.modelviewdialog.createWizard('Data-tier Application Wizard');
-		let selectOperationWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.selectOperationPageName', 'Select an Operation'));
-		let deployConfigWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.deployConfigPageName', 'Select Deploy Dacpac Settings'));
-		let summaryWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.summaryPageName', 'Summary'));
-		let extractConfigWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.extractConfigPageName', 'Select Extract Dacpac Settings'));
-		let importConfigWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.importConfigPageName', 'Select Import Bacpac Settings'));
-		let exportConfigWizardPage = sqlops.window.modelviewdialog.createWizardPage(localize('dacFx.exportConfigPageName', 'Select Export Bacpac Settings'));
-
-		this.pages.set('selectOperation', new Page(selectOperationWizardPage));
-		this.pages.set('deployConfig', new Page(deployConfigWizardPage));
-		this.pages.set('extractConfig', new Page(extractConfigWizardPage));
-		this.pages.set('importConfig', new Page(importConfigWizardPage));
-		this.pages.set('exportConfig', new Page(exportConfigWizardPage));
-		this.pages.set('summary', new Page(summaryWizardPage));
-
-		selectOperationWizardPage.registerContent(async (view) => {
-			let selectOperationDacFxPage = new SelectOperationPage(this, selectOperationWizardPage, this.model, view);
-			this.pages.get('selectOperation').dacFxPage = selectOperationDacFxPage;
-			await selectOperationDacFxPage.start().then(() => {
-				selectOperationDacFxPage.setupNavigationValidator();
-				selectOperationDacFxPage.onPageEnter();
-			});
-		});
-
-		deployConfigWizardPage.registerContent(async (view) => {
-			let deployConfigDacFxPage = new DeployConfigPage(this, deployConfigWizardPage, this.model, view);
-			this.pages.get('deployConfig').dacFxPage = deployConfigDacFxPage;
-			await deployConfigDacFxPage.start();
-		});
-
-		extractConfigWizardPage.registerContent(async (view) => {
-			let extractConfigDacFxPage = new ExtractConfigPage(this, extractConfigWizardPage, this.model, view);
-			this.pages.get('extractConfig').dacFxPage = extractConfigDacFxPage;
-			await extractConfigDacFxPage.start();
-		});
-
-		importConfigWizardPage.registerContent(async (view) => {
-			let importConfigDacFxPage = new ImportConfigPage(this, importConfigWizardPage, this.model, view);
-			this.pages.get('importConfig').dacFxPage = importConfigDacFxPage;
-			await importConfigDacFxPage.start();
-		});
-
-		exportConfigWizardPage.registerContent(async (view) => {
-			let exportConfigDacFxPage = new ExportConfigPage(this, exportConfigWizardPage, this.model, view);
-			this.pages.get('exportConfig').dacFxPage = exportConfigDacFxPage;
-			await exportConfigDacFxPage.start();
-		});
-
-		summaryWizardPage.registerContent(async (view) => {
-			let summaryDacFxPage = new DacFxSummaryPage(this, summaryWizardPage, this.model, view);
-			this.pages.get('summary').dacFxPage = summaryDacFxPage;
-			await summaryDacFxPage.start();
-		});
-
-		this.wizard.onPageChanged(async (event) => {
-			let idx = event.newPage;
-			let page: Page;
-
-			if (idx === 1) {
-				switch (this.selectedOperation) {
-					case Operation.deploy: {
-						page = this.pages.get('deployConfig');
-						break;
-					}
-					case Operation.extract: {
-						page = this.pages.get('extractConfig');
-						break;
-					}
-					case Operation.import: {
-						page = this.pages.get('importConfig');
-						break;
-					}
-					case Operation.export: {
-						page = this.pages.get('exportConfig');
-						break;
-					}
-				}
-			} else if (idx === 2) {
-				page = this.pages.get('summary');
-			}
-
-			if (page !== undefined) {
-				page.dacFxPage.setupNavigationValidator();
-				page.dacFxPage.onPageEnter();
-			}
-		});
-
-		this.wizard.pages = [selectOperationWizardPage, deployConfigWizardPage, summaryWizardPage];
-		this.wizard.generateScriptButton.hidden = true;
-		this.wizard.doneButton.onClick(async () => await this.executeOperation());
-
-		this.wizard.open();
-	}
-
-	public registerNavigationValidator(validator: (pageChangeInfo: sqlops.window.modelviewdialog.WizardPageChangeInfo) => boolean) {
-		this.wizard.registerNavigationValidator(validator);
-	}
-
-	public setDoneButton(operation: Operation): void {
-		switch (operation) {
-			case Operation.deploy: {
-				this.wizard.doneButton.label = localize('dacFx.deployButton', 'Deploy');
-				this.selectedOperation = Operation.deploy;
-				break;
-			}
-			case Operation.extract: {
-				this.wizard.doneButton.label = localize('dacFx.extractButton', 'Extract');
-				this.selectedOperation = Operation.extract;
-				break;
-			}
-			case Operation.import: {
-				this.wizard.doneButton.label = localize('dacFx.importButton', 'Import');
-				this.selectedOperation = Operation.import;
-				break;
-			}
-			case Operation.export: {
-				this.wizard.doneButton.label = localize('dacFx.exportButton', 'Export');
-				this.selectedOperation = Operation.export;
-				break;
-			}
-		}
-	}
-
-	private async executeOperation() {
-		switch (this.selectedOperation) {
-			case Operation.deploy: {
-				await this.deploy();
-				break;
-			}
-			case Operation.extract: {
-				await this.extract();
-				break;
-			}
-			case Operation.import: {
-				await this.import();
-				break;
-			}
-			case Operation.export: {
-				await this.export();
-				break;
-			}
-		}
-	}
-
-	private async deploy() {
-		let service = await DataTierApplicationWizard.getService(this.model.server.providerName);
-		let ownerUri = await sqlops.connection.getUriForConnection(this.model.server.connectionId);
-
-		let result = await service.deployDacpac(this.model.filePath, this.model.database, this.model.upgradeExisting, ownerUri, sqlops.TaskExecutionMode.execute);
-		if (!result || !result.success) {
-			vscode.window.showErrorMessage(
-				localize('alertData.deployErrorMessage', "Deploy failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
-		}
-	}
-
-	private async extract() {
-		let service = await DataTierApplicationWizard.getService(this.model.server.providerName);
-		let ownerUri = await sqlops.connection.getUriForConnection(this.model.server.connectionId);
-
-		let result = await service.extractDacpac(this.model.database, this.model.filePath, this.model.database, this.model.version, ownerUri, sqlops.TaskExecutionMode.execute);
-		if (!result || !result.success) {
-			vscode.window.showErrorMessage(
-				localize('alertData.extractErrorMessage', "Extract failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
-		}
-	}
-
-	private async export() {
-		let service = await DataTierApplicationWizard.getService(this.model.server.providerName);
-		let ownerUri = await sqlops.connection.getUriForConnection(this.model.server.connectionId);
-
-		let result = await service.exportBacpac(this.model.database, this.model.filePath, ownerUri, sqlops.TaskExecutionMode.execute);
-		if (!result || !result.success) {
-			vscode.window.showErrorMessage(
-				localize('alertData.exportErrorMessage', "Export failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
-		}
-	}
-
-	private async import() {
-		let service = await DataTierApplicationWizard.getService(this.model.server.providerName);
-		let ownerUri = await sqlops.connection.getUriForConnection(this.model.server.connectionId);
-
-		let result = await service.importBacpac(this.model.filePath, this.model.database, ownerUri, sqlops.TaskExecutionMode.execute);
-		if (!result || !result.success) {
-			vscode.window.showErrorMessage(
-				localize('alertData.importErrorMessage', "Import failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
-		}
-	}
-
-	private static async getService(providerName: string): Promise<sqlops.DacFxServicesProvider> {
-		let service = sqlops.dataprotocol.getProvider<sqlops.DacFxServicesProvider>(providerName, sqlops.DataProviderType.DacFxServicesProvider);
-		return service;
-	}
-}