* remove request promise for request-light
* make sure data is a string not a json
* add configure call
* remove unused reference
* more fixes
* Move configure calls
* clean up
* fix name
* move test deps as dev
Co-authored-by: chgagnon <chgagnon@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* rework some code and write an inital test
* fix strict
* add more to standard test
* add to existing workflow test
* fix tests
* simplify the code
* add more tests
* remove bad import
* fix compile
* fix timestampiong
* Add Cell after current active cell
* fixed error
* more fixes
* Addressed PR
* merged with master
* Fixed the tests and code
* removed try catch and modified the test to check the method does not throw.
Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
* - Removed PG connections in the new connection wizard
- If a PG database is active sending an error
- Removed refresh button #6611
* Added back the refresh
* -Using getConnection only once.
* -Fixed the error message
-Fixed the bugs mentioned in the PR
Co-authored-by: Aasim Khan <aaskhan@microsoft.com>
* Added Edit Connection Command
* Wip changes for new connection dialog
* Testing
* WIP commit
* added ID check to ensure connection
* wip commit
* model id check implemented
* addfooterbutton now accepts events
* wip commit
* message explaining check
* temporary change
* connectionManagementService restored
* Revert "connectionManagementService restored"
This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.
* formatting test
* editConnection promise testing
* edit existing connection command added
* WIP Connection Edit
* disconnect added to editConnection promise
* WIP on editExistingConnection
* changed isEdit to true
* Amir/edit connection (#10112)
* Get edit connection working
* Delete unused code
* check for isEdit as well
* connection tree test added
* WIP connection management tests
* comment out test to find out what's wrong
* fix for one error
* added note about test skipped
* changed signature of saveprofile
* saveprofile fixed
* wrote working test
* added additional test
* changed message
* Fixes made
* fix for matcher
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Converted `test-extensions-unit.bat` to javascript to add a small QoL improvement that I think people will find useful: specifying which extension(s) you want to run tests for instead of commenting out lines of a script.
In addition to existing behavior being mostly preserved (node test-extensions-unit.js defaults to running all unit tests), you can specify one or more:
```
node test-extensions-unit.js sql-database-projects
node test-extensions-unit.js sql-database-projects schema-compare
```
* Add a pop up for dotnet install if not present
* Second option of default location for mac/linux
* correcting the pop up message
* remove extra dependency
* updating as per PR comments
* Put new welcome page behind preview features flag (#10099)
* import correct welcome page (#10117)
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* Using azure sql compatible query
* Included changes requested in PR for azure specific DBs and then fixed issue #9361 for contained databases.
* Made some changes mentioned in the PR
- Converted let to const
- Logging the error
* Fixes for attach to. Still need to update cache
* Don't have jupyter hardcoded
* Handle DOTNET_ROOT env var
* Fix on load
* Put behind feature flag
* Cleanup
* Error check
* PR feedback
* Changed the activation event from onCommand to startup "*"
* Refractored some code to fix the issue
* Made some PR related changes and fixed a condition where the same error was occurring when the flatFileImport has to download binaries from the internet.
* Reverted activation event back to previous state as it had no effect.
* Made changes mentioned in the PR
Co-authored-by: Aasim Shahnawaz Khan <aaskhan@microsoft.com>
* Fixing potential bad order of template loading and map construction
* Fixing bug where templates get mapped before loaded from file
* Parallelizing loading templates from file
* Addresses bug: 10062. Replaced scrollTop with getBoundingClientRect.top minus the combined height of the top tabs and action bar.
* Setting initial value of chrome offset, and checking for existence of both tool bars before getting their heights.
* fixes the video images not showing when a 2nd welcome page is opened, and replace the admin pack image
* deletes unused image
* hardcodes video image src into html
* removes dead code
* embeds require.toUrl in markup
* Adding enablePreviewFeatures check before showing the new toolbar.
* Removed unused code.
* Added hook to trigger onDidChangeConfiguration -- this makes the UI change after user has checked or unchecked, without having to restart the app.
* Initializing the component with the current config value of enablePreviewFeatures.
* layout properties in 2 columns
* fix height after collapsing
* update with reflow values
* set height better
* cleanup
* fix crashing when resizing while properties widget is loading
* Switch to grid layout
* Only two columns max
* Update comment
* Undo color change
* Cleanup
* Fix test
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* makes the preview button hover state stay active when hovering over tooltip
* fixes the duplicating list on the extension pack when a 2nd welcome page tab is opened
* Markdown editor toolbar - initial commit
* Moved icons. Refactored new toolbar component to include markup.
* Edited markdown toolbar component and referencing in textCell component markup.
* Completed UI updates for selected cell toolbar and markdown toolbar.
* Modified import path to Event class. Changed EventEmitter to Emitter.
* Cleaned up newly added toolbar components
* Works sometimes sometimes editor is null
* Removed commented out code and styles. CellToolbar and MarkdownToolbar: moved component markup into html file.
* Added icon for highlight. Removed more commented code. Re-scoped two styles to their parent components. Corrected templateUrl reference for the new toolbars.
* Adjusted paths to SVG icons from toolbar stylesheet.
* Add lists and links
* Refactor out of component, add actionbar
* Support for nothing selected, quick bug fix
* Updated split view icons. Added markdown tool backgrounds and cell border colors to color registry and parent components. Updated toolbar icons to use mask as this allows the SVG icon colors to be adjusted on theme change.
* Added colorRegistry entries for code cell. Removed colors from styles. Running registerThemingParticipant from code.component.
* Revised code component style rules and corrected syntax.
* Merged in Chris' working branch and removed unused markup.
* Corrected styles and moved another color into colorRegistry for use in new markdown toolbar.
* Corrected style error. Overrode left position of content inside textCell and codeCell. Added more entries to colorRegistry.
* Moved toolbar and editor icons to common-icons location. Updated related stylesheet. Revised color theming rules for markdown and code cells.
* Added themed border between markdown and preview. Moved all notebook themes into notebookStyles.ts
* Merged in latest from origin/master and included a small but significant style tweak to light theme code cell toolbar.
* Add Undo Support for Markdown Toolbar (#9915)
* Remove comment
* Renamed registered notebook colors and prefixed with notebook. Moved markdown component theme colors into notebookStyles.ts. Removed colors from cellToolbar styles. Revised icon class names to generic names for better re-use. Removed commented markup.
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Added Notebook telemetry for livesite
* added back the metadata retension code
* Unified Telemetry services
* fixed names
* Fixed texts to use new NullAdsTelemetryService
* Validate GUID before sending it
* made GUID check a bit more robust
Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
* WIP sash fix
* stuff to fix
* working mostly
* added tabbedPanel fix
* added null checks
* removed additional space in editdata.css
* wip change for border-top
* Fix for query editor and editdata colors in modes
* removed junk additions for panel.css
* fixed div and classes for editDataGridPanel,
* small optimizations
* Small tweaks
* simplified color checks
* test commit
* Test changes
* no need for important
* updates made
* removed small space
* initial changes for actionbar collapsing
* fix more not always all showing after resizing
* collapse toolbar if window size is already small when dashboard is opened
* make wrapping default behavior and collapse opt in
* fix so keyboard navigation works in overflow
* more keyboard fixing so that the actions in overflow get triggered
* change overflow background with theme
* change margin
* udpate more button
* use icon for ...
* addressing comments
* overflow css changes to match portal
* arrow navigation working
* handle tab and shift tab in overflow
* keep arrow navigation within overflow
* move reused code to helper methods
* set roles for overflow
* use actionsList instead of document.getElementById all the time
* move collapsible action bar to its own class
* renamve to overflowActionBar
* fix focus rectangle around more element
* hide overflow after an action is executed
* hide overflow when clicking an action
* hide overflow when focus leaves and loop focus within overflow when using arrow keys
* fix double down arrow to move focus in overflow
* update comment
* fix clicking more not hiding overflow
* add box-shadow for themes
* fix hygiene error
* fix hygiene error
* widen focused outline for overflow actions
* move properties widget collapse to bottom
* fix double bottom border for high contrast
* show title when collapsed
* move css to classes
* vertical center collapse icon
* adds icons for welcome page
* updates markup and styles for welcome page
* updates color registry with welcome page colors
* updates styles for welcome page
* updates markup for welcome page
* updates theming styles for welcome page and adds date since last opened functionality on history items
* adds all icons and images for welcome page
* updates markup for welcome page
* updates styles for welcome page
* updates color registry with welcome page styles
* updates welcome page icons with microsoft flag and dark theme home banner
* updates welcome page markup
* updates dynamically generated extension list
* updates styles for welcome page
* updates markup for welcome page
* adds dynamic lists for extension pack individual extensions
* updates icons for welcome page
* updates styles for welcome page
* updates welcome page styles
* updates theme colors
* updates markup for welcome page
* updates color registry with welcomepage colors
* updates sql.de.xlf with copy for welcome page
* reverts generated file
* updates welcome page styles
* updates extension pack copy casing
* updates color registry with welcome page styles
* updates welcome page markup
* adds welcome page icons
* updates welcome page markup
* updates welcome page icons
* updates welcome page styles
* reverts color registry in vs folder to original state
* moves color registry to sql folder
* removes dead code, localizes dates
* updates welcome page styles
* moves all colors from css to color registry
* updates styles by removing all colors
* removes stat import because of laying issue, adds color registry colors to welcomePage
* updates welcome page font sizes to ems
* updates localized strings
* removes unnecessary comment
* removes double quotes around string key for single quotes
* updates welcome page styles
* updates color registry
* updates welcome page markup
* adds dropdown button functionality
* adds centering classes for installed button text
* updates welcome page styles
* updates markup and styles for welcome page
* removes icon attempt from color registry
* removes theme specific icon svgs for theme specific icon css
* removes unused import
* removes console.log
* adds back mac new file button
* removes unused rules
* updates markup
* updates markup
* updates extension links to link to extensions in ADS
* pulls in changes from welcome-page-reskin-anthonydresser
* adds back code-icon to vs folder
* reverts welcomePage.css
* removes duplicate color registry variables
* fixes icon overlap on text for mac
* removes null import
* updates welcome page styles for mac
* updates welcome page images to use sql folder
* updates welcome page markup
* updates welcome page styles
* updates styles
* updates files paths
* delete images from sql folder
* updates icons
* updates welcome page styles
* updates preview popup
* updates markup for accessibility
* adds hover state to tiles
* updates dropdown
* fixes line-height issue
* updates class names
* updates keyboard accessibility for tooltip
* format document
* updates accessibility for preview tooltip
* removes whitespace
* updates preview modal accessibility
* adds aria labels to popup and tooltip
* removes max-width for zoom
* removes escaped strings, adds keycodes to promises, marks function as async and has the return as the signature of the function
* moves keycoes to class, removes comment
* fixes promise
* testing promise
* testing promise
* promise test
* localizes copy
* uses keycode import
* removes unnecessary arguments
* formating
* refactor constructor into async function called by constructor
* attempts to fix floating promise
* removes floating promise
* moves icons and images to sql folder, removes unused icons
* uses icons already existing in ads
* updates styles
* updates color registry
* updates keycode events
* fixes issues per charles comments
* moves icons to media folder
* updates image file paths
* updates file path
* adds href to extension pack extensions
* fixes links
* fixes issues per alan's comments
* uses exisiting colors from color registry
* updates welcome page to use existing colors from color registry
* updates dark theme
* updates color registry
* updates dark theme
* formats css
* fixes dropdown arrow icon on mac
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* initial changes
* Enable cloud console
* Delete unnecessary code
* error handling
* error handling
* Deal with promises
* Fix externals
* Fix externals for ws
* Cleanup name of terminal
* Update yarn.lock
* Fix yarn.lock
* Fix externals
* Cleanup parts of the code
* Fix more issues
* Fix cloud terminal
* Go back to our client ID
* Fix message
* Respect preferred location
* Fix govt cloud
* Some more messaging
* Enable items on right click
* Some feedback
* Change to status message
Adds the ability for the user to select from two or more linked azure accounts, using an integrated UI dialog, when executing a query that requires a Always Encrypted column master key located in Azure Key Vault.
* Fix the select box issue
* map => forEach
* Fix tests and a product issue
* Maybe another potential fix
* Fix a few more issues
* Change backendValue to value
* localization
* Use Array.isArray
* dashboard improvement - WIP (#8836)
* wip
* wip
* tabgroup
* tab group
* agent views
* clean up
* formats
* feedback
* fix error
* contribute top level server/db dashboard tab (#8868)
* tabbedPanel component (#8861)
* tabbed panel
* tabbed panel
* fix errors
* revert main.ts changes
* use margin
* address comments
* remove orientation property
* content tab group (#8878)
* add databases tab
* use more extensible approach
* remove unnecessary code
* add when expression
* objects tab for database dashboard (#8892)
* fix build errors
* fix build error
* Dashboard toolbar (#9118)
* remove old toolbar with only edit and refresh
* remove tasks widgets from server and databases dashboards
* adding toolbar to dashboardpage and clicking new query works
* restore and new notebook now do something
* add backup to toolbar for database dashboards
* new notebook connects to db
* only show backup and restore for non-azure
* new backup and restore svgs
* clean up
* got toolbar actions to show up from contribution
* some cleanup and add database dashboard toolbar contributions
* don't show all tasks when there should be no tasks
* fix toolbar showing multiple times when switching opening another dashboard from OE
* only show toolbar for home page
* update to new icons - same icons for light and dark theme
* don't show separator if there aren't any actions
* read toolbar actions from tasks-widget
* remove tasks widget from home dashboard page
* show extension's actions in toolbar
* clean up
* more cleaning up
* fix extension actions not always loading the first time
* add configure dashboard
* remove old edit icon css
* change tasks back to original order
* make sure tasks widget is the one being removed
* collapsible tab panel (#9221)
* collapsible vertical tab panel
* fix lint error
* comments batch 1
* pr comments
* update new query icon (#9351)
* Update toolbar actions (#9313)
* remove edit and configure dashboard and add refresh to toolbar for other dashboard pages too
* Add refresh for tabs that have container type with refresh implemented
* change refresh to only refresh the current tab
* remove map for tab to actions
* add back configure dashboard to home toolbar
* check if index is -1 before trying to remove tasks widget from widgets
* Move objects widget back to database home tab (#9432)
* move objects widget back to database home tab and reorder toolbar
* change order of actions back to previous order
* Allow extensions to add actions to home toolbar (#9269)
* add support for extensions to add actions to home toolbar
* fix spacing
* use menu contribution point
* undo previous changes that added dashboardToolbarHomeAction contribution
* remove home from name
* add context key for tab name
* allow actions to also be added to the toolbar of other tabs
* add extension contributed actions even if no tasks-widget
* fix refresh being added twice after merging
* hide the tab list when collapsed (#9529)
* update the order of css selectors (#9606)
* Update dashboard style to be closer to mockups (#9570)
* update style to be closer to mockups
* tab panel styling
* change back tab styling for tabs in a tab contributed by an extension
* change color of borders when theme changes
* set dark theme active tab background to same as OE for now
* update border colors
* move colors to theme file
* fix a few issues (#9690)
* couple fixes
* comments
* small dashboard toolbar fixes (#9695)
* fix backup icon in toolbar
* fix database page toolbar border color
* add back center center in common-icons.css (#9703)
* change padding so bottom border shows again (#9710)
* tab panel fixes (#9724)
* tab panel fixes
* fix package.nls.json
* feedbacks (#9761)
* feedbacks
* remove comments
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
* Handle webmode
* Fix keytar
* Specify that it can be null too.
* Configuraiton option
* Fix callback URL
* Update message, only show if the user is on Linux
* Change message
* Connection management service work
* Fix tests
* Change how accounts are deleted
* Be consistent with names
* feedback
* Fix based on feedback
* Change sqltoolsservice version
* async-await install service; add check for the files after downloading
* remove del
* use the same function for installing service
* fix for unix
* fix ssmin on linux
* fix syntax
* fix script
* fix issue
* Work around coveralls parallel upload issue
* Make dir
* Fix extension paths
* Revert "Fix extension paths" (#9639)
This reverts commit 4598561f858a62b49de5f951de95c099889a85b2.
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
* address untitled editor file name differences; remove feature for updating title for untitled to content
* add tests for new methods
* fix tests
* fix up tests
* remove unncessary await
* revert changes to title for content
* Prevent check in openerService for cmdregistry
* Revert "Prevent check in openerService for cmdregistry"
This reverts commit c40079e6f38dcd379941474accc1a1e3b42f6103.
* Add internal command that calls extension command
* Add comment
* initial commit
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* added file watcher on toc file v1
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* repen book on toc update
* update book in-place
* fix close book
* error handling for closeBook
* PR comments
* addressed comments
* moved the watch block to try ,watch vs watchFile
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* add schema compare to database connection context menu
* don't show dacfx and schema compare in context menus for system dbs
* Remove checks for system db
* undo whitespace change
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* PR comments
* Fix tests
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
* added secondary action
* create book command
* open as untitled
* create toc.yml and update title
* added comments
* throw error if filenames have unsupported chars
* update prompt message
* remove the toLocaleLower
* added await
* moced createbookpath out of the command handler
* removed tolocalelower and added comments
* moved the formatting and file handling code from core to notebook
* fixes for contents with folders
* collapse the code cell
* remove output
* reused existing command to open book
* comment typu and added await
* some optimization
* check for table
* fix table resizing
* Fix for sash crash
* Removed space
* small optimization
* small change in message
* small change
* changed wording
* removed timeout for onResize
* Removed onGridRendered
* fix isCellOnScreen
* small spacing fixes
* removed timeout in gridParentComponent
* fix for indexing
* reduced instances of "self"
* minor fixes for self and this
* Checkpoint
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* PR feedback
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* Fixing linter errors
* Reworked tree
* Fixing missing grandchildren
* Correcting tree URI construction
* Refactoring to isolate tree item responsibilities from data model responsibilities
* project file parsing
* constructing tree from project files rather than filesystem
* Fixing double-initialization
* Changing projectEntry to take enum for file type
* Correct node type for project item
* Parsing datasources.json
* Child nodes for sql data source
* Localizing strings
* Checkpoint
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* PR feedback
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* Fixing linter errors
* Reworked tree
* Fixing missing grandchildren
* Correcting tree URI construction
* Refactoring to isolate tree item responsibilities from data model responsibilities
* project file parsing
* constructing tree from project files rather than filesystem
* Fixing double-initialization
* Changing projectEntry to take enum for file type
* Correct node type for project item
* Parsing datasources.json
* Child nodes for sql data source
* Localizing strings
* missed file in merge
* changed extension method to helper
* cleanup
* Adding docstrings
* remove required from dropdowns
* set required for dropdown
* also set required for editable dropdown
* add back required for db and server dropdowns
* add back to required to databaseLoader
* Even more robust handling of extension tree loading
* Fix initial loading and add new test for CMS
* Fix compile errors
* Fix logic
* Remove debug log statements
* Support for removing hardcode deployment options
* Add missing file
* Generalize errors and make name and id required. Sort dropdowns.
* Fix test
* Capitalize text
* set dirty for editdata to false (prevent backup)
* small wording change
* Temporary fix for issue
* using proper fix
* Used editInputData onDidChangeDirty
* Moved all code to editDataInput
* Implemented fix from notebooks into editdata.
* Fix for unregistering copy service
* Fix in QueryEditorService
* add handling in case of changes made while editing
* Small optimization, removed setdirty in sql check
* moved onDidChangeDirty to EditDataInput
* some text changes
* small fix for consistency in slickColorTheme
* another commmit
* Now shows blank grid, nullcheck in queryhistory
* renamed onAngularLoaded to onComponentLoaded
* removed whitespace
* removed unused dataservice import
* now displays data, need to fix contextmenu actions
* minor changes
* another small commit
* added timeout for context menu
* updated queryhistoryserviceimpl
* removed log
* added commented out contextmenuregistrations
* context menu now shows up need to test
* added plugin registration WIP
* another commit
* yet another commit
* added wip function
* Clean up commit
* more cleaning up
* removed accessor
* renamed instances of parts
* updated
* fixed merge conflicts
* refactored bootstrapparams
* fixed code
* small changes to format
* set editable to true for testing
* added more options
* moved options to separate variable
* added texteditorclass for later
* added rudimentary create editor support
* changed grid.resize.emit to fire
* added formatterfactory
* added tslint disable
* removed debug message
* added more functions from Slickgrid.ts
* added wip handlechanges function
* another change
* added columndefinitions
* Managed to display table using handlechange
* added ability to edit for now
* added changes to table creation
* added setupevents
* added onInit
* fixed sql.xlf
* minor changes
* tidying up
* more cleaning up
* changed console.log messages to debug ones.
* added this.enableEditing
* made changes to getoverridabletexteditor
* fixed opencontextmenu
* added timeout for detectChange
* need to find way to run oncontext asynchronously
* check stuff
* oncontextmenu now no longer constantly refreshes
* added oldDataRows for future use
* add check for datarows
* small changes made
* set enableediting to true
* more changes
* added additional information for handlechanges
* another change
* more changes
* set enableediting to true
* fixed rerender
* added small test mssage for jquery
* text editor is in getOverridableTextEditorClass()
* removed debug messages
* added transparency for input.editor for table.
* need to find out how to add editing for input
* Added grid div to make slickgrid style work
* reinstated selected.
* disabled selectedcellcssclass
* restored selected
* removed selectionmodel due to not being found in the original code
* Added externalSelectionModel for correct results
* removed selectionmodel as its not used.
* WIP work on refreshresultsets
* temporarily bringing back selection model for now
* added getSelectedRanges from slickgrid into Table
* added getselectedranges from slickgrid into table
* small cleanup changes
* removed detectchanges
* removed last of detectchanges
* return of toprownumber
* no need for toprownumber
* removed isColumnLoading
* some small formatting
* fixed null check
* added back todo comment
* Added fix for context menu
* small change
* added missing value to getFormatter in grid panel
* added fix for last row italics
* added fix for null inconsistencies
* Some consolidation
* added new check for null cells
* minor change
* add check for selections (usually undefined)
* removed null check in formatters
* Some changes made
* changed plugins array
* removed todo
* renamed some variables
* deleted html file
* Moved height and width to editData.css
* added box-sizing for slickgridcontainer
* fixed editdatagridpanel css
* added small changes
* More minor changes
* removed params
* renamed refreshResultsets to refreshDatasets
* removed the stylesheet.remove lines
* added fix for null
* removed tables
* removed spaces in refreshGrid
* More minor changes
* optimization and formatting
* removal of unnecessary lines
* replaced firstRender in some parts with firstLoad
* Added timeout fix
* minor changes
* Still testing
* cleanup
* restored 200 timeout
* added styling changes for editdata
* removed angular2-slickgrid and added styling
* Small formatting changes to editDataGridPanel
* consolidation
* Fixes for broken notebook experience
* add sql carbon edit
* sql carbon edit
* add another sql carbon edit for import
* Set untitledResource instead of no resource
* Implemented match case and whole wrd
* removed unused ref
* renamed test method
* escape \
* refactored search
* added more tests
* updated tests appying match case and whole word to spcl characters
* regex update
* spcl to special
* non-capturing group added to the regex
* test
* Fix new editor windows to open with global connection
* Fix test
* Fix tests
* Move logic to queryInputFactory
* Remove unused function
* Remove unneeded check
* Add tests
* Added fix for italics for last row
* Added null handling in formatters
* Fixed issue with null not italicizing on grid
* small formatting fix
* some consolidation
* removed null check
* minor change
* removed null check in formatters
* updates to existing book tests
* notebookFindModal tests
* remove commented code
* undo book test changes
* undo book test changes
* resolve the find array
* additional tests
* add test for schema compare include exclude
* combine a few checks
* small fixes
* add testData folder to whtiespace check exclusion list
* addressing comments
* fix testData path in gulpfile.hygiene.js
* move change up a couple lines
* Adds rule for .icon extensions
* revert
* Fixed issue and formatted for consistency
* reverted change for regular menuentryaction
* changed id back to old name
* Removed comment
* removed space
This change adds to handlers to unexpected promise rejection scenarios.
This PR fixes#8640
* add handlers for promise rejections
* Displaying all tools load errors
* Update toolBase.ts - setting errorMessage to be displayed in the additional information field
* disable the select button when tools not discovered
* PR fixes
* Adding mock contents for tree
* added open sqlproj dialog
* reading files from directory
* Added directory traversal
* Adding tree sorting by folder vs file and label
* Improved auto-unfolding of tree based on node type
* replacing fs with fs.promise alias
* added activation event for when workspace contains sqlproj files
* Returning after displaying error
* initial commit
* get notebook content
* skeleton for find in notebookModel
* add search function and keyboard shortcut
* add command for hiding find widget
* started on search logic
* continue search logic
* continue search logic
* add findcountchange listener
* notebook find position
* added css class
* hide find widget
* focus find input
* search for multiple occurrences in one line
* start notebook find decorations
* start adding decorations to notebook model
* added editor_model_defaults
* added cursor position
* merged master and resolved husky erros
* initial changes added to Lucyls base implementation
* pass NotebbokRange instead of Range to decorations
* changes after merging master
* temp changes for testing
* style updates from vscode merge
* implemented the empty methods and added supporting functionality from textModel
* just a little error checking
* It gets more and more yellow
* making highlight work between code cells
* highlight only word
* remove highlight on close and maintain the position
* cleanup of unused references
* clean up
* find between code cells refactored
* highlight markdown line and scroll to it
* find index fix
* find index fix
* code clean up
* remove commented code
* tslint fix for: Cannot use global 'NodeJS'
* linting rule fixes
* deltaDecoration base implementation on the base class
* moced class defnitions from interface fikle
* updated action names
* DOM.addClass instead of overwriting
* resooved conflicts
* moved 'find' code away from notebookmodel to sep class
* moved find realted code to seperate folder
* created notebookFindModel
* clean up
* highlight color changes
* spacing and typo fixes
* highlight correct element for nested elements
* do not iterate through paragraphs and li
* find accross notebooks
* keep track of index
* clear decorations on close
* floating promises
* maintain search context
Co-authored-by: Lucy Zhang <lucyzhang929@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
We noticed that if displayName is undefined this method would return the first auth type it found as getAuthTypeDisplayName() would return undefined.
If the displayName is undefined, we would not have a matchingTYpe and it should be undefined.
* add remote build to the pipeline
* add a separte compile step
* fix darwin build
* add linux container and fix docker creation
* fix distro
* remove system install and add xvfb start
* distro
* add logic to only run tests on hosted machine
* fix yml
* fix yml
* add linux docker container
* fix docker file
* fixdocker
* fix darwin
* fix linux build
* add cache salt to npm cache
* intentially ignore kerberos binaries
* disable docker for now
* remove vsix from win32
* fix linxu and win32
* fix linux and win32
* fix linux and win32
* fix linux
* maybe fix win32
* fix linux
* fix linux image; disable server package for noe
* fix minimatch for win32 test
* fix linux build
* add back in docker
* fix test
* use tmp directory insteado workspace
* change name of docker image
* try a differnt folder
* fix download
* add a git clean step
* bump cache
* fix issues with builidng
* readd windows build, revert signing changes
* simplify win32 server packaage
* some more optimizations
* use decompress task
* add back in install for windows test
* fix linux build
* add integration test to bat file
* make platform the same
* add copy extension to windows test
* revert tests back
* fix vsix drop aquasition
* inital changes
* fix download
* fix dependent on for release
* just downlaod everything which makes it easier
* setup pipeline artifacts
* more clean up
* fix linux
* add logic to install extensions for integration tests
* fix extension install
* fix build failures
* fix some issues
* fix darwin drop
* change linux build copy to js
* fix darwin archive
* fix copy artifacts and use it for windows
* use for darinw
* fix darwin
* ad dep on linux
* fix win32
* fix darwin
* fix copy artifacts
* mkdir p darwin
* fix copy
* add error handler
* add more binaries
* add more binaries
* fix archive path on linux
* add more options to integration extension install
* add more binaries
* add verbose to installer copy
* fix ip rate issues
* fix bat file for including extensions
* move echo
* add windows test condition
* use powershell cmdlet rather than cp
* remove verbose
* remove compiling of extensions
* fix pipelines
* update docker location
* fix copy item
* fix signing on win32
* fix locations
* move back to using cp
* ensure the docker folder exists
* test a createdrop script on darwin
* wip
* fix copy
* add drop for linux
* fix builds
* fix drop
* fix docker on linx
* fix darwin
* lets try this again
* fix linux drop
* i guess try the copy files task
* add create drop for win32
* ensure windows drop location exists
* fix extension install
* just use mkdir
* add better logic for installing extensions
* ignore errors?
* try force
* testing
* ok this should work
* use production cli
* fix liveshare vscodeignore
* fix integration test script
* revert changes to integration tests to fix them
* try newitem
* remove exec
* explicitly clear last exit code
* fix test build
* revert publish scripts
* add version json
* fix tests
* add back sources creation
* this is stupid
* fix clean positioning
* add version information to drop
* fix locations of artifacts in publush scripts
* Update schema compare extension to support SQL Login
* Update schema compare extension to support SQL Login
* Fixed the scenario where scmp file doesn't open as expected- cleaning up previous connect information and setting appropriate button states if either source or target info is missing. Also updated function getEndpointName to return empty string if serverName and databaseName aren't present, instead of partial information.
* Addressed comments. Fixed var names and moved repeatitive code in a helper function.
* saving intermediate work - to merge master
* remove inadvertent change
* Remove Pip3 installation from all tools
* working version
* making some small fixes
* add back accidently removed file
* Update resourceTypePickerDialog.ts
* Removing redundant trailing ","
* Remove commented dead code
* fix casing of nls string
* remove inadvertent change
* change installation locations from field to properties so that they are constructed at run time'
* Add changes for flavor selection
* Use getDefaultProviderId method
* Update default engine user setting description
* Add back check for codeEditor
* Add test for multiple providers
* Removing extra merge line
* Add an attribute to ConnectionProviderProperties for language flavor
Adding a boolean property to ConnectionProviderProperties for providers that are language flavors. When it is set to true, the provider will be part of drop down for changing SQL language flavor.
* Update variable name
* Put logic for removing CMS at one place and remove flag for flavor provider
* Using keys instead of entries
Using Object.keys instead of entries as doing [0] can be error prone if no provider matches.
* Adding logic to check from params
* Updating variable names
* Rename dedup map
* Fix action
* Refactoring Manage Packages dialog so that other extensions can contribute to it by registering package mange providers for different location and package type
* only sign windows once
* more scoping and add copy steps
* remove reh
* wip
* use min everywhere
* fix zip file name
* fix location of build file
* fix version.json production
* remove unneeded vars
* fix archive drop
* give mac more time
* fix location of windows archive
* fix system location and add comments
* fix installer signing
* remove unnecessary build step
* reduce the sign count
* fix dlls
* remove missing dlls
* Changes
* Work in progress
* Authenticate with azure
* enbable national clouds and initialization
* Add support for tenants
* Finish up account work
* Finish up azure auth
* Don't allow prompt if we're not initialized
* Shut down server
* Remove trailing comma
* encode uri component
* ignore errors
* Address comments on github
* Fix issues and disable feature without env var
* Don't encode the nonce
* Only use env variables to disable the new sign in
* Show more user friendly messages to users
* Initial wip
* wip
* Working implementation
* Make widths a bit nicer and remove sqlops addition
* Add sqlops back in
* Fix timing issue with tables
* Undo change to sql.bat and remove loading component when done
* First attempt to add Azure MFA login for PostgreSQL
* Finish merge with master
* Fix auth type default selection
* Add AzureMFAAndUser auth type for Orcas
* Fix formatting
* Update change log
* Incorporate some review comments
* Missed an occurrence of AzureResource
* Try to move all changes out of azdata.d.ts and sqlops.d.ts
* Concrete implementation of ConnectionProfile in azdata no longer has azureAccount
* Use enum names instead of numbers in config files
* don't package every time, only on linux
* fix build
* fix build
* fix floating promises
* add comment
* fix order of steps
* clean up packaging of the extensions
* minor cleanup
* make code easier to read and add more logging
* do some rename
* maybe?
* re order the code
* fix output path not existing
* update how we handle editors
* small edit
* handle changing languages
* implement generic language association
* implement notebook serializers
* fix tests
* formatting
* update how we handle editors
* small edit
* handle changing languages
* implement generic language association
* implement notebook serializers
* fix tests
* formatting
* fix broken
* fix compile
* fix tests
* add back in removed note book contributions
* fix layering
* fix compile errors
* fix workbench
* fix hanging promises
* idk why these changed
* fix change
* add comments to language change code
* fix a few bugs
* add query plan association
* Update exclude/include message in SchemaCompare
* Segregated the messages as discussed
* Updated message with a comma and merged two If statements in one
* remove steps that delete code sign.md
* update sign tool
* fix config
* wip
* add continue on error for md delete
* try this
* copy exactly what was there
* remove final del
* saving untested changes
* Fix for issue #8341
* Fix tab navigation within modal dialog (#8326)
* Fix tab navigation within modal dialog
* Add import
* Fix spelling
* Change to just add/remove items from DOM as necessary
* Fix a couple a11y issues with manage access (#8386)
* Fix a couple a11y issues with manage access
* Fix strict null check
* Fix another strict null check
* Update js file with monaco -> ads workbench (#8398)
* Set encoding to true (Bug fix for flavor) (#8395)
For offline scripts it shows the flavor as “Choose SQL Language”, this is because in flavorStatus.ts line 150 when we compare (uri === currentUri), the value of current Uri is "file:///d%3A/GitHub/PGExtension/TestDatabase/1ae730a9.sql" whereas the value for uri is "file:///d:/GitHub/PGExtension/TestDatabase/1ae730a9.sql" which ends up returning label ‘Choose SQL Language’.
In queryInput.ts we set public get uri(): string { return this.getResource().toString(true); }
This is the variable that we use in doChangeLanguageFlavor. And as we compare this with getEditorUri() later in flavorStatus.ts, it does not match. So enabling encoding here as well to get the encoded string in both the cases.
* bump handlebars in extensions (#8411)
* remove active css class on mouse leave (#8410)
* Bump SqlToolsService (#8404)
* Remove open notebook entry points (#8393)
* Add aria role and selected properties (#8405)
* Add aria role and selected properties
* Add img role fix
* Add title to text
* Notebooks cleanup: Remove old out of proc markdown option (#8394)
* Remove old out of proc markdown option
* Revert change to stats.js
* remove debug console.logs
* PR feedback
* escape characters only on hyperlinks
* removed extra line
* added tests and changes to accomodate tests
* updates to test
* added comments
* use path.join
* format doc build error
* added comments
* Couple of a11y fixes for BDC Dashboard
* Moving ariaRole into separate PR
* Remove missed ariaRole tag
* Switch to just using notification dialog
* add back in blank line
For offline scripts it shows the flavor as “Choose SQL Language”, this is because in flavorStatus.ts line 150 when we compare (uri === currentUri), the value of current Uri is "file:///d%3A/GitHub/PGExtension/TestDatabase/1ae730a9.sql" whereas the value for uri is "file:///d:/GitHub/PGExtension/TestDatabase/1ae730a9.sql" which ends up returning label ‘Choose SQL Language’.
In queryInput.ts we set public get uri(): string { return this.getResource().toString(true); }
This is the variable that we use in doChangeLanguageFlavor. And as we compare this with getEditorUri() later in flavorStatus.ts, it does not match. So enabling encoding here as well to get the encoded string in both the cases.
* code complete
* minor fixes from self-review
* installation searchaPaths and display logs fixes
* revert inadvertent change
* fixing installaton roott for debian and mac
* Chaning from getos to linux-release-info with sync api usage for figuring out os distribution
* adding file missed in previous commit
* fixing indvertent compile error that creeped in
* fix default install root for azli
* saving untested work
* fixes for #8165 and #8167
* minor fixes
* fix for #8260
* minor quoting fixes
* fix for #8264
* minor fixes
* minor fixes.
* move tools constants to their own files
* remove execution cell results from notebooks.
* remove extraneous changes
* move ensuring of StoragePath to platformservice
* remove fix for #8264 pending pm input
* update packages
* remove fs
* fix more deps
* test adding governance to ci
* ignore samples for cacheing
* fix save cache too
* bump more packages
* attempt to fix slickgrid
* add more deps
* use slickgrid version
* bump https-proxy
* bump more packages.
* fix service-downloader
* remove typings
* fix compile
* update more packages
* add vscode back to the extensions that need it for testing
* add fail on critical
* regrab proxy agent
* lock more deps
* replace final high warning
* revert service downloader changes
* remove the deps on jquery ui and event drag
* added try catch aroud the json parse and bypassing the err by logging to console
* updated error message with package info
* updates to address PR comments
* added package info and refactored the err logging
* backslash update
* refactored error method and added try for the entire method
* Some promise cleanup
* Handle more promise issues
* Remove changes that aren't needed anymore
* Use log service
* another one
* Be more explicit
* Some more promises cleaned up
* Handle promises here too
* Strings for errors
* Some more cleanup
* Remove unused imports
* Fix relative images on notebook markdown pc
* PR feedback around replace ordering
* update databaseName when it's set to master
* usinng query as example
* don't uncheck difference if unsuccessful
* changes after rebasing to get schema compare fix
* First cut of column checkbox checking reactive to include opteration
* handle blocking dependencies and affected dependencies
* Changing the checked property of table to be list
* Addressing comments
* add map to keep row number of diff entries
* remove findDifferenceRow() since it isn't needed anymore
* fix scrolling to the top when checking/unchecking and add info message
* change checked to updateCells
* improve warning cannot include/exclude message
* Azure: add PostgresSQL support and refactor to use resource graph
- Refactored to use @azure/arm-resourcegraph for all queries
- Refactored database lookup to do just 2 queries
(all servers, all DBS) instead of waiting serially on 1 query per RG
- Added Azure Database for PostgresSQL Servers support in the tree
- Removed use of older azure APIs in preference to ones compatible with resource graph
- Note: Had to use v1.0 of new subscriptions package because resourcegraph is 2month out of date vs all other packages
* checking temp work to move to another branch
* removing freeTds
* dependencies Messages and No curl on Win32
* elipsis instead of ...
* add min version check post install and pr fixes
* removing unnecessary comment
* removing old TODO comment
* fix text messages
* add github toke nto electron download (#8047)
* remove hardcode of kubectl version for download
* add hygiene task to test file length
* check for the filename length instead of the path
* formatted the error message
* added check for entire path including directories
* error messaged fixed
* check relative length for 150 as agreed upon
* error message to include 150
* added file length filter
* check the file length seperately
* ffsdfsdf
* remove the test file
* move it to last
* restore the filtered files for further checks
* removed comment
* test
* test
* remove the test file
* test commit
* remove the test file
* restore fileLengthFilter
* test
* remove the testfile
* revert
* xfgdgdfg
* huh
* test file
* revert.
* add all to the filter
* pass install paths to notebooks
* onComplete
* discover and publish actual installation Path
* pass the path to notebook
* minor fixes needed post merge of code from remote
* fix some errors
* remove unused variable
* try loc with single file model
* adding filter and languages
* add links in langpack json
* changing variable name and limiting the list to only tested extensions
* builtinExtension-insiders to builtinExtension
* maintain both insiders and stable.
* builtinExtension.js is for build time and skipping the check for dev.
* check quality and pick insider vs stable json
- Add SQL Instances folder and support using existing SQLClient API
- Sort subscriptions in tree and quickpick for easier search
- Sort all resources (Databases, Servers, Instances) alphabetically too
Not in this PR:
- Will experiment with Graph API for faster perf & easier addition of other Azure resources such as PostgreSQL
Consolidated most logic into a base class and common resource request pattern.
Reduces cost to add new providers, which will help for SQL Managed Instance support
* Add context awareness to troubleshoot button on dashboard
* Remove tests for now
* Undo yarn.lock changes
* Correct yarn.lock version
* Lower case service check
* Use separate icons for non-stable builds
* Fix file name
* Switch icon
* Updated icons
* Switch to copy of code.ico until issue is fixed
* Fix icon
* remove
* add
* Fix file renaming
* Fix a couple naming issues
* Move iss changes to build file
* wip
* make connection work with strict-nulls
* change comments
* fix tests; remove unneeded type forcing
* address feedback
* adjust the logic of query editor
* clean up typing
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
- acounts view
- new tab view in dashboard
- many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.
Fixes#7827
* Open cluster dashboard
* Remove old translated strings and update var name
* Add exported auth type
* Add newline
* Add connection retry for dashboard
* Change getMainSectionComponent to return multiple (no undefined)
* Move try/catch to withConnectRetry
* Add connection retry for dashboard
* Change getMainSectionComponent to return multiple (no undefined)
* Move try/catch to withConnectRetry
* add install tools button (#7454)
* add install tools button
* address comments
* remove description for install tools hint message
* First working version of AutoDeployment of tools (#7647)
First working version of AutoDeployment of tools.
This pull request adds feature to install the tools needed for doing BDC/TINA deployments.
This has been tested so far only on win32 and testing on other platforms is in progress.
* removing TODO and redundant code
* Not localizing azuredatastudio product name
* convert methods returning Promises to async-await
* changing from null to undefined
* Localize all the command labels
* using existing sudo-prompt typings
* progres/error status in ModalDialogue && PR fixes
* review feedback to change warning to information
* revert settings.json changes
* fix resource-Deployment Extension Unit Test
* ensuring platform service's working directory
* incorporate review feedback
* review feedback
* addressing PR feedback
* PR fixes
* PR Feedback
* remove debug logs
* disable UI deployment containers when installing
* addding data type to stdout/stderr messaging
* remove commented code
* revert accidental change
* addressing review feedback
* fix failed install with zero exit code
* fixing bug due to typo
* fixes for linux
* Misc fixes during mac testing
* PR fixes
* QueryExecutionOptions change
* add config points
* Change api type used
* Revert "QueryExecutionOptions change"
This reverts commit 7adc3b032b5e4bc92234d337f0a145f0963c2d34.
Let's not change the azdata file.
* Change the signature of this api
* Change the event
* Change SqlCMD to use the API properly
* Add type
* Change type to interface - handle existing files
* Remove unused import
* Delete useless code
* Remove unnecessary code
* Fix the interface
* remove whitespace
* Check if light and dark are URI
* Added a map in the extensionsRegistry to check
* Moved resolve check to connectionProviderExtension
* removed resolvedUsers from extensionsRegistry.ts
* removed unused imports and spaces
* Formatting for import
* Simplified resolver check.
* ToString is sufficient to avoid any complications
* Small formatting fix
* removed extra comment
* BDC Dashboard fixes
* Make refresh indicate when refresh is happening
* Fix refresh button to properly reset even if error occurs. Refactor onclick into own method.
* Undo refresh button rotation per design feedback
* Added notification for unsaved file in scheduling
* Removed logging message in line 216
* Changed regex for all 3 platforms (forbid '/')
* Untitled file prompts to save in mainController
* removed spaces and changed save message
* Mount delete, refresh and default to new folder for mount create
- Delete mount action added
- Refresh mount action added
- Added "mymount" to theend of existing path so that we don't use already-existing HDFS folder. The call fails unless folder doesn't exist
* Add support for default permissions on directories
(cherry picked from commit 4e81cceba142c6763c3447b4d2965cd75764f8f9)
* Remove unneeded import
(cherry picked from commit ffe5f357357e75e9290966e89768c699df2e1311)
* Add recursive apply and clean up webhdfs
(cherry picked from commit ae76df14f99e599df1cdfcc74ee22d3822f11a59)
* Final set of changes
* Undo changes to azdata/sqlops and few minor fixes
* Remove cast to fix build error
* Hide defaults checkbox for files and switch checkbox order
Implemented in this PR
- New base dialog for anything needing to work with the controller. This is important since going from SQL -> Controller we "should" have the right permissions but aren't guaranteed
- Support for Mount HDFS via a dialog. Includes basic polling for success/failure, but have to give up after 2.5min as mounting could take hours. By then it's assumed to be successful since server-side has 2min timeout built in.
Not implemented in this PR
- Script as Notebook button. This should convert the inputs to a set of cells in a notebook so users can run things themselves
- Updates based on PM / UX reviews. I think we'll need a round of feedback before completing this work.
* isolated problem involving user friendly names
* Fix to handle horizontalBar
* Working rough version, need to implement data structure to store alternative names later
* consolidated checks into its own static method, data structure still highly recommended to implement
* Version with hashMap implemented
* Moved check for alternative names into chartView
* removed parseOption
* removed space in selectbox
* removed unused import
* removed unused import and spaces
* Fixed formatting
* Added new comment and modified changeToAltNames
* Localization has been added to the Hash
* flxed small formatting issue
* fixed double quotes for nls.localize
* isolated problem involving user friendly names
* Fix to handle horizontalBar
* Working rough version, need to implement data structure to store alternative names later
* consolidated checks into its own static method, data structure still highly recommended to implement
* Version with hashMap implemented
* Add display property to ModelView components
* Update DisplayType property in sqlops as well
* More updates to HDFS Manage Access dialog
* More updates to HDFS Manage Access dialog
* First go at it
* undo unnecessary change to copy api
* Revert "undo unnecessary change to copy api"
This reverts commit f95f7f7a42277586f4d4d0eb7b0733c11853b413.
* Revert "First go at it"
This reverts commit 410c0d3c61b7c7cae3a2469a2672f67fe3b745b6.
* Actual super simple fix
This is the 1st step to supporting HDFS Tiering
Changes:
Add new mounted folder icon. Will have separate commit for file icon
Disable delete/mkdir/upload for mounted files and folders
Disable delete for root HDFS folder (this was added in error)
* Open latest ADS release notes in browser
* Only show release notes for stable builds
* Update config description text
* Have release notes notification prompt user before opening
* Remove unneeded import
* Add width and height properties to checkbox component
* Initial work on manage access dialog
* Add missed change
* Add comments and clean up
* Initial work on manage access dialog
* Add missed change
* Add comments and clean up
* Add return type
* Address comments and use apiWrapper
* Fix compile error
- Use token API to get auth token before using other endpoints. Note this needs server updates before it'll work as expected (will only checkin after verifying this)
- Add auth option in controller UI and plumb through connection save, load, and uses of the controller API
Because the swagger spec is split in 2 created new file for the 2nd swagger spec including token auth endpoints. These come from a running cluster and instructions were updated to reflect this.
New UI Changes:
- Added authentication type field with "Basic" and "Windows Authentication" as the options
- Moved error notifications to the dialog instead of separate notification window. That's the recommended pattern
- Username / password aren't required for Windows Authentication. I couldn't find a way to change required status in form container on switching from Windows => Basic Auth so have error show on clicking OK.
- Controller URL should use ":" not "," for IP:Port
* fall back to the old text component behavior...
if no required indicator and description is needed, fall back to the old text component behavior.
* Update text.component.ts
indention
* Fix don't like; unclear if grammar necessssary too
* Cleanup and sanity check
* Cleanup and sanity check
* Add test
* Call onBeforeAttached for 3 types of editor models
* add saved/untitled views to the books viewlet and provide save option to untitled
* addressed comments
* fixes after merge
* await on async methods
* reverted back
* await on promise
* added localize for books view names
* initial commit
* missed a file change
* changes to make the merges work part1
* fixes after merges 2
* getChildren to get all books
* chnages to address comments
* fsPromises instead of fs.readSync
* merged master
* replaced deprecated fs.exists async call with pathExists
* renamed method
* Have mssql activate wait for service to be ready before returning
* Change to using deferred promise
* Await on server ready
* Finish removing old code
* More cleanup
* Go back to exposed promise API
* Make property readonly
* Add missing file
* Add back in deleted stuff
* Go back to awaiting
* replaced fs with IFileService
* work around for URI with relative paths
* updates to comments
* renamed existsSync to exists
* await on promise inside non-async method
* .then change
* await async calls
* removed the old code
* include everthing in .then
* remove file exists check
* added _ for consistency
* use path.abosult method
* fixed the cleanIrl calls back and path.sep change
* reverted path.sep for now
* Add abillity to open to specific item within a Jupyter book
* Move helper method into BookTreeItem class
* Fix default URL path
* Add typing to Jupyter book code
* Update comment and typings
* Fix compile error and cleanup
* Better cell selection
* Explicit return type and undefined assignment
* More complex copy/paste
* Get TS to be less mad at me
* Remove EoL
* Fail safe if statement
* strict null check
* Initial commit
* Fix up QueryEventType
* Making query history visible in view and open query command (#6479)
* Add QueryInfo to query event events
* Pull actual query text/connection info for displaying
* cons and expand (#6489)
* Making query history visible in view and open query command
* expand and icons
* Failure icon enabled (#6491)
* Making query history visible in view and open query command
* expand and icons
* failure icon enabled
* Minor cleanup
* Open query with connection and add run query (#6496)
* Add initial query-history extension
* Fix issues caused by master merge, cleanup and add query-history extension (#6567)
* Open query with connection and add run query
* Fix issues caused by latest master merges, cleanup and add query-history extension
* Remove child nodes (#6568)
* Open query with connection and add run query
* Fix issues caused by latest master merges, cleanup and add query-history extension
* Remove child node expansion
* Layering movement and add delete action (#6574)
* Open query with connection and add run query
* Fix issues caused by latest master merges, cleanup and add query-history extension
* Remove child node expansion
* Some layering movement and add delete action
* Move query tracking into service (#6578)
* Open query with connection and add run query
* Fix issues caused by latest master merges, cleanup and add query-history extension
* Remove child node expansion
* Some layering movement and add delete action
* Move query history tracking into service
* Add comment
* Fix actions
* Remove unnecessary type
* cleanup
* Remove unused section of README
* Fix merge issues and address PR comments
* Fix compile and tslint errors
* Change startup function name
* Focus piping for extension buttons
* Focus the done button when entering the summary page for DacFx wizard
* Adding internal value resets for extension-side button model.
* Correcting remark string
* added agent notebooks, notebook history view and view materialized notebook button
* Got a basic UI running for viewing notebook history
* made some changes to make UI look good
* Added new notebook dialog
* Added new notebook Dialog
* Added create notebook dialog
* Added edit and delete notebook job
* Added some notebook history features
* Added new notebook job icons, fixed a minor bug
in openmaterializednotebookAPI and added fixed the
schedule Picker API.
* Fixed Bugs in Notebook Grid expansion
* Fixed Notebook table highlighting and
grid generation is done using code.
* fixed some UI bugs
* Added changes to reflect sqltoolservice api
* Fixed some localize keys
* Made changes in the PR and added
ability to open Template Notebooks from
notebook history view.
* Added pin and renaming to notebook history
* made some library calls async
* fixed an import bug caused by merging from master
* Validation in NotebookJobDialog
* Added entry points for scheduling notebooks
on file explorer and notebook editor
* Handled no active connections and
a small bug in collapsing grid
* fix a bug in scheduling notebook from explorer
and toolbar
* setting up agent providers from connection now
* changed modals
* Reupload edited template
* Add dialog info, solved an edit bug and localized
UI strings.
* Bug fixes in UI, notebook renaming and
editing template on fly.
* fixed a bug that failed editing notebook jobs from notebook jobs table
* Fixed a cyclic dependency, made strings const and
some other changes in the PR
* Made some cyclic dependency and some fixes from PR
* made some changes mentioned in the PR
* Changed storage database health text
* Changed the sqltoolservice version to the point to the latest build.
* Added open Latest notebook notebook run to notebooks view context menu
* Fixed a small compilation error
* fixed a spelling mistake in function name
* made changes mentioned in the PR added open Notebook Functionality to charts
* Changed some context menues strings and order
* made some changes from the PR and fixed an API call
* made some changes mentioned in the PR
* Changed sqltoolsservice version to point to the latest build
* added agent notebooks, notebook history view and view materialized notebook button
* Got a basic UI running for viewing notebook history
* made some changes to make UI look good
* Added new notebook dialog
* Added new notebook Dialog
* Added create notebook dialog
* Added edit and delete notebook job
* Added some notebook history features
* Added new notebook job icons, fixed a minor bug
in openmaterializednotebookAPI and added fixed the
schedule Picker API.
* Fixed Bugs in Notebook Grid expansion
* Fixed Notebook table highlighting and
grid generation is done using code.
* fixed some UI bugs
* Added changes to reflect sqltoolservice api
* Fixed some localize keys
* Made changes in the PR and added
ability to open Template Notebooks from
notebook history view.
* Added pin and renaming to notebook history
* made some library calls async
* fixed an import bug caused by merging from master
* Validation in NotebookJobDialog
* Added entry points for scheduling notebooks
on file explorer and notebook editor
* Handled no active connections and
a small bug in collapsing grid
* fix a bug in scheduling notebook from explorer
and toolbar
* setting up agent providers from connection now
* changed modals
* Reupload edited template
* Add dialog info, solved an edit bug and localized
UI strings.
* Bug fixes in UI, notebook renaming and
editing template on fly.
* fixed a bug that failed editing notebook jobs from notebook jobs table
* Fixed a cyclic dependency, made strings const and
some other changes in the PR
* Made some cyclic dependency and some fixes from PR
* made some changes mentioned in the PR
* Changed storage database health text
* Changed the sqltoolservice version to the point to the latest build.
- This already handles commandline which needs same logic
- Includes visual confirmation to avoid connecting by default to untrusted server
- If successful will connect & expand in Connections tree
- If failed, will show dialog with all presets
- Shows New Query by default, can add option for New Notebook instead in the future
Connection protocol is `azuredatastudio://connect?server=mysqldw.database.windows.net&database=db1&user=myusername&aad=true`
Same args as commandline, namely:
- server
- database
- user
- aad
- integrated
I have also added `provider` arg to allow non-MSSQL providers. In the future, we should update logic to prompt for install of correct extension for that provider if it's missing.
* Loading components now announce themselves. Likely need way to disable.
* Adding focus elements to table for screen-reading after component is loaded in
* Adding piping for aria roles on tables
* Alerting on completion of deploy plan summary
* Removing extra ariaLive property
* Make sql master link clickable that opens connection
* Improve comments and fix break
* Show error message if failed to connect and clear username
* Make service names clickable tab links
* Remove key handler event again
* Make sql master link clickable that opens connection
* Improve comments and fix break
* Show error message if failed to connect and clear username
* Remove key handler - text doesn't even get focus currently so this isn't doing anything
* Change cursor over tabs to be hand (pointer)
* Change hyperlink color
* Hook up CSSStyles to be updated from extension side and make BDC dashboard tabs change style when selected
* Remove unused file
* Add back in call to updateStyles
* Fix typos
* edit perf
* Save multiline source in notebooks
* More merges
* Single, multi line works needs work
* Works with single + multi and recomputes active
* Actual perf improvements this time
* code cleanup
* Calculating output position on the fly
* Hmm can we use brackets to make this simpler?
* monday progress
* output working. lots of improvements.
* First tests working
* 10 tests now, fixed bugs
* Cleanup, add output test
* More fixes
* Need to still fix execution count bug
* Tests pass, added comments
* Cleanup
* PR comments round 1
* Deal with merge issues from master, layering
* Deleting duplicate file
* More PR Comments
* PR Comments
* added tests for getBooks and getTableOfContents
* update tests for new getTableOfContents method
* wait for all toc.yml to be found
* add event to signal all toc.yml files read
* add workspae folder parameter back
* remove toc filter
* added timeout logic
* added test for invalid toc.yml
* added tests for invalid toc.yml file format
* added tests for error handling
* update uuid package
* increase timeout time
* change workspacefolder to string
* initial commit
* fix: added initialize method to fix the previous/next links rendering
* added checks
* open first markdown/ipynb in the book ans expand the view
* added launch book from command pallete, removed the pick folder and save option added launching the first notebook/markdown
* moved the open book command pallet action from mssql to notebooks
* open as untitled to true
* opening markdown files issue fix
* removed opening as untitled files
* open ipynb files as untitled and changes for previous&next links to work
* add books as seperate viewlet
* localize double quote issues and renamed treeCollapsibleState
* renames and added logic to conditionally show Preview command
* moved registerCommands from widget to extension contribution
* isEditorUntitled check
* async comment updates
* formatting issues.
* promisfying the async calls
* moved existsAsync to top
* Changes to enable retry for Service downloader.
* removing 'enabled' flag from the "retry" config.
* use 0.1.7 release of service-downloader which enables the retry feature.
* working; new query and scripting
* working; removing manage from menus and combining data explorer contributions
* consolidate dashboard contributions; move manage action to dashboard contributions; make groupings the same
* fix notebook actions not firing
* fix notebook actions
* notebooks working
* move backup and restore entry points into their own file; move explorerwidget contribution into their respective files
* fix tests
* move extension actions to their own file
* fix tests
* change tests
Tables in Extensions need a way to override tab so that tabbing in table cells is not possible and tabbing takes control out of Table - this is the accessibility requirement for tables not having actionable cells. Keeping it as a switch so that we can continue having older behavior where needed.
* Fix HDFS AD write support + improve error logging
- Implemented write stream piping correctly so data is paused until we're ready to push to server
- During testing, noted that things weren't awaited correctly. Tweaked some functions to improve this
* Use correct content type
* Server selection with proper awaits
* Handle keyboard clicks immedietely.
* Clean up the event a little more
* Eat the event if its not mouse or keyboard
* working; new query and scripting
* working; removing manage from menus and combining data explorer contributions
* consolidate dashboard contributions; move manage action to dashboard contributions; make groupings the same
* fix notebook actions
* fix tests
* Fix HDFS with AD auth for browse, read
- HDFS now fully supports expanding nodes for all levels, including using cookie for auth
- HDFS now support reading files from HDFS
- HDFS write file is broken and will be fixed (either in PR update or separate PR)
- Removed hack to use gateway-0 instead of actual DNS name now these are supported. Needed for testing
* Fix Jupyter error using new DMV with endpoints
* Adds button extension for explicitly setting aria-label, in case the label is not screen-reader friendly
* Explicitly set aria-label for ellipsis buttons in SchemaCompare
* Changing localize call to double-quotes
* Removes unused getter for ariaLabel
* Adding aria-rowcounts for long scrollable tables
* fixing simple name changes
* Fixing button color and tabbing on tabs
* removing some extra lines of code
* Adding some null checks
* Updating as per PR comments
* added test for sections and navigation
* update variable names
* latest from master
* add await for creating file methods
* wait for all toc.yml to be found
* add event to signal all toc.yml files read
* add workspae folder parameter back
* remove toc filter
* use onReadAllTOCFIles event
* added timeout logic for getting toc.yml files
* latest from master
* new method for comparing book items
* Adds button extension for explicitly setting aria-label, in case the label is not screen-reader friendly
* Explicitly set aria-label for ellipsis buttons in SchemaCompare
* Changing localize call to double-quotes
* Removes unused getter for ariaLabel
Partially working AD support for BDCs with some known issues
- Plumbed through kerberos support to Notebooks.
- Using "gateway-0" for service temporarily as service endpoints API doesn't yet return correct DNS name. Will update in separate PR once available
- Plumbed kerberos auth to HDFS, Spark. Only partially working as we use same token on each call
- Will fix in separate PR, as this requires a refactor of WebHDFS library. Will need to either get new token every time or set a cookie, both of which require refactors
- Fixed error when Data Service node expansion failed and blocked all OE expansion
- Support for SqlToolsService change to use new cluster endpoints DMV
- Updated API to add new endpoints field to replace IP + port
- Added logic to handle case where endpoints for Yarn, Grafana etc. are in the list
- Sort list and use expected new localized strings
- Updated SqlToolsService to include support for new DMV
- Add "gateway-0" handling in Jupyter session as workaround for lack of domain names in endpoints list
Updated existing serialization code so it actually supports serialization. Still needs work to replace the saveAs function when a QueryProvider doesn't support save as, but want to handle in separate PR.
Removed separate MainThread/ExtHostSerializationProvider code as the DataProtocol code is the right place to put this code
Plumbed support through the gridOutputComponent to use the new serialize method in the serialization provider
Refactored the resultSerializer so majority of code can be shared between both implementations (for example file save dialog -> save -> show file on completion)
* Update to latest SQLToolsService release
* remove sync methods
* added assertion to log error
* create random folder
* change variable name to be more descriptive
* Update book.test.ts
* Update book.test.ts
- Fix spark job failing when 1 or more servers are connected
and listed in getActiveConnections
- If nothing is connected, prompts to choose a server
- Added option to dropdown when 1 or more server is connected
to support picking a different connection
Root bug was trying to access "host" not "server" in options bag, which no longer exists.
* Fixed telemetry events for visualizer recommendation prompts
* Added telemetry event for when Visualizer button in action bar is clicked and added respective telemetry keys
* Created TelemetryView and TelemetryAction and relocated new constants
* extension recommendation on application launch
* Introducing Visualizer (SandDance) to the SQL Query Editor. (#6347)
* Created Visualizer icon in the results grid. Utilized a context key so that the icon only shows if Visualizer extensions (currently, just SandDance) is installed. Visualizer icon open up SandDance in a top-level document.
* When the user clicks on Charts, visualizer recommendation popup appears. User can click on "Install Extensions" to download the visualizer extensions.
* Enabled SQL Query Editor to pass query data to SandDance extension.
* Introducing Visualizer (SandDance) to the SQL Query Editor. (#6347)
* Created Visualizer icon in the results grid. Utilized a context key so that the icon only shows if Visualizer extensions (currently, just SandDance) is installed. Visualizer icon open up SandDance in a top-level document.
* When the user clicks on Charts, visualizer recommendation popup appears. User can click on "Install Extensions" to download the visualizer extensions.
* Enabled SQL Query Editor to pass query data to SandDance extension.
* Cleaned code; made changes according to PR comments
* removed the test service for extensions gallary
* Cleaned up code according to PR changes
* unid changes to build/azure-piplines
* Removed all the build/azure-pipelines changes
* removed changes on media/language.svg
* refactored extension recommendation system to allow it to be generic
* updated extensionsViews to support generic extension query search; added localized constants for visualizer extensions
* Made syntax and error message changes acccording to PR comments.
* Updated recommendation message according to scenario type
* Allow column resizing in preview table
* added property to TableComponentProperties
* hooked up new prop into model view
* new setOptions
* adding enum to azdata interface
* bring in slickgrid 2.3.30
* PR feedback
* Fix#6477 controller login + fix dashboard layout
- Service endpoints shoudl be on own column, cut off smaller screen
- Controller login not working due to 404 error
This is due to a breaking API change
We have requested fixes to help mitigate need for cluster name,
but for now have a default value for this
Finally, modified code so it's easier to update swagger API
and also added instructions on how to update in future
* add webpack for built in extensions
* fix the casing issue
* Rename azCLITool.ts to azCliTool.ts
* Rename kubectlTool.ts to kubeCtlTool.ts
* fix the error
* fix the packaging issue
* Replace Big Data Cluster with big data cluster
Official docs guidance is to use "big data cluster" instead of "Big Data Cluster"
* Use doublequotes and full product name
* initial commit: new modelview widget that shows books
* moved the new command action to notebook contribution and addressed the comments
* localize changes
* removed changes from src/vs file and string changes
* make directory for each contribution
* typo fix
This adds SQL Server Notebook as a built-in extension
by pulling it from blob storage.
It also adds support in mssql extension for reading the contribution points from other extensions.
This will contribute troubleshooting and other books as widgets.
In this commit:
- Bundle the extension in the build
- Bundle in sql.sh / sql.bat so it appears in local testing
- Avoid installing in Stable. Should only appear in Dev/Insiders builds
- Extensions with `notebook.books` contribution point will be discovered & their books available in MSSQL
Coming later:
- Integrate this with Maddy's work to show a Notebooks widget in the SQL Server big data cluster UI
- When clause isn't supported yet for filtering. Will be done as we refactor towards more books for different server types
Issue here is that for some reason click in tree causes 2 events:
- Selection Changed
- Resource Opened
Due to this, we get the markdown event 2 times and this misbehaves.
I am not confident in changing markdown so implemented similar pattern:
- Throttle requests if they're for the same resource inside 300ms
- This means 2nd event is ignored
Testing:
- Manual, clicked a bunch of markdowns
- It "just works" for me now
- The OEAction calls through a command service implementation that loses the context object.
Directly instantiating the NewNotebookAction solves this.
Also tested NewQuery and that didn't have an issue so left as-is
* open notebooks as untitled files and removed the saving to home directory
* return just filename without extension since save is adding the .ipynb ext
* Changes to open bdc notebooks as untitled docs. Updated tests to align with the changes
* changes: not to show untitled file as dirty and cleaned up tests in notebookService
* changes to address untitled name conflicts with open editors.
* comment cleanup
* added previous and next buttons
* previous and next notebook API
* links for prev/next notebooks
* fixed first and last pages
* made code more readable
* addressed Kevin's comments
* moved logic over to BookTreeItem
* show buttons in dev mode only
* added BookTreeItemFormat interface
* added interface and enum
* removed localize call
* Remove --user option when doing pip installs for our standalone Python version.
* Use force-reinstall option when installing sparkmagic since we use a custom version.
* Use force-reinstall when installing pip packages from Manage Packages dialog so that dependencies don't get split across multiple locations.
* Update PATH after install to include additional package directories.
* Fix#5238 Notebooks should support relative links
- Added detection of relative #links inside notebooks
- Added handling of these, at least for current notebook
Not handled: open other notebook & scroll to position.
* make deployment ext only available in insider
* delete big-data-cluster extension
* formatting
* Revert "delete big-data-cluster extension"
This reverts commit 0ac667e59d2bd15eeb383fb1e20d2bf8933ffab0.
- Fix#6221 Notebooks: Keyboard Shortcut for New Notebook has Changed.
- Use Win+Alt+N instead of Win+Shift+N
- New Grid is now "stable" (forgot to do this in last PR)
* fixed context for data explorer
* added more files
* initial servers and database context menu actions finished
* added all actions for servers and databases with correct conditions
* added nodetype and nodelabel for subtype actions
* added nodeinfo logic to oe shim
* fixed context for cms
* added all scripting actions to data explorer
* review comments
* fix import
* fix correct context key
* removed unused import
* fix typo
* fixed context for data explorer
* added more files
* initial servers and database context menu actions finished
* added all actions for servers and databases with correct conditions
* added nodetype and nodelabel for subtype actions
* added nodeinfo logic to oe shim
* fixed context for cms
* added all scripting actions to data explorer
* review comments
* fix import
* fix correct context key
* removed unused import
* separate PR for commands and menus added
* rename mssql context menu nodes
* remove command id constants
This is a staged refactor to use the exact same grid logic in the Notebook and query editors, including context menu support, font settings, and sizing logic. The goal long term is:
- As the core Query grid is updated, Notebook can benefit from the changes
- As we add in support for contributions like new buttons & actions working on the grid, can share the logic
- Ideally if and when we refactor things like the action bar for grid results, we can apply in both places though this is TBD.
Fixes a number of issues:
- Fixes#5755 Grids don't respond to font settings. @anthonydresser can we remove setting from each query results editor and just use Notebook Styles since these are global (not scoped) settings?
- Fixes#5501 Copy from grid settings.
- Fixes#4938 SQL Notebook result sets are missing the actions provide for SQL File results sets. this now has the core ability to solve this, and separate work items for specific asks (serialization, charting) are tracked.
Currently hidden:
- Save as... options in context menu
- All right toolbar actions (save as, chart).
Remaining issues to address in future commits:
- Need to implement support for serialization (#5137).
- Need to add charting support
- Need to solve the layout of buttons on the right hand side when a small number of columns are output. It doesn't look right that buttons are so far away from the results
- Will work with UX on this. For now, mitigating this by hiding all buttons, but will need to solve in the future
- Would like to make buttons contributable via extension, but need to refactor similar to ObjectExplorer context menu so that we can serialize context menu options across to extension host while still having internal actions with full support
With this change, Plotly types will be successfully rendered in a Notebook.
Currently they have a default width of 700px with a scrollbar if the window size is smaller (this matches other notebook viewers).
The Plotly library is dynamically required to avoid startup time perf hits. This is something we could look at for other components too.
* Change service installation messages to not steal focus
* Undo unnecessary changes to localized strings in serviceClient.ts
* Add default case for missing server event types
* Update admin-tool-ext-win to use new ads-extension-telemetry package
* Add AdsTelemetryService for sending telemetry events using the ADS Common Schema
* Clean up unused import and add engineType
* Address PR comments
* Update private var names
* NB improve startup using built-in markdown render
This is a sample branch showing perf improvements if we load content using built-in markdown rendering
- Has issues where images aren't correctly rendered due to sanitization, need to copy renderer code and update settings
- Moves content load up before anythign to do with providers since we can render without knowing about these things
# Conflicts:
# src/sql/workbench/parts/notebook/cellViews/textCell.component.ts
* Re-enable logging of each cell's rendering time
* Fix test issue
* Kernel loading working with new markdown renderer
# Conflicts:
# src/sql/workbench/parts/notebook/cellViews/textCell.component.ts
* Fixed tests, cleaned up code
* markdownOutput component integration
* PR Comments
* PR feedback 2
* PR feedback again
- Added a registry for output components
- Refactored existing renderers to plug in via Angular
- Added Markdown renderer using new Angular contribution point
- Added support to notebook module to dynamically load new components
* initial commit: added cluster status notebook and dashboard task
* following the previous naming conventions
* endpoint widget changes to accomodatw naming changes
* management-proxy/mgmtproxy chnages
* updates to address the comments and added the new copy image with hover text.
* added user select for making the table selectable
* localize changes
* added the final documented notebook
* reset execution_count to 0 for all cells
* style changes
* updated the url to point to private repo
* can compare scmp with databases
* show error if can't connect to db
* excludes now work
* fixes after rebase and other small fixes
* Addressing comments
* fixes after rebasing
* fix excludes not always being remembered correctly
* fix switched check
* addressing comments
* update dacpac and schema compare extensions to use getConnections
* use more const
* make MSSQL a const
* changing name of mssql const
* add comment for name of parameter
* Removing database name from server connection and adding required asterisk to database dropdowns
* also remove database name in flat file import wizard
* Schema compare cancel changes for ADS
* adding a missed change
* Merge from Master
* Updating SqltoolsService version
* trying stress with bigger runtime
* trying one more stress fix with unique operation ids
* refactoring test a bit to ensure stress run works
* Improve notebook link handling
- Single click now works for links inside Output areas
- Command links in untrusted notebooks have link color
- Refactored to use directive so code is in 1 place and can be easily
added elsewhere if needed
* Removed unneeded service from constructor
Adds a protocol handler for notebook open, which can be used from browsers
Uses extension-based handler support so all URIs must start with `azuredatastudio://microsoft.notebook`
Adds 2 actions:
- `/new` opens a new empty notebook
- `/open` opens a HTTP/S file as an untitled notebook or text document
Sample URL:
```
azuredatastudio://microsoft.notebook/open?url=https%3A%2F%2Fraw.githubusercontent.com%2Fkevcunnane%2Fmsbuild_ads_demo%2Fmaster%2F0_YoAzdata.ipynb
```
* Add Notebook Save integration tests
Wrote test to verify save behavior
Fixed issues found during testing,
specifically around how we notify dirty state change to extensions
* Improved error messages
* Changes to 1. Enable Icon for Schema Compare model view editor 2. Set context setting in editable drop down 3. Fix a console error
* new icons
* Changes as per PR comments
* Adding PR comments
* Fixing a spelling mistake
Opening connection dialog was broken if you have a postgres connection
listed in the Connections view and the extension isn't installed.
The capabilities service breaks as it returns an undefined object.
Added handling, so now it does show as "loading..." forever
but doesn't crash
* made all jobs get focus and keyboard friendly
* added tooltip for steps image
* made operator dialog accessible
* change job name as soon as job name changes in text box
- Updated test baselines
- Removed duplicate 'Standard SQL DB context menu test'
- it's identical to Azure test
- Standalone database context menu test covers non-Azure
* Log telemetry when all markdown cells rendered
* Enable referencing previous telemetry timestamps
* Fix broken unit test to do a null check
* Undo loading icon changes in textcelll
* Addressing PR comments
* PR comments II
* Fix New Notebook issues
- Fix#5338 New Notebook menu item should be next to New Query
- Fix#4936 Add a shortcut to create a notebook in the document well
Created a built-in New Notebook command
that routes to the existing extension-based command.
This avoided a rearchitecture that was more complex that seemed worth it.
Per VSCode patterns, used a _ modifier for the existing command so it's "private"
* fix accessbility issue where tabbing would get wrong focus
* dialogs open one at a time
* get focus on filter headers
* added tool tips to proxy dialog
* added labels to step dialog
- Updated the notebook API to add a change kind, and support saved, executed and other simplified status
- Plumbed this through to the main thread classes
- Support sending the events from cell / input to the notebook model so they loop over the extension host as a content changed event
- Add executed event from the cell
This isn't necessary since we aren't providing the VS binaries as redist-able. VS has signed off as confirming that the main extension license is enough to cover the VS binaries as well. (#5880)
* Add test for opening existing SQL file and typing text into it
* Clean up
* More cleanup, remove unneeded queryEditor and add smoke test scripts
* Update comments to be clearer
* cms connections dont save
* added value to enum
* remove refresh and update provider name for cms
* removed ownerUri from saved connection and contributed to array
* removed owneruri
* ownerUri not needed any more
* removed AAD from cms
* initial review
* changed comments
* add back saveProfile option for connectionProfile
* review fixes and other UI improvements
* fixed auth
* added cms integration tests
* added constants
* removed utils from apiwrapper
* changed connection type name
* review comments
* clearer code and addressed reviews
* added more error checks
* add back functions in apiwrapper
- Azure token wasn't being copied into profile so expand didn't work, it spun forever
- Fixed this by saving in password/token after the connection profile copy, & refactored to be cleaner
- We should ideally ensure session notifies resolves even on fail so if there's a different error it'll break, not spin forever. Punting this part of the fix for now
- Also doesn't solve issue where we always try to connect even if user + password combo isn't saved. Will investigate / work in a separate PR on this.
* make diff readonly
* change to use ResourceEditorInput instead of UntitleEditorInput since it is readonly
* inject service
* use this instead of declaring local variables
* addressing comments
* cms connections dont save
* added value to enum
* remove refresh and update provider name for cms
* removed ownerUri from saved connection and contributed to array
* removed owneruri
* ownerUri not needed any more
* removed AAD from cms
* initial review
* changed comments
* add back saveProfile option for connectionProfile
* review fixes and other UI improvements
* fixed auth
* added cms integration tests
* added constants
* removed utils from apiwrapper
* changed connection type name
* review comments
* clearer code and addressed reviews
* Improve Azure startup time and fix command palette
- Improvement (but not full fix) for #4732 where Azure startup is very slow.
This speeds the startup by up to 5 seconds by
- Changing from fixed 5 second initial wait time to a promise to check for accounts
- Using the accounts changed notification to send a message when accounts are ready. This is usually what will "win out" since Azure seems to load before the Account Providers are set up.
- Remove right-click actions from the command palette.
- Rename Azure actions so it's clear what they are in the command palette.
* Remove coveralls task while investigating how to make optional task
* Add void return type
- Notebooks Can be Improperly Trusted After Save + Reopen
Fix was to only save if actually trusted.
Also fixed condition where it wasn't correctly skipping if in the queue
* Revert "Revert "Provide a default result grid height (#5710)" (#5738)"
This reverts commit f8ab5fef78.
* Tune the sizing a bit to be more closer to May release
* changes to resue properties widget for endpoints
* comments added
* added loader
* changes to address the review comments: code clean up and constants
* dark theme style fox and misc
* added varibale for display aligment
* renamed hyperlink to isHyperlink
* added endpoints as a modelview to be used on dashboard
* added padding to fix the overlap issues.
* removed the propertieswidget changes
* formatting fixes for hygiene errors
* renamed endpoints to bdc-endpoints
* chnages to address the comments
* added null check
* First version of Stress - moving over from feat/Stress1 branch
* a working version - still issues with stresssified notebook tests
* update notebooks to use new message event (#5395)
* Latest changes for notebook tests
* Stressify objectExplorer tests
* formatting changes
* removing the tracing added previously and ability to set tsc verbose option in tsconfig.json
* addressing review feedback
* addressing review feedback
* implementing runtime parameter for Stress
* addresing review feedback and moved out stress modules to its own project outside of azuredata source tree
* referencing adstest from the github location
* incorporating review feedback
* Review feedbak
* removing uncommong entries added to .gitignore
* removing unrelated change
* replacing debug/trace statements with console.info or cosole.warn statments in integration-tests\main.tx
* add message to recompare if options changed
* changes after rebasing
* Add compare button to notification
* remove async
* change to yes and no button
* Adding code to change checkbox list to table with checkbox.
* removing some unnessary ','
* Increasing the table a little bit
* reverting height changes
* Adding PR comments
* refactored job actions to wait for job objects to load
* sorted the jobs in descending order
* decreased steps table height in jobs dialog
* cannot open multiple instances of dialogs now
* fixed edit job not show up some times when re opening history page
* fix broken icon
* fix a bunch of stuff and refactored code
* added isopen prop to dialog
* Adding include exclude boxes
* Adding as table component generic column and rememebering state.
* converged custome action and select checkboxes, moved sc checkbox to middle, can have multiple checkboxes and can remember state now
* adding action on column as a common column property
* Taking PR comments
* Changing Arg name as per CR comment
* Taking a PR comment
* Add test product-insider.json file
* Update some GUID
* Update mixin file
* Add more mixin customizations
* Update the mixin strings a little more
* Reorder code blocks to shorten a bit
* initial tests for schema compare
* Adding schema compare integration test
* Adding code to fix some build issues
* DB compare test
* Adding some CR comments
* db creation and deletion as per CR comments
* Fix#3439 Trusted doesn't get saved in Notebooks
The main fix is to add a memento to store trust information. This is only needed for saved files - untitled files are always trusted as the user created them.
On clicking trusted or saving a file, the trusted state is cached. In the future, we will also handle code execution here too by sending notification on snapshot state.
I found issue #5506 during testing - existing issue where we should track trusted state changing on run. In the case all cells are ran, the whole notebook should become trusted.
Finally, I did a decent amount of refactoring to move more logic to the model - removing unnecessary calls from components which duplicated model behavior, moving trust notification to the model or at least the notebook service completely.
Added tests and logging for catch handling
* Fix server name in URN for Azure servers and update menu when clauses
* Use setStatusBarMessage instead of constructing our own. Remove server name from URN - it's not necessary.
* Clean up unused code
Initial query execution options PR. This is the second in a set of query editor extensibility improvements I'm making. The PRs include (1) bug fix for webview in query tab (2) dynamic toolbars and (3) fix query event sequencing and event metadata info.
* Update vscode dependency (needed for test runner) to pull latest 1.x version
* Update to use 1.1.5 instead
* Undo change to vscode engine version
* Switch to using vscodetestcover for running tests
* Switch to cobertura output for coverage reports
* Remove vscode dependency from profiler extension
* Update yarn.lock with combined changes
* Remove unnecessary 'use strict' lines and add hygiene check for them
* Move check to under tslint filters to reduce number of filters needed
* Only take first 10 lines of file
* can make imports, but need to change success and failure views
* fixed error handling UX
* removed unused function
* cr comments
* fix typo
* requested change
VSCode serialization changed rejection handling to only serialize errors, which caused things to break
- Changed to return either account info or a cancel message in the resolve
- Rewrote to use promises. Tracking how to return canceled through 4+ thenables was way trickier than just using a promise
- Updated unit tests to handle new scenario
- Tested integration tests, realized they a) didn't run and b) didn't passed.
- Added vscode dev dependency to fix run issue
- Fixed tests to account for behavior changes in tree state.
* removes more builder references
* remove builder from profiler
* formatting
* fix profiler dailog
* remove builder from oatuhdialog
* remove the rest of builder references
* formatting
* add more strict null checks to base
* enable strict tslint rules
* code layering of base
* wip
* working through changes to table data view
* fix tests
* update editabledropdown to not use layout service
* wip
* fix imports
* fix import
* fix compile error
* add more localization
* add comments to changes to import patterns
* add more import comments
* Fixed#4953 following query editor behavior provide create file option when file name doesn't exist
* Check active edtior is the correct one before closing
* close editor
* Removed codes not needed
* Check error null
* replace observable references with just promises
* add tests for searching in dataview
* add comments
* work through respecting max matches
* fix tests
* fix strict null checks
Fixed #5236
- Change the icon to blue image. Existing icons are not deleted. We will use them when the icons are - - moved as the secondary actions.
- Change the font size to 13px
- Change the height to 21px
- Move Add actions to the left
* Add support for more SsmsMin property dialogs and the Generate Script Wizard. Also fixed bug with ExtHostObjectExplorerNode getParent function
* Localize package.json entries
* Fix localization tokens
* Address PR comments
* Fix regex and getParent
Fixes#5231
- Add stdin handling. Has to be at UI level so add plumb through handling
- Add unit tests
- Add new StdIn component.
Testing:
Unit Tests and manual testing of following:
- Prompt for password using `getpass` in python.
- Password prompt is hidden since "password" is true.
- Hit enter, it completes
- prompt, stop cell running, StdIn disappears
- prompt, hit escape, stdIn disappears and stdIn request is handled.
Issues: focus isn't always set to the input even though we call focus.
Will investigate this further.
* Fix markdown security and enable most CSS
Stops using our sanitizer and instead disables HTML in markdown engine
- This was blocking Note because it converted > to >
- It's slightly more strict in that it fully disables HTML unless trusted. Will need to improve handling of Trusted to support this in a future PR
Adds in correct CSS, both from .css file in markdown extension and from built-into all webviews global CSS
- Fix#3765 standard markdown support
- Fix Support of Notes by bringing correct styles
- Fix code block colorization
- Fix link handling so it's not bolded / gets underlined on hover
- Fixes table rendering (for markdown and HTML tables)
* Reduce scope of CSS changes
- Removed some CSS that wasn't needed or caused issues
- Scoped most things under the preview section not the whole component
* Avoid markdown html block by sanitizing after render
* Fix pre node not overflowing
- This was a bug in existing implementation too
* various clean ups
* formatting
* remove linting
* formatting
* IConfigurationService is even better
* messing with connection config tests
* update tests
* formatting
* foramtting
* remove unused code
* add more tests
* working through tests
* formatting
* more factoring of connection store and increase code coverage
* formatting
* fix tests
* change use of state service to storage service
* remove unused files
* fix strict null errors
* formatting
- Copied over click handler from VSCode markdown renderer
- Added logic to only support command links if trusted
Now clicking on a link will do an action or open a file.
Created #5238 to track need to support relative links which doesn't work
* extension now working
* make button messages better
* fix diff editor title disappearing and remove border from source and target name boxes
* redoing a bunch of stuff that disappeared after rebasing
* add images and add to extensions.ts
* moving a few changes to the right place after rebase
* formatting
* Initial schema compare options working code
* Adding description.icon etc.
* Enabling disabling options button
* Name change: SchemaCompareOptions to DeploymentOptions. To reflect SqltoolsService side parameters
* Adding sorting and correct sql tools version
* Adding options button themes
* Formatting fix
* Adding get default options call to get options from tools service
* Exclude/Include changes - first commit
* Adding border to checkboxes
* Taking PR comments
* Updating to latest sqltools with schema compare options
* first set of changes to experiment the registration of cms related apis
* Adding cms service entry to workbench
* Adding basic functionality for add remove reg servers and group
* Returning relative path as part of RegServerResult as string
* initial extension
* cleaned building with connecting to server
* get list of registered servers
* progress with registered servers tree
* cms base node with server selection
* removed unused services
* replaced azure stuff with cms
* removed cmsResourceService
* list servers progress
* Removing the cms apis from core. Having mssql extension expose them for cms extension
* create server working fine
* initial expansion and nodes
* Propogating the backend name changes to apis
* initial cms extension working
* cached connection needs change in api
* connect without dashboard in proposed
* Fixing some missing sqlops references
* add registered server bug found
* added refresh context menu option
* added payload
* server description not disabled after reject connection
* added more context actions and action icons
* added empty resource and error when same name server is added
* fixed connection issues with cms and normal connections
* added initial tests
* added cms icons
* removed azure readme
* test script revert
* fix build tests
* added more cms tests
* fixed test script
* fixed silent error when expanding servers
* added more cms tests
* removed cmsdialog from api
* cms dialog without object
* fixed theming issues
* initial connection dialog done
* can make connections
* PM asks for strings and icons
* removed search
* removed unused code and fixed 1 test
* fix connection management tests
* changed icons
* format file
* fixed hygiene
* initial cr comments
* refactored cms connection dialog
* fixed bug when switching dialogs
* localized connection provider options
* fixed cms provider name
* code review comments
* localized options in cms and mssql
* localized more options
* Connect opened query editors to the ser
* only show firewall rule error for one file
* remove unused imports
* sync to latest
* add comment
* one more comment
* Close jupyter and python
* Ensure we stop jupyter correctly on process end
* dont stopServer from clientSession shutdown
* PR comments
* close notebook after each test
* Fixed#4772 create unique connection for each notebook by using notebook path as uri
Disconnect sqlConnection from SqlKernel to ensure no connection left after the notebook is closed.
* SqlSessionManager is ADS level manager
* Moved path to SqlKernel constructor
* testing code coverage for /sql/
* fix test result path
* fixed coverage task:
'
* added coverage to linux and mac as well
* fix script for mac and linux
* bash script cmd
* fixed scripts
* remove warnings from summary
* remove coverage from linux
* added job action tests
* added more tests
This fixes an issue where if you copy azdata.proposed.d.ts to
an extension project, it would fail to compile using default
tsconfig.json settings due to missing return type
* extension now working
* fix diff editor title disappearing and remove border from source and target name boxes
* redoing a bunch of stuff that disappeared after rebasing
* add images and add to extensions.ts
* moving a few changes to the right place after rebase
* formatting
* update toolbar svgs
* addressing comments
* add return types
* Adding PR comments
* Adding light and dark theme icons
* Fixing the diff editor title for dark theme
* ADS Welcome Page
* sample notebook section
* Opens in browser :(
* Remove sample notebooks section
* fix open file in windows
* Change az_data_welcome_page to be under sql/
* fix tslint issue
* Scope table css down
* Fix Data Explorer context menu items visibility
The when clause was making the menu items show up for all nodes in the Data Explorer - even ones that didn't make sense such as the Databases folders. This change makes it only appear for the Database and Server nodes (which is how the OE tree is set up)
* removes more builder references
* remove builder from profiler
* formatting
* fix profiler dailog
* remove builder from oatuhdialog
* remove the rest of builder references
* formatting
* add more strict null checks to base
* Touchbar icon support in notebooks
- updated shortcut keys to only work if notebook is active
- Added icons
- Now have 1 "add cell" icon that prompts for code/text.
This is useful as there wasn't an icon to differentiate
* Fix 2 notebook issues
- Do not create notebook model twice on start
- Do not cause disposed warnings due to markdown cell deserialization
* Fix notebook dirty on open issue
Before model is resolved we weren't getting dirty events.
Solution is to use backing text model until it's ready.
Must hook to the dirty event & notify to get the dot to appear
* preserving spaces in query results - all beginning, trailing and middle spaces will be shown as is
* removing the change through formatting and replacing with css change formatting was leaving special char while removing nbsp
* Basic touchbar support
* Touchbar support for Run Cell, Run Query, Add Cell
- Add top 3 notebook commands
- Add top query command
Actions only appear on having active editor of expected type.
In order to make Notebook work as expected, added tabindex to support focusing
and hide outline to ensure it doesn't get weird blue outline on click
Note: does not have icons yet, which would be nice.
However can add in subsequent PR once this comes from UX.
This is a partial fix that lays groundwork for full "Prompt to connect" if a kernel needs a connection.
I am waiting on Yurong's refactoring of connection handling before doing any of the prompt work.
- Adds kernel metadata about whether a connection is required.
- For Jupyter, only Spark kernels are listed as requiring a connection
- If this is true and there's no active connection, will show notification and not call execute
In the future, this path will still be used if user is prompted to connect and cancels out.
The future change will be to inject a "connect" handler from notebook.component to the cell callback and use to set connection context
Add back check for textDocuments with same name, should've been there anyhow
On rehydration files show as text docs before clicking as only get
changed by customInputConverter code path.
We should look at this long term - ideally we'd update notebookDocuments
with correct values on initial start. #4958 opened to track this.
* automate the setup and use akv to store values
* update readme.md
* get rid of the save to file part
* update readme
* add more messages
* fix the error
* fix some errors
* fix the readme
* intial code for diff view inside model view
* Adding basic Split View Container depending on Flex Layout
* Enabled resizing between top and bottom view
* cleaning up some of the sqlops references
* Adding height as per CR comment
comment:"Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
name:'Needs Logs',
action:'comment',
comment:"We need more info to debug your particular issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.\n\nTo find your logs:\n\n- Open command palette (Click **View** -> **Command Palette**)\n- Run the command: **`Developer: Open Logs Folder`**\n\nThis will open the log file locally. Please include renderer.log"
* Hotfix for https://github.com/microsoft/azuredatastudio/milestone/54?closed=1
## Version 1.17.0
* Release date: April 27, 2020
* Release status: General Availability
* New Welcome Page
* New Notebook features
* New Markdown editor toolbar
* Books viewlet now works with notebooks
* Improved dashboard
* Always encrypted support
* Accessibility bugs
* VS Code merge
## Version 1.16.0
* Release date: March 18, 2020
* Release status: General Availability
* Notebooks:
* Charting
* Creating Jupyter books
* Postgres extension update - Users can now authenticate to Azure Postgres servers with their linked Azure account
* Accessibility bugs
* VS Code merge
* In the next release, GitHub releases will no longer contain the binary files to the latest version. Rather, they will contain links to the latest release. This will have no impact on users using the in-app update functionality.
## Version 1.15.1
* Release date: February 19, 2020
* Release status: General Availability
* Resolved [#9145 Edit Data render the result grid incorrectly when using custom query](https://github.com/microsoft/azuredatastudio/issues/9145).
* Resolved [#9149 Show Active Connections](https://github.com/microsoft/azuredatastudio/issues/9149).
## Version 1.15.0
* Release date: February 13, 2020
* Release status: General Availability
* New Azure Sign-in improvement - Added improved Azure Sign-in experience, including removal of copy/paste of device code to make a more seamless connected experience.
* Find in Notebook support - Users can now use Ctrl+F inside of a notebook. Find in Notebook support searches line by line through both code and text cells.
* VS Code merge from 1.38 to 1.42 - This release includes updates to VS Code from the 3 previous VS Code releases. Read their [release notes](https://code.visualstudio.com/updates/v1_42) to learn more.
* Fix for the ["white/blank screen"](https://github.com/microsoft/azuredatastudio/issues/8775) issue reported by many users.
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/issues?q=is%3Aissue+label%3ABug+milestone%3A%22February+2020%22+is%3Aclosed).
## Version 1.14.1
* Release date: December 26, 2019
* Release status: General Availability
* Hotfix for bug https://github.com/microsoft/azuredatastudio/issues/8768
## Version 1.14.0
* Release date: December 19, 2019
* Release status: General Availability
* Added bigdatacluster.ignoreSslVerification setting to allow ignoring SSL verification errors when connecting to a BDC [#8129](https://github.com/microsoft/azuredatastudio/issues/8129)
* Changed attach to connection dropdown in Notebooks to only list the currently active connection [#8582](https://github.com/microsoft/azuredatastudio/pull/8582)
* Allow changing default language flavor for offline query editors [#8419](https://github.com/microsoft/azuredatastudio/pull/8419)
* GA status for Big Data Cluster/SQL 2019 features [#8269](https://github.com/microsoft/azuredatastudio/issues/8269)
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/44?closed=1).
## Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
## Version 1.13.1
* Release date: November 15, 2019
* Release status: General Availability
* Resolved [#8210 Copy/Paste results are out of order](https://github.com/microsoft/azuredatastudio/issues/8210).
## Version 1.13.0
* Release date: November 4, 2019
* Release status: General Availability
* General Availability release for Schema Compare and DACPAC extensions
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/43?closed=1).
## Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* aspnerd for `Use selected DB for import wizard schema list` [#7878](https://github.com/microsoft/azuredatastudio/pull/7878)
## Version 1.12.2
* Release date: October 11, 2019
* Release status: General Availability
* Hotfix release (1.12.2): `Disable automatically starting the EH in inspect mode` https://github.com/microsoft/azuredatastudio/commit/c9bef82ace6c67190d0e83820011a2bbd1f793c1
## Version 1.12.1
* Release date: October 7, 2019
* Release status: General Availability
* Hotfix release: `Notebooks: Ensure quotes and backslashes are escaped properly in text editor model` https://github.com/microsoft/azuredatastudio/pull/7540
## Version 1.12.0
* Release date: October 2, 2019
* Release status: General Availability
## What's new in this version
* Announcing the Query History panel
* Improved Query Results Grid copy selection support
* TempDB page added to Server Reports extension
* PowerShell extension update
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/42?closed=1).
## Version 1.11.0
* Release date: September 10, 2019
* Release status: General Availability
## What's new in this version
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/41?closed=1).
## Version 1.10.0
* Release date: August 14, 2019
* Release status: General Availability
## What's new in this version
* [SandDance](https://github.com/microsoft/SandDance) integration — A new way to interact with data. Download the extension [here](https://docs.microsoft.com/sql/azure-data-studio/sanddance-extension)
* Notebook improvements
* Better loading performance
* Ability to right click SQL results grid to save your results as CSV, JSON, etc.
* Buttons to add code or text cells in-line
* [Other fixes and improvements](https://github.com/microsoft/azuredatastudio/issues?q=is%3Aissue+label%3A%22Area%3A+Notebooks%22+milestone%3A%22August+2019+Release%22+is%3Aclosed)
* SQL Server Dacpac extension can support Azure Active Directory authentication
* Updated SQL Server 2019 extension
* Visual Studio Code May Release Merge 1.37 - this includes changes from [1.36](https://code.visualstudio.com/updates/v1_37) and [1.37](https://code.visualstudio.com/updates/v1_37)
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/39?closed=1).
## Version 1.9.0
* Release date: July 11, 2019
* Release status: General Availability
## What's new in this version
* Release of [SentryOne Plan Explorer Extension](https://www.sentryone.com/products/sentryone-plan-explorer-extension-azure-data-studio)
* **Schema Compare**
* Schema Compare File Support (.SCMP)
* Cancel support
* [Other fixes and improvements](https://github.com/Microsoft/azuredatastudio/issues?q=is%3Aissue+milestone%3A%22July+2019+Release%22+is%3Aclosed+label%3A%22Area%3A+Schema+Compare%22)
* **Notebooks**
* Plotly Support
* Open Notebook from Browser
* Python Package Management
* Performance & Markdown Enhancements
* Improved Keyboard Shortcuts
* [Other fixes and improvements](https://github.com/Microsoft/azuredatastudio/issues?q=is%3Aissue+milestone%3A%22July+2019+Release%22+is%3Aclosed+label%3A%22Area%3A+Notebooks%22)
* **SQL Server Profiler**
* Filtering by Database Name
* Copy & Paste Support
* Save/Load Filter
* SQL Server 2019 Support
* New Language Packs Available
* Visual Studio Code May Release Merge 1.35 - the latest improvements can be found [here](https://code.visualstudio.com/updates/v1_35)
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/35?closed=1).
## Version 1.8.0
* Release date: June 6, 2019
* Release status: General Availability
## What's new in this version
* Initial release of the Database Admin Tool Extensions for Windows *Preview* extension
* Initial release of the Central Management Servers extension
* **Schema Compare**
* Added Exclude/Include Options
* Generate Script opens script after being generated
* Removed double scroll bars
* Formatting and layout improvements
* Complete changes can be found [here](https://github.com/microsoft/azuredatastudio/issues?q=is%3Aissue+milestone%3A%22June+2019+Release%22+label%3A%22Area%3A+Schema+Compare%22+is%3Aclosed)
* Messages panel moved into results panel - when users ran SQL queries, results and messages were in stacked panels. Now they are in separate tabs in a single panel similar to SSMS.
* **Notebook**
* Users can now choose to use their own Python 3 or Anaconda installs in notebooks
* Multiple Stability + fit/finish fixes
* View the full list of improvements and fixes [here](https://github.com/microsoft/azuredatastudio/issues?q=is%3Aissue+milestone%3A%22June+2019+Release%22+is%3Aclosed+label%3A%22Area%3A+Notebooks%22)
* Visual Studio Code May Release Merge 1.34 - the latest improvements can be found [here](https://code.visualstudio.com/updates/v1_34)
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/32?closed=1).
## Version 1.7.0
* Release date: May 8, 2019
* Release status: General Availability
## What's new in this version
* Announcing Schema Compare *Preview* extension
* Tasks Panel UX improvement
* Announcing new Welcome page
* Resolved [bugs and issues](https://github.com/microsoft/azuredatastudio/milestone/31?closed=1).
## Contributions and "thank you"
We would like to thank all our users who raised issues.
## Version 1.6.0
* Release date: April 18, 2019
* Release status: General Availability
## What's new in this version
* Align with latest VS Code editor platform (currently 1.33.1)
* Resolved [bugs and issues](https://github.com/Microsoft/azuredatastudio/milestone/26?closed=1).
## Contributions and "thank you"
We would like to thank all our users who raised issues, and in particular the following users who helped contribute fixes:
* yamatoya for `fix the format (#4899)`
## Version 1.5.1
* Release date: March 18, 2019
* Release status: General Availability
@@ -108,7 +300,7 @@ We would like to thank all our users who raised issues, and in particular the fo
## What's new in this version
* Announcing the SQL Server 2019 Preview extension.
* Support for SQL Server 2019 preview features including big data cluster support.
* Support for SQL Server 2019 preview features including Big Data Cluster support.
* Azure Data Studio Notebooks
* The Azure Resource Explorer viewlets you browse data-related endpoints for your Azure accounts and create connections to them in Object Explorer. In this release Azure SQL Databases and servers are supported.
* SQL Server Polybase Create External Table Wizard
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
[](https://gitter.im/Microsoft/sqlopsstudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
(quality==='insider'&&/^master$|^refs\/heads\/master$/.test(sourceBranch)&&/Project Collection Service Accounts|Microsoft.VisualStudio.Services.TFS/.test(queuedBy))||
// Exploration: any build from electron-4.0.x branch
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.