ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Close connection explicitly on rename (#2129)

Browse Source
This commit is contained in:
Cheena Malhotra
2023-07-06 22:19:17 -07:00
committed by GitHub
parent 226b30ffbd
commit 03a99e48dc
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypeHandler.cs
View File

@@ -74,6 +74,11 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
throw new Exception(SR.ObjectNotRenamable(objectUrn)); throw new Exception(SR.ObjectNotRenamable(objectUrn));
} }
} }
// If connection is not instantiated in the using statement, it can be leaked here, therefore close explicitly.
if(serverConnection.SqlConnectionObject.State == System.Data.ConnectionState.Open)
{
serverConnection.SqlConnectionObject.Close();
}
return Task.CompletedTask; return Task.CompletedTask;
} }