ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Update assessment NuGet version + mark GAed VM SKUs as non-preview (#1510)

Browse Source 
* Update assessment NuGet version and metadata

* Consider Eb VM SKUs without preview flag as they are now GAed

* Update assessment NuGet to 1.0.20220527.33
This commit is contained in:
Raymond Truong
2022-05-31 14:54:29 -07:00
committed by GitHub
parent 989137ddb7
commit 0c37dc50f9
8 changed files with 46 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Packages.props
View File

@@ -25,7 +25,7 @@
<PackageReference Update="Microsoft.Azure.Kusto.Data" Version="9.0.4" />
<PackageReference Update="Microsoft.Azure.Kusto.Language" Version="9.0.4"/>
<PackageReference Update="Microsoft.SqlServer.Assessment" Version="[1.0.305]" />
<PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20220211.24" />
<PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20220527.33" />
<PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="160.22504.0" />
<PackageReference Update="Microsoft.Azure.OperationalInsights" Version="1.0.0" />
<PackageReference Update="Microsoft.CodeAnalysis.CSharp" Version="3.10.0" />

BIN
bin/nuget/Microsoft.SqlServer.Migration.Assessment.1.0.20220211.24.nupkg → bin/nuget/Microsoft.SqlServer.Migration.Assessment.1.0.20220527.33.nupkg
View File

Binary file not shown.

BIN
src/Microsoft.SqlTools.ServiceLayer/Migration/Metadata/Data/AzureVirtualMachine.json
View File

Binary file not shown.

2
src/Microsoft.SqlTools.ServiceLayer/Migration/Metadata/TargetAssessment/AzureSQLDatabase/AzureSQLDbFeatureRuleMetadataStore.xml
View File

File diff suppressed because one or more lines are too long

75
src/Microsoft.SqlTools.ServiceLayer/Migration/Metadata/TargetAssessment/ManagedInstance/MIFeatureRuleMetadataStore.xml
View File

File diff suppressed because one or more lines are too long

28
src/Microsoft.SqlTools.ServiceLayer/Migration/Metadata/TargetAssessment/ManagedInstance/MIRuleResources.resx
View File

@@ -175,7 +175,7 @@
<value>xp_cmdshell is not supported in Azure SQL Managed Instance.</value>
</data>
<data name="XpCmdshellIssueCategory" xml:space="preserve">
<value>Issue</value>
<value>Warning</value>
</data>
<data name="XpCmdshellDescription" xml:space="preserve">
<value>Xp_cmdshell which spawns a Windows command shell and passes in a string for execution is not supported in Azure SQL Managed Instance.</value>
@@ -333,24 +333,6 @@
<data name="MIHeterogeneousMSDTCTransactSQLMoreInformationlink" xml:space="preserve">
<value>https://docs.microsoft.com/en-us/azure/azure-sql/database/elastic-transactions-overview#transactions-across-multiple-servers-for-azure-sql-managed-instance</value>
</data>
<data name="ClrStrictSecurityTitle" xml:space="preserve">
<value>CLR assemblies marked as SAFE or EXTERNAL_ACCESS are considered UNSAFE</value>
</data>
<data name="ClrStrictSecurityIssueCategory" xml:space="preserve">
<value>Warning</value>
</data>
<data name="ClrStrictSecurityDescription" xml:space="preserve">
<value>CLR Strict Security mode is enforced in Azure SQL Managed Instance. This mode is enabled by default and introduces breaking changes for databases containing user defined CLR assemblies marked either SAFE or EXTERNAL_ACCESS.</value>
</data>
<data name="ClrStrictSecurityRecommendation" xml:space="preserve">
<value>CLR uses Code Access Security (CAS) in the .NET Framework, which is no longer supported as a security boundary. Beginning with SQL Server 2017 (14.x) Database Engine, an sp_configure option called clr strict security is introduced to enhance the security of CLR assemblies. clr strict security is enabled by default and treats SAFE and EXTERNAL_ACCESS CLR assemblies as if they were marked UNSAFE. When clr strict security is disabled, a CLR assembly created with PERMISSION_SET = SAFE may be able to access external system resources, call unmanaged code, and acquire sysadmin privileges. After enabling strict security, any assemblies that are not signed will fail to load. Also, if a database has SAFE or EXTERNAL_ACCESS assemblies, RESTORE or ATTACH DATABASE statements can complete, but the assemblies may fail to load. To load the assemblies, you must either alter or drop and recreate each assembly so that it is signed with a certificate or asymmetric key that has a corresponding login with the UNSAFE ASSEMBLY permission on the server.</value>
</data>
<data name="ClrStrictSecurityMoreInformation" xml:space="preserve">
<value>CLR strict security</value>
</data>
<data name="ClrStrictSecurityMoreInformationlink" xml:space="preserve">
<value>https://docs.microsoft.com/en-us/sql/database-engine/configure-windows/clr-strict-security?view=sql-server-ver15</value>
</data>
<data name="ComputeClauseTitle" xml:space="preserve">
<value>COMPUTE clause is discontinued and has been removed.</value>
</data>
@@ -535,7 +517,7 @@
<value>Azure SQL Managed Instance supports a maximum of 100 databases per instance.</value>
</data>
<data name="NumDbExceeds100IssueCategory" xml:space="preserve">
<value>Warning</value>
<value>Issue</value>
</data>
<data name="NumDbExceeds100Description" xml:space="preserve">
<value>Maximum number of databases supported in Azure SQL Managed Instance is 100, unless the instance storage size limit has been reached.</value>
@@ -694,16 +676,16 @@
<value>https://docs.microsoft.com/en-us/azure/azure-sql/managed-instance/transact-sql-tsql-differences-sql-server#sql-server-agent</value>
</data>
<data name="WindowsAuthenticationTitle" xml:space="preserve">
<value>Database users mapped with Windows authentication (integrated security) are not supported in Azure SQL Managed Instance</value>
<value>Database users mapped with Windows authentication (integrated security) should be remapped to equivalent Azure AD identities.</value>
</data>
<data name="WindowsAuthenticationIssueCategory" xml:space="preserve">
<value>Warning</value>
</data>
<data name="WindowsAuthenticationDescription" xml:space="preserve">
<value>Azure SQL Managed Instance supports two types of authentication 1) SQL Authentication, which uses a username and password 2) Azure Active Directory Authentication, which uses identities managed by Azure Active Directory and is supported for managed and integrated domains. Database users mapped with Windows authentication (integrated security) is not supported in Azure SQL Managed Instance.</value>
<value>Azure SQL Managed Instance supports three types of authentication 1) SQL Authentication, which uses a username and password 2) Azure Active Directory Authentication and 3) Windows Authentication, which both use identities managed by Azure Active Directory and is supported for managed and integrated domains. Windows logins and users not in Azure Active Directory are not supported in Azure SQL Managed Instance.</value>
</data>
<data name="WindowsAuthenticationRecommendation" xml:space="preserve">
<value>Federate the local Active Directory with Azure Active Directory. The Windows identity can then be replaced with the equivalent Azure Active Directory identities. Alternatively, migrate to SQL Server on Azure Virtual Machine.</value>
<value>Synchronize the local Active Directory with Azure Active Directory. The Windows identity can then be replaced with the equivalent Azure Active Directory identities. Alternatively, migrate to SQL Server on Azure Virtual Machine.</value>
</data>
<data name="WindowsAuthenticationMoreInformation" xml:space="preserve">
<value>An overview of Azure SQL Database and SQL Managed Instance security capabilities</value>

2
src/Microsoft.SqlTools.ServiceLayer/Migration/Metadata/TargetAssessment/SqlServer/SqlServerUpgradeFeatureRuleMetadataStore.xml
View File

File diff suppressed because one or more lines are too long

16
src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs
View File

@@ -625,18 +625,16 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
string jsonFile = File.ReadAllText(Path.Combine(assemblyPath, RecommendationConstants.DataFolder, RecommendationConstants.SqlVmCapability));
List<AzureSqlIaaSCapability> vmCapabilities = JsonConvert.DeserializeObject<List<AzureSqlIaaSCapability>>(jsonFile);
if (includePreviewSkus)
// Eb series capabilities stored separately
string computePreviewFilePath = Path.Combine(assemblyPath, RecommendationConstants.DataFolder, RecommendationConstants.SqlVmPreviewCapability);
if (File.Exists(computePreviewFilePath))
{
// Eb series (in preview) capabilities stored separately
string computePreviewFilePath = Path.Combine(assemblyPath, RecommendationConstants.DataFolder, RecommendationConstants.SqlVmPreviewCapability);
if (File.Exists(computePreviewFilePath))
{
jsonFile = File.ReadAllText(computePreviewFilePath);
List<AzureSqlIaaSCapability> vmPreviewCapabilities = JsonConvert.DeserializeObject<List<AzureSqlIaaSCapability>>(jsonFile);
jsonFile = File.ReadAllText(computePreviewFilePath);
List<AzureSqlIaaSCapability> vmPreviewCapabilities = JsonConvert.DeserializeObject<List<AzureSqlIaaSCapability>>(jsonFile);
vmCapabilities.AddRange(vmPreviewCapabilities);
}
vmCapabilities.AddRange(vmPreviewCapabilities);
}
foreach (VirtualMachineFamily family in AzureVirtualMachineFamilyGroup.FamilyGroups[VirtualMachineFamilyType.GeneralPurpose]
.Concat(AzureVirtualMachineFamilyGroup.FamilyGroups[VirtualMachineFamilyType.MemoryOptimized]))