mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 01:25:40 -05:00
Add action to ask for validation when modifying Packages.props (#1165)
* Add action to ask for validation when modifying Packages.props * test * update name * undo
This commit is contained in:
25
.github/workflows/packages-validation-comment.yml
vendored
Normal file
25
.github/workflows/packages-validation-comment.yml
vendored
Normal file
@@ -0,0 +1,25 @@
|
||||
name: Packages.props validation message
|
||||
on:
|
||||
pull_request:
|
||||
paths:
|
||||
- 'Packages.props'
|
||||
branches:
|
||||
- main
|
||||
|
||||
jobs:
|
||||
main:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: mshick/add-pr-comment@v1
|
||||
with:
|
||||
message: |
|
||||
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
|
||||
they've done the following checks.
|
||||
|
||||
**Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR**
|
||||
|
||||
- [ ] Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
|
||||
- [ ] Tested changes on all major platforms (Windows/Mac/Linux)
|
||||
- [ ] Check the source repo for any open issues with the release being updated to (if available)
|
||||
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
||||
repo-token-user-login: 'github-actions[bot]' # The user.login for temporary GitHub tokens
|
||||
@@ -1,7 +1,7 @@
|
||||
<Project>
|
||||
<ItemGroup>
|
||||
<PackageReference Update="Newtonsoft.Json" Version="12.0.3" />
|
||||
|
||||
|
||||
<PackageReference Update="System.Net.Http" Version="4.3.4" />
|
||||
<PackageReference Update="System.IO.Packaging" Version="4.7.0" />
|
||||
<PackageReference Update="System.Runtime.Loader" Version="4.3.0" />
|
||||
|
||||
Reference in New Issue
Block a user