ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-01 01:25:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

Handle null passwords when creating SecureStrings in AdminService (#457)

Browse Source
This commit is contained in:
Matt Irvine
2017-09-14 11:06:15 -07:00
committed by GitHub
parent 84ea045572
commit 52913aa815
2 changed files with 47 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Microsoft.SqlTools.ServiceLayer/Admin/AdminService.cs
View File

@@ -180,10 +180,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Admin
// check if the connection is using SQL Auth or Integrated Auth
if (string.Equals(connInfo.ConnectionDetails.AuthenticationType, "SqlLogin", StringComparison.OrdinalIgnoreCase))
{
var passwordSecureString = new System.Security.SecureString();
foreach (char c in connInfo.ConnectionDetails.Password) {
passwordSecureString.AppendChar(c);
}
var passwordSecureString = BuildSecureStringFromPassword(connInfo.ConnectionDetails.Password);
dataContainer = new CDataContainer(
CDataContainer.ServerType.SQL,
connInfo.ConnectionDetails.ServerName,
@@ -207,6 +204,16 @@ namespace Microsoft.SqlTools.ServiceLayer.Admin
return taskHelper;
}
internal static System.Security.SecureString BuildSecureStringFromPassword(string password) {
var passwordSecureString = new System.Security.SecureString();
if (password != null) {
foreach (char c in password) {
passwordSecureString.AppendChar(c);
}
}
return passwordSecureString;
}
/// <summary>
/// Create data container document
/// </summary>

36
test/Microsoft.SqlTools.ServiceLayer.UnitTests/Admin/AdminServiceTests.cs Normal file
View File

@@ -0,0 +1,36 @@
//
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
//
using System.Security;
using Xunit;
using Microsoft.SqlTools.ServiceLayer.Admin;
using Microsoft.SqlTools.ServiceLayer.Connection;
using Microsoft.SqlTools.ServiceLayer.Connection.Contracts;
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Admin
{
/// <summary>
/// Tests for AdminService Class
/// </summary>
public class AdminServiceTests
{
[Fact]
public void TestBuildingSecureStringFromPassword()
{
string password = "test_password";
var secureString = AdminService.BuildSecureStringFromPassword(password);
Assert.Equal(password.Length, secureString.Length);
}
[Fact]
public void TestBuildingSecureStringFromNullPassword()
{
string password = null;
var secureString = AdminService.BuildSecureStringFromPassword(password);
Assert.Equal(0, secureString.Length);
}
}
}