ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

added rule id (#1190)

Browse Source
This commit is contained in:
Christopher Suh
2021-04-15 12:02:32 -07:00
committed by GitHub
parent 516553f72a
commit 6bafed10eb
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Microsoft.SqlTools.ServiceLayer/Migration/Contracts/MigrationAssessmentInfo.cs
View File

@@ -22,6 +22,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration.Contracts
/// </summary> /// </summary>
public string RulesetName { get; set; } public string RulesetName { get; set; }
/// <summary>
/// Gets or sets assessment ruleset name
/// </summary>
public string RuleId { get; set; }
/// <summary> /// <summary>
/// Gets or sets assessed target's type. /// Gets or sets assessed target's type.
/// Supported values: 1 - server, 2 - database. /// Supported values: 1 - server, 2 - database.

4
src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs
View File

@@ -194,7 +194,8 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
var targetName = !string.IsNullOrWhiteSpace(migrationResult.DatabaseName) var targetName = !string.IsNullOrWhiteSpace(migrationResult.DatabaseName)
? $"{target.ServerName}:{migrationResult.DatabaseName}" ? $"{target.ServerName}:{migrationResult.DatabaseName}"
: target.Name; : target.Name;
var ruleId = migrationResult.FeatureId.ToString();
var item = new MigrationAssessmentInfo() var item = new MigrationAssessmentInfo()
{ {
@@ -210,6 +211,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
TargetType = target.Type, TargetType = target.Type,
RulesetName = Engine.Configuration.DefaultRuleset.Name, RulesetName = Engine.Configuration.DefaultRuleset.Name,
RulesetVersion = Engine.Configuration.DefaultRuleset.Version.ToString(), RulesetVersion = Engine.Configuration.DefaultRuleset.Version.ToString(),
RuleId = ruleId,
Message = r.Message, Message = r.Message,
AppliesToMigrationTargetPlatform = migrationResult.AppliesToMigrationTargetPlatform.ToString(), AppliesToMigrationTargetPlatform = migrationResult.AppliesToMigrationTargetPlatform.ToString(),
IssueCategory = "Category_Unknown" IssueCategory = "Category_Unknown"