ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Made connection errors more user-friendly (#57)

Browse Source
This commit is contained in:
Mitchell Sternke
2016-09-21 11:59:03 -07:00
committed by GitHub
parent 159362f01b
commit 803a19d716
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
View File

@@ -162,8 +162,16 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
connectionInfo.SqlConnection = connectionInfo.Factory.CreateSqlConnection(connectionString);
connectionInfo.SqlConnection.Open();
}
catch(Exception ex)
catch (SqlException ex)
{
response.ErrorNumber = ex.Number;
response.ErrorMessage = ex.Message;
response.Messages = ex.ToString();
return response;
}
catch (Exception ex)
{
response.ErrorMessage = ex.Message;
response.Messages = ex.ToString();
return response;
}

12
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectResponse.cs
View File

@@ -16,10 +16,20 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
public string ConnectionId { get; set; }
/// <summary>
/// Gets or sets any connection error messages
/// Gets or sets any detailed connection error messages.
/// </summary>
public string Messages { get; set; }
/// <summary>
/// Error message returned from the engine for a connection failure reason, if any.
/// </summary>
public string ErrorMessage { get; set; }
/// <summary>
/// Error number returned from the engine for connection failure reason, if any.
/// </summary>
public int ErrorNumber { get; set; }
/// <summary>
/// Information about the connected server.
/// </summary>