ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-01 17:24:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding some default values to match SSDT and other tools (#818)

Browse Source 
* Adding some default values to match DacFx deploy Extension and other tools. This help the default behavior but doesn't fix the issue.

* Fixing a test for default values and adding comment
This commit is contained in:
udeeshagautam
2019-05-24 10:51:21 -07:00
committed by GitHub
parent 5583cc182f
commit b30926b273
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/Contracts/DeploymentOptions.cs
View File

@@ -207,6 +207,18 @@ namespace Microsoft.SqlTools.ServiceLayer.SchemaCompare.Contracts
public DeploymentOptions()
{
DacDeployOptions options = new DacDeployOptions();
// Adding these defaults to ensure behavior similarity with other tools. Dacfx and SSMS import/export wizards use these defaults.
// Tracking the full fix : https://github.com/microsoft/azuredatastudio/issues/5599
options.AllowDropBlockingAssemblies = true;
options.AllowIncompatiblePlatform = true;
options.DropObjectsNotInSource = true;
options.DropPermissionsNotInSource = true;
options.DropRoleMembersNotInSource = true;
options.IgnoreKeywordCasing = false;
options.IgnoreSemicolonBetweenStatements = false;
options.IgnoreWhitespace = false;
System.Reflection.PropertyInfo[] deploymentOptionsProperties = this.GetType().GetProperties();
foreach (var deployOptionsProp in deploymentOptionsProperties)

10
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/SchemaCompare/SchemaCompareServiceOptionsTests.cs
View File

@@ -372,6 +372,16 @@ END
DeploymentOptions deployOptions = new DeploymentOptions();
DacDeployOptions dacOptions = new DacDeployOptions();
// Changes to match new defaults
dacOptions.AllowDropBlockingAssemblies = true;
dacOptions.AllowIncompatiblePlatform = true;
dacOptions.DropObjectsNotInSource = true;
dacOptions.DropPermissionsNotInSource = true;
dacOptions.DropRoleMembersNotInSource = true;
dacOptions.IgnoreKeywordCasing = false;
dacOptions.IgnoreSemicolonBetweenStatements = false;
dacOptions.IgnoreWhitespace = false;
System.Reflection.PropertyInfo[] deploymentOptionsProperties = deployOptions.GetType().GetProperties();
System.Reflection.PropertyInfo[] ddProperties = dacOptions.GetType().GetProperties();