ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Updating DacFx.Projects to bring in UpdateSqlCmdVariable fix (#2045)

Browse Source 
* checkpoint

* typo

* removing old nuget
This commit is contained in:
Benjin Dubishar
2023-05-08 11:06:35 -07:00
committed by GitHub
parent bd1fc0997d
commit b9d6657886
4 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Packages.props
View File

@@ -23,7 +23,7 @@
<PackageReference Update="Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider" Version="1.1.1" />
<PackageReference Update="Microsoft.SqlServer.Management.SmoMetadataProvider" Version="170.12.0" />
<PackageReference Update="Microsoft.SqlServer.DacFx" Version="162.0.34-preview" />
<PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="162.1.3-alpha" />
<PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="162.1.6-alpha" />
<PackageReference Update="Microsoft.Azure.Kusto.Data" Version="9.0.4" />
<PackageReference Update="Microsoft.Azure.Kusto.Language" Version="9.0.4" />
<PackageReference Update="Microsoft.SqlServer.Assessment" Version="[1.1.17]" />

BIN
bin/nuget/Microsoft.SqlServer.DacFx.Projects.162.1.3-alpha.nupkg
View File

Binary file not shown.

BIN
bin/nuget/Microsoft.SqlServer.DacFx.Projects.162.1.6-alpha.nupkg Normal file
View File

Binary file not shown.

5
src/Microsoft.SqlTools.ServiceLayer/SqlProjects/SqlProjectsService.cs
View File

@@ -531,9 +531,8 @@ namespace Microsoft.SqlTools.ServiceLayer.SqlProjects
{
await RunWithErrorHandling(() =>
{
SqlProject project = GetProject(requestParams.ProjectUri, onlyLoadProperties: true);
project.SqlCmdVariables.Delete(requestParams.Name); // idempotent (won't throw if doesn't exist)
project.SqlCmdVariables.Add(new SqlCmdVariable(requestParams.Name, requestParams.DefaultValue));
SqlProject project = GetProject(requestParams.ProjectUri!, onlyLoadProperties: true);
project.SqlCmdVariables.Update(requestParams.Name, requestParams.DefaultValue); // won't throw if doesn't exist
}, requestContext);
}