100 Commits
Author SHA1 Message Date
Karl Burtram 5954bdc65c Query logins on system database for Azure connections (#2038)
* Query logins on system database for Azure connections

* Fix name of connection variable
2023-05-02 12:46:18 -07:00
Karl Burtram ccad4e1f8f Remove extra connection in User dialog (#2033)
* Remove extra connection in User dialog

* Remove a couple unneeded queries
2023-04-27 09:03:18 -07:00
Karl Burtram 175f530403 Fix user default language handling (#2029) 2023-04-22 08:38:51 -07:00
Karl Burtram 96c4b82ab5 Fix scripting of users on SQL DB (#2014)
* Fix scripting of users on SQL DB

* Minor typos

* Add null checks
2023-04-19 08:36:38 -07:00
Karl Burtram 54bd06ef98 Prepopulate server roles in Login dialog (#2011) 2023-04-17 16:11:49 -07:00
Karl Burtram 4614795f19 Add support for AAD contained users in SQL DB (#2005) 2023-04-14 17:02:00 -07:00
Karl Burtram 78136e53dd Enable scripting for Logins (#2003)
* Add a LoginActions class

* Enable scripting for Login
2023-04-13 18:20:53 -07:00
Karl Burtram 948ae3903e Support scripting for Users (#2002)
* WIP 1

* WIP2

* Fix merge break

* Support alter existing object
2023-04-13 11:52:37 -07:00
Karl Burtram 83b58a27a4 Move Login handlers to separate file (#1995)
* Move login handlers

* Move Login handlers to seperate file
2023-04-06 16:07:45 -07:00
Karl Burtram b48f1f2833 Fix exception creating user with no connect access (#1989) 2023-04-04 18:21:28 -07:00
Karl Burtram 539ad243c1 Catch exception when querying sys.logins without permissions (#1984) 2023-04-03 19:27:05 -07:00
Karl Burtram 0b2eb26d45 Fix additional contained user/sqldb bugs (#1983) 2023-04-03 19:26:53 -07:00
Karl Burtram ffcae33b18 Fix 'Contained DB' property check exception on SQL DB (#1979) 2023-04-03 12:02:51 -07:00
Karl Burtram c3444e5cf5 Support creating & editing additional user types (#1962)
* WIP

* Fix contained user password handling

* More user related bug fixes
2023-03-23 18:01:55 -07:00
Karl Burtram a104251885 Enable support for Windows users (#1957)
* WIP

* Update for Windows user
2023-03-21 19:00:11 -07:00
Karl Burtram f59ca1954b Enable user management tests (#1912)
* Enable user management tests

* Fix update user test
2023-03-15 17:52:09 -07:00
Karl Burtram b53ab57abf Only support User with Login users (#1931)
* Only support User with Login users

* Use an alternate implementation
2023-03-09 14:46:37 -08:00
Karl Burtram b424d45902 Apply UI values regardless of add or edit code path (#1926) 2023-03-08 17:38:21 -08:00
Karl Burtram 94becba176 User handler bugs WIP (#1925) 2023-03-08 16:45:46 -08:00
Karl Burtram f055e28bbc Fix updating users in SQL DB (#1924) 2023-03-08 16:30:12 -08:00
Karl Burtram a074b5bf67 Update User edit handlers (#1903)
* WIP

* Update user tests

* WIP updates

* WIP

* Fix several edit use bugs

* Disable failing tests

* minor updates

* Remove unused using
2023-03-06 14:43:38 -08:00
Karl Burtram 3d1c8b91b6 Remove yarn.lock file (#1891) 2023-03-02 15:23:44 -08:00
Karl Burtram 675427c690 User creation handler clean-ups (#1867)
* Wire up init user message

* Send schema list

* Load database roles

* Add create user

* Add a delete user handler and format service file
2023-02-17 08:38:17 -08:00
Karl Burtram 8d428aeb8a Minor follow-ups for user management support classes (#1857) 2023-02-08 18:26:44 -08:00
Karl Burtram 2ef5f0918a User management support classes (#1856)
* WIP

* Fix nullable warnings in UserData class

* WIP2

* WIP

* Refresh database prototype classes

* Fix some typos & merge issues

* WIP

* WIP

* WIP

* Additional updates

* Remove unneded using
2023-02-08 18:02:08 -08:00
Karl Burtram 51892519ef Remove unneccessary nullable directive (#1848) 2023-02-07 16:18:57 -08:00
Karl Burtram f288bee294 Make nullable warnings a per file opt-in (#1842)
* Make nullable warnings a per file opt-in

* Remove unneeded compiler directives

* Remove compiler directive for User Data
2023-02-03 18:10:07 -08:00
Karl Burtram 735517a503 Fix nullable warnings in UserData class (#1843)
* Fix nullable warnings in UserData class

* Missing commit
2023-02-03 09:51:31 -08:00
Karl Burtram 7110b1b39b Update fake password for credscan (#1839) 2023-02-01 11:04:15 -08:00
Karl Burtram 3c25549986 Initial WIP code for user management (#1838)
* Initial user management code

* WIP

* Fix whitespace

* WIP user objects

* WIP user objects

* Cleanup ported code

* WIP

* WIP

* Update the User contracts

* Additional cleanups

* Remove warning silencing which isn't intended for this PR

* Fix some warnings as error in CI
2023-01-31 21:12:53 -08:00
Karl Burtram fd82d5bc17 Fix warning during "dotnet restore" (#1822) 2023-01-24 13:54:14 -08:00
Karl Burtram c9f310cb47 Remove InsightsGenerator project (#1764) 2022-12-07 10:56:12 -08:00
Karl Burtram 3a5935df99 Revert "Update to latest .Net SDK 7.0 (#1760)" (#1763)
This reverts commit 71cda5bbdc.
2022-11-15 11:29:41 -08:00
Karl Burtram 71cda5bbdc Update to latest .Net SDK 7.0 (#1760)
* Bump to SDK 7.0 and related updates

* More net 7 updates

* Install SDK 2.0 for ESRP

* Fix typo

* Address comment and update integration test script

* Disable new warnings from SDK update
2022-11-14 20:24:25 -08:00
Karl Burtram 3885c8f680 Revert async dispatcher change 08c74be (#1655)
* Revert 08c74be51f async message handling

* Fix merge error in SetEventHandler
2022-08-29 10:44:26 -07:00
Karl Burtram e6d9163f9d Add nuget package for osx-arm64 (#1555) 2022-06-21 22:52:08 -07:00
Karl Burtram c2a238acb3 Add osx-arm runtime to build (#1545) 2022-06-20 19:30:53 -07:00
Karl Burtram 5fdad0edc8 Add connection retry logic to integration tests (#1523)
* Add retry to live connection

* Disable migration test

* Tune the retry logic

* Disable SQLCMD test
2022-05-27 15:31:33 -07:00
Karl Burtram e86b0bc87f Fix some integration tests (#1516)
* Fix integration test cases

* More test fixes

* Dacfx test fix

* Make master default test db is none specified
2022-05-26 13:08:53 -07:00
Karl Burtram a70402fe60 Revert SMO bump (#1492) 2022-05-11 15:34:15 -07:00
Karl Burtram 853335df72 Revert "graph type logic for node sub type (#1440)" (#1468)
This reverts commit 553b9af36e.
2022-04-21 11:46:55 -07:00
Karl Burtram 3a18cb6fc1 Upgrade to .Net Core 6.0 SDK (#1344)
* Bump to SDK 6.0

* Additional .Net 6.0 changes
2022-01-05 13:14:21 -08:00
Karl Burtram cb290cdbb5 Revert query execution changes (#1341)
* Revert "handle sql variable type (#1333)"

This reverts commit 51c801eb33.

* Revert "handle large decimal (#1326)"

This reverts commit fd5b8af0c0.
2021-12-15 11:15:11 -08:00
Karl Burtram 5d5debbad6 Enable scripting for subobjects such as triggers (#1237)
* WIP 1

* Cleanups

* Change how schema is appended in to urn

* Add comment and fix incorrect condition

* Add parent type name to support Views, etc.
2021-08-26 13:06:15 -07:00
Karl Burtram 63aa6758e8 Fix OE with dbpool connection (#1197)
* Fix OE with dbpool connection

* Remove extra whitespace

* Remove hard-coded number
2021-05-05 14:24:45 -07:00
Karl Burtram 6a45865f3a Bump SMO and SqlClient driver (#1196) 2021-04-27 13:19:21 -07:00
Karl Burtram ccf95aed77 Move unused forked code to external directory (#1192)
* Move unused forked code to external directory

* Fix SLN build errors

* Add back resource provider core since it's referenced by main resource provider project

* Update PackageProjects step of pipeline
2021-04-16 15:33:35 -07:00
Karl Burtram 6fe715d2d8 Do not update the DB name when connecting to DB pool (#1186)
* Do not update the DB name when connecting to DB pool

* Fix typo in the connection service
2021-04-15 14:48:02 -07:00
Karl Burtram 6b2de9c5bd Bump SDK to latest 3.1 revision (#1172) 2021-03-08 15:22:59 -08:00
Karl Burtram dc34f63969 Revert "Update version of sqlclient in Package props file. (#1142)" (#1162)
This reverts commit 97d7547feb.
2021-02-23 12:56:01 -08:00
Karl Burtram 9fc5dfa647 Add thirdpartynotices.txt file to package (#1152)
* Add thirdpartynotices.txt file to package

* Update Notice.txt file per feedback
2021-01-29 11:46:58 -08:00
Karl Burtram df595ab425 Bump SDK version (#1151) 2021-01-28 19:01:39 -08:00
Karl Burtram 83da69c063 Revert "Update SqlClient to 2.1.0 (#1124)" (#1137)
This reverts commit 4f42b17226.
2020-12-10 10:41:28 -08:00
Karl Burtram 7ea825c453 Update name in license.text (#1135) 2020-12-07 10:46:28 -08:00
Karl Burtram b2736e5e33 Remove unneeded SqlClient patch files (#1111) 2020-11-09 14:40:02 -08:00
Karl Burtram b9e1618260 Revert "Rollback migration changes" (#1099)
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"

This reverts commit e96c0064ad.

* Move SQL Tools Service last in Main project list
2020-10-16 16:29:22 -07:00
Karl Burtram 1a0388c8cb Initial migration service changes for assessment support (#1093)
* Migration service WIP 1

* Assessment DLLs

* WIP

* WIP 2

* Add migration nuget package

* WIP2

* Fix up assessment handler

* WIP

* Fix build scripts

* WIP

* Update Assessment references

* Fix metadata copy to work with publish
2020-10-13 11:02:29 -07:00
Karl Burtram 479e5242ff Wrong parameter usage in serialization (#1065) 2020-09-04 10:09:37 -07:00
Karl Burtram 3393e31f55 Remove kustoservicelayer from SQL Tools Service load (#1068) 2020-09-04 10:09:15 -07:00
+1 5cf5b59a0d Insights generator project (#1066)
* InsightsGenerator project template files

* Add insights projects to SLN

* Setting up siggen class (#1003)

* Setting up siggen class

* fixed the learn method

* Refactoring code
Fixed compile errors

* renamed results to result

* Basic transformation logic (#1004)

* Fix a couple bugs and add a simple test (#1007)

* Fix a couple bugs and add a simple test

* More tests and bug fix

* Nara/workflow (#1006)

* added a queue processor

* ordered  using statements

* Armemon/analytics (#1008)

* Basic transformation logic

* changed some structure of siggen

* added sum and average method, as well as select rows by input name

* add insights to results

* min, max added

Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>

* Added rules engine base implementation (#1005)

* Added rules engine base implementation

* update comments

* addressing comments

* adding template text to columnheaders object

* adding template text to columnheaders object

* fixing columnheaders class

* Added test

* Added Template Parser unit test in Test project

* Deleted unnecessary files and reverted the files that were modified by mistake

Co-authored-by: Jinjing Arima <jiarima@microsoft.com>

* Insights generator message handler placeholder (#1013)

* Aasim/insights/insight methods (#1014)

* Basic transformation logic

* changed some structure of siggen

* Added top and bottom insight functions

* Added top, bottom insights
Added tests for top, bottom insights

* Armemon/insights2 (#1011)

* max and min insightsperslice, and tests

* got rid of unneccesssary function

* get indexes

Co-authored-by: Arslan Memon <armemon@microsoft.com>

* Armemon/insights2 (#1012)

* max and min insightsperslice, and tests

* got rid of unneccesssary function

* get indexes

* learn for stringinputtyype

* add learn implentation

Co-authored-by: Arslan Memon <armemon@microsoft.com>

* Added Tests
Removed duplicate methods

Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: arslan9955 <53170027+arslan9955@users.noreply.github.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>

* Armemon/insights2 (#1016)

* Basic transformation logic

* changed some structure of siggen

* Added top and bottom insight functions

* Added top, bottom insights
Added tests for top, bottom insights

* max and min insightsperslice, and tests

* got rid of unneccesssary function

* get indexes

* learn for stringinputtyype

* add learn implentation

* add unique inputs

* fix merge error

* add to result

Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>

* Added all the templates (#1015)

* Added all the templates
Added a method to find matched template

* Added a function to replace # and ## values in a template

* Added ReplaceHashesInTemplate call

* Added comments

* Updated the template txt

* Updated GetTopHeadersWithHash function to add #toplist

* Updated the logic per offline discussion with Hermineh

* Update request handler contract to take array (#1020)

* added rulesengine findmatchingtemplate (#1019)

* Add support for getting DacFx deploy options from a publish profile (#995)

* add support for getting options from a publish profile

* update comments

* set values for default options if they aren't specified in the publish profile

* addressing comments

* Updating to latest DacFx for a bug fix (#1010)

* added rulesengine findmatchingtemplate

* Update DacFx deploy and generate script with options (#998)

* update deploy and generate script to accept deployment options

* add tests

* add test with option set to true

* merge

* merge

* incorporated FindMatchedTemplate

Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>

* -Added logic for Insights Generator Service Handler (#1017)

* -Added logic for Insights Generator Service Handler

* Fixed some logic

* Adding workflow test

* Update transform and add tests (#1024)

* Jiarima/fix rules engine logic (#1021)

* Added all the templates
Added a method to find matched template

* Added a function to replace # and ## values in a template

* Added ReplaceHashesInTemplate call

* Added comments

* Updated the template txt

* Updated GetTopHeadersWithHash function to add #toplist

* Updated the logic per offline discussion with Hermineh

* Update with the fixes

* Updated template and foreach conditions

* Added distinct

* Updated tests according to the logic change (#1026)

* Nara/remove queing (#1023)

* loc update (#914)

* loc update

* loc updates

* Add support for getting DacFx deploy options from a publish profile (#995)

* add support for getting options from a publish profile

* update comments

* set values for default options if they aren't specified in the publish profile

* addressing comments

* Updating to latest DacFx for a bug fix (#1010)

* Update DacFx deploy and generate script with options (#998)

* update deploy and generate script to accept deployment options

* add tests

* add test with option set to true

* intermediate check in for merge, transformed not working

* intermediate check in for merge, transformed not working

* added test case

* merged

Co-authored-by: khoiph1 <khoiph@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>

* Output data types from transform (#1029)

* Fix bug process input_g (#1030)

* Fixed the insight generator service (#1028)

* Jiarima/added more testings (#1031)

* Added another test
Updated ReplaceHashesInTemplate function to return string instead of Template

* Added third test

* Merged

* Reverted the workflow file to match with the one in hack/insights

* Bugs fixes to hook insights up to ADS (#1033)

* Bug fixes for hack insights (#1032)

* Fixed the minColumn index bug in Data Transformation
Fixed the template matching logic.

* Adding changes from PR

* Try to fix Workflow tests

* Readd workflow tests

* Fix template load location

Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Nara <NaraVen@users.noreply.github.com>
Co-authored-by: arslan9955 <53170027+arslan9955@users.noreply.github.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>
Co-authored-by: gadudhbh <68879970+gadudhbh@users.noreply.github.com>
Co-authored-by: Jinjing Arima <jiarima@microsoft.com>
Co-authored-by: jiarima <68882862+jiarima@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: khoiph1 <khoiph@microsoft.com>
2020-09-03 14:15:51 -07:00
Karl Burtram 35878fbc24 Switch pdb type back to portable (#1042) 2020-08-09 19:45:27 -07:00
Karl Burtram 0014687343 Update SDK to latest version (#1002) 2020-07-24 10:06:59 -07:00
Karl Burtram 3106240cbd Bump version to fix release script (#982)
* Bump version to fix release script

* Fix typo
2020-06-15 19:17:23 -07:00
Karl Burtram 5ad23552b4 Remove SQL Client patch from build (#977) 2020-06-15 10:40:59 -07:00
Karl Burtram 28e479f239 Bump to latest .Net Core SDK 3.1.301 (#974) 2020-06-12 12:58:38 -07:00
Karl Burtram e8e699dbd8 Revert "-Removed forced master condition (#957)" (#972)
This reverts commit 69b93a05f2.
2020-06-09 13:42:29 -07:00
Karl Burtram 4f749c73cc Use InvariantCulture for log path (#896) 2019-11-26 13:41:45 -08:00
Karl Burtram 427f0c11e8 Bump SMO and SqlClient to pickup Microsoft.Data.SqlClient fixes (#894)
* Revert "Revert to SMO with older SQLClient driver (#889)"

This reverts commit b763abae47.

* Bump SMO and SqlClient
2019-11-22 17:17:21 -08:00
Karl Burtram e9ac5b7ff5 Log early exceptions to console (#893) 2019-11-21 13:00:15 -08:00
Karl Burtram b763abae47 Revert to SMO with older SQLClient driver (#889)
* Revert "Update SMO (#875)"

This reverts commit 96593d66e3.

* Revert "Switch Tools Service to new SMO and Microsoft.Data.SqlClient driver (#865)"

This reverts commit 9d140b53f3.

* Bump SMO to 160.1910315.0-preview
2019-11-04 13:00:45 -08:00
Karl Burtram 43abb8def2 Restrict settings to known values (#821) 2019-06-04 13:27:18 -07:00
Karl Burtram 151a2de625 Query execution settings support (#812)
* WIP

* WIP 3

* WIP 3

* Additional query settings updates

* Add settings tets

* Address code review feeback

* Updates from testing
2019-05-16 15:21:17 -07:00
Karl Burtram e261d77bb8 Fix "Save to CSV" CodePages assembly version mismatch (#790)
* Fix "Save to CSV" CodePages assembly version mismatch

* Add comment to delete packagereference once moving off preview version
2019-03-26 18:34:28 -07:00
Karl Burtram e41b9bcf51 Make "--enable-logging" an ignored option for mssql back-compat (#788) 2019-03-24 17:54:29 -07:00
Karl Burtram eaaff8b8a1 Remove Peek Definition error popup (#786)
* Remove Peek Definition error popup

* Fix broken test case

* Fix bug
2019-03-22 16:52:45 -07:00
Karl Burtram 022282800a Move managed parser into its own project (test code coverage) (#774)
* Created New ManagedBatchParser project in .NetStandard

* Addressing PR Comments

* Resolve 'No Repository' warning.

* Move batch parser tests to integrations test project

* Fix SLN file
2019-02-07 20:13:03 -08:00
Karl Burtram 0fd98df79b Update SqlClient to 4.6.0 (#761) 2019-01-07 16:22:35 -08:00
Karl Burtram a1946edca3 Rebuild SqlClient patch bits for .Net Core 2.2 RTW (#754) 2018-12-04 16:43:41 -08:00
Karl Burtram 27bcb96597 Enable scripting for SQL Server 2019 (#751) 2018-11-29 15:56:06 -08:00
Karl Burtram 7a47db8806 Revert ""I have changed access modifier from Internal to Public . These classes are being refered outside. (#742)" (#747)
This reverts commit a54eff11b6.
2018-11-26 13:03:28 -08:00
Karl Burtram 3c915a92f6 Send a Object Explorer session disconnect message on socket exceptions (#739)
* WIP

* WIP 2

* Send disconnect message o binding exception

* Add a try catch around the binding queue error handler
2018-11-16 12:07:05 -08:00
Karl Burtram 6153279840 Update broken BindingQueue test from previous commit (#725) 2018-10-31 15:24:02 -07:00
Karl Burtram adf10ece87 Wait for queued tasks to complete before processing subsequent tasks (#724) 2018-10-31 09:48:57 -07:00
Karl Burtram df023da0ba Revert "Rollback SMO to latest 14.0 version (#722)" (#723)
This reverts commit 407e9feb40.
2018-10-30 17:20:25 -07:00
Karl Burtram 407e9feb40 Rollback SMO to latest 14.0 version (#722)
* Rollback SMO to latest 14.0 version

* Add back nunit package reference
2018-10-30 12:13:23 -07:00
Karl Burtram 2391759477 Update SqlClient patch to set KeepAlive retry interval to 1 second (#719) 2018-10-26 15:33:31 -07:00
Karl Burtram 2b6eeb19ab Update references to use non preview references (#718) 2018-10-24 17:23:23 -07:00
Karl Burtram 8460ce023d Only reopen connection on exception if it's closed (#717) 2018-10-24 15:55:27 -07:00
Karl Burtram 5ab904dd1c Private KeepAlive .Net Core 2.2 macOS binaries (#716) 2018-10-22 16:44:15 -07:00
Karl Burtram a241a4510b Bump .Net Core SDK to 2.2.100 Preview (#715)
* Bump .Net Core SDK to 2.2

* Update travis file

* Try to fix broken AppVeyor code coverage
2018-10-22 15:54:17 -07:00
Karl Burtram 7c1710d396 Reopen connections prior to creating query execution data readers (#704)
* Reopen connections prior to creating query execution data readers

* Reopen connection if an exception was rasied executing the query

* Fix unit tests
2018-10-08 12:41:04 -07:00
Karl Burtram d31ce985ce Check that connection is open in ReliableConnectionHelperTest (#694) 2018-09-25 14:23:29 -07:00
Karl Burtram 066be2f46f Revert "Switch to the unified SMO NuGet" (#686)
* Revert "fixed perf tests and added more scenarios (#683)"

This reverts commit aa2b30f486.

* Revert "Switch to the unified SMO NuGet so all binaries are strong named and signed. (#682)"

This reverts commit 69961992bb.
2018-09-04 11:01:44 -07:00
Karl Burtram 4ac02eab01 Add back XEventDBScopedEnum to fix Profiler in Azure (#674) 2018-08-03 03:16:09 -04:00
Karl Burtram e8360ef68e Remove unneeded checked in Nuget package (#673) 2018-08-01 20:43:11 -04:00
Karl Burtram 290b242015 Add back missing XEventEnum dependency (#672) 2018-08-01 20:35:10 -04:00
Karl Burtram 38cf5414ce Add IncludePassword parameter to Get Connection String request (#670)
* Add IncludePassword flag to get connection string method

* Override connection application name

* Fix typo

* Fix test break

* Use ****** as password placeholder
2018-08-01 15:16:01 -04:00
Karl Burtram 7c96ceb501 Get Connection String request handler (#665) 2018-07-25 15:03:00 -04:00
Karl Burtram a6721bfae5 Fix null ref creating Agent Job with no description (#659) 2018-07-17 18:03:59 -07:00
Karl Burtram b8c31e1138 Fix Agent Job rename (#657) 2018-07-16 13:18:47 -07:00