In this PR, we make the appropriate backend service changes in order to enable the login migrations feature in the SQL migration extension.
Changes include:
updating the Microsoft.SqlServer.Migration.Login NuGet version to the latest version
adding a new request handler for StartLoginMigrations calls, which makes the appropriate calls to the login NuGet
adding ExtensionMethod helper to properly combine exception maps login migration nuget calls
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP - update NuGet and add xevent assessment request
* Update API
* Update nupkg to official build
* Add try/catch around individual recommendation models
* Clean up
* Add HS to SQL DB SKU recommendation input
* Update NuGet version and remove metadata
* Remove Content Include from csproj
* Remove unnecessary PrivateAssets tag
* Use official NuGet build
* Remove reference in IntegrationTests
* Include Object Types are getting from DacFx
* All tests are passing now with excludObjectType casting
* Test fix with new ExccvludeObjectType change
* Added test case for the include objects types
* Updated name to objectTypesDictionary and objectType getName from Display attribute
* code Review updates
* Removing Exclude word logic here as the options were updated on DacFx
* updating the null check
* DacFx vBump
* code updates according to review comments
* enable table designer for sqlproj
* return issues and new table info on initialization
* vbump dacfx
* Revert "vbump dacfx"
This reverts commit f59768b41f67866bd7620e06b141e8bfdb1523aa.
* Update assessment NuGet version and metadata
* Consider Eb VM SKUs without preview flag as they are now GAed
* Update assessment NuGet to 1.0.20220527.33
* Enabled backup to and restore from URL
* Created RPC, but when process tries to load Microsoft.Azure.Storage.Blob.dll, it crashes
* Added create shared access token
* Code refactor
* Minor changes
* Changed RPC path
* Moved createSas RPC to the newly created BlobService, fixed PR comments
* Added sas expiration date parameter to the RPC
* Added copyright headers
* Removed ConnectionInstance property from BlobService
* Removed unhelpful comment
* Removed unused using statements
* Changed copy/paste comments
* Disposable objects fix
* Small formatting fix
* Changed backup to/restore from url supported device types
* Added backup to url integration test
* Created restore integration test. Test are now getting azure blob params from env variables instead of file.
* Culture invariant epiration date param, fixed comment, and typo
* Updated headers
* PR comments fix
* Changed supported device type logic
* string localization fix
* String formatting fix
* build failure fix
* Typo
* Updated supported restore device types
* add AdvancedType related contract & lib call
* use type list from col
* add description support to all view models
* remove desc for edge constraint
* bump DacFx to 160.6093.0-preview
* nit
Updated the E-series VM IOPS, throughput capability based on ms doc as rest endpoint giving very low number on throughput particularly.
Updated only for SKUs with local disk.
Haven't checked if D-series has similar problem, however it wouldn't cause problem as we are not showing any Dev-test recommendation for ADS.
Note : Mostly, any other mismatches wouldn't be relevant for prod recommendations.
msdoc reference : https://docs.microsoft.com/en-us/azure/virtual-machines/edv5-edsv5-series
* Initial check in for SQL migration SKU recommendation feature (#1362)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* Integration test for Get SKU Recommendation. (#1377)
* Integration test for Get SKU Recommendation.
* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.
* Implement start/stop perf data collection (#1369)
* Add SqlInstanceRequirements to SKU recommendation output (#1378)
* test for data collection start and stop (#1395)
* improve error handling, add RefreshPerfDataCollection (#1393)
* WIP - refresh data collection
* Capture messages before logging
* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)
* Update NuGet version to 1.0.20220208.23, update assessment metadata
* Update SKU recommendation metadata
* Include preview SKUs
* Clear message/error queue after refreshing
* Clean up
* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
