Commit Graph

3 Commits

Author SHA1 Message Date
Raymond Truong
0c37dc50f9 [SQL Migration] Update assessment NuGet version + mark GAed VM SKUs as non-preview (#1510)
* Update assessment NuGet version and metadata

* Consider Eb VM SKUs without preview flag as they are now GAed

* Update assessment NuGet to 1.0.20220527.33
2022-05-31 14:54:29 -07:00
Neetu Singh
d704a84740 Update Assessment package. Change Description from PR - https://msdata.visualstudio.com/Database%20Systems/_git/sql-migrate-asmt/pullrequest/747674 (#1407)
Updated the E-series VM IOPS, throughput capability based on ms doc as rest endpoint giving very low number on throughput particularly.

Updated only for SKUs with local disk.
Haven't checked if D-series has similar problem, however it wouldn't cause problem as we are not showing any Dev-test recommendation for ADS.
Note : Mostly, any other mismatches wouldn't be relevant for prod recommendations.
msdoc reference : https://docs.microsoft.com/en-us/azure/virtual-machines/edv5-edsv5-series
2022-02-11 17:31:38 -08:00
Raymond Truong
1693843ab0 [Feature] SKU recommendations in SQL migration extension (#1399)
* Initial check in for SQL migration SKU recommendation feature (#1362)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* Integration test for Get SKU Recommendation. (#1377)

* Integration test for Get SKU Recommendation.

* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.

* Implement start/stop perf data collection (#1369)

* Add SqlInstanceRequirements to SKU recommendation output (#1378)

* test for data collection start and stop (#1395)

* improve error handling, add RefreshPerfDataCollection  (#1393)

* WIP - refresh data collection

* Capture messages before logging

* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)

* Update NuGet version to 1.0.20220208.23, update assessment metadata

* Update SKU recommendation metadata

* Include preview SKUs

* Clear message/error queue after refreshing

* Clean up

* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)

Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-10 19:02:27 -08:00