Commit Graph
11 Commits
Author SHA1 Message Date
Connor Quagliana 6f8fc51d6f Add comment explaining ObjectDisposedException 2017-02-15 16:25:59 -08:00
Connor Quagliana b63db9cb39 Wait unit after query executes to change database (#222)
Change logic for database change so OnInfoMessage does not get called until after the query execution is complete. This prevents multiple calls to open a single DataReader.
2017-02-03 13:49:48 -08:00
Connor Quagliana c055c459a0 Update connection logic to handle multiple connections per URI (#176)
* Add CancelTokenKey for uniquely identifying cancelations of Connections associated with an OwnerUri and ConnectionType string.

* Update ConnectionInfo to use ConcurrentDictionary of DbConnection instances. Add wrapper functions for the ConcurrentDictionary. 

* Refactor Connect and Disconnect in ConnectionService.

* Update ConnectionService: Handle multiple connections per ConnectionInfo. Handle cancelation tokens uniquely identified with CancelTokenKey. Add GetOrOpenConnection() for other services to request an existing or create a new DbConnection.

* Add ConnectionType.cs for ConnectionType strings.

* Add ConnectionType string to ConnectParams, ConnectionCompleteNotification, DisconnectParams.

* Update Query ExecuteInternal to use the dedicated query connection and GetOrOpenConnection().

* Update test library to account for multiple connections in ConnectionInfo.

* Write tests ensuring multiple connections don’t create redundant data.

* Write tests ensuring database changes affect all connections of a given ConnectionInfo.

* Write tests for TRANSACTION statements and temp tables.
2017-01-18 17:59:41 -08:00
Connor Quagliana 3ad7cc1a8b Move Integration Tests to dedicated project (#201)
Add IntegrationTests project. Move all tests ifdef'd with LIVE_CONNECTION_TESTS to IntegrationTests project. Delete files that have no remaining code. Update codecoverage.bat to run integration tests
2017-01-04 11:37:57 -08:00
Connor Quagliana ba12a80fbf Add fix for SendEvent causing test to fail (#195)
Add flag in ServiceHost to ignore SendEvent errors
2016-12-19 14:01:03 -08:00
Connor Quagliana 319c5ef7ed Merge pull request #193 from Microsoft/bug/addGetSignatureHelpTest
Add positive test for GetSignatureHelp
2016-12-16 11:08:34 -08:00
Connor Quagliana 2db585ad63 Removed #define 2016-12-15 13:46:25 -08:00
Connor Quagliana b5cd9d6359 Changed line parameter to zero-indexed 2016-12-15 13:45:29 -08:00
Connor Quagliana d5de4c8b21 Merge branch 'dev' into bug/addGetSignatureHelpTest 2016-12-15 12:01:00 -08:00
Connor Quagliana 2f1debc7c9 Added positive test for GetSignatureHelp 2016-12-15 11:40:10 -08:00
Connor Quagliana 40c1434745 Fixed null ref exception in GetSignatureHelp (#175)
- Fixed a few places where ScriptParseInfo was being used before it was verified to be non-null
- Added 1 basic test for GetSignatureHelp scenario
2016-12-09 15:18:08 -08:00