* getting table name from a script
* add InsertSqlInputBindingOperation
* cleanup
* move azure functions stuff out of dacfx service
* cleanup
* add tests
* add another test
* cleanup
* add comments and connection string setting
* addressing comments
* change name to use add instead of insert
* added other languages to ServiceLayer
* fixed travis and appveyor yaml, added other languages for localization
* added spanish and german strings to credentialslocalization, also WIP for coreservices test
* added WIP localization test for CoreServices
* Removed unit test for coreservices, need to work on those later.
* restored travis and appveyor
* added kusto string resource localization test
* added localization test and locale change for SqlToolsCredentials
* added locale command options to ResourceProvider
* revert resourceprovider test
* Localized SqlTools.Credentials
* added hosting localization
* replaced new with translation to be consistent with main service layer
* reverted external changes as it is unnecessary
* Translated ManagedBatchParser
* test culture value
* test culture change
* temporarily comment out service layer command options
* returned sr.cs
* temporarily remove bad tests
* restored tests and allowed for SR culture to change for dependencies (for future testing)
* localization for resourceprovider components added.
* Set LocaleSetter to public and also removed InternalsVisible for Kusto, Credentials and ResourceProvider
* removed unnecessary changes
* Removed CredentialsCommandOptions
* renamed pt-BR to pt-br
* Rename sr.pt-BR.xlf.template to sr.pt-br.xlf.template
* Rename src/Microsoft.SqlTools.ServiceLayer/Localization/LCL/pt-BR/sr.resx.lcl to src/Microsoft.SqlTools.ServiceLayer/Localization/LCL/pt-br/sr.resx.lcl
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* Rename sr.pt-BR.xlf to sr.pt-br.xlf
* Rename sr.pt-BR.resx to sr.pt-br.resx
* restored newlines
* Update sr.pt-br.xlf.template
Removed newline
* removed newline
* fixing newlines for consistency
* removed unnecessary newline
* checkpoint
* Not having cake, nor eating it
* Working
* Swapping external dll for nupkg
* Extracting statement out of full TSQL
* Improving error message
* Fixing filename capitalization
* Reverting csproj changes
* Adding updated sr.cs file
* VS lost tracking on strings file?
* PR feedback
* resx additions
* More updated string files
* Swapped nuget for dll
* Revert "Swapped nuget for dll"
This reverts commit 6013f3fadf58ebc7e3590a46811d9fd9fc3eaa4a.
* Bumped netcore version to pull in support for extern aliasing nugets
* InsightsGenerator project template files
* Add insights projects to SLN
* Setting up siggen class (#1003)
* Setting up siggen class
* fixed the learn method
* Refactoring code
Fixed compile errors
* renamed results to result
* Basic transformation logic (#1004)
* Fix a couple bugs and add a simple test (#1007)
* Fix a couple bugs and add a simple test
* More tests and bug fix
* Nara/workflow (#1006)
* added a queue processor
* ordered using statements
* Armemon/analytics (#1008)
* Basic transformation logic
* changed some structure of siggen
* added sum and average method, as well as select rows by input name
* add insights to results
* min, max added
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>
* Added rules engine base implementation (#1005)
* Added rules engine base implementation
* update comments
* addressing comments
* adding template text to columnheaders object
* adding template text to columnheaders object
* fixing columnheaders class
* Added test
* Added Template Parser unit test in Test project
* Deleted unnecessary files and reverted the files that were modified by mistake
Co-authored-by: Jinjing Arima <jiarima@microsoft.com>
* Insights generator message handler placeholder (#1013)
* Aasim/insights/insight methods (#1014)
* Basic transformation logic
* changed some structure of siggen
* Added top and bottom insight functions
* Added top, bottom insights
Added tests for top, bottom insights
* Armemon/insights2 (#1011)
* max and min insightsperslice, and tests
* got rid of unneccesssary function
* get indexes
Co-authored-by: Arslan Memon <armemon@microsoft.com>
* Armemon/insights2 (#1012)
* max and min insightsperslice, and tests
* got rid of unneccesssary function
* get indexes
* learn for stringinputtyype
* add learn implentation
Co-authored-by: Arslan Memon <armemon@microsoft.com>
* Added Tests
Removed duplicate methods
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: arslan9955 <53170027+arslan9955@users.noreply.github.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>
* Armemon/insights2 (#1016)
* Basic transformation logic
* changed some structure of siggen
* Added top and bottom insight functions
* Added top, bottom insights
Added tests for top, bottom insights
* max and min insightsperslice, and tests
* got rid of unneccesssary function
* get indexes
* learn for stringinputtyype
* add learn implentation
* add unique inputs
* fix merge error
* add to result
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>
* Added all the templates (#1015)
* Added all the templates
Added a method to find matched template
* Added a function to replace # and ## values in a template
* Added ReplaceHashesInTemplate call
* Added comments
* Updated the template txt
* Updated GetTopHeadersWithHash function to add #toplist
* Updated the logic per offline discussion with Hermineh
* Update request handler contract to take array (#1020)
* added rulesengine findmatchingtemplate (#1019)
* Add support for getting DacFx deploy options from a publish profile (#995)
* add support for getting options from a publish profile
* update comments
* set values for default options if they aren't specified in the publish profile
* addressing comments
* Updating to latest DacFx for a bug fix (#1010)
* added rulesengine findmatchingtemplate
* Update DacFx deploy and generate script with options (#998)
* update deploy and generate script to accept deployment options
* add tests
* add test with option set to true
* merge
* merge
* incorporated FindMatchedTemplate
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
* -Added logic for Insights Generator Service Handler (#1017)
* -Added logic for Insights Generator Service Handler
* Fixed some logic
* Adding workflow test
* Update transform and add tests (#1024)
* Jiarima/fix rules engine logic (#1021)
* Added all the templates
Added a method to find matched template
* Added a function to replace # and ## values in a template
* Added ReplaceHashesInTemplate call
* Added comments
* Updated the template txt
* Updated GetTopHeadersWithHash function to add #toplist
* Updated the logic per offline discussion with Hermineh
* Update with the fixes
* Updated template and foreach conditions
* Added distinct
* Updated tests according to the logic change (#1026)
* Nara/remove queing (#1023)
* loc update (#914)
* loc update
* loc updates
* Add support for getting DacFx deploy options from a publish profile (#995)
* add support for getting options from a publish profile
* update comments
* set values for default options if they aren't specified in the publish profile
* addressing comments
* Updating to latest DacFx for a bug fix (#1010)
* Update DacFx deploy and generate script with options (#998)
* update deploy and generate script to accept deployment options
* add tests
* add test with option set to true
* intermediate check in for merge, transformed not working
* intermediate check in for merge, transformed not working
* added test case
* merged
Co-authored-by: khoiph1 <khoiph@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
* Output data types from transform (#1029)
* Fix bug process input_g (#1030)
* Fixed the insight generator service (#1028)
* Jiarima/added more testings (#1031)
* Added another test
Updated ReplaceHashesInTemplate function to return string instead of Template
* Added third test
* Merged
* Reverted the workflow file to match with the one in hack/insights
* Bugs fixes to hook insights up to ADS (#1033)
* Bug fixes for hack insights (#1032)
* Fixed the minColumn index bug in Data Transformation
Fixed the template matching logic.
* Adding changes from PR
* Try to fix Workflow tests
* Readd workflow tests
* Fix template load location
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Nara <NaraVen@users.noreply.github.com>
Co-authored-by: arslan9955 <53170027+arslan9955@users.noreply.github.com>
Co-authored-by: Arslan Memon <armemon@microsoft.com>
Co-authored-by: gadudhbh <68879970+gadudhbh@users.noreply.github.com>
Co-authored-by: Jinjing Arima <jiarima@microsoft.com>
Co-authored-by: jiarima <68882862+jiarima@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: khoiph1 <khoiph@microsoft.com>
[SQL Assessment API](https://docs.microsoft.com/en-us/sql/sql-assessment-api/sql-assessment-api-overview) provides a mechanism to evaluate the configuration
of SQL Server for best practices. SQL Assessment API gives a list
of recommended actions to improve SQL Server performance or security.
The SQL Assessment service is used by the expected SQL Assessment
feature of Azure Data Studio.
SqlAssessmentService forwards JSONRPC calls to SQL Assessment engine
and wraps results as a response.
`assessment/getAssessmentItems` returns a set of checks
applicable to a given target.
`assessment/invoke` returns a set of recommendations
for improving SQL Server instance or database configurations.
`assessment/generateScript` returns a T-SQL script for storing
an assessment result set to a SQL data table.
* Enable the enclave connection parameters.
* Update the switch statement to use the enum constants for EnclaveAttestationProtocol
* Update verbiage for Always Encrypted connection options
* Update the argument exception to chose one specific to this connection option
* Add resource logic to resource files.
* Add error checking for when enclave parameters are added and Always Encrypted is set to disabled.
* Add/Update unit tests
* Initial Investigation
* Working code with include, connect, on error and tests
* Adding some loc strings
* Some cleanup and more tests
* Some dummy change to trigger build
* Adding PR comments
* Addressing PR comments
* Hotfix for ads dashboard for sqlondemand
* Generalizing engine edition functions and adapting tests
* Minor comment and cosmetic fixes
* Adding SqlOnDemand server edition string
Added a method that handles serialization requests
Support splitting save over multiple requests to reduce overall message size
Added unit tests
String changes used a new version of the string tool for generation.
Will publish PR separately for the changes to build & localization
so this can run on Mac without .Net Core 1.0
* initial open scmp changes
* more open scmp changes and adding tests
* moving some common test code
* simplify endpoint info parsing
* addressing comments and moving more common test code
* addressing comments
* Initial code for Including/Excluding individual changes (no tests added yet)
* Adding Exclude include tests. Default options call and additional options tests.
* Taking PR comments
* Retry in test for reliability
* Agent Proxy account WIP
* Fixup Credential create\update\delete handlers
* Use current user for test credential
* Cleanup and delete code
* Convert tabs to spaces
* Additional SQL Agent config classes (WIP)
* Fix build breaks
* Clean up job step code
* Add VS Code build files
* Move changes to other machine
* More of the action execution classes
* More execution processing refactors
* More refactoring
* Disable tests for WIP merge
* Fix break on Release config
* Stage changes to other machine.
* Initial non-refactored SQL Agent alert classes (WIP)
* Move agent classes into subdirectories
* Refactor the agent config code a bit more
* Add more implementation for handlers
* Add more code to the create alert handler
* Clean up agent alert class
* Clean up alert methods a bit
* Initial Operator contracts
* Additonal SQL Agent config changes
* More Proxy config cleanup
* Cleanup AgentProxy class
* Additional cleanups
* Run SRGen
* Add security service to create credential objects
* Differentiate External and FileTable types in object explorer list
- Add (External) and (File Table) to the labels
- Pre-fetch these properties to avoid perf hit
Note on testing: These are both quite hard to initialize, so adding tests to the integration tests would require always having a server with Polybase enabled / FileTable enabled. Given this I feel it should be OK to use manual testing. Long term, we should have unit-level tests that cover the functionality or figure out how to have a perfect pre-configured server and a set of tests to run the breadth of this logic against it.
* Fix handling of vNext servers to default to latest known version
- Default uplevel / unknown versions to the latest version
- In the IsValidFor check also just see if the server version registers as "All" since this is the default for unknown servers. This is a backup handler, the 1st fix is the primary one
* Refactoring sql script formatting helpers into To and From helpers
* Updates to make error messages for formatting errors more useful
* Fixing dumb breaks in unit tests
* Addressing comments from PR
* Updates to the SR files...
* WIP
* All the new RowCreate tests are working
* Fixing a couple bugs with the row delete and row update tests
* Regenerating localization files
* Fixing multiple iteration in tests
