Commit Graph

1146 Commits

Author SHA1 Message Date
Charles Gagnon
978a2cb525 Fix nunit package reference (#1120)
* Fix nunit package reference

* update more packages

* Fix casing
2020-11-11 13:31:03 -08:00
Charles Gagnon
9aea96ccaa Update pipeline job names (#1119)
* debug

* cd

* undo debug
2020-11-10 13:58:07 -08:00
Karl Burtram
b2736e5e33 Remove unneeded SqlClient patch files (#1111) 2020-11-09 14:40:02 -08:00
Charles Gagnon
87cd2ecdad Remove schedule from pipeline (#1118)
* Remove schedule from pipeline

* remove value completely
2020-11-09 12:55:25 -08:00
Charles Gagnon
aa4f4b3fdd Create combined build and release pipelines (#1117)
* Combine build and release pipelines

* remove

* remove another
2020-11-09 11:07:22 -08:00
Charles Gagnon
455d3bc975 Update release pipeline to validate build artifacts hash against current source hash (#1116)
* initial

* update password and checkout

* fix param

* pull

* print

* cd

* use build secret

* older build

* Use env var

* use old secret

* use env var

* remove debug

* remove unused secret
2020-11-06 17:42:30 -08:00
Aleksei Guzev
11960fd904 Fix handling some SQL Assessment warnings (#1114)
* Some new SQL Assessment warnings may have Check property set to null. Handle the warnings with no exception.
* Make names of SQL Assessment test methods more informative.
2020-11-04 22:13:46 +03:00
Justin M
954df47ec9 13159 Kusto Aria Fix (#1112)
* 13159 Changed NodeValue in TreeNode to PrettyName instead of Name. In KustoDataSource, changed Exists to run different query for Aria. Changed GetClusterDiagnostics to return empty DiagnosticsInfo for Aria. Changed SetDatabaseMetadata to not includeSizeDetails for Aria connections.

* 13159 Fixed unit test Refresh_Returns_Children
2020-11-02 15:35:37 -08:00
Benjin Dubishar
65c4fc01aa Adding External Streaming Job I/O validation to DacFxService (#1106)
* checkpoint

* Not having cake, nor eating it

* Working

* Swapping external dll for nupkg

* Extracting statement out of full TSQL

* Improving error message

* Fixing filename capitalization

* Reverting csproj changes

* Adding updated sr.cs file

* VS lost tracking on strings file?

* PR feedback

* resx additions

* More updated string files

* Swapped nuget for dll

* Revert "Swapped nuget for dll"

This reverts commit 6013f3fadf58ebc7e3590a46811d9fd9fc3eaa4a.

* Bumped netcore version to pull in support for extern aliasing nugets
2020-11-02 12:03:14 -08:00
Christopher Suh
d94e691b07 Fix logic for result (#1113)
* commented subscription caching

* added additional code path if user.UniqueId not set

* fixed failing unit tests

* updated logic
2020-11-02 09:44:30 -05:00
Benjin Dubishar
271a0f5733 Updated loc build outputs (#1110) 2020-10-30 14:04:56 -07:00
Christopher Suh
71a98eacf4 Add handling of user.UniqueId if not set (#1109)
* commented subscription caching

* added additional code path if user.UniqueId not set

* fixed failing unit tests
2020-10-30 13:25:07 -04:00
Charles Gagnon
b3bd1f8f99 Revert "Added additional code path if user.UniqueId not set (#1105)" (#1108)
This reverts commit 2354dfc4c7.
2020-10-30 09:17:06 -07:00
BranislavGrbicMDCS
4ce9416219 removing server roles for sql od (#1107) 2020-10-30 08:15:29 -07:00
Christopher Suh
2354dfc4c7 Added additional code path if user.UniqueId not set (#1105)
* commented subscription caching

* added additional code path if user.UniqueId not set
2020-10-29 18:43:19 -04:00
Cory Rivera
8c805a72a9 Add a parent process ID argument to ServiceLayer so that we can exit gracefully if the parent process exits. (#1103) 2020-10-29 13:00:23 -07:00
Benjin Dubishar
563593eba7 Bumping dacfx (#1104) 2020-10-27 16:19:43 -07:00
BranislavGrbicMDCS
3e98a2f17b [brgrbic] SqlOD changes for cloud Server Type and minor bug fixes (#1092)
* The ServerType of SQL OD in SMO is being changed to cloud. This is a minimal set of changes needed in sqltoolservice in order to keep everything working within ADS.

* SMO version update
2020-10-23 18:48:33 +02:00
Monica Gupta
dbfcf4ad61 Fix for queries with comments separated by new lines (#1101)
* Fix for queries with comments separated by new lines

* Mimic Kusto behaviour for comments ran as query

* extra check

* address comment

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-20 13:53:34 -07:00
Charles Gagnon
9b9325b43e Split sql batches into separate code cells for convert (#1100)
* Split sql batches into separate code cells for convert

* remove unneeded sort
2020-10-16 16:31:40 -07:00
Karl Burtram
b9e1618260 Revert "Rollback migration changes" (#1099)
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"

This reverts commit e96c0064ad.

* Move SQL Tools Service last in Main project list
2020-10-16 16:29:22 -07:00
Charles Gagnon
e96c0064ad Revert "Initial migration service changes for assessment support (#1093)" (#1098)
This reverts commit 1a0388c8cb.
2020-10-16 13:35:59 -07:00
Charles Gagnon
b64d5a3146 Fix Notebook Convert namespace (#1097) 2020-10-16 12:27:54 -07:00
Karl Burtram
1a0388c8cb Initial migration service changes for assessment support (#1093)
* Migration service WIP 1

* Assessment DLLs

* WIP

* WIP 2

* Add migration nuget package

* WIP2

* Fix up assessment handler

* WIP

* Fix build scripts

* WIP

* Update Assessment references

* Fix metadata copy to work with publish
2020-10-13 11:02:29 -07:00
Monica Gupta
1ee0c1d09a Make Kusto control commands work (#1094)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-08 17:51:08 -07:00
Justin M
a94ab9d8b4 Changed logic to use database name provided by connectionString (#1091) 2020-10-06 20:45:54 -07:00
Justin M
f2eb590d97 3490 Kusto Connection Refresh Fix (#1085)
* 3490 Injected OwnerUri into KustClient to store for token refreshing. Removed UpdateAzureToken from IDataSource, DataSourceBase, and KustoDataSource. Removed logic for retrying queries related to Unauthorized datasource in Batch and Query. Changed ScriptingService, ScriptingScriptOperation, and ScriptAsScriptingOperation to take DataSource in the constructor instead of datasourcefactory. Changed ScriptingService to inject ConnectionService through InitializeService function.

* 3490 Removed Catch block for DataSourceUnauthorizedException in ExecuteControlCommandAsync

* 3490 Removed OwnerUri from KustoClient and used azureAccountToken to refresh token in ConnectionService.

* 3490 Reverted unneeded changes.

* 3490 Split ExecuteQuery in KustoClient to execute first query then remaining queries after

* 3490 Passed OwnerUri down into KustoClient to refresh token.

* 3490 Removed DataSourceUnauthorizedException. Refactored ExecuteQuery to catch aggregate exception. Added RefreshAzureToken logic to ExecuteControlCommand

* 3490 Added logic to update ReliableDataSourceConnection azure token within ConnectionInfo.

* 3490 Add retry logic to ExecuteQuery and ExecuteControlCommand in KustoClient
2020-10-06 17:20:13 -07:00
Justin M
2b022d2e48 3326 Kusto HTTPS url fix (#1086)
* 3326 Removed sqlConnection.Open from CreateSqlConnection in ConnectionService.

* 3326 Removed unused variables and functions from ConnectedBindingContext, ConnectedBindingQueue, IBindingContext, and IConnectedBindingQueue

* 3326 Removed unused constant SqlAzureEdition and unused functions CreateSqlConnection and CreateServerConnection from ConnectionService. Removed ServerConnection, MetadataDisplayInfoProvider, Binder, and SmoMetaDataProvider from ConnectedBindingContext. Deleted SqlConnectionOpener and ISqlConnectionOpener.
2020-10-05 00:56:40 -07:00
Monica Gupta
164ca951da Fix for multiple queries separated by space for Kusto (#1089)
* Fix for multiple queries separated by space

* Addressed comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-10-04 19:12:33 -07:00
Charles Gagnon
725d4ba5db Fix Notebook->Sql convert to correctly handle multiline comments within a batch (#1087) 2020-10-02 08:27:57 -07:00
Udeesha Gautam
fe4c2ce5b9 update dacfx to bring in ASDE support - first set of features (#1088) 2020-10-01 12:32:09 -07:00
Justin M
d061e781f4 3644 Kusto Azure Token Refresh (#1081)
* 3644 Created KustoClient to handle interaction with Kusto servers. Refactored KustoDataSource and moved execution logic into KustoClient.

* 3644 Added RequestSecurityTokenParams, RequestSecurityTokenResponse, and SecurityTokenRequest to Kusto. Moved intellisense functions from KustoDataSource to KustoIntellisenseHelper. Added SchemaState to readonly property on KustoDataSource. Added catch block to Batch.cs to catch KustoRequestExceptions.

* 3644 Removed unused reference from ConnectionDetails and ConnectedBindingContext. Added UpdateAzureToken function to IKustoClient, KustoClient, IDataSource, KustoDataSource, and KustoDataSource. Added dataSource.Dispose to ReliableDataSourceConnection > Close. Added RefreshAzureToken to ConnectionService to refresh azure token.

* 3644 Removed unused properties from RequestSecurityTokenParams and RequestSecurityTokenResponse

* 3644 Added default to DbColumnWrapper to UnknownTypeName when null. Moved database query logic from KustoIntellisenseHelper to KustoClient. Moved KustoIntellisenseHelper data objects out of class. Changed SchemaState to load through separate tasks.

* 3644 Changed ReRunQuery logic in Kusto Batch to flip back to false if the query fails a second time so it can be rejected

* 3644 Updated GetAutoCompleteSuggestions and GetHoverHelp with changes from main

* 3644 Added AccountId to RequestSecurityTokenParams and set value in ConnectionService. Added throw to Batch.cs to ensure exceptions that are non-Unauthorized bubble up to ADS.

* 3644 Changed KustoUnauthorizedException to take original exception as inner exception. Changed catch block to only throw KustoUnauthorizedException when FailureCode is 401

* 3644 Renamed KustoUnauthorizedException to DataSourceUnauthorizedException. Moved logic to throw exception down into KustoClient. Changed retryLogic in Batch.cs to a decrementing count

* 3644 Changed logic in Batch.cs for throwing InvalidOperationException
2020-09-28 13:24:23 -07:00
Charles Gagnon
d6ff73d510 Add fallback to query server property when getting BDC endpoints (#1083) 2020-09-28 09:19:21 -07:00
Monica Gupta
dfa4f2eaaa Fix to address dynamic type (#1084)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-26 13:43:07 -07:00
Alex Ma
47e7a2f492 Fix for multiple parameter error. (#1082)
* Clearing first use of parameters

* restore space

* added finally block

* Added try catch block in correct position

* fixed spacing

* added space before try

* duplicate row check simplified by Alan

* Revert "duplicate row check simplified by Alan"

This reverts commit 445ac506bd96b353266778abd0cf9bad2be2a3c3.

* removed exception and changed message

* added exception back for test purposes

* added working executescalar

* Added "<=" for delete action that deletes nothing.

* spacing fix for check duplicate

* Added comments and changed function logic.

* added clarifying message

* Added new extended class

* small space fix
2020-09-25 10:52:59 -07:00
Monica Gupta
fd4d067e71 Fix intellisense if multiple kusto queries exist (#1080)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-21 10:23:00 -07:00
Shafiq Ur Rahman
2e6b134953 Result handling for Kusto results (#1079)
* Revert "Fix for displaying multiple table (#1075)"

This reverts commit df0be31019.

* KustoResultsReader trims results
2020-09-21 10:02:23 -07:00
Monica Gupta
fea050448d Fix to escape table names only (#1078)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-20 17:19:01 -07:00
Monica Gupta
daff5a9445 Merge branch 'main' of https://github.com/Microsoft/sqltoolsservice into main 2020-09-17 20:33:33 -07:00
Monica Gupta
86dabba2f8 Change default kusto query to get 10 rows (#1077)
* Query to get 10 rows for Kusto queries

* fix unit tests

* Addressed comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-17 17:00:26 -07:00
Monica Gupta
f8e9d091cb Merge branch 'main' of https://github.com/Microsoft/sqltoolsservice into main 2020-09-17 14:23:29 -07:00
rajeshka
df0be31019 Fix for displaying multiple table (#1075) 2020-09-17 11:59:01 -07:00
Monica Gupta
f471da1f5a Query to get 10 rows for Kusto queries 2020-09-17 10:44:10 -07:00
Justin M
c80b70bea4 3715 Default database name for Kusto (#1076)
* 3715 Refactored GetDatabaseName to load database names from kusto server when no database name available in connection string.

* 3715 Removed variable name from GetDatabaseName
2020-09-15 13:34:21 -07:00
Monica Gupta
f25fb3c5d7 Kusto control command with comments or spaces (#1074)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-12 00:10:48 -07:00
Justin M
d39a67df30 3643 Intellisense fix for spaces (#1073)
* 3643 Enhanced GetAutoCompleteSuggestions to escape spaces in the insertText when generating list of suggestions. Changed detail to include kind.

* 3643 Fixed formatting

* 3643 Changed variable in GetAutoCompleteSuggestions
2020-09-11 15:22:58 -07:00
Monica Gupta
66cba8b77d Fix suggestions after keyword (#1071)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-10 09:52:26 -07:00
Udeesha Gautam
bb735a409f update DacFx (#1072) 2020-09-10 09:29:49 -07:00
Alan Ren
b00e53c6b3 stop getting os version by parsing string (#1070)
* stop getting os version by parsing string

* ignore error
2020-09-09 11:06:59 -07:00
Justin M
f0ec7e14d4 3702 Changed CancelQuery to use ExecuteControlCommand instead of ExecuteQuery in KustoDataSource. Fixed runtime error in NodePathGenerator for loading TreeNodeDefinition.xml (#1069) 2020-09-08 14:05:45 -07:00