Raymond Truong
c8ba317980
[SQL Migration] Show correct recommendation when viewing issues in assessment results ( #1441 )
2022-03-23 17:17:44 -07:00
Aditya Bist
553b9af36e
graph type logic for node sub type ( #1440 )
2022-03-22 21:43:43 -07:00
Lewis Sanchez
8215d88dcf
Adds new graph comparison request handler to the Execution Plan Service. ( #1438 )
...
* Adds new graph comparison request handler to the Execution Plan Service.
* Code review changes
* Renames execution plan compare params, result, and request classes.
2022-03-22 14:52:42 -07:00
Alex Ma
d5e2a58db4
[Loc] updated xlfs and resx files ( #1439 )
2022-03-22 10:51:36 -07:00
Lewis Sanchez
f7b37091ca
Renames ShowPlan directories along with corresponding namespaces ( #1435 )
...
* Renames ShowPlan directories along with corresponding namespaces
* Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils
* Revert "Renames ShowPlanGraphUtils to ExecutionPlanGraphUtils"
This reverts commit 5dc2696ae906598447eed7360a3f342218432b83.
* Reverts show plan tests name change.
* Renames show plan test XML files.
* Renames ported directory to ShowPlan and updates namespace accordingly
2022-03-21 16:25:44 -07:00
csigs
a5c8fd4c53
LEGO: Merge pull request 1437
...
LEGO: Merge pull request 1437
2022-03-20 08:35:28 -07:00
csigs
745e31f0b0
LEGO: Merge pull request 1436
...
LEGO: Merge pull request 1436
2022-03-19 08:35:00 -07:00
Charles Gagnon
ad419dd234
Update build pipeline ( #1431 )
2022-03-18 09:50:28 -07:00
Hai Cao
3b2ffe8aea
change table designer report type to markdown ( #1433 )
2022-03-17 18:39:06 -07:00
Alan Ren
fb7ed1e4dc
fix enum name ( #1432 )
2022-03-17 13:23:54 -07:00
Alan Ren
92cb4beca0
support issue severity ( #1430 )
2022-03-17 10:16:42 -07:00
Alan Ren
271f5f881a
add validation rule for identity setting ( #1429 )
2022-03-16 17:03:09 -07:00
Alex Ma
8dbfa9112c
[Loc] added unknownsqlforeignkeyaction ( #1426 )
2022-03-14 12:33:17 -07:00
Alan Ren
cc5cb4066b
fix for issue that decimal number are exported to excel as strings ( #1425 )
...
* fix export to excel issue with decimals
* add comment
2022-03-14 11:28:16 -07:00
Aasim Khan
aa97389d8e
Adding ExecutionPlanService to ADS ( #1422 )
...
* Adding ExecutionPlanService to ADS
* Changing name to execution plan service
* Renaming file
* Fixing some PR comments
* Renaming class
* Changing api name to queryexecutionplan
2022-03-12 00:49:17 -08:00
Alan Ren
b495ea7475
handle UDT type ( #1424 )
2022-03-11 18:10:08 -08:00
csigs
d62b0f7609
LEGO: Merge pull request 1423
...
LEGO: Merge pull request 1423
2022-03-11 08:33:07 -08:00
csigs
87fdf762d3
LEGO: Merge pull request 1421
...
LEGO: Merge pull request 1421
2022-03-10 08:35:29 -08:00
Alan Ren
7a326b2487
new table designer features ( #1420 )
...
* support graph table types
* more fixes
* refresh view upon edit
* support temporal tables
* temporal and memory table
* primary key and default constraint
* bug fixes
* dispose table designer
* vbump dacfx
* update string
2022-03-08 18:52:51 -08:00
Aditya Bist
3e5bf00cc5
Change preview report type ( #1418 )
...
* change report type
* PR comments
* fix doc for report
* rename format to mimetype
* nitpicks
* edit comments
* default to plain text
2022-03-08 14:07:30 -08:00
Charles Gagnon
40c5d48c5e
Fail build on unneeded usings ( #1417 )
2022-03-04 16:38:01 -08:00
Charles Gagnon
c248400a6c
Add linting for copyright and unused usings ( #1416 )
...
* Add linting for copyright and unused usings
* Add one more + comment
* Enforce in build and fix errors
* Fix build
2022-03-04 15:17:29 -08:00
dependabot[bot]
025f9af4fd
Bump ajv from 6.6.1 to 6.12.6 in /test/CodeCoverage ( #1408 )
...
Bumps [ajv](https://github.com/ajv-validator/ajv ) from 6.6.1 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases )
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.6.1...v6.12.6 )
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-01 12:05:17 -08:00
Aasim Khan
3f711ef6dc
Using custom 1ES pool for running build pipelines. ( #1414 )
...
* Enable trimming to reduce package size
* trimming kusto
* Trying a new pool
* Fixing yaml errors
* Removing package trimming
* Removing formatting changes
* Using specific image
* Fixing formatting
* Fixing yml syntax
2022-02-28 13:02:39 -08:00
Alan Ren
5005c344ad
fix typo ( #1412 )
2022-02-17 15:02:50 -08:00
Alan Ren
2542df3502
add validation for table designer ( #1411 )
...
* add validation for table designer
* comments
2022-02-17 11:12:27 -08:00
Alan Ren
c2d826548c
always allow a column to be added to PK ( #1410 )
2022-02-17 10:04:25 -08:00
Alex Ma
b066d03f3f
[Loc] update to sr.xlf ( #1409 )
...
* [Loc] update to sr.xlf
* added resx updates
2022-02-14 11:54:31 -08:00
Neetu Singh
d704a84740
Update Assessment package. Change Description from PR - https://msdata.visualstudio.com/Database%20Systems/_git/sql-migrate-asmt/pullrequest/747674 ( #1407 )
...
Updated the E-series VM IOPS, throughput capability based on ms doc as rest endpoint giving very low number on throughput particularly.
Updated only for SKUs with local disk.
Haven't checked if D-series has similar problem, however it wouldn't cause problem as we are not showing any Dev-test recommendation for ADS.
Note : Mostly, any other mismatches wouldn't be relevant for prod recommendations.
msdoc reference : https://docs.microsoft.com/en-us/azure/virtual-machines/edv5-edsv5-series
2022-02-11 17:31:38 -08:00
csigs
20a9bd00a2
LEGO: Merge pull request 1406
...
LEGO: Merge pull request 1406
2022-02-11 08:34:09 -08:00
Vasu Bhog
8120858ad2
Modify Get Connection String Request to use connection details ( #1394 )
...
* connection string accepts connectionInfo
* get connection string from disconnected scenarios
2022-02-10 20:48:39 -08:00
Raymond Truong
1693843ab0
[Feature] SKU recommendations in SQL migration extension ( #1399 )
...
* Initial check in for SQL migration SKU recommendation feature (#1362 )
Co-authored-by: Raymond Truong <ratruong@microsoft.com >
* Integration test for Get SKU Recommendation. (#1377 )
* Integration test for Get SKU Recommendation.
* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.
* Implement start/stop perf data collection (#1369 )
* Add SqlInstanceRequirements to SKU recommendation output (#1378 )
* test for data collection start and stop (#1395 )
* improve error handling, add RefreshPerfDataCollection (#1393 )
* WIP - refresh data collection
* Capture messages before logging
* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402 )
* Update NuGet version to 1.0.20220208.23, update assessment metadata
* Update SKU recommendation metadata
* Include preview SKUs
* Clear message/error queue after refreshing
* Clean up
* Add 'IsCollecting' to RefreshPerfDataCollection (#1405 )
Co-authored-by: Neetu Singh <23.neetu@gmail.com >
2022-02-10 19:02:27 -08:00
csigs
4a33da5a18
LEGO: Merge pull request 1404
...
LEGO: Merge pull request 1404
2022-02-10 08:33:27 -08:00
Aasim Khan
00c2fdbe99
Fixing faulty showInTooltip logic and adding prop display value for Query Plan ( #1401 )
...
* Fixing faulty showInTooltip logic
* Renaming one prop appropriately
* Fixing prop function
* Fixed PR related comments
* Fixing stuff
* Logging errors now
2022-02-09 22:54:17 -08:00
Charles Gagnon
cf959b3278
Bump nuget package versions ( #1400 )
2022-02-09 10:20:35 -08:00
Charles Gagnon
13bd3b434c
Use PackageLicenseExpression for nuget packages ( #1398 )
...
* Add MIT license expression
* Remove license file
2022-02-08 14:53:39 -08:00
Alan Ren
d3b17187b5
new sql parser ( #1397 )
2022-02-08 13:39:10 -08:00
Alan Ren
6b1b2720f2
enable AAD auth for Table Designer ( #1396 )
2022-02-08 12:56:43 -08:00
Alex Ma
25bbbcf60e
[Loc] update to sr resx and xlf ( #1392 )
2022-02-07 09:52:05 -08:00
csigs
267ee07130
LEGO: Merge pull request 1391
...
LEGO: Merge pull request 1391
2022-02-05 08:33:58 -08:00
Charles Gagnon
1b5ac4c017
Skip component governance for release pipeline ( #1389 )
...
* initial
* try
* fix
* undo
2022-02-04 10:28:21 -08:00
csigs
187f34d0bb
LEGO: Merge pull request 1388
...
LEGO: Merge pull request 1388
2022-02-04 08:35:04 -08:00
Alan Ren
308e3019f7
refresh the table information after saving ( #1387 )
...
* refresh the table information after saving
* add comment
2022-02-03 18:06:34 -08:00
Charles Gagnon
1cd27bdb70
Fail build on Component Governance alert ( #1385 )
2022-02-03 17:34:06 -08:00
Charles Gagnon
b10f693b31
Move code coverage packages to devDependencies ( #1386 )
...
* Move to devDependencies
* Fail build on Component Governance alert
(cherry picked from commit 3ccb3b1f2dd70a4561c515ff8612166c6c9a76b9)
* update package lock
* Revert "Fail build on Component Governance alert"
This reverts commit 747cd06beeed5133fb383acc1d6bd6a7a458ac05.
2022-02-03 16:54:41 -08:00
Vasu Bhog
8e5a23f755
Optional application name parameter for connection string ( #1380 )
...
* optional application name parameter for connection string
2022-02-03 16:00:08 -08:00
Charles Gagnon
c092b194da
Build win-x86 ( #1384 )
...
* Build win-x86
* Move to prop
* Correct RID
2022-02-03 13:43:40 -08:00
Charles Gagnon
75749a405f
Update System.Text.Encodings.Web to 4.7.2 ( #1383 )
...
* Update System.Text.Encodings.Web to 4.7.2
* cleanup
2022-02-03 09:03:09 -08:00
Alex Ma
3157c6186e
[Loc] update to resx and xlfs ( #1382 )
2022-02-02 16:09:32 -08:00
Alan Ren
3c93d57730
table designer - support second level entities ( #1381 )
...
* support secondary entities
* new table info for existing table scenario
* delete column confirmation
* vbump Dacfx
2022-02-02 13:40:45 -08:00