Commit Graph

910 Commits

Author SHA1 Message Date
Aditya Bist
e0a1df13c6 fix CMS Service issue (#782)
* fixed issue with add registered servers call

* changed server name to alias

* fixed issue with adding server group to cms server

* remove script file
2019-03-28 10:36:07 -07:00
Karl Burtram
e261d77bb8 Fix "Save to CSV" CodePages assembly version mismatch (#790)
* Fix "Save to CSV" CodePages assembly version mismatch

* Add comment to delete packagereference once moving off preview version
2019-03-26 18:34:28 -07:00
Karl Burtram
e41b9bcf51 Make "--enable-logging" an ignored option for mssql back-compat (#788) 2019-03-24 17:54:29 -07:00
Karl Burtram
eaaff8b8a1 Remove Peek Definition error popup (#786)
* Remove Peek Definition error popup

* Fix broken test case

* Fix bug
2019-03-22 16:52:45 -07:00
Charles Gagnon
57727409c1 Update to latest version of SMO (15.1.18097.0)
This contains a fix for netcore Registered servers that was preventing setting the ConnectionString property. (#784)
2019-03-22 10:30:42 -07:00
Aditya Bist
a08e4058a2 Agent/improvements (#779)
* job step type and error message details change

* added newline for both environments

* checked for inner exceptions

* sorted imports

* added ability to change job owner
2019-03-21 11:31:15 -07:00
udeeshagautam
5778dc7b01 Fix for : 4045: Cannot cancel a Query. Query runs too long. (And SMO update) (#780)
* Fix for : 4045: Cannot cancel a Query. Query runs too long.
HandleExecuteRequest was returning a task to awaiter - which was getting waited on. changed it to async function to start task in new thread and return nothing to awaiter . Also the cancellation token set by cancel request was getting checked only after making the connection to execute batches. Added an additional check for cancellation token befor the connection has been made.

Fix for 4319: Error showing dbs when using AAD in... 1.5.0-alpha.74
David has already created a new version of SMO nuget with the fix. - incorporating the same (150.18096.0-preview).

* Adding awaitable internal task for tests to run properly

* Adding more cancel tests
2019-03-13 15:39:00 -07:00
Aditya Bist
a08666af0f Added more options to job changes and elaborated error messages (#775)
* job step type and error message details change

* added newline for both environments

* checked for inner exceptions

* sorted imports
2019-03-07 11:42:20 -08:00
kisantia
01bcfd8df9 Add Schema Compare (#777)
* successfully sends list of differences to ADS

* bumping dacfx nuget package version

* add second schema compare try for case when first db to db comparison fails but works on second try

* move schemacompare out of dacfx folders

* capitalizing

* more capitalizing

* addressing comments
2019-03-05 11:43:06 -08:00
udeeshagautam
676ce9c7de Missing one spelling Fix (#778) 2019-03-01 14:51:15 -08:00
udeeshagautam
9551022fff Feature/cms backend (#776)
* First cut of CMS get Server Api - returns only names

* Adding Proper naming and some more functions

* Adding add remove Server and tests for it

* Changing relative path to derive from KeyChain.Urn and Nuget update

* Adding async thread for requests

* Addressing CR comments and adding one more test

* Adressed PR comments around naming
2019-03-01 11:55:19 -08:00
Karl Burtram
022282800a Move managed parser into its own project (test code coverage) (#774)
* Created New ManagedBatchParser project in .NetStandard

* Addressing PR Comments

* Resolve 'No Repository' warning.

* Move batch parser tests to integrations test project

* Fix SLN file
2019-02-07 20:13:03 -08:00
kisantia
0a172f3c8e Add DacFx Generate Deploy Plan Operation (#768)
* initial adding upgrade plan

* upgrade plan request from ADS works

* now data loss operations are returned

* fixes after rebasing

* refactoring to use GenerateDeployPlan instead of UpgradePlan

* improving test

* Addressing comments

* changing abstract execute to virtual

* changed GenerateDeployPlanOepration to use Execute()

* addressing comments

* simplyfing deploy options

* adding deploy options to deploy and generate script operations
2019-02-06 17:22:20 -08:00
Yurong He
9177a6be8b Fixed #3839 (#770)
Cloud doesn't have model.sys.assemblies. Also can't use three part naming to access. The workaround is changing the query to check if the cluster_endpoint_info exist or not
2019-01-28 21:20:42 -08:00
kisantia
1917100bfb Add DacFx Generate Deploy Script operation (#759)
* Adding DacFx Generate Deploy Script operation
2019-01-25 11:34:28 -08:00
Yurong He
adc13cff82 Unified connection support (#765)
* Added the query to get big data cluster endpoints
Added bigDataClusterEndpoints to ObjectExplorerSession
Added bigDataClusterEndpoints to ServerInfo
Fixes some tests.

* Removed bigDataClusterEndpoints from session

* Since server property to get IsBigDataCluster is not implemented yet, use query of sys.asseblies instead to unblock us. Need to use server property when it is available
Add options to ServerInfo, so no need to change the contract in the further when adding new properties. Will move the existing properties to option later

* Undo changes not needed

* Resolved PR comments.

* Fixed node is null exception when can't find NodePath.

* Added comments

* Removed not used using

* Catch sqlException for the reader of BDC endpoints and set empty list to the option.

* Added comments for returning empty nodes.
2019-01-24 20:06:35 -08:00
Alan Ren
7cc2636e6a Disconnect session (#764) 2019-01-16 22:03:18 -08:00
Arvind Ranasaria
5f6d500977 This change ensures that we send back only one 'isComplete=true' message for a given result set (#763)
Fixes:
The streaming protocol is now tightened to ensure that only the last message for a result set contain isCompleted=true. Now isCompleted=true is never sent in isAvailable message.
Tightened logic in sending messages to make sure that no duplicate messages get sent out due to concurrent processing.
Made a fix to a null reference exception when processing special action which was a pre-existing benign bug.
Testing: Added 1 more new test that runs existing tests concurrently 1000 times to make sure no random timing issues are observed and tightened verifications to existing tests to ensure no duplicate messages and only one isComplete=true message is sent across.

* tightening the protocal to ensure only one message (the last one) with completed=true is sent back for a single result set within a query batch
2019-01-11 10:21:52 -08:00
Karl Burtram
0fd98df79b Update SqlClient to 4.6.0 (#761) 2019-01-07 16:22:35 -08:00
Aditya Bist
046563318a added ability to start at step (#758) 2018-12-06 17:34:48 -08:00
Arvind Ranasaria
e4808c12aa Feat/result streaming - Fix for issue #746 in toolsservice and issue Microsoft/azuredatastudio#3348 (#753)
* fix for issues 746 & azuredatastudio issue 3348

* test coverage improvement for results streaming

* addressed minor review comments

* adding generated file test/CodeCoverage/package-lock.json to workaround code coverage issue.
2018-12-04 20:49:05 -08:00
Karl Burtram
a1946edca3 Rebuild SqlClient patch bits for .Net Core 2.2 RTW (#754) 2018-12-04 16:43:41 -08:00
Matt Irvine
1a9a750fa8 Fix CodePages version issue (#752) 2018-11-29 16:37:59 -08:00
Karl Burtram
27bcb96597 Enable scripting for SQL Server 2019 (#751) 2018-11-29 15:56:06 -08:00
Thomas Struller-Baumann
b00f829317 Simplified code (#750) 2018-11-29 15:45:16 -08:00
Aditya Bist
2f1097028f Fixed update agent step (#748)
* fixed update step

* fix new step from edit job

* allowed to reorder steps in edit job
2018-11-29 10:47:57 -08:00
Thomas Struller-Baumann
87e8eb9ef6 Removed unnecessary IErrorDetectionStrategy (#749) 2018-11-29 10:45:58 -08:00
kisantia
d5fd968b3c DacFx import/export (#728)
Adding DacFx import/export/deploy/extract functionality
2018-11-27 16:10:46 -08:00
Karl Burtram
7a47db8806 Revert ""I have changed access modifier from Internal to Public . These classes are being refered outside. (#742)" (#747)
This reverts commit a54eff11b6.
2018-11-26 13:03:28 -08:00
NiranjanVirtuosity
a54eff11b6 "I have changed access modifier from Internal to Public . These classes are being refered outside. (#742) 2018-11-26 12:53:12 -08:00
Arvind Ranasaria
6dd9a4b5f1 Feat/result streaming (#721)
This changes adds the following two notifications from the results processing within a batch. These new notifications allows a consumer to stream results from a resultset instead of getting them all at once after the entire resultset has been fetched.

ResultsAvailable
This is issued after at least 1 row has been fetched for this resultset.

ResultsUpdated
This is issued periodically as more rows are available on this resultset. The final send of this notification when all rows have been fetched has the property 'Complete' set to true in the ResultSummary object.

Detailed Change Log:
* Initial completed implementation of QueryResults stream feature. 3 unittests still need fixing

* Fix for the 3 failing test. I will look into making MockBehavior strict again for the three tests later

* Making GetReader/GetWriter use filestream objects in FileShare.ReadWrite mode so the file can be concurrently read and written

* Changing resultsAvailable also to fire off on a timer instead of after 1st row

* adding a project for clr TableValuedFunction to produce result set with delays after each row. This is helpful in end to end testing.

* Fixing up some tests and simplifying implementation of result update timer

* Address review comments

* Some test fixes

* Disabled flaky test verification
2018-11-26 10:24:54 -08:00
Cory Rivera
688e128c4c Bump assembly version to pick up new CoreServices changes. (#745) 2018-11-21 14:07:19 -08:00
Cory Rivera
b384885866 Treat databases used by Polybase as system databases when listing databases in a server. (#743) 2018-11-21 12:22:13 -08:00
Alan Ren
c9885abb67 fix for https://github.com/Microsoft/azuredatastudio/issues/3262 (#741) 2018-11-16 21:20:58 -08:00
Matt Irvine
a1ab9aa650 Use consistent version of SqlClient (#740) 2018-11-16 12:08:57 -08:00
Karl Burtram
3c915a92f6 Send a Object Explorer session disconnect message on socket exceptions (#739)
* WIP

* WIP 2

* Send disconnect message o binding exception

* Add a try catch around the binding queue error handler
2018-11-16 12:07:05 -08:00
Matt Irvine
7f28f249de Add support for Azure Active Directory connections (#727) 2018-11-13 11:50:30 -08:00
Alan Ren
2cb7f682c5 fix for issue 3123 (#729)
* fix for issue 3123

* using seperate thread to handle the requests and fixed a typo
2018-11-08 14:48:27 -08:00
Aditya Bist
4f148a583b Agent/improvements (#720)
* add steps and schedules to edit job

* added alerts to edit data logic

* fixed c# style
2018-10-31 16:40:17 -07:00
Karl Burtram
6153279840 Update broken BindingQueue test from previous commit (#725) 2018-10-31 15:24:02 -07:00
Karl Burtram
adf10ece87 Wait for queued tasks to complete before processing subsequent tasks (#724) 2018-10-31 09:48:57 -07:00
Karl Burtram
df023da0ba Revert "Rollback SMO to latest 14.0 version (#722)" (#723)
This reverts commit 407e9feb40.
2018-10-30 17:20:25 -07:00
Karl Burtram
407e9feb40 Rollback SMO to latest 14.0 version (#722)
* Rollback SMO to latest 14.0 version

* Add back nunit package reference
2018-10-30 12:13:23 -07:00
Karl Burtram
2391759477 Update SqlClient patch to set KeepAlive retry interval to 1 second (#719) 2018-10-26 15:33:31 -07:00
Karl Burtram
2b6eeb19ab Update references to use non preview references (#718) 2018-10-24 17:23:23 -07:00
Karl Burtram
8460ce023d Only reopen connection on exception if it's closed (#717) 2018-10-24 15:55:27 -07:00
2966a53b70 Fix: DATETIMEOFFSET data types should be ISO formatted (#714) 2018-10-22 16:46:02 -07:00
Karl Burtram
5ab904dd1c Private KeepAlive .Net Core 2.2 macOS binaries (#716) 2018-10-22 16:44:15 -07:00
Karl Burtram
a241a4510b Bump .Net Core SDK to 2.2.100 Preview (#715)
* Bump .Net Core SDK to 2.2

* Update travis file

* Try to fix broken AppVeyor code coverage
2018-10-22 15:54:17 -07:00
Arvind Ranasaria
1ef70ef259 Bug fix for https://github.com/Microsoft/azuredatastudio/issues/2923 and misc other fixes (#711) 2018-10-19 13:25:18 -07:00