Benjamin Russell
e9814435d8
Merge pull request #18 from Microsoft/feature/queryCancellation
...
Adding support for query cancellation
2016-08-16 16:15:13 -07:00
benrr101
709123eaaf
Final iteration, fixing a couple mistakes for query exceptions
2016-08-16 16:14:27 -07:00
Mitchell Sternke
91b28127ce
Merge pull request #19 from Microsoft/dev_intellisenseCacheTests
...
Added initial tests for the connection manager's intellisense cache
2016-08-16 15:55:24 -07:00
Mitchell Sternke
41172f0d0a
Merge branch 'dev_intellisenseCacheTests' of https://github.com/Microsoft/sqltoolsservice into dev_intellisenseCacheTests
2016-08-16 15:54:14 -07:00
Mitchell Sternke
e33df61dc3
Addressing code review feedback
2016-08-16 15:53:00 -07:00
Mitchell Sternke
c80a90331d
Added initial tests for the connection manager's intellisense cache
2016-08-16 15:32:36 -07:00
Mitchell Sternke
3ba4a93463
Merge pull request #20 from Microsoft/feature/connectionCleanup
...
Cleaned up connection management code
2016-08-16 15:29:27 -07:00
Mitchell Sternke
6ffdf644ba
Addressing code review feedback
2016-08-16 15:27:26 -07:00
Mitchell Sternke
a6cc14d31f
Cleaned up connection management code
2016-08-16 13:48:36 -07:00
Benjamin Russell
c38ca5f6b8
Merge pull request #17 from Microsoft/bug/exceptionLoop
...
Fix: Infinite Exception Loop, Plaintext Password Logging, Ever-expanding Message Buffer
2016-08-16 12:36:03 -07:00
benrr101
71d852ba07
Renaming the hosting error method
2016-08-16 12:35:39 -07:00
benrr101
981c144bfe
Merge branch 'dev' into bug/exceptionLoop
2016-08-16 12:29:02 -07:00
benrr101
9fa183ea6d
Fixing String.Format to string.Format
2016-08-16 12:28:52 -07:00
Mitchell Sternke
b7f88084c0
Added initial tests for the connection manager's intellisense cache
2016-08-16 12:21:42 -07:00
Benjamin Russell
062c40368d
Adding support for query cancellation
...
Query cancellation support is added via CancellationToken mechanisms that
were implemented previously. This change adds a new request type
"query/cancel" that will issue the cancellation token. Unit tests were
also added.
2016-08-15 15:23:07 -07:00
Benjamin Russell
3981b1d544
Merge pull request #16 from Microsoft/feature/queryExecuteServerMessages
...
Server Message Support for Query Execution
2016-08-15 14:18:09 -07:00
Benjamin Russell
1acc8c9122
Fixing up error logging
...
Fixing issue where plaintext passwords could be written to logs
Fixing up todo issues where error events needed to be passed back from the
service layer when the hosting component fails.
2016-08-12 17:38:41 -07:00
Benjamin Russell
ba144bd5d0
Unit tests for the message reader
2016-08-12 17:37:07 -07:00
Benjamin Russell
fe79f6e85c
Fixing infinite exception loop bug
...
Fixing issue where submitting a malformed JSON RPC request results in the
message reader entering into an infinite loop of throwing and catching
exceptions without reading anything from the input stream.
At the same time, this change also fixes a potential memory leak where the
message read buffer is never reinstantiated or shrunk. This issue is fixed
by shifting buffer contents after a message was read successfully, or if
an error occurs during parsing.
2016-08-12 15:37:16 -07:00
Benjamin Russell
c596a0db7a
Small tweaks to query execution
...
* Adding comments where missing
* Adding "# rows affected" only if there was 0 or more
2016-08-11 17:41:18 -07:00
Benjamin Russell
9890e828bd
Adding unit tests to the updated message mechanism
2016-08-11 16:39:33 -07:00
Benjamin Russell
1be4daf41d
Adding enhanced support for messages from server
...
* Adding error flag for Query class
* Adding message capture for messages from server (using SqlConnection
cast)
* Adding better handling of SELECT queries with 0 results
* Adding affected row count message
* Adding SqlError unwrapping (using SqlException cast)
* Removing DbException handling from QueryExecutionService and into Query
class
2016-08-11 15:45:59 -07:00
Benjamin Russell
a2983539a7
Merge branch 'feature/queryExecutionV1' into dev
2016-08-10 16:55:22 -07:00
Benjamin Russell
793ad383c1
Small bug fix for unit tests
2016-08-10 16:54:56 -07:00
Benjamin Russell
20e465c528
Merge pull request #15 from Microsoft/feature/queryExecutionV1
...
Query Execution v1
2016-08-10 16:44:34 -07:00
Benjamin Russell
68c25f506e
Adding changes as requested for code review
2016-08-10 16:40:36 -07:00
Benjamin Russell
8167330e16
Finishing up unit tests
2016-08-10 15:14:56 -07:00
Benjamin Russell
430860dd5d
Merge branch 'dev' into feature/queryExecutionV1
2016-08-09 11:15:22 -07:00
Benjamin Russell
d783fd505b
Second batch of unit tests
...
Making slight changes to RequestContext to make it easier to mock
2016-08-09 11:10:54 -07:00
Mitchell Sternke
1b339bec17
Merge pull request #14 from Microsoft/feature/connectUsingService
...
Feature/connect using service
2016-08-09 10:18:33 -07:00
Mitchell Sternke
f3231fba56
Addressing PR 14 feedback
2016-08-09 10:17:29 -07:00
Benjamin Russell
9f371cd0bc
Unit tests, part 1
2016-08-05 18:38:21 -07:00
Mitchell Sternke
5c03ba336d
Added disconnect and connect when already connected service code
2016-08-05 17:46:16 -07:00
Benjamin Russell
a5582889bf
Forgot to make corresponding changes in other files
2016-08-05 15:11:58 -07:00
Benjamin Russell
a06003c966
Another change for @anthonydresser
2016-08-05 15:08:28 -07:00
Benjamin Russell
368a98c8e0
Quick fix for @anthonydresser
2016-08-05 14:55:59 -07:00
Benjamin Russell
315c1fd7b0
Merge branch 'feature/connectUsingService' into feature/queryExecutionV1
2016-08-05 11:22:52 -07:00
Benjamin Russell
0740e81dab
Stub files for tests for query execution
2016-08-05 11:11:50 -07:00
Mitchell Sternke
8fba793a46
Incremental checkin of connection work
2016-08-05 10:56:51 -07:00
Benjamin Russell
05e4c4f3a9
Final changes before V1 testing
2016-08-04 17:20:52 -07:00
Benjamin Russell
719a0f091a
Merge branch 'feature/connectUsingService' into feature/queryExecutionV1
2016-08-04 16:11:48 -07:00
Benjamin Russell
3ba22c94ac
WIP for QueryExecution, mostly complete
2016-08-04 14:48:58 -07:00
Mitchell Sternke
5249924b12
Fixed a few minor errors from the last commit
2016-08-04 14:29:57 -07:00
Mitchell Sternke
6ca893a122
Merge branch 'feature/connectUsingService' of https://github.com/Microsoft/sqltoolsservice into feature/connectUsingService
2016-08-04 14:10:00 -07:00
Kevin Cunnane
402e25f77d
Per editor Connect support v0.1
...
- Basic plumbing to support connections for a URI rather than global connections. Typical use case is editor requests to connect, but this isn't the only possible use
- Tests pass but need updating to cover new functionality, and re-enable AutoCompleteService test once there is a ServiceDiscovery component that registers and returns services. This is necessary as .Instance won't allow for dependency injection and proper testing.
2016-08-04 14:01:17 -07:00
Benjamin Russell
1618b77790
Merge branch 'dev' into feature/queryExecutionV1
2016-08-03 15:42:26 -07:00
Benjamin Russell
d191b0483c
Small bugfix after the previous merge
...
My mistake, didn't pay enough attention when performing the refactoring as
requested in the last code review.
2016-08-03 15:41:11 -07:00
Benjamin Russell
92c1481f14
Merge branch 'dev' into feature/queryExecutionV1
2016-08-03 15:00:01 -07:00
Benjamin Russell
a751e30a32
Merge pull request #13 from Microsoft/feature/queryExecutionV1_cr
...
ConnectionService ISqlConnection -> DbConnection
2016-08-03 14:56:20 -07:00
Benjamin Russell
13fd97ef90
Fixing issues as per suggestions from @kevcunnane
2016-08-03 14:51:17 -07:00
