* add flag to handler
* cleanup
* concurrency control
* add flag for handler setters
* update service flags
* fix event handlers
* more handlers
* make sure behavior is unchanged if flag is off
* cleanup
* add test case for parallel processing
* comments
* stop dispatcher in test
* add log for request lifespan
* cleanup and add comments
* correctly release semaphore
* remove deleted file from merge
* use await for semaphore release
* move handler invocation to await and adjust test
* cleanup exception handling and wrapper
* space
* loose assertion condition to make test stable
In this PR, we make the appropriate backend service changes in order to enable the login migrations feature in the SQL migration extension.
Changes include:
updating the Microsoft.SqlServer.Migration.Login NuGet version to the latest version
adding a new request handler for StartLoginMigrations calls, which makes the appropriate calls to the login NuGet
adding ExtensionMethod helper to properly combine exception maps login migration nuget calls
Co-authored-by: Akshay Mata <akma@microsoft.com>
* WIP - update NuGet and add xevent assessment request
* Update API
* Update nupkg to official build
* Add try/catch around individual recommendation models
* Clean up
* Add HS to SQL DB SKU recommendation input
* Fix null logger resulting in undefined error being surfaced to user
* WIP - implement elastic recommendation model
* WIP - implement elastic recommendation model
* Clean up
* Remove unnecessary content files after updating NuGet version
* Refactor
* Clean up
* Update assessment NuGet version and metadata
* Consider Eb VM SKUs without preview flag as they are now GAed
* Update assessment NuGet to 1.0.20220527.33
* Initial check in for SQL migration SKU recommendation feature (#1362)
Co-authored-by: Raymond Truong <ratruong@microsoft.com>
* Integration test for Get SKU Recommendation. (#1377)
* Integration test for Get SKU Recommendation.
* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.
* Implement start/stop perf data collection (#1369)
* Add SqlInstanceRequirements to SKU recommendation output (#1378)
* test for data collection start and stop (#1395)
* improve error handling, add RefreshPerfDataCollection (#1393)
* WIP - refresh data collection
* Capture messages before logging
* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)
* Update NuGet version to 1.0.20220208.23, update assessment metadata
* Update SKU recommendation metadata
* Include preview SKUs
* Clear message/error queue after refreshing
* Clean up
* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)
Co-authored-by: Neetu Singh <23.neetu@gmail.com>
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"
This reverts commit e96c0064ad.
* Move SQL Tools Service last in Main project list