Commit Graph

70 Commits

Author SHA1 Message Date
Mitchell Sternke
f3231fba56 Addressing PR 14 feedback 2016-08-09 10:17:29 -07:00
Mitchell Sternke
5c03ba336d Added disconnect and connect when already connected service code 2016-08-05 17:46:16 -07:00
Mitchell Sternke
8fba793a46 Incremental checkin of connection work 2016-08-05 10:56:51 -07:00
Mitchell Sternke
5249924b12 Fixed a few minor errors from the last commit 2016-08-04 14:29:57 -07:00
Mitchell Sternke
6ca893a122 Merge branch 'feature/connectUsingService' of https://github.com/Microsoft/sqltoolsservice into feature/connectUsingService 2016-08-04 14:10:00 -07:00
Kevin Cunnane
402e25f77d Per editor Connect support v0.1
- Basic plumbing to support connections for a URI rather than global connections. Typical use case is editor requests to connect, but this isn't the only possible use
- Tests pass but need updating to cover new functionality, and re-enable AutoCompleteService test once there is a ServiceDiscovery component that registers and returns services. This is necessary as .Instance won't allow for dependency injection and proper testing.
2016-08-04 14:01:17 -07:00
Benjamin Russell
d191b0483c Small bugfix after the previous merge
My mistake, didn't pay enough attention when performing the refactoring as
requested in the last code review.
2016-08-03 15:41:11 -07:00
Benjamin Russell
a751e30a32 Merge pull request #13 from Microsoft/feature/queryExecutionV1_cr
ConnectionService ISqlConnection -> DbConnection
2016-08-03 14:56:20 -07:00
Benjamin Russell
13fd97ef90 Fixing issues as per suggestions from @kevcunnane 2016-08-03 14:51:17 -07:00
Kevin Cunnane
a40180bcb1 Per editor Connect support v0.1
- Basic plumbing to support connections for a URI rather than global connections. Typical use case is editor requests to connect, but this isn't the only possible use
- Tests pass but need updating to cover new functionality, and re-enable AutoCompleteService test once there is a ServiceDiscovery component that registers and returns services. This is necessary as .Instance won't allow for dependency injection and proper testing.
2016-08-02 18:55:25 -07:00
Benjamin Russell
b2f44031b7 Switching from ISqlConnection to DbConnection
This is a fairly minor change that will save tons of time as we develop
this service. The DbConnection and associated Db* abstract classes
ask for synchronous versions of the code and allow the addition of async
code. The SqlClient implementation already implements Db* abstract
classes, so we can piggy back off that for our dependency injection layer.

Tests and existing code has been updated to handle the change, as well
2016-08-02 18:19:51 -07:00
Benjamin Russell
f40aa31c67 Merge branch 'dev' into feature/queryExecutionV1
Also adding a fancy new mocked out reader for mocking db calls.
2016-08-01 14:27:57 -07:00
Benjamin Russell
2df5ebfdb8 Merge pull request #12 from Microsoft/feature/fixProjectNames
Feature/fix project names
2016-07-29 18:42:36 -07:00
Benjamin Russell
d53c0d3f45 Correcting InternalsVisibleTo attribute 2016-07-29 17:14:40 -07:00
Benjamin Russell
e83d2704b9 Fixing project names to fix VS bugs
For whatever reason, Visual Studio throws a fit if a referenced project has a name
and the folder name (which is used to reference the project) is different than that name.
To solve this issue, I've renamed all the projects and folders to match their project
names as stated in the project.json.
2016-07-29 16:55:44 -07:00
Benjamin Russell
d78c1947e0 Stubbing out connectionservice with guid id 2016-07-29 12:52:24 -07:00
Kevin Cunnane
bb0cd461b6 Merge pull request #11 from Microsoft/dev_connmgr
Add error handling to Connect command
2016-07-28 16:57:27 -07:00
Kevin Cunnane
5c9c3699b9 Remove unnecessary whitespace 2016-07-28 12:52:08 -07:00
Kevin Cunnane
f4c6589681 Add error handling to Connect command
- Handles errors when connecting
- Adds method to capture the settings so the connection service can use these. Expect to read settings from here (and possible connections) in the future
- Minor rename to the test namespace to be consistent with refactor
2016-07-27 18:38:18 -07:00
Benjamin Russell
bc0383b6e6 Expanding SqlConnection to be more like DBConnection
Also shifting the Connect operation to be async
2016-07-27 18:03:55 -07:00
Benjamin Russell
2ea5cf3457 Quick refactor of the connection service
Refactoring to match the layout of the other services.
2016-07-27 16:45:01 -07:00
Karl Burtram
ad008db4f5 Merge pull request #10 from Microsoft/dev_langservice
Fix project names and add internalsvisible for tests
2016-07-26 11:45:56 -07:00
Karl Burtram
818c9fa47f Fix breaks introduced in the refactoring merge. 2016-07-26 11:43:55 -07:00
Karl Burtram
7ff6cc34a0 Fix binary names and add internalsvisible flag for tests 2016-07-25 18:19:20 -07:00
Karl Burtram
ee2dc04e39 Fix merge build breaks 2016-07-25 18:10:42 -07:00
Karl Burtram
69eea577af Merge branch 'dev' into dev_langservice 2016-07-25 17:51:23 -07:00
Benjamin Russell
e2ac321a2f Merge pull request #8 from Microsoft/feature/componentizeServiceHost
Feature/componentize service host
2016-07-25 16:35:39 -07:00
Benjamin Russell
b1f0453341 Merge branch 'dev' into feature/componentizeServiceHost 2016-07-25 16:34:51 -07:00
Benjamin Russell
639ab4f205 Small items for code review iteration
* Removing unused OutputType and OutputWrittenEventArgs classes
* Adding class comment blocks
* Tweaking a couple comment blocks as per @kcunanne comments
2016-07-25 13:33:04 -07:00
Karl Burtram
53e26798fc Language Service diagnostics and autocomplete (#9)
* Merge master to dev (#4)

* Misc. clean-ups related to removing unneeded PowerShell Language Service code.
* Remove unneeded files and clean up remaining code.
* Enable file change tracking with Workspace and EditorSession.

* Setup standard src, test folder structure.  Add unit test project.

* Actually stage the deletes.  Update .gitignore

* Integrate SqlParser into the onchange diagnostics to provide error messages.

* Add tests for the language service diagnostics

* Initial implementation for autocomplete.

* Switch to using sys.tables for autocomplete
Move some code into a better class

* Delete unused csproj file.

* Add nuget.config to pickup SQL Parser nuget package
2016-07-25 13:04:14 -07:00
Karl Burtram
6464240f0b Add nuget.config to pickup SQL Parser nuget package 2016-07-25 12:58:44 -07:00
Benjamin Russell
6664de2252 Renaming callbacks to be more sane 2016-07-25 12:37:48 -07:00
Benjamin Russell
46032d3e2e Making singleton instances threadsafe 2016-07-25 12:15:03 -07:00
Benjamin Russell
31576d0731 Renaming namespaces to prevent issues with class names 2016-07-25 11:43:26 -07:00
Karl Burtram
ffc89231f4 Delete unused csproj file. 2016-07-24 13:38:44 -07:00
Karl Burtram
4cebc196ff Switch to using sys.tables for autocomplete
Move some code into a better class
2016-07-24 13:37:10 -07:00
Karl Burtram
a7d634a014 Merge branch 'dev' into dev_langservice 2016-07-24 11:15:47 -07:00
Karl Burtram
4484c8d8cf Initial implementation for autocomplete. 2016-07-24 02:47:45 -07:00
Karl Burtram
3a55333598 Add tests for the language service diagnostics 2016-07-23 17:05:49 -07:00
Karl Burtram
7119db3bcd Integrate SqlParser into the onchange diagnostics to provide error messages. 2016-07-23 15:05:02 -07:00
Benjamin Russell
bd83045a0a Applying refactor to test project
For some strange reason, the using statements don't seem to want to work
for the Message type. The full name has been used instead, but it's an
ugly workaround for the time being.
2016-07-22 16:56:34 -07:00
Benjamin Russell
b9f041cdf4 The last 10% of the refactor
This will build successfully
2016-07-22 16:41:23 -07:00
Benjamin Russell
85668cb3de First major portion of refactor 90%
The overall architecture of the service host is completed here. However,
this doesn't build because the EditorSession dependencies haven't been
worked out just yet.
2016-07-22 11:49:50 -07:00
Benjamin Russell
5d776863d8 Moving the WorkspaceService contracts into a contract folder
I'm not convinced yet that this is the best place for these files, but it
will be ok for now.
This doesn't build
2016-07-21 16:53:53 -07:00
Benjamin Russell
9ec6265602 Separated LanguageServer into different components
LanguageServer ->
LanguageService - for any functionality that deals with parsing SQL
ServerService - for any functionality that is required to manage the
service layer
WorkspaceService - for any functionality that deals with managing the
state of the workspace, session, or text document

Namespace changes have not been applied yet, so this doesn't build yet.
2016-07-21 14:29:41 -07:00
Benjamin Russell
eb25f56e64 Renaming all the namespaces for ServiceHost
Also wiring up the namespace changes to make the servicehost component
build.
NOTE: This will not build
2016-07-21 13:39:01 -07:00
Benjamin Russell
f1e6b8a4e4 Changing the default namespace
... to better match the nomenclature we're using internally for the
difference between the UX and the Service Layer.
2016-07-21 12:17:53 -07:00
Benjamin Russell
a7eb53cc06 Moving the MessageProtocol files into ServiceHost/Protocol
The contracts for the basic protocol have been moved into their own
/Protocol/Contracts folder. No code changes have been made to change the
namespaces or class names
2016-07-21 12:15:22 -07:00
Benjamin Russell
9edeb19946 Renaming the classes for the ServiceHost
NOTE: This is a WIP commit, it will not build
2016-07-21 12:00:53 -07:00
Benjamin Russell
1b592aeaef Moving LanguageServer to ServiceHost
NOTE: This is a WIP commit
2016-07-21 11:36:38 -07:00