Commit Graph

23 Commits

Author SHA1 Message Date
junierch
fddf73407e Mark Premium-series SQL MI SKUs as GA (#1684) 2022-09-13 08:38:08 -07:00
Raymond Truong
004a0b2178 [SQL Migration] SKU recommendation fixes + improvements (#1602)
* Fix null logger resulting in undefined error being surfaced to user

* WIP - implement elastic recommendation model

* WIP - implement elastic recommendation model

* Clean up

* Remove unnecessary content files after updating NuGet version

* Refactor

* Clean up
2022-08-16 09:49:12 -07:00
Raymond Truong
28a33bea9a [SQL Migration] Enable saving assessment/recommendation reports (#1613)
* Implement save assessment report

* Implement save recommendation report

* Remove unnecessary content files after updating NuGet version
2022-08-15 11:01:43 -07:00
Charles Gagnon
fd00114a0e Catch Request/Event handler errors at dispatcher level (#1610)
* Catch Request/Event handler errors at dispatcher level

* Fix tests

* Use Exception overload of SendError

* Fix tests
2022-07-29 17:31:36 -07:00
Raymond Truong
0c37dc50f9 [SQL Migration] Update assessment NuGet version + mark GAed VM SKUs as non-preview (#1510)
* Update assessment NuGet version and metadata

* Consider Eb VM SKUs without preview flag as they are now GAed

* Update assessment NuGet to 1.0.20220527.33
2022-05-31 14:54:29 -07:00
Raymond Truong
c8ba317980 [SQL Migration] Show correct recommendation when viewing issues in assessment results (#1441) 2022-03-23 17:17:44 -07:00
Raymond Truong
1693843ab0 [Feature] SKU recommendations in SQL migration extension (#1399)
* Initial check in for SQL migration SKU recommendation feature (#1362)

Co-authored-by: Raymond Truong <ratruong@microsoft.com>

* Integration test for Get SKU Recommendation. (#1377)

* Integration test for Get SKU Recommendation.

* Addressing comments -
1) Moving sample files to data folder.
2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'.

* Implement start/stop perf data collection (#1369)

* Add SqlInstanceRequirements to SKU recommendation output (#1378)

* test for data collection start and stop (#1395)

* improve error handling, add RefreshPerfDataCollection  (#1393)

* WIP - refresh data collection

* Capture messages before logging

* Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402)

* Update NuGet version to 1.0.20220208.23, update assessment metadata

* Update SKU recommendation metadata

* Include preview SKUs

* Clear message/error queue after refreshing

* Clean up

* Add 'IsCollecting' to RefreshPerfDataCollection (#1405)

Co-authored-by: Neetu Singh <23.neetu@gmail.com>
2022-02-10 19:02:27 -08:00
Aasim Khan
6f5cac4cb5 Adding a flag for migration blocker flag in sql assessment and switching to new APIs (#1242)
* Adding a flag for migration blocker in sql assessment and switching to new APIs

* Fixing var names
2021-09-08 15:15:56 -07:00
Aasim Khan
c5cbcf02a2 Removing unused code (#1229)
and adding a null check
2021-08-06 20:11:58 -07:00
Aasim Khan
a7703e63a4 Fixing the logic to retireve rule metadata in sql assessments (#1223) 2021-07-21 17:40:04 -07:00
Christopher Suh
d0f9af0a3e Enable Multiple Assessments (#1219)
* wip

* wip

* modified assessments to handle multiple DBs

* pr comment change

* cleanup

* cleanup

* cleanup
2021-07-21 11:20:16 -07:00
Aasim Khan
f25dd5d2a4 Adding server metadata to SQL Migration Assessment API (#1222)
* WIP

* Adding server metdata to assessment call

* Fixed spacing

* Sorted imports
Added copyright header
Changes some class names
Fixed description

* Fixed assessment result and removing unused imports

* Adding assessment result
2021-07-19 12:38:10 -07:00
Christopher Suh
ae9ec03018 Update Assessment Nuget to Enable Logging (#1215)
* wip

* updated nuget package

* removed unused nuget

* updated assessment nuget to add logging

* added logs filepath'

* updated assessment nuget

* updated nuget
2021-06-15 10:49:20 -07:00
Aasim Khan
add0724c21 Adding network share validation in sql migration. (#1203)
* adding network file validator contract

* Adding UNC path validation

* Using helper methods for sanity checks

* Fixed the validation variable type

* Fixing if condition
2021-05-04 15:16:31 -07:00
Aasim Khan
3ad2b2312a Adding windows account validation api for sql migration extensions. (#1202)
* Adding validate file share api

* Making message endpoint camel case

* Adding validation for windows username
2021-05-03 23:51:45 -07:00
Christopher Suh
6bafed10eb added rule id (#1190) 2021-04-15 12:02:32 -07:00
Christopher Suh
2badd8e728 Fix Sql Auth for Migration Assessments (#1182)
* pass connection string to dma engine

* cleanup

* remove optional parameter

* modified query
2021-03-26 15:59:07 -07:00
Aasim Khan
5a8cfab8fa Sending assessment errors to ads (#1180) 2021-03-22 09:14:02 -07:00
Christopher Suh
0f4767aa6c Added Server Name (#1176)
* added DatabaseName field

* added servername
2021-03-16 18:40:14 -04:00
Christopher Suh
8fb6474cf0 added DatabaseName field (#1166) 2021-02-23 21:32:02 -05:00
Karl Burtram
b9e1618260 Revert "Rollback migration changes" (#1099)
* Revert "Revert "Initial migration service changes for assessment support (#1093)" (#1098)"

This reverts commit e96c0064ad.

* Move SQL Tools Service last in Main project list
2020-10-16 16:29:22 -07:00
Charles Gagnon
e96c0064ad Revert "Initial migration service changes for assessment support (#1093)" (#1098)
This reverts commit 1a0388c8cb.
2020-10-16 13:35:59 -07:00
Karl Burtram
1a0388c8cb Initial migration service changes for assessment support (#1093)
* Migration service WIP 1

* Assessment DLLs

* WIP

* WIP 2

* Add migration nuget package

* WIP2

* Fix up assessment handler

* WIP

* Fix build scripts

* WIP

* Update Assessment references

* Fix metadata copy to work with publish
2020-10-13 11:02:29 -07:00