mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-14 09:59:48 -05:00
This change ensures that when calling `requestContext.SendError` you are only able to supply parameters that match the language service beta protocol expected Error object. In other words, you have to provide an error message and optionally and error code. # **BREAKING API CHANGES** This will break displaying errors in Microsoft/vscode-mssql. I will be making changes to properly handle the error object shortly. * Adding contract for returning Error objects as per LanguageService "protocol" * Fixes throughout codebase to send only error message in error cases Cleanup of CredentialServiceTest unit test class Adding standard error handling for event flow validator * Adding optional data field as per protocol spec https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md * Adding optional validation for error objects
249 lines
10 KiB
C#
249 lines
10 KiB
C#
//
|
|
// Copyright (c) Microsoft. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
//
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
|
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts.ExecuteRequests;
|
|
using Microsoft.SqlTools.ServiceLayer.SqlContext;
|
|
using Microsoft.SqlTools.ServiceLayer.Test.Common;
|
|
using Microsoft.SqlTools.ServiceLayer.UnitTests.Utility;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.QueryExecution
|
|
{
|
|
public class ExecutionPlanTests
|
|
{
|
|
#region ResultSet Class Tests
|
|
|
|
[Fact]
|
|
public void ExecutionPlanValid()
|
|
{
|
|
// Setup:
|
|
// ... I have a batch that has been executed with a execution plan
|
|
Batch b = Common.GetExecutedBatchWithExecutionPlan();
|
|
|
|
// If:
|
|
// ... I have a result set and I ask for a valid execution plan
|
|
ResultSet planResultSet = b.ResultSets.First();
|
|
ExecutionPlan plan = planResultSet.GetExecutionPlan().Result;
|
|
|
|
// Then:
|
|
// ... I should get the execution plan back
|
|
Assert.Equal("xml", plan.Format);
|
|
Assert.Contains("Execution Plan", plan.Content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecutionPlanInvalid()
|
|
{
|
|
// Setup:
|
|
// ... I have a batch that has been executed
|
|
Batch b = Common.GetBasicExecutedBatch();
|
|
|
|
// If:
|
|
// ... I have a result set and I ask for an execution plan that doesn't exist
|
|
ResultSet planResultSet = b.ResultSets.First();
|
|
|
|
// Then:
|
|
// ... It should throw an exception
|
|
await Assert.ThrowsAsync<Exception>(() => planResultSet.GetExecutionPlan());
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region Batch Class Tests
|
|
|
|
[Fact]
|
|
public void BatchExecutionPlanValidTest()
|
|
{
|
|
// If I have an executed batch which has an execution plan
|
|
Batch b = Common.GetExecutedBatchWithExecutionPlan();
|
|
|
|
// ... And I ask for a valid execution plan
|
|
ExecutionPlan plan = b.GetExecutionPlan(0).Result;
|
|
|
|
// Then:
|
|
// ... I should get the execution plan back
|
|
Assert.Equal("xml", plan.Format);
|
|
Assert.Contains("Execution Plan", plan.Content);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task BatchExecutionPlanInvalidTest()
|
|
{
|
|
// Setup:
|
|
// ... I have a batch that has been executed without an execution plan
|
|
Batch b = Common.GetBasicExecutedBatch();
|
|
|
|
// If:
|
|
// ... I ask for an invalid execution plan
|
|
await Assert.ThrowsAsync<Exception>(() => b.GetExecutionPlan(0));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-1)] // Invalid result set, too low
|
|
[InlineData(2)] // Invalid result set, too high
|
|
public async Task BatchExecutionPlanInvalidParamsTest(int resultSetIndex)
|
|
{
|
|
// If I have an executed batch which has an execution plan
|
|
Batch b = Common.GetExecutedBatchWithExecutionPlan();
|
|
|
|
// ... And I ask for an execution plan with an invalid result set index
|
|
// Then:
|
|
// ... It should throw an exception
|
|
await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => b.GetExecutionPlan(resultSetIndex));
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region Query Class Tests
|
|
|
|
[Theory]
|
|
[InlineData(-1)] // Invalid batch, too low
|
|
[InlineData(2)] // Invalid batch, too high
|
|
public async Task QueryExecutionPlanInvalidParamsTest(int batchIndex)
|
|
{
|
|
// Setup query settings
|
|
QueryExecutionSettings querySettings = new QueryExecutionSettings
|
|
{
|
|
ExecutionPlanOptions = new ExecutionPlanOptions
|
|
{
|
|
IncludeActualExecutionPlanXml = false,
|
|
IncludeEstimatedExecutionPlanXml = true
|
|
}
|
|
};
|
|
|
|
// If I have an executed query
|
|
Query q = Common.GetBasicExecutedQuery(querySettings);
|
|
|
|
// ... And I ask for a subset with an invalid result set index
|
|
// Then:
|
|
// ... It should throw an exception
|
|
await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => q.GetExecutionPlan(batchIndex, 0));
|
|
}
|
|
|
|
#endregion
|
|
|
|
|
|
#region Service Intergration Tests
|
|
|
|
[Fact]
|
|
public async Task ExecutionPlanServiceValidTest()
|
|
{
|
|
// If:
|
|
// ... I have a query that has results in the form of an execution plan
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(Common.ExecutionPlanTestDataSet, true, false, workspaceService);
|
|
var executeParams = new ExecuteDocumentSelectionParams
|
|
{
|
|
QuerySelection = null,
|
|
OwnerUri = Constants.OwnerUri,
|
|
ExecutionPlanOptions = new ExecutionPlanOptions
|
|
{
|
|
IncludeActualExecutionPlanXml = false,
|
|
IncludeEstimatedExecutionPlanXml = true
|
|
}
|
|
};
|
|
var executeRequest = RequestContextMocks.Create<ExecuteRequestResult>(null);
|
|
await queryService.HandleExecuteRequest(executeParams, executeRequest.Object);
|
|
await queryService.ActiveQueries[Constants.OwnerUri].ExecutionTask;
|
|
|
|
// ... And I then ask for a valid execution plan
|
|
var executionPlanParams = new QueryExecutionPlanParams { OwnerUri = Constants.OwnerUri, BatchIndex = 0, ResultSetIndex = 0 };
|
|
var executionPlanRequest = new EventFlowValidator<QueryExecutionPlanResult>()
|
|
.AddResultValidation(r =>
|
|
{
|
|
// Then: Messages should be null and execution plan should not be null
|
|
Assert.NotNull(r.ExecutionPlan);
|
|
}).Complete();
|
|
await queryService.HandleExecutionPlanRequest(executionPlanParams, executionPlanRequest.Object);
|
|
executionPlanRequest.Validate();
|
|
}
|
|
|
|
|
|
[Fact]
|
|
public async Task ExecutionPlanServiceMissingQueryTest()
|
|
{
|
|
// If:
|
|
// ... I ask for an execution plan for a file that hasn't executed a query
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(null, true, false, workspaceService);
|
|
var executionPlanParams = new QueryExecutionPlanParams { OwnerUri = Constants.OwnerUri, ResultSetIndex = 0, BatchIndex = 0 };
|
|
var executionPlanRequest = new EventFlowValidator<QueryExecutionPlanResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await queryService.HandleExecutionPlanRequest(executionPlanParams, executionPlanRequest.Object);
|
|
executionPlanRequest.Validate();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecutionPlanServiceUnexecutedQueryTest()
|
|
{
|
|
// If:
|
|
// ... I have a query that hasn't finished executing (doesn't matter what)
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(Common.ExecutionPlanTestDataSet, true, false, workspaceService);
|
|
var executeParams = new ExecuteDocumentSelectionParams
|
|
{
|
|
QuerySelection = null,
|
|
OwnerUri = Constants.OwnerUri,
|
|
ExecutionPlanOptions = new ExecutionPlanOptions
|
|
{
|
|
IncludeActualExecutionPlanXml = false,
|
|
IncludeEstimatedExecutionPlanXml = true
|
|
}
|
|
};
|
|
var executeRequest = RequestContextMocks.Create<ExecuteRequestResult>(null);
|
|
await queryService.HandleExecuteRequest(executeParams, executeRequest.Object);
|
|
await queryService.ActiveQueries[Constants.OwnerUri].ExecutionTask;
|
|
queryService.ActiveQueries[Constants.OwnerUri].Batches[0].ResultSets[0].hasBeenRead = false;
|
|
|
|
// ... And I then ask for a valid execution plan from it
|
|
var executionPlanParams = new QueryExecutionPlanParams { OwnerUri = Constants.OwnerUri, ResultSetIndex = 0, BatchIndex = 0 };
|
|
var executionPlanRequest = new EventFlowValidator<QueryExecutionPlanResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await queryService.HandleExecutionPlanRequest(executionPlanParams, executionPlanRequest.Object);
|
|
executionPlanRequest.Validate();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecutionPlanServiceOutOfRangeSubsetTest()
|
|
{
|
|
// If:
|
|
// ... I have a query that doesn't have any result sets
|
|
var workspaceService = Common.GetPrimedWorkspaceService(Constants.StandardQuery);
|
|
var queryService = Common.GetPrimedExecutionService(null, true, false, workspaceService);
|
|
var executeParams = new ExecuteDocumentSelectionParams
|
|
{
|
|
QuerySelection = null,
|
|
OwnerUri = Constants.OwnerUri,
|
|
ExecutionPlanOptions = new ExecutionPlanOptions
|
|
{
|
|
IncludeActualExecutionPlanXml = false,
|
|
IncludeEstimatedExecutionPlanXml = true
|
|
}
|
|
};
|
|
var executeRequest = RequestContextMocks.Create<ExecuteRequestResult>(null);
|
|
await queryService.HandleExecuteRequest(executeParams, executeRequest.Object);
|
|
await queryService.ActiveQueries[Constants.OwnerUri].ExecutionTask;
|
|
|
|
// ... And I then ask for an execution plan from a result set
|
|
var executionPlanParams = new QueryExecutionPlanParams { OwnerUri = Constants.OwnerUri, ResultSetIndex = 0, BatchIndex = 0 };
|
|
var executionPlanRequest = new EventFlowValidator<QueryExecutionPlanResult>()
|
|
.AddStandardErrorValidation()
|
|
.Complete();
|
|
await queryService.HandleExecutionPlanRequest(executionPlanParams, executionPlanRequest.Object);
|
|
executionPlanRequest.Validate();
|
|
}
|
|
|
|
#endregion
|
|
|
|
}
|
|
}
|