Adds helpful placeholder text to repo quickpick

Moves show all quickpick item to be first
This commit is contained in:
Eric Amodio
2017-02-13 13:41:39 -05:00
parent 5f147f6262
commit 48b33d47ca
2 changed files with 5 additions and 4 deletions

View File

@@ -48,7 +48,7 @@ export class ShowAllCommitsQuickPickItem implements QuickPickItem {
detail: string;
constructor(maxItems: number) {
this.label = `Show All Commits`;
this.label = `\u21BB Show All Commits`;
this.description = `\u2014 Currently only showing the first ${maxItems} commits`;
this.detail = `This may take a while`;
}

View File

@@ -47,10 +47,11 @@ export default class ShowQuickRepoHistoryCommand extends Command {
if (!log) return window.showWarningMessage(`Unable to show repository history`);
const commits = Array.from(Iterables.map(log.commits.values(), c => new CommitQuickPickItem(c, ` \u2014 ${c.fileName}`))) as QuickPickItem[];
let placeHolder = '';
let placeHolder = 'Search by commit message, filename, or sha';
if (maxCount !== 0 && commits.length === this.git.config.advanced.maxQuickHistory) {
placeHolder = `Only showing the first ${this.git.config.advanced.maxQuickHistory} commits`;
commits.push(new ShowAllCommitsQuickPickItem(this.git.config.advanced.maxQuickHistory));
// placeHolder += `; Only showing the first ${this.git.config.advanced.maxQuickHistory} commits`;
// commits.push(new ShowAllCommitsQuickPickItem(this.git.config.advanced.maxQuickHistory));
commits.splice(0, 0, new ShowAllCommitsQuickPickItem(this.git.config.advanced.maxQuickHistory));
}
let pick: QuickPickItem;