ckaczor/vscode-gitlens
1
0
Fork 0
mirror of https://github.com/ckaczor/vscode-gitlens.git synced 2026-01-14 01:25:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

Cleans up some command overrides

Browse Source
This commit is contained in:
Eric Amodio
2017-09-05 21:30:07 -04:00
parent 68fcbf713d
commit ece34dba32
8 changed files with 15 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/commands/openBranchInRemote.ts
View File

@@ -22,10 +22,8 @@ export class OpenBranchInRemoteCommand extends ActiveEditorCommand {
protected async preExecute(context: CommandContext, args: OpenBranchInRemoteCommandArgs = {}): Promise<any> {
if (isCommandViewContextWithBranch(context)) {
args = { ...args };
args.branch = context.node.branch.name;
args.remote = context.node.branch.getRemote();
return this.execute(context.editor, context.uri, args);
}
return this.execute(context.editor, context.uri, args);

1
src/commands/openBranchesInRemote.ts
View File

@@ -20,7 +20,6 @@ export class OpenBranchesInRemoteCommand extends ActiveEditorCommand {
if (isCommandViewContextWithRemote(context)) {
args = { ...args };
args.remote = context.node.remote.name;
return this.execute(context.editor, context.uri, args);
}
return this.execute(context.editor, context.uri, args);

1
src/commands/openRepoInRemote.ts
View File

@@ -20,7 +20,6 @@ export class OpenRepoInRemoteCommand extends ActiveEditorCommand {
if (isCommandViewContextWithRemote(context)) {
args = { ...args };
args.remote = context.node.remote.name;
return this.execute(context.editor, context.uri, args);
}
return this.execute(context.editor, context.uri, args);

12
src/commands/showQuickCommitDetails.ts
View File

@@ -24,16 +24,16 @@ export class ShowQuickCommitDetailsCommand extends ActiveEditorCachedCommand {
super(Commands.ShowQuickCommitDetails);
}
protected async preExecute(context: CommandContext, ...args: any[]): Promise<any> {
protected async preExecute(context: CommandContext, args: ShowQuickCommitDetailsCommandArgs = {}): Promise<any> {
if (context.type === 'view') {
args = { ...args };
args.sha = context.node.uri.sha;
if (isCommandViewContextWithCommit(context)) {
args = [{ sha: context.node.uri.sha, commit: context.node.commit }];
}
else {
args = [{ sha: context.node.uri.sha }];
args.commit = context.node.commit;
}
}
return this.execute(context.editor, context.uri, ...args);
return this.execute(context.editor, context.uri, args);
}
async execute(editor?: TextEditor, uri?: Uri, args: ShowQuickCommitDetailsCommandArgs = {}) {

12
src/commands/showQuickCommitFileDetails.ts
View File

@@ -24,16 +24,16 @@ export class ShowQuickCommitFileDetailsCommand extends ActiveEditorCachedCommand
super(Commands.ShowQuickCommitFileDetails);
}
protected async preExecute(context: CommandContext, ...args: any[]): Promise<any> {
protected async preExecute(context: CommandContext, args: ShowQuickCommitFileDetailsCommandArgs = {}): Promise<any> {
if (context.type === 'view') {
args = { ...args };
args.sha = context.node.uri.sha;
if (isCommandViewContextWithCommit(context)) {
args = [{ sha: context.node.uri.sha, commit: context.node.commit }];
}
else {
args = [{ sha: context.node.uri.sha }];
args.commit = context.node.commit;
}
}
return this.execute(context.editor, context.uri, ...args);
return this.execute(context.editor, context.uri, args);
}
async execute(editor?: TextEditor, uri?: Uri, args: ShowQuickCommitFileDetailsCommandArgs = {}) {

2
src/commands/stashApply.ts
View File

@@ -28,7 +28,7 @@ export class StashApplyCommand extends Command {
return this.execute(args);
}
return super.preExecute(context, args);
return this.execute(args);
}
async execute(args: StashApplyCommandArgs = { confirm: true, deleteAfter: false }) {

2
src/commands/stashDelete.ts
View File

@@ -26,7 +26,7 @@ export class StashDeleteCommand extends Command {
return this.execute(args);
}
return super.preExecute(context, args);
return this.execute(args);
}
async execute(args: StashDeleteCommandArgs = { confirm: true }) {

2
src/commands/stashSave.ts
View File

@@ -35,7 +35,7 @@ export class StashSaveCommand extends Command {
return this.execute(args);
}
async execute(args: StashSaveCommandArgs = { }) {
async execute(args: StashSaveCommandArgs = {}) {
if (!this.git.repoPath) return undefined;
try {