Commit Graph
100 Commits
Author SHA1 Message Date
Barbara ValdezandCory Rivera 6e84766cec Add basic validation to database names (#23842)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-14 10:11:52 -07:00
Barbara Valdez 03acee1d12 Create new context menu item for Database (#23771) 2023-07-11 11:28:04 -07:00
Barbara Valdez bfb8536aa6 Fix error when trying to update server or database properties (#23695) 2023-07-11 11:07:09 -07:00
Barbara ValdezandCharles Gagnon 017fcf14b0 Fix issues found in the bug bash (#23741)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 10:15:41 -07:00
Barbara Valdez 9e3f117c4a include latest changes in sts (#23699) 2023-07-07 15:54:58 -07:00
a52f86bc48 Add memory inputs validation (#23685)
* memory validation

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* rename property to match sts

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-07 12:36:55 -07:00
Barbara Valdez 8048cab162 enable properties dialog (#23691) 2023-07-07 11:41:28 -07:00
Barbara Valdez a6cba3b318 Update STS (#23682)
* vbump sts

* update version to latest build
2023-07-07 09:57:51 -07:00
Barbara Valdez 32356cabc5 Server properties fixes (#23667)
* server properties fixes
2023-07-06 12:58:01 -07:00
Barbara ValdezandCharles Gagnon 378585d43e Add server properties dialog (#23270)
Add General tab for server properties
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-06-22 13:38:51 -07:00
Barbara Valdez 01bcdf9c01 update workbench file and fix relative link not working in markdown (#23109) 2023-05-11 15:31:43 -07:00
Barbara Valdez a618ef983a Display tables in html (#20640) 2022-11-04 19:00:19 -07:00
Barbara ValdezandCharles Gagnon efe56eba8c Notebook scrolling to search result instead of selected cell (#20580)
* do not scroll to current result if there's other cell active

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-11-04 11:05:26 -07:00
Barbara Valdez 2d5c168182 Update @vscode/ripgrep path (#21052) 2022-11-01 08:29:25 -07:00
Barbara Valdez 275a772496 Reimplement drag and drop with the new interface (#21037)
* re enable drag and drop in book tree view
2022-10-31 10:12:23 -07:00
Barbara Valdez 1ac141b381 remove smooth behavior from scroll for code cells (#20905) 2022-10-20 17:14:52 -07:00
Barbara Valdez 5d63f0d229 remove smooth behavior (#20794) 2022-10-10 11:48:09 -07:00
Barbara Valdez 6c7d4a2f6b disable v2 tests temporarily (#20603) 2022-09-13 20:45:12 -07:00
Barbara Valdez 7e4e8e728f Skip failing book tests (#20590) 2022-09-12 12:01:16 -07:00
Barbara Valdez 46a7fbd313 Fix unpin notebook (#20393)
* convert uri to vscode uri
2022-08-17 15:29:25 -07:00
Barbara Valdez 2119c96c88 Update pin/unpin icon after pinning notebook (#20273) 2022-08-12 14:59:07 -07:00
Barbara Valdez db8bd021be update relative path to katex css (#20293) 2022-08-10 13:17:48 -07:00
Barbara Valdez 74f01c429a Add more tests to cell image attachments (#19851)
* add more tests to cell image attachments

* remove cell attachment image name with spaces test
2022-06-29 14:13:54 -07:00
Barbara Valdez 7b16a78176 add tests for anchor links (#19659) 2022-06-20 09:29:33 -07:00
Barbara Valdez a73eb0386b Extend sql bindings api (#19651) 2022-06-07 10:12:41 -07:00
Barbara Valdez f06fd7f6f7 Fix split cell not working with attachments (#19587) 2022-06-01 16:23:46 -07:00
Barbara Valdez 132d22bfe7 add open api project method to api (#19401) 2022-05-17 15:09:16 -07:00
Barbara Valdez f551cfb835 exit infite loop after closing error message (#19376) 2022-05-13 15:14:48 -07:00
Barbara Valdez 9f69139dea add description to quick pick item (#19356) 2022-05-12 11:25:48 -07:00
Barbara Valdez e69bd2c01f Show function name when prompting user for sql binding type (#19336) 2022-05-11 13:51:15 -07:00
Barbara Valdez 742232ddd5 Add option to create sdk style project (#19290)
* update sql proj api

* remove extra spaces

* simplify check
2022-05-04 15:21:13 -07:00
Barbara ValdezandMatt Bierner ae8d3ab1bf Make sure markdown.showSource correctly awaits opening the document (#19289)
Fixes #132914

Co-authored-by: Matt Bierner <matb@microsoft.com>
2022-05-04 14:57:48 -07:00
Barbara Valdez bfd878bff7 skip test for now (#19260) 2022-05-02 10:37:15 -07:00
Barbara Valdez 5dd1cbeed8 Keyboard navigation smoke test (#18796) 2022-04-28 17:05:23 -07:00
Barbara Valdez 7a8681481e fix cell nav (#19082) 2022-04-14 10:49:17 -07:00
Barbara Valdez 683d906138 Create directory when adding a book section from book tree view (#18966)
* create folder when creating a book section

* fix test
2022-04-07 16:19:33 -07:00
Barbara Valdez 80a9d94648 Update SQL Bindings API (#18748)
* refactor addSqlBindingQuickpick so they can be called using sql-bindings api
2022-03-17 00:21:49 -07:00
Barbara Valdez 8b543d1d12 check find widget is not focused (#18506)
* remove logic to check that the find widget is visible
2022-03-02 16:57:37 -08:00
Barbara Valdez 75d9246f5e Fix search experience in notebooks (#18474)
* fix search on notebooks

* keep focus on findwidget
2022-02-18 10:53:45 -08:00
Barbara Valdez cbaffd0b0d fix section markdown and html link (#18478)
* fix section markdown and html link
2022-02-18 10:08:33 -08:00
Barbara Valdezandchgagnon ede0937c2b fix holding down key scrolling issue (#18322)
* Stop propagation + debounce scroll

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-02-17 00:25:01 -08:00
Barbara Valdez 87d5da00bf Fix on click edit mode states (#18321)
* fix click code cell

* modified editmode when updating active cell
2022-02-16 15:52:05 -08:00
Barbara Valdez 8695b463dc Enable keyboard navigation in notebooks (#18176) 2022-02-08 14:30:58 -08:00
Barbara Valdez 8378e89639 Fix Notebook Tree View smoke tests (#18101)
* pin SQL notebook
2022-01-19 09:44:34 -08:00
Barbara Valdez f8e4969ab1 Remove undo/redo listeners from notebook component (#17966)
* remove undo/redo hostlisteners
2021-12-21 14:22:26 -06:00
Barbara Valdez 2bf3c28370 Add redo action for split cells (#17947)
* add redo action for split cells
2021-12-17 15:02:37 -08:00
Barbara Valdez a267e957b0 Register undo redo command (#17948)
* register undo redo command
2021-12-16 11:35:22 -08:00
Barbara Valdez 772d0bea83 Fix split cell undo (#17845)
* fix split cell undo
2021-12-08 15:17:54 -08:00
Barbara Valdez 1651f3f8bc Add undo/redo to convert cells (#17835)
* add undo/redo to convert cells
2021-12-07 15:51:33 -08:00
Barbara Valdez 8a205965d2 add telemetry to undo/redo at cell level (#17804)
* add telemetry to undo/redo at cell level

*add sendTelemetryActionEvent that sends telemetry from notebook model
2021-12-03 16:21:52 -08:00
Barbara Valdez bb83110606 bump sqlservernotebook version (#17770)
* bump sqlservernotebook version

* Update version to 0.5.0
2021-12-03 13:03:32 -08:00
Barbara Valdez f404edbb60 do not show Add Section from command palette (#17805) 2021-12-03 09:19:35 -08:00
Barbara Valdez 8b09ba8844 Implement undo/redo at cell level (#17744)
Implemented undo and redo for adding, deleting and moving cells.
2021-12-02 13:41:42 -08:00
Barbara Valdez 9a38578c54 Edit books using dnd fix (#17141)
* add hierarchyId to tree element
2021-09-29 19:33:36 -07:00
Barbara Valdez dfc2635aa7 Add vertical scroll bar to Preview in Split View (#17164)
* reset max height

* add editor height

* set md editor height
2021-09-29 15:29:03 -07:00
Barbara Valdez ce13d01efb Book Editing: Support adding new sections to a book (#17074)
* add a new section command
2021-09-14 11:31:43 -07:00
Barbara Valdez 08eee69bbc only modify toc and move files if the target is a section or book (#17054) 2021-09-13 10:15:30 -07:00
Barbara Valdez 8161061d07 mark test as stable again (#16949) 2021-09-02 11:36:25 -07:00
Barbara Valdez bb3ccb92a4 Edit book using drag and drop (#16906)
- Use the onDrop method for moving notebooks/sections in the Notebooks Tree View.
- Allow multi selection in tree view
- Modify notebook commands to only show when a single tree item is selected.
2021-09-02 11:07:03 -07:00
Barbara Valdez 3dd212c90d Modify treeDataChange event (#125214) (#16907)
Modify treeDataChange event to support firing arrays.
2021-08-26 15:11:13 -07:00
Barbara Valdez 8aa0dffccf Remove circular reference from book tree item (#16579)
* Enable drag and drop and multiple selection in Book Tree View

* replace children for hasChildren to remove circular reference
2021-08-18 10:37:54 -07:00
Barbara Valdez 95a08d2ce7 Mark test as unstable (#16785)
* mark test as unstable

* fix close book test
2021-08-16 21:02:26 -07:00
Barbara Valdez b99be156ad set book as untrusted before running test (#16677) 2021-08-10 15:16:02 -07:00
Barbara ValdezandAlex Ross 30393a1f1b Integrate drag and drop api (#16500)
* Initial implementation of drag and drop api (#122239)

* Add drag and drop controller (#123542)

* Tree data transfer dnd (#128666)

* add drop method to sql files

Co-authored-by: Alex Ross <alros@microsoft.com>
2021-08-02 10:43:52 -07:00
Barbara Valdez f17689319c Revert to previous markdown renderer (#16246)
* Add marked files under sql/base/common
2021-07-16 17:51:53 -07:00
Barbara Valdez 6df69f525c Add conditional operator before checking length (#16180)
* add optional op to sections

* remove check for undefined
2021-07-16 11:38:18 -07:00
Barbara Valdez f7fc145b0c Set notebook path before moving. (#16055)
* set the original path when moving a single notebook

* save original file path before attempting to move in case of error_
)
2021-07-12 10:32:15 -07:00
Barbara Valdez 74cfac39d2 Fix book toc manager tests (#16034)
* fix book toc manager tests

* add js-yaml to notebooks package.json
2021-07-08 11:51:08 -07:00
Barbara Valdez 9a8c9041df add create book entry point to the bookTreeView (#15902) 2021-07-07 14:17:30 -07:00
Barbara Valdez a6644333c0 Pin and unpin notebook smoke test (#15936)
* add pin/unpin smoketest

* fix simple search query assert
2021-06-30 22:14:18 -07:00
Barbara Valdez 0e10e3e3ca fix WYSIWYG toolbar (#15901)
* fix WYSIWYG toolbar

* add height

* remove new rule and specify css selectors
2021-06-30 17:28:11 -07:00
Barbara Valdez ae7e69381a Resize open book icon (#15828)
* resize icon

* rename icon and remove icon from commands
2021-06-24 09:50:50 -07:00
Barbara Valdez aef6511ba6 Show book's notebook TOC title in pinned notebooks view (#15583)
* Show notebook title in pinned notebooks view

* fix test

* change interface name
2021-05-27 14:09:51 -07:00
Barbara Valdez 555e6a10e9 change book icon (#15539) 2021-05-20 16:05:24 -07:00
Barbara Valdez 4c66b04572 Init assets in dialog model (#15533)
* check that there are assets before filtering

* init assets as empty array
2021-05-20 15:11:15 -07:00
Barbara Valdez 558dfd693c Notebooks View: Do not recenter view when selecting a notebook that is visible (#15442)
* do not focus element when tree item is visible

* reset reveal behavior

* add comment
2021-05-13 10:19:19 -07:00
Barbara Valdez fd0a0ec2b0 replace notebook tab icon (#15282) 2021-04-29 11:31:45 -07:00
Barbara Valdez f712c14b93 fix search loading animation (#15063) 2021-04-08 15:29:40 -07:00
Barbara Valdez 4f67f32262 fix anchor links in wysiwyg (#14950)
* fix anchor links in wysiwyg
2021-04-08 10:56:11 -07:00
Barbara Valdez a7a6918b1a bump sqlservernotebook version (#15025) 2021-04-07 14:39:01 -07:00
Barbara Valdez fde5caa9a4 Add documentation and fix paths (#14948)
* use posix relative path

* add doc link in dialog

* rename book to Jupyter book
2021-04-02 15:44:25 -07:00
Barbara Valdez a00ffa0469 fix search action (#14937)
* fix search action

* remove book version from book tree item
2021-04-01 11:16:32 -07:00
Barbara Valdez fc13fb2200 Book Fixes (#14931)
* change folder icon and fix book path

* change folder icon in dark mode

* add folder.svg under resources
2021-03-31 14:02:08 -07:00
Barbara Valdez 8aa222d1c8 Add new file UI (#14773)
Adds a notebook or markdown file to a book's top level or a section by right click on Book Tree View
2021-03-30 18:44:52 -07:00
Barbara Valdez 15f7b12849 Search smoke tests (#13469)
* Add smoke test

* add simple tests for searching in notebooks view

* address pr comments

* address pr comments

* add search smoke tests to separate file

* remove span from selector
2021-03-25 12:43:55 -07:00
Barbara Valdez 5c67f3dbed fix tests on windows (#14827)
* fix tests on windows

* fix test
2021-03-23 10:03:48 -07:00
Barbara Valdez 5da4690be8 fix relative paths in wysiwyg (#14743)
* Convert relative paths to absolute paths based on the notebook uri before converting to markdown
2021-03-18 10:24:15 -07:00
Barbara Valdez 784d76b886 Remove book notebook from toc (#14704)
* Add remove notebook from book
2021-03-16 15:02:29 -07:00
Barbara Valdez 4b462a41ab Queue concurrent calls when initializing contents in BookModel (#14586)
* Initial work for handling concurrent operations when calling initialized books

* fixes to init contents

* create a queue of deferred promises for initializing books

* resolve active promise and set to undefined

* remove duplicated variable

* address pr comments
2021-03-09 10:19:30 -08:00
Barbara Valdez 0ef99ab42a remove Jupyter string from books and notebooks in UI (#14583) 2021-03-05 16:26:34 -08:00
Barbara Valdez a17a4a585e [Editing Books] - Refactor buildToc method (#14532)
* refactor buildToc method to only modify the section found and return a boolean

* fix tests

* Address pr comments
2021-03-05 11:41:31 -08:00
Barbara Valdez 3f0ca8b714 Create book dialog improvements (#14429)
* add improvements TODO on creating book experience

* fix create book to support a more complex folder structure

* replace \\ to a forward slash on windows

* address pr comments

* fix tests

* use the posix version of path.sep
2021-03-02 21:23:28 -08:00
Barbara Valdez 3d5ff25d13 Fix debounce issue when book toc is updated (#14392)
* pass function to debounce

* remove debounce decorator and move watch methods to bookmodel

* Move the vscode tree change data event to book model

* address pr comments

* fix book tests
2021-02-24 14:24:50 -08:00
Barbara Valdez 5ece9b968a Create book UI (#14210)
* Add dialog for creating books

* create empty book

* add localized constants

* add validation to dialog

* reset the create book command to original

* address pr comments

* change error message

* Init book toc manager in bookTreeView
2021-02-22 13:29:09 -08:00
Barbara Valdez 0f748a60b3 Fix not numbered inconsistency (#14269)
* fix not numbered field

* fix for adding extra field and removing it from sections

* use const for variable

* use spread operator to create new object

* address pr comments

* change function name and simplify

* Add comment and put the initializeContents in the finally block
2021-02-12 19:17:22 -08:00
Barbara Valdez 415689de9f Fix search results display (#14265)
* fix search results

* fix paths for windows
2021-02-12 16:51:14 -08:00
Barbara Valdez 612c385725 mark test as unstable (#14284) 2021-02-12 16:44:07 -08:00
Barbara Valdez 75cda19504 Add await to refresh book method (#14236)
* add await to refresh book method

* change name of method

* Reload tree view

* address pr comments

* adding finally on finally
2021-02-11 21:57:53 -08:00
Barbara Valdez 06bace1fcf replace backlash when moving notebooks on windows (#14186) 2021-02-07 20:17:30 -08:00
Barbara Valdez 467a34e878 Fix book editing issues (#14177)
* Fix issue moving a duplicated section to another book
2021-02-05 18:50:29 -08:00