Commit Graph
100 Commits
Author SHA1 Message Date
Aasim Khan b790d70089 updating sts (#22653) 2023-04-06 16:07:23 -07:00
Aasim Khan 4f341a0989 revert async changes (#22649) 2023-04-06 13:33:29 -07:00
Aasim Khan a8d851b1ed Removing oe service changes from release 1.43 (#22593)
* Revert "Fixing connection without saved password not connecting in Async Server Tree (#22535)"

This reverts commit d49ff85afc.

* Revert "Adding caching in OE service (#22539)"

This reverts commit a1acaf2096.
2023-04-03 16:04:28 -07:00
Aasim Khan d49ff85afc Fixing connection without saved password not connecting in Async Server Tree (#22535) 2023-03-31 09:19:01 -07:00
Aasim Khan a1acaf2096 Adding caching in OE service (#22539) 2023-03-31 09:18:36 -07:00
Aasim Khan 4ff16885c1 Cleaning update children logic in async server tree (#22550) 2023-03-30 15:17:45 -07:00
Aasim Khan 2a9705c495 Fixing async server tree (#22511)
* Changing look of new OE

* Fixing styling

* Fixing moving of connected profile

* Fixing drag and drop where treenodes delete connection nodes

* Fixing Deleting and disconnecting in AsyncServerTree

* Adding constant for OE timeout

* Updated interfaces

* Removing test compilation errors

* Fixing most events in async server tree

* Fixing connection pane styling

* Fixing find node function

* Fixing some more operations

* Fixing some ops

* All operations done

* Fixed active connections

* Fixed data source

* Adding support for setting parents

* code cleanup

* Fixing icon styling issues

* Fix errors

* Fixing comment

* Fixing spacing

* Adding explanation to OE service.

* Reverting server delegate changes

* Reverting styling

* reverting more styling change

* reverting more styling

* Fixing has children

* Fixing drag and drop to tree nodes

* fixing drag and drop

* reverting timing

* fixing drag and drop

* cleaning some code

* Fixed server and group moving

* spell check

* consolidating some logic

* Fixed whitespace

* fixing moving to root group
2023-03-29 13:59:35 -07:00
Aasim KhanandCharles Gagnon f60bd1335c Adding promises and operation timeouts to fix race conditions and infinite loading in OE (#22475)
* Adding promises and operation timeouts to fix race conditions

* cleaning up logic

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing promise type

* Reverting back to old error logic

* Making onsessioncreated async

* Removed polling and converted to event based

* removing connection variable out of promise

* Combining promises

* Update src/sql/workbench/services/objectExplorer/browser/treeUpdateUtils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing error messages and localizing user facing errors

* Fixing error message

* localizing config

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing comment

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-03-28 18:36:45 -07:00
Aasim Khan 3aee3f006a Fixing icon styling in tree (#22490) 2023-03-28 09:23:15 -07:00
Aasim Khan e80c6f2dcb Fixing async tree styling (#22458) 2023-03-27 13:16:23 -07:00
Aasim Khan f9e72b0d93 Fixing connection group change for connections (#22379) 2023-03-20 15:37:47 -07:00
Aasim Khan f0a5d296bf Fixing new connections not expanding in object explorer. (#22307)
* Fixing new connection node not expanding in OE

* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.

* Fixing test

* Adding a setting for node expansion timeout

* Not saving when loading tree based connections

* Adding some logs

* Removing special casing for mssql provider

* Missing providers

* Adding user toast for node expansion timeout

* Adding notification service to test

* Fixing node type for mssql

* remove polling

* Fixing onNodeStatus

* Fixing stuff

* consolidating functions

* Consolidating resolve logic

* removing extra try catch

* code cleanup

* adding size checks

* Removing commented code

* Ignoring errors from other sessions and nodepaths.
2023-03-14 10:50:46 -07:00
Aasim Khan 9fddefc8fb Fixing execution plan not finding provider (#22238) 2023-03-08 12:55:49 -08:00
Aasim Khan 84c9a03bf9 Fixing icon for group by schema (#22212) 2023-03-08 12:13:49 -08:00
Aasim Khan d3f4f0daa4 Adding light contrast theme (#22028)
* Adding light contrast theme

* fixing oe icons

* Fixing more files

* Converting ep files to support hc light

* Revert "Copy Headers for Selected Columns (#21622)"

This reverts commit f74d6f6d9b.

* Adding more css rules

* Fixing modal

* Fixing azure icons
2023-03-06 17:31:27 -08:00
Aasim Khan 644f5a16ef Fixing URI openings for execution plans (#22139) 2023-03-04 15:14:50 -08:00
Aasim Khan 9033ed5583 Adding group by schema button to OE (#22083) 2023-03-02 11:35:33 -08:00
Aasim Khan 555f8fbb1e Adding null checks to prevent runtime exceptions (#22054) 2023-02-27 23:46:14 -08:00
Aasim Khan 45d41347ba Adding null checks and fixing values in slickgrid checkbox column plugin (#22050)
* Adding null checks to checkbox column

* Setting default value for undefined checkbox
2023-02-27 18:52:16 -08:00
Aasim Khan dbd1c1b5b3 Fixing table being announced for button (#22024)
* Fixing table being announced for button

* Fixing issue in the component

* Reverting other changes
2023-02-27 11:24:58 -08:00
Aasim Khan 4fd6a57afc Adding aria label (#22030) 2023-02-27 10:43:15 -08:00
Aasim Khan c3e0478447 Adding aria role to hyperlink cell in slickgrid (#21998)
* Adding aria role to hyperlink

* Adding default
2023-02-22 10:42:11 -08:00
Aasim Khan 22c3829225 Adding setting for OE expansion timeout (#21985)
* Adding setting for OE expansion timeout

* Cleaning up the names

* Adding minimum timeout value
2023-02-17 23:02:57 -08:00
Aasim Khan e40c8dda25 Removing migration contracts from mssql (#21966)
* Removing migration contracts from sts

* Update sts

* Pushing latest sts
2023-02-17 13:50:53 -08:00
Aasim Khan 48d0aa72cc Replacing select with focus in OE (#21954) 2023-02-15 17:27:36 -08:00
Aasim KhanandCharles Gagnon d6c35836cc Adding group by schema to OE (#21941)
* Adding group by schema and updating schema icon

* Adding item context menu

* Fixing command logic

* Adding telemetry for group by and changing default config

* reverting no child nodes error message

* Code cleanup

* Cleaning up constants

* Removing unused imports

* Update extensions/mssql/src/main.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* converting to sendActionEvent

* sendActionEvent

* Adding telemetryViews and telemetry actions

* Fixing localized string

* registering context

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-02-15 15:18:10 -08:00
Aasim KhanandAkshay Mata 837236be0f Modifying the migration extension to use its own service. (#21781)
* Adding migration service to sql migrations

* enabling auto flush log

* Adding support for env variable

* Adding TDE Migration service

* code cleanup

* updating service downloader

* Removing custom output channel

* remove unnecessary await

* Updated service version to get latest code

* Consolidate TDE into migration service

* Sync to latest main

* Update sql-migration package version

* Fix merge conflict error

* Fixing all merge conflicts

* Fixing stuff

* removing extra whitespace

* Cleaning up

---------

Co-authored-by: Akshay Mata <akma@microsoft.com>
2023-02-12 09:59:09 -08:00
Aasim Khan 95d4f130c6 Replacing select with focus to prevent second create session (#21811) 2023-02-02 15:07:05 -08:00
Aasim Khan ccc8df31c7 Adding prompt for delete connection (#21624)
* Adding prompt for disconnect

* changing to Idialog service

* Code cleanup and fixing comments

* Adding comments and making a test async

* removing then and awaiting for function
2023-01-23 22:56:09 -08:00
Aasim Khan 4971a94244 Fixing nvda (#21625) 2023-01-20 12:51:34 -08:00
Aasim Khan 3b31d1018f Adding better handling for checkbox column based row selection (#21553)
* Adding better handling for checkbox column based row selection

* Replacing any with proper typings
2023-01-18 01:20:26 -08:00
Aasim Khan ed43817da7 Revert "Auto closing issues that needs logs after 7 days of inactivity. (#21390)" (#21403)
This reverts commit 30f4a3554a.
2022-12-12 13:45:46 -08:00
Aasim Khan 30f4a3554a Auto closing issues that needs logs after 7 days of inactivity. (#21390)
* Adding old issue

* Adding needs more info

* Making a different step for every issue label
2022-12-12 12:31:47 -08:00
Aasim Khan 7bc8aa8d1f updating data client protocol in import extension (#21391) 2022-12-09 16:10:29 -08:00
Aasim Khan d0b2dc702f Updating out of scope comment (#21384) 2022-12-08 16:38:40 -08:00
Aasim Khan 1117a72ade Updating decode URI lib (#21349) 2022-12-01 22:13:45 -08:00
Aasim Khan 945a134018 Vbumping electorn (#21336) 2022-11-30 12:19:12 -08:00
Aasim Khan c0a194df4a Adding wizard and dialog footer loading spinner (#21230)
* Adding wizard and dialog loading

* Moving apis to proposed

* fixing namespace

* Only firing event when the value changes

* Only firing when value is changed

* Adding loading complete message to dialog and wizard

* Registering listeners and making a new base interface for loading components

* Fixing api comment

* Renaming prop to loadingCompleted

* old loading icon
2022-11-30 12:18:34 -08:00
Aasim Khan 813fa6b2ef Updating qs lib across ads (#21323) 2022-11-29 11:40:22 -08:00
Aasim Khan c8a80a5270 Adding SQL Carbon edit comment (#21202) 2022-11-10 15:46:05 -08:00
Aasim Khan 298cc4676b Updating id generation logic to avoid substring overlaps (#21181) 2022-11-09 15:40:20 -08:00
Aasim Khan 00b797b4f3 Adding keyboard shortcuts for column resizing in slickgrid (#21100)
* Adding column resize keyboard shortcuts in slickgrid

* Switching to standard keyboard evt

* Adding comment for the functionality

* Cleaning up code and adding more comments

* Using quick input to get column resize width

* Adding check for negative sizes

* Fixing some stuff
2022-11-04 16:15:04 -07:00
Aasim Khan 355c750fce Removed plan tree as default for screen reader mode (#21082) 2022-11-02 15:30:56 -07:00
Aasim Khan 4823a76833 Adding screen reader optimized mode to slickgrid (#21069) 2022-11-02 15:11:16 -07:00
Aasim Khan 998b528680 Fixing schema compare checkbox column functions (#21025)
* Fixing select checkbox event and data state changes

* Only subscribing to event when check all is present

* converting object to map

* logic cleanup
2022-10-28 18:15:48 -07:00
Aasim Khan 968f4c7aa4 Fixing result grid plans not opening execution plan editor. (#21022) 2022-10-28 10:28:54 -07:00
Aasim Khan 512eba5675 Remove preview checks from ep (#21008) 2022-10-27 10:05:16 -07:00
Aasim Khan 1743c7ea13 Fixes: (#21004)
1. Navigation info announcement when user enter graph
2. Allowing users to expand/collapse button
3. Tooltips shown only when enter is pressed
2022-10-26 22:16:36 -07:00
Aasim Khan 4d5e9adbc1 Adding option to sort columns using F3 key in SlickGrid. (#20897) 2022-10-25 08:22:31 -07:00
Aasim Khan 84305c32c0 Adding accessible tooltips and tooltip based alerts (#20912) 2022-10-21 14:28:27 -07:00
Aasim Khan 5942980300 Adding missing stream icons for execution plan (#20896) 2022-10-20 15:24:30 -07:00
Aasim Khan e6b36cec0f Changing tree grid toggle icon color when the cell is selected (#20868)
* Changing toggle color when selected

* Using styles to support chevron coloring

* Adding escape to fix hygiene issues

* Fixing hygiene error
2022-10-20 13:53:28 -07:00
Aasim Khan d5c63f4bfb Fixing aria bug (#20872) 2022-10-19 19:39:46 -07:00
Aasim Khan 9f5ee32825 Adding new filter icon (#20762) 2022-10-06 21:34:21 -07:00
Aasim Khan 3a8cdd8440 Updating integration test script and adding additional logging. (#20710)
* killing all sub proc

* Updating file to match vscode

* Adding addtional logging

* Removing inaccurate echo
2022-10-06 16:05:56 -07:00
Aasim Khan 2a9c0a6935 Fixing filter stylings (#20685) 2022-09-30 10:00:13 -07:00
Aasim Khan 02697105f5 Fixing row selection and styling in select column (#20670) 2022-09-27 15:55:55 -07:00
Aasim Khan fd8993134f Execution Plan Filtering and UI improvements (#20631)
* Fixing execution plan stuff

* Adding filter to top operations

* Flipped custom zoom icon

* changing keys

* Moving constants to a file

* Search properties

* Making logic concise
2022-09-23 12:57:30 -07:00
Aasim Khan 37636012da Fixing Slick Grid accessibility bugs. (#20514)
* some alignment fixes

* Redesigning slickgrid checkbox plugin

* Reverting original plugin to main state

* Fixing css

* Reverting file

* Removing extra whitespace

* Adding title

* Removing older plugin

* vbumping slick grid

* Pushing other vbumps

* Adding more targeted css selectors
2022-09-22 14:25:19 -07:00
Aasim Khan 3f6f6ed07b Changing property header row styling for execution plan properties (#20594) 2022-09-12 17:20:16 -07:00
Aasim Khan 010fe91921 Adding image support to list view (#20449) 2022-08-31 09:02:40 -07:00
Aasim Khan 7857e5946f New azdata graph layout (#20451)
* Updated contracts

* Adding latest azdataGraph update

* Updating graph lib
2022-08-24 12:09:17 -07:00
Aasim Khan ec215604a8 Adding arialabel to radio groups (#20423) 2022-08-19 15:10:23 -07:00
Aasim Khan a7a337f063 Adding properties grid enhancements in execution plan (#20208)
* init push

* Fixing properties in plan comparison

* Add long Text Cell viewer

* Disabling auto edit by default

* Removing text editor
2022-08-11 11:22:12 -07:00
Aasim Khan d139559d98 Adding arialive to text (#20242) 2022-08-03 20:25:17 -07:00
Aasim Khan 1cbe11ad38 Adding ariaLive to assessment in progress (#20237) 2022-08-03 13:46:39 -07:00
Aasim Khan 518bb33a2f Adding plan tree to execution plan (#20158)
* Adding plan tree

* Fixing localization keys

* Removed whitespace
2022-07-26 14:30:46 -07:00
Aasim Khan 67637a41f5 Making better ep highlights (#20055) 2022-07-15 15:31:01 -07:00
Aasim Khan 59889252f1 updating sts to get latest top operations changes (#20005) 2022-07-12 15:55:11 -07:00
Aasim Khan b15f3bd986 Fixing port request actions (#19966) 2022-07-12 15:54:56 -07:00
Aasim Khan 980a233aad Sorting top by cost initially (#19998) 2022-07-11 21:34:38 -07:00
Aasim Khan 53a0388858 Deleting old query plan code (#19996) 2022-07-11 19:14:47 -07:00
Aasim Khan 5d17ed6760 Updating gulp-atom-electron to update braces (#19947) 2022-07-11 09:01:44 -07:00
Aasim Khan 059b70c6a4 Fixing macos test results publishing warnings (#19968)
* Fixing macos task

* Renaming job step
2022-07-08 18:43:33 -07:00
Aasim Khan 61c38b8f83 updating ajv (#19950) 2022-07-08 16:10:34 -07:00
Aasim Khan 9cfa1436d9 Adding top operations to execution plans (#19902)
* Adding top operations to execution plans

* Adding title to links

* Fixing pr comments

* Hiding top operations icon in execution plan editor

* Reducing outline width, adding separator and removing placeholder text

* Registering TopOperationsTabView
2022-07-07 12:50:52 -07:00
Aasim Khan 19b9290dfa Updating sts (#19943) 2022-07-07 09:37:22 -07:00
Aasim Khan b8b3c65588 Updating azure-storage in build (#19936) 2022-07-06 16:09:53 -07:00
Aasim Khan 15a611d4a4 Fixing tabbing logic for tab headers (#19770)
* Fixing tabbing logic for tab headers

* Renaming stuff
Making null checks concise
Adding comments

* Renaming css class and interfaces from active to selected

* Renaming styling classes and objects

* Changing tabbing logic to match w3 behavior

* Fixing focus logic in tab

* Adding helper comment

* Code cleanup
2022-06-21 13:13:10 -07:00
Aasim KhanandCharles Gagnon 8079cf8a2d Adding arialive to flex and div container (#19757)
* Adding arialive to flex and div container

* Fixing compilation issues

* Moving ariaLive to container properties

* fixes

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-06-21 09:45:45 -07:00
Aasim Khan d4509a6528 Removing truncation from tab header components to make it match the portal look (#19746)
* Fixing truncated tab headers

* Localizing changes to horizontal tab headers

* Remove max - width

* Reverting older changes
2022-06-16 14:07:45 -07:00
Aasim Khan b980fe1106 Hiding description tooltip on escape key. (#19741)
* Hiding text tooltip on escape

* Fixing hover event
2022-06-15 18:23:18 -07:00
Aasim Khan 489259d364 Fixing graph root padding and truncating long queries in execution plan (#19703)
* Fixing graph root padding
Truncating queries to one line

* Updating remote package
2022-06-09 17:05:35 -07:00
Aasim Khan b1d8e43569 Changing plan comparison properties table logic and icons (#19700)
* Changing plan comparison logic and icons

* Removing empty class ref
2022-06-09 14:15:35 -07:00
Aasim Khan 0b89272739 Removing filter from set Data (#19640) 2022-06-06 13:44:42 -07:00
Aasim Khan 36c480699f Surfacing extension install errors (#19613)
* Surfacing extension install error

* Fixing error property

* removing unncessary await

* Fixing error type and message

* Fixing some more strings

* Adding missing period

* Consolidating some strings

* consolidating strings

* revert vbump

* Switching to ExtensionManagementError
2022-06-03 19:41:09 -07:00
Aasim Khan b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Aasim Khan f0f4a0a3cf Updating sqltoolsservice (#19614) 2022-06-03 16:25:16 -07:00
Aasim Khan 67f8ffea52 Updating vsce package (#19536)
* Updating vsce package

* Removing unsupported extensionKind
2022-05-26 13:13:25 -07:00
Aasim Khan 386c986480 Updating set-value (#19534) 2022-05-26 10:08:35 -07:00
Aasim Khan 63712909aa updating normalize-url (#19535) 2022-05-26 10:08:15 -07:00
Aasim Khan 4e39c5fcf6 Updatin kind-of (#19533) 2022-05-26 10:03:57 -07:00
Aasim Khan f7aeccb0d4 updating gulp-azure-storage (#19492) 2022-05-25 22:19:57 -07:00
Aasim Khan 36cd60f290 Reverting gulp-untar resolution (#19529) 2022-05-25 18:10:20 -07:00
Aasim Khan 6282958bd1 scoping css (#19520) 2022-05-25 10:31:29 -07:00
Aasim Khan 6838261aed Updating tar across ads (#19507) 2022-05-24 18:23:41 -07:00
Aasim Khan b194a5a784 updating gulp-eslint (#19491) 2022-05-24 10:28:50 -07:00
Aasim Khan 719a7889fc updating kind-of (#19489) 2022-05-23 17:51:12 -07:00
Aasim Khan a7749471ec Updating remote-retry-src (#19488) 2022-05-23 16:16:17 -07:00
Aasim Khan c9c670cc86 Updating a vulnerable package (#19485) 2022-05-23 15:22:03 -07:00