Vasu Bhog
a0576456b6
Add Keybindings for some Markdown Toolbar Actions ( #17198 )
...
* Add Keybindings for some markdown toolbar
* add extension registry
* when in text cell stopPropagation to only trigger one command
2021-09-30 15:20:45 -07:00
Vasu Bhog
db1d3cc517
Markdown Horizontal Scrollbar Fix ( #17083 )
...
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
2021-09-27 16:54:43 -07:00
Vasu Bhog
529e4fe0de
Fix ADS Web notebook cross linking ( #16926 )
...
* fix cross linking files
* use host location instead
2021-08-30 15:43:16 -07:00
Vasu Bhog
179678b495
Refactor Notebook Link Handling ( #16473 )
...
* add keep absolute paths instead convert setting
* update tests/config
* refactor links in NotebookLinkHandler
2021-07-30 19:20:38 -07:00
Vasu Bhog
788c84a1ee
fix email else condition ( #16491 )
2021-07-29 18:37:06 -07:00
Vasu Bhog
151522013f
Notebook Markdown email rendering fix ( #16417 )
...
* fix email WYSIWYG rendering
2021-07-23 15:24:34 -07:00
Vasu Bhog
63e97caa94
Fix Windows WYSIWYG linking issue (switching to splitview and resolving links in WYSIWYG) ( #16133 )
...
* fix relative links not correctly formatted due to marked js
* logic in one place
2021-07-16 13:27:45 -07:00
Vasu Bhog
27823e9900
Fix CalloutDialog not opening after bad link ( #16051 )
...
* fix null parentNode
2021-07-09 09:01:48 -07:00
Vasu Bhog
14ce88023e
Add allow root setting for Ubuntu and Web Mode users ( #16027 )
...
* add allow root setting for Ubuntu and Web Mode users
2021-07-07 11:02:12 -07:00
Vasu Bhog
7cf7ca5d15
use helper function for smoke test ( #15964 )
2021-06-30 21:33:54 -07:00
Vasu Bhog
ec057ba8c1
[ADS Web] Fix Plotly notebook rendering issue ( #15948 )
...
* fix Plotly render issue
2021-06-30 09:56:09 -07:00
Vasu Bhog
c3e0958f2d
Add simple smoke test for collapse/expand cell ( #15879 )
...
* simple smoke test for collapse / expand cells
2021-06-25 18:08:35 -07:00
Vasu Bhog
b8dbd3f0dc
do not prompt for notebook uri file ( #15809 )
2021-06-18 13:07:08 -07:00
Vasu Bhog
1de05a2339
Fix WYWIWYG Table cell adding new line in table cell ( #15594 )
...
* fixes new line in table cell
* add test and fix for table head
2021-05-28 13:47:50 -07:00
Vasu Bhog
730367494b
Run with Parameters learn more link to use correct format and kernels ( #15547 )
...
* indicate to users correct format and kernels
* add test for unsupported kernel
* replace with enum
2021-05-25 17:39:19 -07:00
Vasu Bhog
8a0c183114
fix changing kernels from kusto to other kernels ( #15545 )
2021-05-24 13:52:32 -07:00
Vasu Bhog
70b0d89b5d
Notebook URI Handler File Support ( #15340 )
...
* file URI handler
* supports Parameterization
2021-05-12 18:11:40 -07:00
Vasu Bhog
cb06ca07c0
Fixes the empty parameter cell and multi parameters on one line ( #15234 )
...
* fix two bugs
* work on empty parameter cell and format properly
* add empty cell tests
2021-05-06 14:48:38 -07:00
Vasu Bhog
c66a8ca171
fix parameterized notebook output ( #15233 )
2021-04-27 12:40:49 -07:00
Vasu Bhog
6951bf3b90
Ability to see and edit links in split view/markdown mode ( #15150 )
...
* callout dialog selects link properly in split/markdown mode
* use regex for links
2021-04-20 23:33:14 -07:00
Vasu Bhog
3a1885491f
Update run w/parameters icon and increment parameterized notebook ( #15127 )
...
* update icon and increment parameterized notebook
2021-04-14 15:28:27 -07:00
Vasu Bhog
58d0add46f
Save Kusto Notebook with proper language notebook info ( #15113 )
...
* save kusto language info
2021-04-13 17:28:33 -07:00
Vasu Bhog
9f63653a53
Fixes notebook integration tests + running parameterized notebook ( #15107 )
...
* fix interface
* fix run all cells on new parameterized notebook
* add getNotebookUri function
2021-04-13 17:23:15 -07:00
Vasu Bhog
d76a6698a9
[Notebook] Run Parameters Action openNotebook Functionality in Core ( #14978 )
...
* NotebookService update
* openNotebook functionality in NbService
* Add tests for RunParametersAction
2021-04-08 14:48:37 -07:00
Vasu Bhog
04af3e161a
See and Edit Selected Links in Callout Dialog ( #14987 )
...
* Add URL label to linkCallout
* add test for file link
2021-04-06 11:51:53 -07:00
Vasu Bhog
0a7719b475
[Notebook] Run Parameters Action UI Component ( #14889 )
...
* Run Parameters Action UI Component
* Update UX discussion - accept empty string
2021-04-05 13:59:27 -07:00
Vasu Bhog and Vasu Bhog
0141db80bc
[Notebook] Open Kernel Alias (Kusto) notebook with Kernel Alias (Kusto) as selected kernel ( #14504 )
...
* Open kernel alias notebook with kernel alias as selected kernel
* Add language info test
* fix test
Co-authored-by: Vasu Bhog <bhogvu@mail.uc.edu >
2021-03-04 12:36:25 -08:00
Vasu Bhog
df51f35be0
Enable Parameterization via Notebook URI ( #13869 )
...
* Enable Parameterization via Notebook URI
* Add Parameterization and Move notebookModel tests
* minor typos
* parameter typo
* Multiple parameters through uri fix
* Address PR comments and tests fix
* add new injected parameters after original injected parameters
* Add new test to verify notebookURi parameter is injected after both parameter and injected cell
* fix tests
2021-01-08 00:38:33 -08:00
Vasu Bhog
133958ea47
renable kernels dropdown test ( #13727 )
...
Verify no skipped core tests
2020-12-11 17:49:20 -08:00
Vasu Bhog
048f85d918
Fix notebook unordered grid values after papermill execution ( #13614 )
...
* Fix unordered table
* check entire first row schema:
* SQL Notebooks should not get affected
* delete unused variable and edit comments
* refactor for efficient table ordering
* nit naming
2020-12-03 19:37:22 -06:00
Vasu Bhog
2a7b90fd70
Fix WYSIWYG text + image paste ( #13542 )
...
* Fix WYSIWYG text + image paste
* add test for a link and text
2020-11-25 12:42:07 -06:00
Vasu Bhog
7cd4964f35
Fix for < > (non HTML) tags disappearing in WYSIWYG ( #13267 )
...
* Push the latest update for WYSIWYG bug
* Improvements to nested lists
* OL tests and PR feedback
* Fixed all toolbar options for tags
* Address PR comments
* Ensure style is kept and not escaped
* Add all markdown toolbar action tests
* Style text edge case fix
* Address repeat function and type comment
* add more clarifying test
2020-11-09 20:26:28 -06:00
Vasu Bhog
351516f08d
Change the way we insert Injected Parameter ( #13171 )
2020-11-02 09:14:37 -08:00
Vasu Bhog
338beaff29
Update powershell kernel version to 0.1.4 ( #13167 )
...
* Update powershell kernel version to 0.1.4
2020-10-31 09:01:05 -07:00
Vasu Bhog
cb30dd1893
Notebook Parameterization - Papermill Compatibility ( #13034 )
...
* Parameterization papermill fix
* Utilize isParameter instead
* Address PR comments, and fix tests
* Address comment
2020-10-23 20:32:55 -05:00
Vasu Bhog
bf9fd5a3b8
UI Component for Parameterized Notebook ( #13021 )
...
* Backend work for Parameterization + Tests
* address comments
* Add Parameters Tag upon state change
* Edit CSS Styling for accessibility
* more generic tag names
2020-10-23 19:51:03 -05:00
Vasu Bhog
fcec690546
Backend work for Notebook Parameterization and Tests ( #12914 )
...
* Backend work for Parameterization + Tests
* minor comments
* fix test
* address comments
2020-10-20 13:26:59 -05:00
Vasu Bhog
53f00bee12
Fix connection when changing kernel from Kusto to SQL ( #12881 )
...
* Fix Kusto to SQL kernel connection change
* Updated Fix - removes kernel alias mapping while ensuring multi kusto notebooks work properly
* Fix tests
2020-10-10 00:10:33 -05:00
Vasu Bhog
726f0cef0e
Add Notebook tests for Kernel Alias connections ( #12722 )
...
* More Generic tests for kernel alias connections
* Kernel Alias tests for the Notebook Model
* Updated titles of tests
2020-10-05 23:17:41 -05:00
Vasu Bhog
63adfd4d38
Fix PySpark kernel connection change ( #12494 )
2020-09-18 20:35:25 -05:00
Vasu Bhog
eea35d4920
Fix Spark kernel connections and switch from Kusto to Spark kernels ( #12436 )
...
* Fix connection dialog for Spark and issue when switching from Kusto to Spark
* Address comments
2020-09-17 22:16:42 -05:00
Vasu Bhog
7a524d7a35
Fix Notebook Kusto Kernel Consistency ( #12256 )
...
* fix kusto notebook consistency
* Address undefined
2020-09-14 14:18:53 -05:00
Vasu Bhog
ff61eae164
Fixed Kusto change connections for previous notebooks ( #12207 )
...
* fix connection dialog for change connection on notebook
* Better way to show all connections for providers
* minor change
2020-09-10 13:20:35 -05:00
Vasu Bhog
3a0be70783
Kusto Kernel New Notebook Changes ( #12085 )
...
* Kusto New Notebook Action Changes
* Kusto Cluster properly switches context when kernel changes
* SQL Connections kernel change to Kusto works properly
* Multiple New Kusto Notebooks open properly and change kernels properly
* Fix SQL Notebook - Change to Kusto Kernel
* Fix unit tests
* Address comments
* Add test, and finalize changes
2020-09-09 09:19:36 -05:00
Vasu Bhog
d59063ebab
Add tests to NotebookUriHandler ( #11959 )
...
* NotebookUriHandler Test
* set test to previous, return promise for handleUri
* Added tests for file uri scheme https/http
* Updated NotebookUri to await handleUri calls and add more tests
2020-08-28 10:51:12 -05:00
Vasu Bhog
29fbc7d952
Refactored Server Instance Tests ( #11868 )
...
* Refactored and improved testing through sinon
* Addressed changes - helper function and direct call to function refactor
2020-08-19 17:28:15 -05:00
Vasu Bhog
2bfba53e21
Kusto Notebook Kernel Changes ( #11760 )
...
* Able to get Kernel Alias using extension registery
* Get Kernel Alias through Capability Services
* Notebook Action feature to add kusto to dropdown based on extension - complete
* Fixed indexing issue when Kusto is in kernels Dropdown
* Kusto Kernel listed properly and selected when kernel changes
* Added kernel change when user Attaches To Kusto connection
* Deleted unnecessary code/refactored
* Fix Merge Issues
* Resolving Compile issues - test file error
* Capabilities Provider Changes
* Fixed Notebook Tests
* Rearchitect kernel changes to Notebook Model
* Address minor changes
2020-08-18 14:52:25 -05:00
Vasu Bhog
71fbe2ed53
Fix markdown cell toolbar focus not being visible ( #11386 )
...
* Markdown Toolbar focus fix
* Fixed sizing issues of icons
* Fixed spacing
2020-07-17 11:04:17 -05:00
Vasu Bhog and Vasu Bhog
e714c876c2
Onboarding Pull Request ( #11298 )
...
Co-authored-by: Vasu Bhog <vasubhog@Vasus-MacBook-Pro.local >
2020-07-10 16:17:35 -05:00