ckaczor/azuredatastudio
Archived
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,550 Commits 1 Branch 152 Tags
1f0cdf82e4047b9a08cc77cf3dc786c5abfcd2af
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris LaFreniere 1f0cdf82e4 Notebook Text Cell Highlight Improvements (#12197) 
* 1st iteration

* works but multiple highlights

* remove comment

* Works but multiple selects

* wip

* cleanup

* cleanup

* Update TPN

* Add mark.js to remote + web

* PR feedback

* Tweak workbench html files
 2020-09-10 21:40:29 -07:00
Chris LaFreniere 869d071f73 storage class data controller (#12209) 2020-09-10 10:41:12 -07:00
Chris LaFreniere adefa213e2 String update (#12202) 2020-09-09 19:07:40 -07:00
Chris LaFreniere 82132583af Re-enable previously commented out configure python wizard tests (#11945) 
* Re-enable configure python wizard tests

* Remove extra comment
 2020-08-25 11:26:37 -07:00
Chris LaFreniere e90578694b Call onDidInsert Before Layout (#11819) 2020-08-14 19:52:27 -07:00
Chris LaFreniere a34a72795b Notebook Code Cleanup + Utils Test (#11754) 
* Cleanup + Utils Test

* Removing unnecessary util method
 2020-08-14 14:08:56 -07:00
Chris LaFreniere 0c3c714be1 Stop hardcoding python3 (#11464) 2020-07-21 16:38:04 -07:00
Chris LaFreniere 3792a6328f Fix Notebooks Word Wrapping Logic (#11415) 
* make word wrap logic easier

* Stop passing in IConfigurationService
 2020-07-20 13:50:26 -07:00
Chris LaFreniere 171f091c88 Fix no books currently selected error in viewlet (#11269) 
* Fix no books currently selected error

* check sections undefined vs length
 2020-07-09 23:14:46 -07:00
Chris LaFreniere 5f8180ebbf Add Notebook Completion Item Provider Unit Tests (#11222) 
* completion item provider tests

* Add nb completionItemProvider tests
 2020-07-07 12:48:22 -07:00
Chris LaFreniere 2b5ae5e3a8 Update singular vcore string (#11157) 2020-06-30 17:10:46 -07:00
Chris LaFreniere a8a7559229 Add more notebook extension tests (#11143) 
* more tests

* More tests

* More tests

* Add prompt tests
 2020-06-30 11:01:51 -07:00
Chris LaFreniere a32f42d475 Update Arc Extension with New Strings and azdata Version (#11148) 
* Strings and azdata version changes

* change azdata description
 2020-06-30 09:08:01 -07:00
Chris LaFreniere 061d3510b9 Run ADS Commands from Notebooks (#11069) 
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
 2020-06-28 21:17:50 -07:00
Chris LaFreniere 9dc7ca056f Change nb before/after strings (#11121) 2020-06-26 17:36:28 -07:00
Chris LaFreniere 7080e3ec4e Notebooks: Add Some Jupyter Controller Tests (#11053) 
* First jupyter controller tests

* PR comments

* remove unnecessary checks for throw

* fix comment typo
 2020-06-23 23:08:25 -07:00
Chris LaFreniere 98ff618efd Add deprecated tag for standardKernels property (#11038) 
* Remove unnecessary prop from NotebookProvider API

* Add deprecated tag

* make standardKernels required again

* tweak comment
 2020-06-22 21:15:39 -07:00
Chris LaFreniere eaf753f79e Remove unused prompt code (#10996) 2020-06-18 17:23:32 -07:00
Chris LaFreniere 77ba5a36aa Add Jupyter Notebook Manager Tests (#10955) 
* jupyter notebook manager tests

* cover config duplicate integrationTest
 2020-06-17 14:42:35 -07:00
Chris LaFreniere 960aa14027 stop running magics that dont exist (#10894) 2020-06-12 14:25:01 -07:00
Chris LaFreniere 168ef80d8f Fix Notebook Viewlet Highlighting (#10868) 
* Stop double tree data provider registrations

* revert book finding logic, leverage currentBook
 2020-06-10 22:27:16 -07:00
Chris LaFreniere 48ec8e6dd8 Bring back hover state setting on cell model (#10758) 2020-06-05 17:14:36 -07:00
Chris LaFreniere 258310ba81 Change markdown cell to text cell (#10715) 2020-06-04 12:38:30 -07:00
Chris LaFreniere cc3554e987 Only show edit cell action for markdown cells (#10719) 2020-06-04 10:20:47 -07:00
Chris LaFreniere 6d710c7144 Add plumbing and simple notebookService tests (#10349) 2020-05-19 21:36:59 -07:00
Chris LaFreniere 452bd6a0cb Notebook model ready sooner (#10420) 2020-05-15 11:48:11 -07:00
Chris LaFreniere 5e1978e29f Ensure ipynb is associated with editor (#10055) 2020-05-08 14:50:48 -07:00
Chris LaFreniere e4614582cd Cleanup nbformat, more common tests (#10311) 2020-05-08 14:50:24 -07:00
Chris LaFreniere 0fbc3d1cb6 Get rid of red herrings (#10309) 2020-05-08 14:49:49 -07:00
Chris LaFreniere dac1970c43 Notebooks: Refactor Empty Session Classes (#10265) 
* Cleanup empty sessionmanager

* Cleanup

* PR Feedback import noKernel from notebookActions
 2020-05-07 16:20:14 -07:00
Chris LaFreniere 52abcd68af Tweak cell margin (#10247) 2020-05-01 14:12:41 -07:00
Chris LaFreniere a9bfdf0fc9 Updating Arc Names (#10201) 2020-04-29 10:34:47 -07:00
Chris LaFreniere 0a3a0ec80f Notebooks: Support User-Installed Kernels (#10194) 
* Fixes for attach to. Still need to update cache

* Don't have jupyter hardcoded

* Handle DOTNET_ROOT env var

* Fix on load

* Put behind feature flag

* Cleanup

* Error check

* PR feedback
 2020-04-29 10:34:27 -07:00
Chris LaFreniere 5b57b13005 Update python Mac install url (#10200) 2020-04-29 10:29:52 -07:00
Chris LaFreniere 98f3f57f77 Improve code selection and undo, add tests (#10160) 2020-04-28 16:26:23 -07:00
Chris LaFreniere fb1fbb214d Notebook Cell Magic Mapper Tests (#10172) 
* cell magic mapper tests

* Add space in description for test
 2020-04-28 16:18:55 -07:00
Chris LaFreniere e9339bb0d5 Cleanup and clientSession uncomment (#10162) 2020-04-27 11:07:35 -07:00
Chris LaFreniere 7633c810aa First tests for notebook markdown transformer (#10072) 
* First tests for markdown toolbar

* Fix loader issues

* PR Feedback
 2020-04-23 21:24:15 -07:00
Chris LaFreniere 4f1d4276a0 Check for file scheme in linkhandler (#10090) 2020-04-20 17:18:38 -07:00
Chris LaFreniere 51f47fbdee Bring back hover buttons for adding cells (#10012) 2020-04-16 11:22:29 -07:00
Chris LaFreniere 4e92c27189 Notebooks: Fix Issue Around Load Error when Tables Have No Rows (#9980) 
* Table element children length check

* Add another check
 2020-04-15 12:10:40 -07:00
Chris LaFreniere fca2344c2e Remove old CTP code, add test (#9877) 2020-04-07 20:09:52 -07:00
Chris LaFreniere 1d22e23c2d Add a few more notebook model unit tests (#9859) 
* Add a few more notebook model tests

* Add tests for nb managers, active cell

* Add assert messages
 2020-04-06 16:39:02 -07:00
Chris LaFreniere c102322594 Revert "Merge branch 'master' of https://github.com/microsoft/azuredatastudio" (#9844) 
This reverts commit ec46783e47, reversing
changes made to 6e6649d006.
 2020-04-03 02:09:47 -07:00
Chris LaFreniere bb135d6c67 Ensure kqlmagic is only offered for pip (#9776) 2020-03-30 16:33:49 -07:00
Chris LaFreniere 2c05b07ee4 Fix Notebook Tokenization Warnings (#9725) 
* Change html table serialization to array

* PR feedback

* rename variable
 2020-03-26 13:03:51 -07:00
Chris LaFreniere 7658a5df28 Fix search icon only working when section expanded (#9596) 2020-03-12 21:35:38 -07:00
Chris LaFreniere 16fab722d5 Remove Decompress + Replace with Other Package (#9532) 
* add windows support

* works on windows

* Still testing, works on Windows

* Reject on error

* Fix adm-zip external
 2020-03-10 19:55:25 -07:00
Chris LaFreniere 268463b5c7 Remove decompress (#9530) 2020-03-10 13:21:51 -07:00
Chris LaFreniere 3a1cd98856 Add Internal Command for New Resource Deployment (#9122) 
* Prevent check in openerService for cmdregistry

* Revert "Prevent check in openerService for cmdregistry"

This reverts commit c40079e6f38dcd379941474accc1a1e3b42f6103.

* Add internal command that calls extension command

* Add comment
 2020-03-10 12:46:55 -07:00
Chris LaFreniere 80ed6131ce Fix find highlight for multiple find occurrences (#9518) 2020-03-10 10:23:16 -07:00
Chris LaFreniere 1fb3faeda1 Notebooks: Fix Internal Links on Windows (#9513) 
* Improve workbench file path detection

* Use fspath instead
 2020-03-09 18:10:24 -07:00
Chris LaFreniereandMaddy 0a9a0d3f46 Ensure Active File is Highlighted in Books Viewlet (#9338) 
* Add Reveal in Books editor tab context option

* Select item in books viewlet automatically

* changes

* easier than i thought it'd be

* Merge from Feat/create book

* Undo Merge from Feat/create book

* Use fsPath instead of path

* PR comments

* Fix tests

Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
 2020-03-05 23:43:22 -08:00
Chris LaFreniere 0f9d98730e Improve find by tracking actual rendered text (#9419) 
* Improve find by tracking actual rendered text

* Fix tests, add notebook md render
 2020-03-03 16:56:11 -08:00
Chris LaFreniere 29cf1f898e Search sections in Jupyter Viewlet (#9346) 2020-02-26 13:59:38 -08:00
Chris LaFreniere 41a90c01c3 Listen to escape key to close nb find widget (#9247) 2020-02-21 15:54:21 -08:00
Chris LaFreniere 2503b18d4b Fix for manage access dialog focus (#9114) 
* Fix for manage access dialog focus

* Leverage eventuallyRunOnInitialized
 2020-02-13 16:40:23 -08:00
Chris LaFreniere f10a504f45 Notebooks: Listen for Enter on Add Package Tab (#9124) 
* Pressing enter searches for package

* cleanup
 2020-02-13 11:14:51 -08:00
Chris LaFreniere b4e30e17af Remove unnecessary code to sql-vnext extension (#9027) 2020-02-06 17:37:46 -08:00
Chris LaFreniere 343daf58fe Notebooks: Fix Padding on Mac SelectContainers in Toolbar (#9021) 
* fix css on mac

* change to monaco workbench mac
 2020-02-05 16:06:55 -08:00
Chris LaFreniere 8e67b104c3 BDC: Add another command for bdc extension activation events (#9050) 
* Add another command for bdc extension activation

* spaces

* Add other activation events

* spacing
 2020-02-04 20:09:39 -08:00
Chris LaFreniere 10d817b6b4 Change ps kernel version to latest 4 updated flow (#9023) 2020-02-04 11:52:28 -08:00
Chris LaFreniereandCharles Gagnon 2208666eef Books: Ensure associatedResource is Present for Untitled Notebooks that have a File Associated with them (#9037) 
* Conditionally add associatedResource t untitled nb

* Fix Jupyter Book notebook titles (#9039)

* Fix notebook titles

* Fix navigation links for books

* Added comments

Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>

* PR comment nit

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2020-02-04 11:42:24 -08:00
Chris LaFreniere de27f2c2a5 stop firing active cell change events unnecessary (#8983) 2020-01-29 13:54:48 -08:00
Chris LaFreniere 89554e5c14 Re-enable windows test (#8981) 2020-01-28 17:48:07 -08:00
Chris LaFreniere 136a1d8cee Temporarily Disable Windows_Test Job in Product Build (#8971) 
* Temporarily Disable Windows Test Job

* Ensure Windows Test is removed from dependsOn
 2020-01-27 17:32:24 -08:00
Chris LaFreniere b02bf17d1f Fixes for broken notebook experience (#8944) 
* Fixes for broken notebook experience

* add sql carbon edit

* sql carbon edit

* add another sql carbon edit for import

* Set untitledResource instead of no resource
 2020-01-23 17:06:32 -08:00
Chris LaFreniere 826e069b63 Fix passing in connection profile (#8689) 2019-12-16 13:20:43 -08:00
Chris LaFreniere 6e8a08c27a Fix Notebook Scrolling by Setting alwaysConsumeMouseWheel to False (#8686) 
* flip alwaysConsumeMouseWheel to false for nb

* remove semicolon
 2019-12-16 13:17:02 -08:00
Chris LaFreniere d1c594cfd0 Change deploy string from connections viewlet/welcome page (#8646) 
* Change deploy string from connections viewlet

* Also change welcome page
 2019-12-12 10:25:22 -08:00
Chris LaFreniere 698b4fce41 Add generic select box padding (#8635) 2019-12-10 22:14:01 -08:00
Chris LaFreniere 302e8305ef add titles to collapse expand button (#8607) 2019-12-10 21:08:28 -08:00
Chris LaFreniere bceb766d28 Notebooks: Fix Cancel for Connection Dialog to Actually Close Window (#8626) 
* Fix connection dialog not going away on cancel

* Remove unnecessary change
 2019-12-10 16:59:15 -08:00
Chris LaFreniere 62565e0577 Notebooks: Only have One Connection in Attach To Dropdown (#8582) 
* Have only one connection in attach to dropdown

* LGTM fixes

* Test fixes not unnecessarily changing context 2x

* PR Feedback
 2019-12-08 11:03:51 -08:00
Chris LaFreniere 8655044dfb Notebooks cleanup: Remove old out of proc markdown option (#8394) 
* Remove old out of proc markdown option

* Revert change to stats.js
 2019-11-20 14:00:06 -08:00
Chris LaFreniere 7e553031ce Remove open notebook entry points (#8393) 2019-11-20 13:46:03 -08:00
Chris LaFreniere 2f1f5b2376 Prevent Markdown Cells from Collapsing (#8317) 2019-11-12 18:40:06 -08:00
Chris LaFreniere 0520870754 notebooks lgtm cleanup part 1 (#8280) 2019-11-11 13:40:48 -05:00
Chris LaFreniere 55acb36e33 Update powershell kernel version to 0.1.2 (#8171) 2019-11-01 10:47:32 -07:00
Chris LaFreniere 5aff7ef4c7 Ensure cwd matches notebook path (#8137) 
* Ensure cwd matches notebook path

* add error checking

* silent, don't store history
 2019-10-31 15:10:49 -07:00
Chris LaFreniere dd270a78fc Notebooks: Improvements to Connection Profile Passing (#8105) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering

* update databaseName when it's set to master

* usinng query as example
 2019-10-30 13:22:17 -07:00
Chris LaFreniere 62af81e88c Notebooks: Fix relative images not rendering on PC for Markdown Cells (#8091) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering
 2019-10-29 19:48:57 -07:00
Chris LaFreniere 3b1c9e910d serverManager to decide if server start needed (#8017) 2019-10-25 11:11:54 -07:00
Chris LaFreniere 5b29aef5f3 fix stdin cancel breaks notebook (#8012) 2019-10-25 10:52:18 -07:00
Chris LaFreniere f8067ffada Fix for Markdown File in Jupyter Books Viewlet not Opening After 2x (#8009) 
* fix for markdown not opening after opened twice

* PR comment to add return type
 2019-10-24 22:14:24 -07:00
Chris LaFreniere f7059a2365 Fix Issue when Saving Wrong Kernel (#7974) 
* Only fire kernelChangeEmitter after lang set

* Fix unused import found by lgtm

* Fix comment
 2019-10-24 22:13:18 -07:00
Chris LaFreniere 5cfad825fc search book gone from command palette (#8002) 2019-10-24 17:45:28 -07:00
Chris LaFreniere b1e0b7c1e3 Always send \n instead of \r\n to Jupyter kernel (#7995) 
* Always send \n instead of \r\n to kernel

* Use replace instead of split/join
 2019-10-24 16:43:52 -07:00
Chris LaFreniere a33820ecdd Fix starting and separators in a row (#7861) 2019-10-24 15:20:58 -07:00
Chris LaFreniere fb4fccf2d5 Notebooks: ensure python path dirs added to path on session start (#7968) 
* ensure python path dirs add to path session start

* Change logic slightly

* PR feedback from Charles
 2019-10-23 19:22:24 -07:00
Chris LaFreniere b53cad78bd Update recommended package versions for ps (#7972) 2019-10-23 18:57:05 -07:00
Chris LaFreniere a431ca7ef2 check for ownerDocument focus for focus (#7964) 2019-10-23 18:56:43 -07:00
Chris LaFreniere c2022cac57 Fix for relative links not being resolved in notebook outputs (#7966) 
* Fix for relative links not being resolved

* Add comment
 2019-10-23 18:49:52 -07:00
Chris LaFreniere 4c24043cc8 Add Option to Halt Notebook when Error Occurs in SQL Kernel (#7884) 
* Add Option to Halt Nb when Error Occurs

* PR comments
 2019-10-22 18:19:36 -07:00
Chris LaFreniere 597a0cad6b Add (dummy) IPyWidgets Renderer (#7849) 2019-10-21 14:22:44 -07:00
Chris LaFreniere e3ae5263c6 Starting Fewer Jupyter Servers for Notebooks (#7744) 
* Start fewer Jupyter servers

* Windows fix for drive casing

* PR Feedback

* Quick fix

* Fixing bug

* Ensure environment variables set 4 session startup

* test fix

* Dummy commit to update comment
 2019-10-20 21:38:58 -07:00
Chris LaFreniere d120102805 Bump up widths for pick, remove schedule buttons (#7517) 2019-10-20 13:22:49 -07:00
Chris LaFreniere 2ee3840650 First improvements for SQL Cell Looping (#7733) 
* First improvements

* clear results

* cleanup

* error handling
 2019-10-18 17:12:10 -07:00
Chris LaFreniere 385d7f2803 Clear Output -> Clear Result for consistency (#7776) 2019-10-17 19:54:12 -07:00
Chris LaFreniere 2ee04e0cf0 null checks for onBeforeDetached (#7782) 2019-10-17 18:24:30 -07:00