This is a partial fix that lays groundwork for full "Prompt to connect" if a kernel needs a connection.
I am waiting on Yurong's refactoring of connection handling before doing any of the prompt work.
- Adds kernel metadata about whether a connection is required.
- For Jupyter, only Spark kernels are listed as requiring a connection
- If this is true and there's no active connection, will show notification and not call execute
In the future, this path will still be used if user is prompted to connect and cancels out.
The future change will be to inject a "connect" handler from notebook.component to the cell callback and use to set connection context
Add back check for textDocuments with same name, should've been there anyhow
On rehydration files show as text docs before clicking as only get
changed by customInputConverter code path.
We should look at this long term - ideally we'd update notebookDocuments
with correct values on initial start. #4958 opened to track this.
* Fixed#4800 need to use ConnectionProfile in order to get the correct connection
* Go back to create connect in run cell to avoid to fail to run cell or close the connection used by other.
* more strict null checks in base browser code
* revert changes to radiobutton
* fix some more minor things, enable strict null check in pipelines
* formatting
* fix compile errors
* make null undefined
* more null to undefined
* runAllCells API
* add comment
* more run cells fixes
* Add integration test
* Add multiple cell SQL notebook test
* Comment out python tests as they fail in the lab
* remove unused imports
* PR comments
* Remove localize
* Return true instead of promise.resolve(true)
* add cluster name to page
* implement profile page -1
* fix compilation error due to new method
* profile page 0328
* summary page
* make divcontainer accessible
* handle disposable
* add support for "coming soon" cards
* Change attach to show user name. Use connectionProfile.title to display the same info as OE server node
* Fixed some potential profile leak
* Removed unused import
* Resolve PR comments
* change to fs to write file
* change random range to 1 to 100
* Added more env variables check as well
* Add azure and standalone env variables
* Add Azure instance to unblock mac pipeline testing
* Fixed some merge issue and improve delete file
* Added standalone test only run on windows
Aditya Bist