Commit Graph
100 Commits
Author SHA1 Message Date
Charles GagnonandADS Merger 2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Charles Gagnon 075d9a8268 Add troubleshooting to test docs (#17991) 2022-01-05 14:30:41 -08:00
Charles Gagnon b2c919e054 Add sample Notebook provider (#17988) 2022-01-05 09:14:54 -08:00
Charles GagnonandCory Rivera 4a2b31f3ba Hook up Notebook execution edits (#17943)
* Start rerouting VSCode cell execution APIs.

* Add more conversion code.

* Convert VSCode notebook registrations into ADS equivalents.

* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.

* Update an error message.

* Add another session argument.

* Add base classes for converting notebook serializers.

* Disable some vscode notebook methods.

* Disable more vscode APIs.

* Disable more stuff.

* Start implementing serializer notebook data conversions.

* Use direct references to extension host notebook methods, rather than azdata ones.

* Add a comment.

* Remove a space.

* Use import type to fix module loading errors.

* Use internal cancellation token class.

* Start adding cell output conversion.

* Convert data from byte array to a string.

* More output work.

* Use a Set for proxy filtering.

* Start adding tests.

* Include metadata in cell conversion. Fix other test failures.

* Fix serialize tests.

* Add more tests.

* Remove wildcard characters from vscode filenames.

* Start implementing session details.

* Add more kernel info.

* Add kernel spec.

* Add Future callback wrapper class.

* Start implementing execute conversion.

* Pass notebook URI to requestExecute.

* Start working on CellExecution methods.

* Move some code around to fix layering issues.

* Use proxy to access browser code, rather than direct imports.

* Move files around to fix layering issues.

* Remove unused imports.

* Start implementing some notebook cell execution behaviors.

* Revert some unnecessary extHost API changes.

* Check for nbformat.

* Also handle nbformat in serialize case.

* Active notebook extensions when resolving NotebookInput.

* Fix nbformat handling.

* Disable VSCode notebooks code.

* Filter out notebook services from registration assertion.

* Wait for providers to load before calling canResolve.

* Use controller's viewType for notebook provider ID, instead of controller ID.

* Start adding extHostNotebook tests for new APIs.

* Re-order proxy calls.

* Remove commented code.

* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.

* Add a comment.

* Remove unnecessary dispose call.

* Handle disposable from registerExecuteProvider.

* Remove a comment.

* Remove unnecessary provider fields.

* Remove reference to notebook service to fix circular reference issue in stringify.

* Add object types for methods in ADSNotebookController.

* Wait for controller languages to be ready before marking session manager as ready.

* Add correct promise.

* Add undefined return type for optional supportedLanguages property.

* Refine promise logic.

* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).

* Fix remaining issues from last commit.

* Replace "not implemented" methods with placeholder return types in order to enable testing.

* Also wait for execution handler to be set before marking session manager as ready.

* Fix usage of NotebookRegistry when updating provider description languages.

* Refine file extension conversion.

* Fix file extension conversion to match ADS extension behavior.

* Emit new provider registration event when adding supported languages.

* Remove checks for duplicate file providers and kernels.

* Fix a test failure.

* Fix file extension parsing.

* Use default executeManager if one isn't defined for provider in notebookModel.

* Add descriptors for waiting on standardKernels registration.

* Increase timeout

* Add an error message.

* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.

* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."

This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.

* Emit activation events after provider registration.

* Wait on standard kernels availability when getting an execute provider.

* Throw an error if session manager isn't ready yet.

* Actually resolve language promise correctly.

* Add some checks for undefined notebook data objects.

* Create kernel spec data correctly.

* Add extension changes for local testing only.

* Clean up test class.

* Add a reminder comment.

* Undo commented out notebook stuff

* Temporarily hard code default kernel.

* Retrieve default kernel in notebookModel if it's not already provided.

* Revert an import change.

* Remove unnecessary method from extHostNotebook.

* Move an interface around.

* wip

* Check for proposed API for some VSCode extHost methods.

* Remove a comment.

* Fix notebookUtils tests.

* Fix notebookModel tests.

* Fix notebookFindModel tests.

* Fix notebookViewsExtension tests.

* Fix remaining notebookView tests.

* Refactor output conversion functionality into separate methods.

* Update some unit tests for output conversion.

* Move a method.

* Rename conversion methods to fit acronym styling.

* Add another conversion test case.

* Revert local testing changes.

* Remove old method.

* cleanup

* Remove some comments.

* Move localized string to locConstants.

* Add a space to loc string.

* Add comments to new SQL Carbon Edit tags.

* Create constants for nbformat and nbformat_minor.

* Move some vscode-only fields to proposed APIs.

* Check for valid state

* Properly null check

* Adding logging for provider wait timeouts.

* wip update

* Fix compile

* Switch to cell edits

* Update docs

* Remove custom output type

* cleanup

* fix

* cleanup

* more cleanup

* Fixes

* Fix tests and lint errors

Co-authored-by: Cory Rivera <corivera@microsoft.com>
2022-01-04 16:35:16 -08:00
Charles Gagnon 2bef6d36b0 Consolidate INotebookEditOperation interfaces (#17944) 2021-12-17 14:21:52 -08:00
Charles Gagnon be933c88c0 Update setting description product name (Code -> ADS) (#17912) 2021-12-14 10:59:40 -08:00
Charles Gagnon 2da29f17c2 Fix API docs for NotebookEditorEdit (#17902) 2021-12-13 10:16:00 -08:00
Charles Gagnon 46fc807b69 Use standard key events for Notebook keybindings (#17880)
* Use standard key events for Notebook keybindings

* Add more
2021-12-09 11:05:07 -08:00
Charles Gagnon ec417fae55 Cleanup link handler tests (#17838) 2021-12-07 18:28:31 -08:00
Charles Gagnon 321a5b8a69 Always clear unused attachments when updating cell source (#17840)
* Always clear unused attachments when updating cell source

* comment

* Fix eslint and improve regex

* Add more tests
2021-12-07 18:28:15 -08:00
Charles Gagnon 5d2f17408e Bump to latest version of azdata (#17735) 2021-11-22 20:35:28 -08:00
Charles Gagnon 4c191d4acc Add resource deployment samples for (#17734) 2021-11-22 15:49:05 -08:00
Charles Gagnon 0caa6390b9 Fix "unsupported version" error when adding sql binding package (#17721) 2021-11-22 10:44:46 -08:00
Charles Gagnon 6ba7bad90c Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode

* comment + fix
2021-11-19 15:04:54 -08:00
Charles Gagnon 77e4fdd407 Fix open external not working (#17717) 2021-11-19 11:25:23 -08:00
Charles Gagnon 8a6ea2669b Add additional properties to wizard page navigation events (#17716) 2021-11-19 10:18:13 -08:00
Charles Gagnon 88b754b739 Add instructions for developing VS Code version of sql-database-projects (#17705) 2021-11-18 14:07:39 -08:00
Charles Gagnon e0ad23a559 Remove galleries list action (#17648) 2021-11-10 15:03:45 -08:00
Charles Gagnon 0a60ed4c75 Fix extensionsGallery.json name (#17646) 2021-11-10 14:51:09 -08:00
Charles Gagnon f96a82f700 Add extension gallery update reminder action (#17644) 2021-11-10 14:45:19 -08:00
Charles Gagnon 615df975ec Fix query editors restoring as plain text (#17643) 2021-11-10 12:31:43 -08:00
Charles Gagnon f91a228066 Update dotnet version used by codesign (#17616) 2021-11-06 13:33:07 -07:00
Charles Gagnon 84ae306d57 Fix not being able to type in code cell after switching from text (#17590)
* Fix not being able to type in code cell after switching from text

* comment
2021-11-03 19:48:04 -07:00
Charles Gagnon 43fe0ce482 VS Code -> ADS setting descriptions (#17563) 2021-11-03 10:05:56 -07:00
Charles Gagnon de3ae26873 Add launch target for sample-resource-deployment (#17553) 2021-11-01 15:05:32 -07:00
Charles Gagnon 25711acde0 Add a few missed instantiation service usages (#17554)
* Add a few missed instantiation service usages

* remove unused
2021-11-01 14:32:37 -07:00
Charles Gagnon 9bbe39e9e2 Add sample value provider (#17548) 2021-11-01 11:27:03 -07:00
Charles Gagnon 470f063124 Don't localize paths in sample resource deployment (#17544) 2021-11-01 10:14:12 -07:00
Charles Gagnon a9d96e166a Delete azurecore value provider and simplify type (#17543) 2021-11-01 10:13:58 -07:00
Charles Gagnon 82805638ad Add onClosed event to ModelView dialogs (#17531)
* Add onClosed event to ModelView dialogs

* Use defined type

* Fix compile

* fix tests

* fix tests2

* Remove unused
2021-10-28 20:53:20 -07:00
Charles Gagnon 00e5380331 sql-database-projects dialog completion cleanup (#17525) 2021-10-28 13:51:48 -07:00
Charles Gagnon 114a768634 String updates for Data Workspace & SQL Proj (#17504)
* Clean up extension descriptions

* More cleanup

* learning to spell

* Remove unused loc strings

* Add bundling information & rename view container

* Update data workspace readme
2021-10-28 13:33:19 -07:00
Charles Gagnon d70ea2fbcb Fix localized titles in VS Code marketplace (#17514) 2021-10-27 13:51:58 -07:00
Charles Gagnon ab6b290b04 Fix update-typings pipeline (#17511) 2021-10-27 12:42:04 -07:00
Charles Gagnon ca20ae4d64 Fix typings files (#17509) 2021-10-27 12:29:00 -07:00
Charles Gagnon d40d6fbe12 Fix publisher for VS Code extensions (#17505) 2021-10-27 10:17:29 -07:00
Charles Gagnon 7049890f24 Don't log internal command executions from ext host (#17482) 2021-10-25 10:53:09 -07:00
Charles Gagnon 89c15c9496 Fix assessment results dialog telemetry (#17483) 2021-10-25 09:51:00 -07:00
Charles Gagnon f57c41fead Fix backups not restoring in correct editor (#17466) 2021-10-22 12:15:30 -07:00
Charles Gagnon 57130f2f2b Fix URL protocol for non-insiders builds (#17442) 2021-10-21 15:42:27 -07:00
Charles Gagnon ec8292adb7 Add initial developer guide for resource deployment (#17395)
* Add initial developer guide for resource deployment

* PR comments
2021-10-19 13:47:36 -07:00
Charles Gagnon 747b8e84a8 Add BDC spark connection logging (#17277)
* Add BDC spark connection logging

* fix test failures
2021-10-05 20:23:38 -07:00
Charles Gagnon 168a50d589 Remove duplicate pipeline trigger (#17275) 2021-10-05 16:57:13 -07:00
Charles Gagnon 32b912c37e Clean up tsconfig.base.json (#17220)
* Clean up tsconfig.base.json

* revert param name

* Try removing comments

* use newer option again

* revert option again

* more
2021-10-04 13:35:24 -07:00
Charles Gagnon ffe5027c3f Bump github-auth axios to 0.21.4 (#17189) 2021-09-28 18:26:27 -07:00
Charles Gagnon 508630411d Update service downloader to 0.2.3 (#17186) 2021-09-28 13:58:32 -07:00
Charles Gagnon 8d3b57cb76 Add no-cond-assign rule (#17039) 2021-09-09 16:23:18 -07:00
Charles Gagnon a3b886d85b Add launch target for debugging just ext host (#17040)
* Add launch target for debugging just ext host

* move
2021-09-09 15:03:21 -07:00
Charles Gagnon d0941bea53 Fix extensions-lint script (#17008) 2021-09-06 17:38:41 -07:00
Charles Gagnon 73c20345e9 Revert change to unit test runner grep option (#16980) 2021-09-02 16:52:09 -07:00
Charles Gagnon 9516472f1b Add no-floating-promises for mssql extension (#16956) 2021-09-02 09:22:25 -07:00
Charles Gagnon f35576ae7f Enable no-floating-promises for azurecore (#16946)
* Enable no-floating-promises for azurecore

* few more

* fix compile
2021-09-02 09:20:32 -07:00
Charles Gagnon f578fc55ee Remove LGTM yml (#16961) 2021-09-01 10:47:39 -07:00
Charles Gagnon d774548951 Enable no-floating-promises for data-workspace (#16958) 2021-09-01 10:47:21 -07:00
Charles Gagnon 45e251c0d6 Add test (#16953) 2021-08-31 15:58:19 -07:00
Charles Gagnon c8cc6c08e9 Add no-floating-promises rule to sql-database-projects extension (#16943)
* Add no-floating-promises rule to sql-database-projects extension

* fix test
2021-08-31 14:13:52 -07:00
Charles Gagnon a96bf181c0 Remove LGTM (#16948) 2021-08-31 12:44:59 -07:00
Charles Gagnon de3ff30398 Add no-floating-promises to admin-tool-ext-win and query-history (#16944) 2021-08-30 21:16:55 -07:00
Charles Gagnon 00da5fdcb3 Add icons for some quickpick items (#16939) 2021-08-30 15:32:20 -07:00
Charles Gagnon 76e01fee60 Fix rest of notebook unhandled promises (#16933)
* Fix rest of notebook unhandled promises

* add rule

* fix some tests
2021-08-30 14:14:48 -07:00
Charles Gagnon 26e08fdf9e Add package metadata for azcli (#16937) 2021-08-30 13:21:14 -07:00
Charles Gagnon 7804c87c87 Fix some unhandled promise lint errors (#16924) 2021-08-30 09:08:28 -07:00
Charles Gagnon fde114bb14 Add STS root folder override (#16927)
* Add STS root folder override

* Display message to user

* Show once for any service
2021-08-30 09:07:33 -07:00
Charles Gagnon e7a719ceb4 Fix extension linting warnings and enable extension linting in pipelines (#16922)
* Fix extension linting errors

* fix test
2021-08-27 15:13:01 -07:00
Charles Gagnon a95d90ce5c Have create proj from database show default save location as option (#16909)
* Default create proj location to setting

* update icons

* undo
2021-08-26 18:59:05 -07:00
Charles Gagnon 159cd7f895 Open project to default location (#16910) 2021-08-26 18:56:28 -07:00
Charles Gagnon 6a0a185cbd Move create new option for publish to top and filter out system dbs (#16908)
* Move create new option for publish to top

* Move New tag to description

* fix
2021-08-26 15:52:08 -07:00
Charles Gagnon be3b5f17cd Undo merge icon change (#16894) 2021-08-26 09:05:37 -07:00
Charles Gagnon 0aede16aaa Fix duplicate editor windows on reload (#16893) 2021-08-25 20:07:58 -07:00
Charles Gagnon f66a0f9761 Bump VS Code version to latest sync point (#16891) 2021-08-25 16:49:28 -07:00
Charles Gagnon fe1f8fb2f3 Add setting for enabling using new markdown renderer (#16864)
* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false
2021-08-25 12:43:32 -07:00
Charles Gagnon 14f1d9c6d2 Add another missed rederer attach (#16874) 2021-08-24 12:14:20 -07:00
Charles Gagnon b14f9cc098 Fix debugger type for sp_whoIsActive (#16870) 2021-08-24 11:13:38 -07:00
Charles Gagnon 51db55408c Disable VS Notebook configuration settings (#16865) 2021-08-23 18:24:55 -07:00
Charles Gagnon 2e92a903c7 Remove optimized table setting (#16857)
* Remove optimized table option

* comment out

* completely remove

* one more
2021-08-23 14:17:34 -07:00
Charles Gagnon ccaf111696 Add more Azure account logging (#16847)
* logging 1

* More logging

* more logging

* Handle each tenant separately.

* cleanup
2021-08-20 13:23:36 -07:00
Charles Gagnon 5b3fbaa5ff azdata.Account -> AzureAccount (#16842) 2021-08-20 10:28:33 -07:00
Charles Gagnon d1dc226ff6 Fix error when getting subscriptions for all tenants (#16837) 2021-08-19 22:11:15 -07:00
Charles Gagnon da73265c9e Promote some proposed APIs (#16831)
* Promote some proposed APIs

* Remove buttoncell

* Fix location
2021-08-19 12:29:48 -07:00
Charles Gagnon 9f9e562e77 Remove Notebook grammar (#15992) 2021-08-19 10:47:14 -07:00
Charles Gagnon 39c23a0382 Clean up launch tasks (#16820) 2021-08-19 09:00:36 -07:00
Charles Gagnon 637c01fe22 Fix typo (#16823) 2021-08-18 14:37:38 -07:00
Charles Gagnon ea6e03f826 Fix azure account tree subscription check (#16822)
* Fix azure account tree subscription check

* comment
2021-08-18 14:35:16 -07:00
Charles Gagnon df49d67f7d Consolidate getSubscriptions (#16821)
* Consolidate getSubscriptions

* Undo test change
2021-08-18 12:56:45 -07:00
Charles Gagnon 82576e54a4 Add more marked.js tests (#16800) 2021-08-17 14:02:18 -07:00
Charles Gagnon 6b1cc85c9a Get tools service install location from extensions (#16796)
* Get STS install location from extensions

* Update error
2021-08-17 13:48:22 -07:00
Charles Gagnon a92ba424ac Handle errors fetching subscriptions from subset of tenants (#16765) 2021-08-16 15:08:08 -07:00
Charles Gagnon ecb5bb4ed8 Fix scan hits (#16788) 2021-08-16 12:59:18 -07:00
Charles Gagnon 455b3478c1 Fix download manually link (#16787)
* Fix download manually link

* Fix compile
2021-08-16 12:45:19 -07:00
Charles Gagnon 6b5c909f7f Fix connection prompt for publish database quickpick (#16767) 2021-08-14 11:57:41 -07:00
Charles Gagnon 041bd560c0 Fix modelview container removal issue (#16753) 2021-08-12 13:12:31 -07:00
Charles Gagnon 0f3be7dabc Fix title icons (#16750) 2021-08-12 10:59:54 -07:00
Charles Gagnon 78f48b69a4 Add new extensions location var (#16747) 2021-08-12 10:16:54 -07:00
Charles Gagnon 1015b2f960 Fix schema compare diff editor not showing (#16733)
* Fix schema compare diff editor not showing

* remove unneeded

* remove more unused
2021-08-11 23:15:08 -07:00
Charles Gagnon 33e46861e9 Remove Azdata CLI Ext from recommend extensions (#16727) 2021-08-11 14:55:50 -07:00
Charles Gagnon 9b2836c9e7 Update admin-tool-ext-win version (#16723) 2021-08-11 12:53:47 -07:00
Charles Gagnon f570c64ce0 Remove azdata extension (#16667)
* Remove azdata extension

* skip failing tests

* unskip tests

* Remove duplicate tests

* skip tests
2021-08-11 09:48:06 -07:00
Charles Gagnon c891584fec Update ADS strings for sql-database-projects (#16683)
* Update ADS strings for sql-database-projects

* fix
2021-08-10 22:21:46 -07:00
Charles Gagnon 549b2de309 Revert some of the urlProtocol changes (#16695) 2021-08-10 21:31:47 -07:00
Charles Gagnon 47c8b22bb4 Add more connection logging (#16682)
* Add more connection logging

* remove return
2021-08-10 17:16:38 -07:00