- Fixes#1764, fixes#1765
- Fixes bug where configModifiers were passed in the dashboard service in some places, and a different object with incompatible / missing fields in a different one. Now it always passes in the owner object, and this should have the required fields
- Note: this doesn't fix the problem where the code does not fail to build, which I would have expected to be the case.
- Adds "provider" as an option for TabConfig including in the schema
- Filter by "provider" type when loading tabs. If provider is not set for a tab, will assume "MSSQL" since it's the default provider. This is a design decision - without this, we would either have to disable tabs that don't show this or have them incorrectly show for non-MSSQL provider types
Notes:
Does not override behavior for individual widgets, which still get the current provider set as their provider if not specified. This seems to be required so should be fine.
We will fix tasks/widgets that aren't supported by a provider showing up in a separate PR, since it's a different issue
* changed columnw widths
* fixed scrolling for prev run job history list
* fixed all resizing and scrolling issues in agent
* removed commented code
* code review comments
- Fix a number of issues that arose while testing a provider without a metadata service or serverInfo object returned via DMP calls. These should be optional services/features and we should be resilient to them not existing. In most places we already have these checks
- This does not cover a number of "improvement" scenarios, such as filtering extension tabs by provider, and defaulting any tabs that don't specify a provider to be MSSQL. This and some other features to ensure things make sense will be implemented in separate PRs but this unblocked the scenario
* added jobs view toolbar
* create job command and dialog stub
* add tab content and wire up the provider
* fix the steps tab error
* create job dialog 6/15 changes
* general tab done
* success action and retries completed
* added failure action dropdown
* add notification tab checkbox events
* added AgentJobStepInfo objects in sqlops
* create job dialog - 0618 update 1
* added model save function
* width for controls and initial state for notification tab controls
* refresh master and changes to work with latest code
* fixed next and prev button positions
* new step dialog ui finished
* implemented parse button
* fix package file
* add validation and sub-items collections
* hook up the step creation dialog - step 1
* merged master
* fixed step issue, step can me made now
* adding lost events flag to events available notification
* Initial changes to support notifications for stopped session and lost events
* Updated localized strings & send stop notification box
* reordering imports
* vbump sqltools & dataprotocolclient, fix notification wording
* Clean up edit data revert behavior
* Unify escape and revert row edit data handling
* Revert unedited new row when clicking off of it
* Make delete work when adding new row
* Displaying all event data
* Fixing viewing blank text panels and highlighting
* add aria-label for insights dialog (#1629)
* Displaying all event data
* Fixing viewing blank text panels and highlighting
* descriptive comments, removing redundant code
* Clear event view pane when starting new session
* Removing debug logging
* Handling pause button
* Cleaning up comments from previous commit
* Fixing comments from PR
* Fixing a comment I forgot to delete
* Bumping dataprotocolclient version
* Bumping sqltoolsservice & sqlops-dataprotocolclient version
Kevin Cunnane