Commit Graph
100 Commits
Author SHA1 Message Date
Vasu Bhog d53a35bf4f Update SQL Bindings VSCode target framework and version, and vbump (#23157)
* update target framework and version, and vbump
2023-05-17 15:49:29 -07:00
Vasu Bhog a4f023f5b9 Update README.md (#20592)
* Update README.md

added event mocking tip
2022-09-12 14:06:59 -07:00
Vasu Bhog 2a94ce3afb Ensure SQL Nuget package reference is always updating to latest (#20390)
* seperate nuget package references to always update to latest

* nit

* nit comments
2022-08-17 18:07:23 -07:00
Vasu Bhog e57acae79a Add output channel for SQL Bindings extension (#20336)
* add output channel for SQL Bindings extension

* add output channel to open once added
2022-08-15 12:12:26 -07:00
Vasu Bhog 4ebe4c4547 [SQL-bindings] remove watcher for files (#20250)
* remove watcher for files

* nit
2022-08-05 16:18:03 -07:00
Vasu Bhog 514b0315cc SQL Bindings add telemetry points (#20125)
* add telemetry points

* address comments
2022-07-27 16:38:37 -07:00
Vasu Bhog 9e8b80f12f delete progress notification not needed (#20060) 2022-07-19 09:43:55 -07:00
Vasu Bhog 9c85baa824 fix sql bindings package.json when menu command (#20056) 2022-07-15 13:35:50 -07:00
Vasu Bhog 163ca5ec64 SQL Bindings - Adds Views support for Create Azure Function with SQL Binding (#19894)
* add views logic

* add views tests

* address PR and Figma comments

* add ObjectType Enum to be used as a parameter

* add comment
2022-07-06 10:31:00 -07:00
Vasu Bhog d5da934572 [SQL Bindings] Skip prompt to select setting from connection settings if there is none (#19798)
* add no setting option

* add tests

* reformat tests
2022-06-27 12:31:46 -07:00
Vasu Bhog c5093dbb5a Add Azure Function Service Error/Cancel tests (#19758)
* cleanup tests

* exit/error scenario tests

* remove + from manuallyEnterObjectName

* address comments

* add resolve for writeFile
2022-06-20 15:48:38 -07:00
Vasu Bhog 4d320c56f0 cleanup tests (#19732) 2022-06-15 11:08:49 -07:00
Vasu Bhog 6ab09d9b1b Add SQL Bindings Tests / Vbump (#19717)
* add further testing

* vbump version

* add successfully test

* address comments
2022-06-14 14:47:36 -07:00
Vasu Bhog 8c223f503e Fix SQL Bindings VSCode telemetry issues (#19648)
* fix package json telemetry issues

* add vs code dependency back
2022-06-07 00:19:00 -07:00
Vasu Bhog bbfd6617f9 vbump SQL Bindings for June Release (#19639) 2022-06-06 12:26:08 -07:00
Vasu Bhog 4cb03a1ef0 [SQL Bindings] Add tests for connection string execute step (#19594)
* add connection string execute step tests
2022-06-02 13:49:25 -04:00
Vasu Bhog 6c7a8313b2 Adds SQL Binding Create Azure Function with SQL Binding tests (#19538)
* add a couple of azure function service tests

* address comments

* use mock for azureFunctionExtensionAPI
2022-05-31 21:04:39 -04:00
Vasu Bhog 96f345a74a add progress noticiations for database that would contain lots of tables (#19572) 2022-05-31 16:33:27 -04:00
Vasu Bhog 09d9ad0020 Fix SQL Bindings README (#19498)
* fix links for vsix

* update to use raw links instead
2022-05-23 23:10:24 -05:00
Vasu Bhog 146b27f511 SQL Bindings Readme Instructions (#19487)
* add readme entry points

* use scenarios

* fix link

* address comments
2022-05-23 18:04:37 -05:00
Vasu Bhog e1fc230273 remove password for connection string non sql auth types (#19484)
* remove password for connection string non sql auth types

* add comment

* fix test
2022-05-23 18:01:55 -05:00
Vasu Bhog 1959736078 fix loop for cancelling out databases (#19460)
* fix loop for cancelling out databases

* remove loop and comments
2022-05-20 13:47:53 -07:00
Vasu Bhog 79875c0b95 fix await (#19437) 2022-05-19 12:20:36 -07:00
Vasu Bhog 9cefed840e SQL Bindings refactor password prompting (#19371)
* remove password enter manually - since we prompt user to include it prior

* go back to connection profile prompt

* add manual entry if connection info password is not saved

* add tests that verify all password prompt scenarios

* nit
2022-05-19 10:41:11 -07:00
Vasu Bhog 8967ec36f4 Add Table Menu for SQL Bindings promptForObjectName (#19358)
* first wip for table menu prompt

* fix up some table prompts

* use simpleExecuteRequest

* fix table prompt scenario for sql binding also

* fix/add more testing and address comments

* add brackets to selected database

* add manually entered option
2022-05-18 14:51:45 -07:00
Vasu Bhog 265f59ae94 SQL Bindings fix preview flag and constants file (#19370)
* fix preview flag and constants file

* address comment
2022-05-13 17:09:00 -07:00
Vasu Bhog f53f4fc522 remove logic now that we have fix in vscode-azurefunctions (#19353) 2022-05-12 15:48:59 -07:00
Vasu Bhog 51e5890c83 Add Connection String Execute Step for SQL Bindings (#19293)
* add execute step

* nit comment

* edit param docs

* address comments

* ensure the user has the installs the latest version
2022-05-09 16:06:02 -07:00
Vasu Bhog e80b8f92f2 vBump sql bindings extension (#19317)
* vBump sql bindings
2022-05-09 16:04:50 -07:00
Vasu Bhog 7ef0ef65f4 remove logic (#19250) 2022-04-28 15:29:13 -07:00
Vasu Bhog a3efb193e0 Fix connection profile prompt for Create Function with SQL Binding (#19211)
* fix no connection profile and progress report

* show connection profile prompt if user exits object

* address comments
2022-04-27 15:14:39 -07:00
Vasu Bhog 727f37d6a5 remove ADS/azdata refs (#19212) 2022-04-27 11:23:53 -07:00
Vasu Bhog c86085352e Make Create Azure Function with SQL Binding more efficient and simple (#19187)
* initial refactor

* fix projectFolder cases

* update create azure function with sql binding when no folder is opened

* corner case exit browse file

* add version since targetFramework is set to specific core tools version

* update telemetry and address comments

* use project folder instead
2022-04-26 13:12:10 -07:00
Vasu Bhog e1cf51653e remove extra error message (#19110) 2022-04-14 16:50:22 -07:00
Vasu Bhog ca05e01144 Fix connectionSettingName for create azure function with sql binding (#19008)
* fix connectionSettingName for create azure function with sql binding

* add sql binding user enters connection string manually

* address comments + fix test

* final comments
2022-04-13 15:53:27 -07:00
Vasu Bhog 675969eebc suppress create function prompt (#18962) 2022-04-12 11:25:44 -07:00
Vasu Bhog ed8d2f9927 Fix for user using command palette (#18948)
* fix for user using command palette command

* rework if a user uses the create azure function via the command

* for now only show in vs code

* move logic to azureFunctionService + address comments

* fix command location

* address comments

* fix validateFunction
2022-04-08 10:28:45 -07:00
Vasu Bhog 4e299dc4b2 fix timeout warning when exiting create function (#18947)
* fix timeout warning when exiting create function

* combine timeout errors

* make more explicit
2022-04-07 13:58:57 -07:00
Vasu Bhog f829218c2c less prompts about langauge and runtime version (#18949) 2022-04-06 12:58:37 -07:00
Vasu Bhog 49b0640fde Update sql-bindings icon (#18946)
* add default icon
2022-04-06 12:57:54 -07:00
Vasu Bhog 69c254aeac Add progress bar for adding sql binding (#18923)
* add progress bar for adding sql binding
2022-04-04 15:13:00 -07:00
Vasu Bhog 2d9004e481 Remove known settings from ConnectionStringSettingName prompt (#18910)
* remove known settings
2022-04-04 13:37:44 -07:00
Vasu Bhog c65c41d704 add guid for session ID (#18912) 2022-04-04 10:43:20 -07:00
Vasu Bhog 0a43ed84e3 Add bindings telemetry (#18851)
* add bindings telemetry

* add exitReasons
2022-03-31 16:29:15 -07:00
Vasu Bhog 783215c160 code owners for sql-bindings (#18795) 2022-03-22 12:23:38 -07:00
Vasu Bhog 1a1556ca75 Use SQL input / output template instead (#18768)
* use sql input / output template instead

* workaround for storage wizard that is opened
2022-03-18 17:31:19 -07:00
Vasu Bhog d063355b1a improve sql bindings extension (#18757) 2022-03-17 11:37:37 -07:00
Vasu Bhog 80007a72cc Remove sql-bindings logic from sql-database-projects (#18754)
* remove sql-bindings logic from sql-database-projects
2022-03-17 11:36:28 -07:00
Vasu Bhog d585e75706 Add rest of sql-bindings/azure funcs logic to sql bindings ext (#18733)
* refactor the rest of azure function and sql binding

* remove vscode-mssql typings that are moved to our sql-bindings ext
2022-03-15 15:10:42 -07:00
Vasu Bhog 2d1ffeb47c Refactor vscode-mssql sql bindings logic to sql bindings ext (#18725)
* wip for refactor of mssql to sql-bindings

* remove STS dependency

* work to bring function over and setup with vscodeMsql APIs

* copy typings from vscode-mssql
2022-03-14 13:07:27 -07:00
Vasu Bhog f424bea0de Fixes issues with SQL Bindings vscode dev (#18695)
* fixes issues with vscode development
2022-03-10 15:37:23 -08:00
Vasu Bhog 0c54c12772 Add SQL Binding Tests (#18687)
* add tests
2022-03-09 16:35:51 -08:00
Vasu Bhog eb77d86136 Refactor SQL Binding code over from sql-database-projects (#18674)
* add sql binding prompt / logic

* remove controller and move to extension

* remove unused dependencies
2022-03-09 01:02:37 -08:00
Vasu Bhog fee8e78011 fix display name and description key (#18666) 2022-03-07 13:22:44 -08:00
Vasu Bhog c9aa3e9f4b Boilerplate for SQL Bindings Extension (#18624)
* boilerplate for sql bindings extension

* edit gulpfile task as it was trying to find specific menus within package.json
2022-03-04 15:16:45 -08:00
Vasu Bhog 0f385b386f Add SQL Binding Disconnected Scenario (#18440)
* disconnected scenario

* match parameters in mssql
2022-02-17 14:20:13 -08:00
Vasu Bhog 9b3dd4247c Add SQL Binding Password Prompts (#18241)
* add password warning

* password prompts
2022-02-09 00:42:27 -08:00
Vasu Bhog b7fe4c09e2 vBump STS to 1.9.5 & add optional application name parameter for connection string (#18201)
* include application name optional parameter

* vBump STS to 1.9.5
2022-02-04 17:56:59 -08:00
Vasu Bhog d4534f875f Add Connection String Enhancement for SQL Bindings (#18011)
* sql database work to prompt users to choose connections

* add test
2022-01-13 17:54:46 -08:00
Vasu Bhog ae8d1b868a vbump playwright to vs code latest (#18005)
* bump playwright to vs code latest

* update install playwright install files
2022-01-06 13:44:48 -08:00
Vasu Bhog a8ee26ed89 Move split cell icon (#17383)
* move split cell icon before delete icon
2021-10-18 16:43:25 -07:00
Vasu Bhog c368fcab25 Add Markdown Keybindings (#17359)
* add markdown keybindings

* remove add link keybinding

* move files

* fix layering
2021-10-15 11:40:19 -07:00
Vasu Bhog faa29945a3 Fix Link Callout Dialog consistency in split/md (#17313)
* fix consistency with space and %20 files in split/md

* add a test
2021-10-08 15:24:00 -07:00
Vasu Bhog c35cd3e48f Fixes Encoding / Decoding issues with Notebook Linking (#17304)
* fixes encoding / decoding issues with %20 files

* fix windows test

* address PR comments and absolute path setting
2021-10-08 15:22:10 -07:00
Vasu Bhog a0576456b6 Add Keybindings for some Markdown Toolbar Actions (#17198)
* Add Keybindings for some markdown toolbar

* add extension registry

* when in text cell stopPropagation to only trigger one command
2021-09-30 15:20:45 -07:00
Vasu Bhog db1d3cc517 Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar

* working horizontal scrollbar

* created new event to handle both scrollbar and mouse wheel

* only show scrollbar when needed
2021-09-27 16:54:43 -07:00
Vasu Bhog 529e4fe0de Fix ADS Web notebook cross linking (#16926)
* fix cross linking files

* use host location instead
2021-08-30 15:43:16 -07:00
Vasu Bhog 179678b495 Refactor Notebook Link Handling (#16473)
* add keep absolute paths instead convert setting

* update tests/config

* refactor links in NotebookLinkHandler
2021-07-30 19:20:38 -07:00
Vasu Bhog 788c84a1ee fix email else condition (#16491) 2021-07-29 18:37:06 -07:00
Vasu Bhog 151522013f Notebook Markdown email rendering fix (#16417)
* fix email WYSIWYG rendering
2021-07-23 15:24:34 -07:00
Vasu Bhog 63e97caa94 Fix Windows WYSIWYG linking issue (switching to splitview and resolving links in WYSIWYG) (#16133)
* fix relative links not correctly formatted due to marked js

* logic in one place
2021-07-16 13:27:45 -07:00
Vasu Bhog 27823e9900 Fix CalloutDialog not opening after bad link (#16051)
* fix null parentNode
2021-07-09 09:01:48 -07:00
Vasu Bhog 14ce88023e Add allow root setting for Ubuntu and Web Mode users (#16027)
* add allow root setting for Ubuntu and Web Mode users
2021-07-07 11:02:12 -07:00
Vasu Bhog 7cf7ca5d15 use helper function for smoke test (#15964) 2021-06-30 21:33:54 -07:00
Vasu Bhog ec057ba8c1 [ADS Web] Fix Plotly notebook rendering issue (#15948)
* fix Plotly render issue
2021-06-30 09:56:09 -07:00
Vasu Bhog c3e0958f2d Add simple smoke test for collapse/expand cell (#15879)
* simple smoke test for collapse / expand cells
2021-06-25 18:08:35 -07:00
Vasu Bhog b8dbd3f0dc do not prompt for notebook uri file (#15809) 2021-06-18 13:07:08 -07:00
Vasu Bhog 1de05a2339 Fix WYWIWYG Table cell adding new line in table cell (#15594)
* fixes new line in table cell

* add test and fix for table head
2021-05-28 13:47:50 -07:00
Vasu Bhog 730367494b Run with Parameters learn more link to use correct format and kernels (#15547)
* indicate to users correct format and kernels

* add test for unsupported kernel

* replace with enum
2021-05-25 17:39:19 -07:00
Vasu Bhog 8a0c183114 fix changing kernels from kusto to other kernels (#15545) 2021-05-24 13:52:32 -07:00
Vasu Bhog 70b0d89b5d Notebook URI Handler File Support (#15340)
* file URI handler
* supports Parameterization
2021-05-12 18:11:40 -07:00
Vasu Bhog cb06ca07c0 Fixes the empty parameter cell and multi parameters on one line (#15234)
* fix two bugs

* work on empty parameter cell and format properly

* add empty cell tests
2021-05-06 14:48:38 -07:00
Vasu Bhog c66a8ca171 fix parameterized notebook output (#15233) 2021-04-27 12:40:49 -07:00
Vasu Bhog 6951bf3b90 Ability to see and edit links in split view/markdown mode (#15150)
* callout dialog selects link properly in split/markdown mode

* use regex for links
2021-04-20 23:33:14 -07:00
Vasu Bhog 3a1885491f Update run w/parameters icon and increment parameterized notebook (#15127)
* update icon and increment parameterized notebook
2021-04-14 15:28:27 -07:00
Vasu Bhog 58d0add46f Save Kusto Notebook with proper language notebook info (#15113)
* save kusto language info
2021-04-13 17:28:33 -07:00
Vasu Bhog 9f63653a53 Fixes notebook integration tests + running parameterized notebook (#15107)
* fix interface

* fix run all cells on new parameterized notebook

* add getNotebookUri function
2021-04-13 17:23:15 -07:00
Vasu Bhog d76a6698a9 [Notebook] Run Parameters Action openNotebook Functionality in Core (#14978)
* NotebookService update

* openNotebook functionality in NbService

* Add tests for RunParametersAction
2021-04-08 14:48:37 -07:00
Vasu Bhog 04af3e161a See and Edit Selected Links in Callout Dialog (#14987)
* Add URL label to linkCallout

* add test for file link
2021-04-06 11:51:53 -07:00
Vasu Bhog 0a7719b475 [Notebook] Run Parameters Action UI Component (#14889)
* Run Parameters Action UI Component

* Update UX discussion - accept empty string
2021-04-05 13:59:27 -07:00
Vasu BhogandVasu Bhog 0141db80bc [Notebook] Open Kernel Alias (Kusto) notebook with Kernel Alias (Kusto) as selected kernel (#14504)
* Open kernel alias notebook with kernel alias as selected kernel

* Add language info test

* fix test

Co-authored-by: Vasu Bhog <bhogvu@mail.uc.edu>
2021-03-04 12:36:25 -08:00
Vasu Bhog df51f35be0 Enable Parameterization via Notebook URI (#13869)
* Enable Parameterization via Notebook URI

* Add Parameterization and Move notebookModel tests

* minor typos

* parameter typo

* Multiple parameters through uri fix

* Address PR comments and tests fix

* add new injected parameters after original injected parameters

* Add new test to verify notebookURi parameter is injected after both parameter and injected cell

* fix tests
2021-01-08 00:38:33 -08:00
Vasu Bhog 133958ea47 renable kernels dropdown test (#13727)
Verify no skipped core tests
2020-12-11 17:49:20 -08:00
Vasu Bhog 048f85d918 Fix notebook unordered grid values after papermill execution (#13614)
* Fix unordered table

* check entire first row schema:

* SQL Notebooks should not get affected

* delete unused variable and edit comments

* refactor for efficient table ordering

* nit naming
2020-12-03 19:37:22 -06:00
Vasu Bhog 2a7b90fd70 Fix WYSIWYG text + image paste (#13542)
* Fix WYSIWYG text + image paste

* add test for a link and text
2020-11-25 12:42:07 -06:00
Vasu Bhog 7cd4964f35 Fix for < > (non HTML) tags disappearing in WYSIWYG (#13267)
* Push the latest update for WYSIWYG bug

* Improvements to nested lists

* OL tests and PR feedback

* Fixed all toolbar options for tags

* Address PR comments

* Ensure style is kept and not escaped

* Add all markdown toolbar action tests

* Style text edge case fix

* Address repeat function and type comment

* add more clarifying test
2020-11-09 20:26:28 -06:00
Vasu Bhog 351516f08d Change the way we insert Injected Parameter (#13171) 2020-11-02 09:14:37 -08:00
Vasu Bhog 338beaff29 Update powershell kernel version to 0.1.4 (#13167)
* Update powershell kernel version to 0.1.4
2020-10-31 09:01:05 -07:00
Vasu Bhog cb30dd1893 Notebook Parameterization - Papermill Compatibility (#13034)
* Parameterization papermill fix

* Utilize isParameter instead

* Address PR comments, and fix tests

* Address comment
2020-10-23 20:32:55 -05:00
Vasu Bhog bf9fd5a3b8 UI Component for Parameterized Notebook (#13021)
* Backend work for  Parameterization + Tests

* address comments

* Add Parameters Tag upon state change

* Edit CSS Styling for accessibility

* more generic tag names
2020-10-23 19:51:03 -05:00