Commit Graph

2708 Commits

Author SHA1 Message Date
Charles Gagnon
53a081262d Fix BDC and resource-deploy extensions to not be packaged separately (#7858)
* Fix BDC and resource-deploy extensions to not be packaged separately

* Update js too
2019-10-21 11:06:22 -07:00
Charles Gagnon
8b46143d48 Fix Manage Access dialog to not allow entering blank user (#7844) 2019-10-21 10:07:28 -07:00
Alan Ren
a05edc619c use required attribute (#7850)
* use required attribute

* readable sql port
2019-10-21 09:53:12 -07:00
Alan Yu
6c5aa6b367 Update ThirdPartyNotices.txt (#7479)
* Update ThirdPartyNotices.txt

* tab -> spaces
2019-10-20 21:56:29 -07:00
Charles Gagnon
0246c3f895 Fix ModelView tree A11y issue (#7835)
* Fix tree A11y issue

* Toggle expanded state on enter

* Move onkeydown method to base class
2019-10-20 21:42:55 -07:00
Chris LaFreniere
e3ae5263c6 Starting Fewer Jupyter Servers for Notebooks (#7744)
* Start fewer Jupyter servers

* Windows fix for drive casing

* PR Feedback

* Quick fix

* Fixing bug

* Ensure environment variables set 4 session startup

* test fix

* Dummy commit to update comment
2019-10-20 21:38:58 -07:00
Alan Ren
0bfb1aab7e set storage settings table name (#7841) 2019-10-20 19:27:50 -07:00
Chris LaFreniere
d120102805 Bump up widths for pick, remove schedule buttons (#7517) 2019-10-20 13:22:49 -07:00
Charles Gagnon
7e5b864299 BDC Dashboard connection retry (#7784)
* Open cluster dashboard

* Remove old translated strings and update var name

* Add exported auth type

* Add newline

* Add connection retry for dashboard

* Change getMainSectionComponent to return multiple (no undefined)

* Move try/catch to withConnectRetry

* Add connection retry for dashboard

* Change getMainSectionComponent to return multiple (no undefined)

* Move try/catch to withConnectRetry
2019-10-19 15:42:49 -07:00
Arvind Ranasaria
4dd6db57ee Feat/tool install master merge back to master (#7819)
* add install tools button (#7454)

* add install tools button

* address comments

* remove description for install tools hint message

* First working version of AutoDeployment of tools (#7647)

First working version of AutoDeployment of tools.

This pull request adds feature to install the tools needed for doing BDC/TINA deployments.

This has been tested so far only on win32 and testing on other platforms is in progress.

* removing TODO and redundant code

* Not localizing azuredatastudio product name

* convert methods returning Promises to async-await

* changing from null to undefined

* Localize all the command labels

* using existing sudo-prompt typings

* progres/error status in ModalDialogue && PR fixes

* review feedback to change warning to information

* revert settings.json changes

* fix resource-Deployment Extension Unit Test

* ensuring platform service's working directory

* incorporate review feedback

* review feedback

* addressing PR feedback

* PR fixes

* PR Feedback

* remove debug logs

* disable UI deployment containers when installing

* addding data type to stdout/stderr messaging

* remove commented code

* revert accidental change

* addressing review feedback

* fix failed install with zero exit code

* fixing bug due to typo

* fixes for linux

* Misc fixes during mac testing

* PR fixes
2019-10-18 23:17:21 -07:00
Udeesha Gautam
a2f105a913 Fix Local keys for spark so that dup key error doesnt occur (#7634) 2019-10-18 18:06:37 -07:00
Charles Gagnon
ab31a7b964 Open cluster dashboard from SQL Dashboard (#7783)
* Open cluster dashboard

* Remove old translated strings and update var name

* Add exported auth type

* Add newline

* PR feedback
2019-10-18 17:35:47 -07:00
Amir Omidi
203ff3872f Test run list proposal (#7617)
* Test run list propsal

* fixed ts errors

* added js file

* excluding testSetup.js file from hygiene

* moved ignore line to indententationFilter
2019-10-18 17:21:40 -07:00
Chris LaFreniere
2ee3840650 First improvements for SQL Cell Looping (#7733)
* First improvements

* clear results

* cleanup

* error handling
2019-10-18 17:12:10 -07:00
Cory Rivera
fa80dbfb27 Update download links for our notebook Python packages. (#7839) 2019-10-18 16:53:29 -07:00
Amir Omidi
2237d286b6 XML output is truncated (#7748)
* QueryExecutionOptions change

* add config points

* Change api type used

* Revert "QueryExecutionOptions change"

This reverts commit 7adc3b032b5e4bc92234d337f0a145f0963c2d34.

Let's not change the azdata file.

* Change the signature of this api

* Change the event

* Change SqlCMD to use the API properly

* Add type

* Change type to interface - handle existing files

* Remove unused import

* Delete useless code

* Remove unnecessary code

* Fix the interface

* remove whitespace
2019-10-18 16:35:45 -07:00
Anthony Dresser
4124f6b1ad Readd labeling (#7834)
* readd labeling

* fix yml structure

* fix more yml structure
2019-10-18 15:07:31 -07:00
Karl Burtram
23361d3d56 Update ENU loc resource files (#7831) 2019-10-18 14:35:15 -07:00
Anthony Dresser
4c8f3ddfd3 Add scripting contributions for explorer widget (#7830)
* add scripting contributions for explorer widget

* utilize or
2019-10-18 14:26:43 -07:00
Amir Omidi
f631a8aa9a Delete unused code (#7800)
* Update cmsUtils.ts

Fix small issue

* Delete unused code
2019-10-18 13:29:34 -07:00
Amir Omidi
bbc6460d3f Update groupContainer.component.ts (#7803)
Fix small issue
2019-10-18 13:27:25 -07:00
Amir Omidi
09d78544cf Update sqlExtHostTypes.ts (#7801)
Fix small mistake
2019-10-18 13:26:53 -07:00
Amir Omidi
a791aff0a2 Update pythonPathLookup.ts (#7807)
Fix regex problem
2019-10-18 13:26:38 -07:00
Amir Omidi
ce318f123f remove unusued deps (#7810) 2019-10-18 13:22:50 -07:00
Amir Omidi
9374056e61 move dependencies around (#7808) 2019-10-18 13:22:13 -07:00
Charles Gagnon
5ef19affd0 Update SqlToolsService (#7826) 2019-10-18 12:12:16 -07:00
Charles Gagnon
d40abf4add Add husky back for precommit hooks (#7825) 2019-10-18 08:47:58 -07:00
Alan Ren
86f8b3f9ec change field type to Password (#7791) 2019-10-17 22:39:31 -07:00
Chris LaFreniere
385d7f2803 Clear Output -> Clear Result for consistency (#7776) 2019-10-17 19:54:12 -07:00
Chris LaFreniere
2ee04e0cf0 null checks for onBeforeDetached (#7782) 2019-10-17 18:24:30 -07:00
Cory Rivera
9bdaba3b65 Remove sqlmlutils from default packages due to installation failures on OSX. (#7780) 2019-10-17 17:21:53 -07:00
Chris LaFreniere
80d46fb8a4 Add search book icon (#7777) 2019-10-17 17:20:07 -07:00
Maddy
268f9ef725 revert the version bump. (#7772) 2019-10-17 15:10:53 -07:00
Alan Ren
3813d9385b update the extensions.json (#7771) 2019-10-17 14:26:47 -07:00
Charles Gagnon
48bf72bfc4 Fix TelemetryOptOut error and add debug targets for running extension integration tests (#7765) 2019-10-17 13:39:11 -07:00
Amir Omidi
fa1d5cc49d Revert "Move Notebook tests back to stable" (#7755)
* Revert "Move Notebook tests back to stable (#7749)"

This reverts commit 5d4da455bd.

* Update notebook.test.ts

* Update notebook.test.ts
2019-10-17 11:30:58 -07:00
Amir Omidi
de5fd11155 Add some more asserts to integration tests (#7759) 2019-10-17 10:55:16 -07:00
Alan Ren
cd30a8cbc0 enable bdc features for stable (#7757) 2019-10-17 09:59:29 -07:00
Alex Ma
ec1e54db9a Handling for parsing of iconpaths (#7738)
* Check if light and dark are URI

* Added a map in the extensionsRegistry to check

* Moved resolve check to connectionProviderExtension

* removed resolvedUsers from extensionsRegistry.ts

* removed unused imports and spaces

* Formatting for import

* Simplified resolver check.

* ToString is sufficient to avoid any complications

* Small formatting fix

* removed extra comment
2019-10-17 09:51:33 -07:00
Maddy
82963ad075 vbump for the updates (#7752) 2019-10-16 23:10:24 -07:00
Elliot Boschwitz
b24671bbf6 disabled failing tests in vs code
Add skip statements for tests found to be failing.
2019-10-16 21:25:03 -07:00
Alan Ren
2ab7a47353 deploy BDC wizard improvement for CU1 (#7756)
* unified admin user account (#7485)

* azdata changes

* spaces

* error message

* comments

* support AD authentication for bdc deployment (#7518)

* enable ad authentication

* remove export for internal interface

* add comments

* more changes after testing

* update notebooks

* escape slash

* more comments

* Update deploy-bdc-aks.ipynb

* Update deploy-bdc-existing-aks.ipynb

* Update deploy-bdc-existing-kubeadm.ipynb

* AD changes and review feedback (#7618)

* enable ad authentication

* remove export for internal interface

* add comments

* more changes after testing

* update notebooks

* escape slash

* more comments

* Update deploy-bdc-aks.ipynb

* Update deploy-bdc-existing-aks.ipynb

* Update deploy-bdc-existing-kubeadm.ipynb

* address comments from scenario review (#7546)

* support AD authentication for bdc deployment (#7518)

* enable ad authentication

* remove export for internal interface

* add comments

* more changes after testing

* update notebooks

* escape slash

* more comments

* Update deploy-bdc-aks.ipynb

* Update deploy-bdc-existing-aks.ipynb

* Update deploy-bdc-existing-kubeadm.ipynb

* scenario review feedbacks

* more fixes

* adjust the display order of resource types

* different way to implement left side buttons

* revert unwanted changes

* rename variable

* more fixes for the scenario review feedback (#7589)

* fix more issues

* add help links

* model view readonly text with links

* fix size string

* address comments

* update notebooks

* text update

* address the feedback of 2nd round of deploy BDC wizard review (#7646)

* 2nd review meeting comments

* fix the unit test failure

* recent changes in azdata

* notebook background execution with azdata (#7741)

* notebook background execution with azdata

* prompt to open notebook in case of failure

* fix path quote issue

* better temp file handling

* expose docker settings (#7751)

* add docker settings

* new icon for container image
2019-10-16 20:41:15 -07:00
Charles Gagnon
5d4da455bd Move Notebook tests back to stable (#7749)
* SqlClient fix is in so these should be stable again

* removed comments
2019-10-16 16:44:36 -07:00
Cory Rivera
0b039830ea Add sqlmlutils to list of required notebook packages. (#7740) 2019-10-16 14:16:09 -07:00
Charles Gagnon
77e1ca59ed Roll back tree icon merge changes to fix loading icon issue (#7722) 2019-10-15 22:44:37 -07:00
Charles Gagnon
e8e8ee5941 BDC Dashboard fixes (#7732)
* BDC Dashboard fixes

* Make refresh indicate when refresh is happening

* Fix refresh button to properly reset even if error occurs. Refactor onclick into own method.

* Undo refresh button rotation per design feedback
2019-10-15 21:50:02 -07:00
Cory Rivera
23861bd369 Wait for python installs to complete before starting a python notebook. (#7729) 2019-10-15 17:06:19 -07:00
Chris LaFreniere
4c946b21a9 Jupyter Book Search First Steps (#7704)
* Crawling for book search. needs icon

* Remove context until decision on entry point

* Add undefined check
2019-10-15 17:04:24 -07:00
Alex Ma
e74538b40d Added notification for unsaved file in scheduling (#7705)
* Added notification for unsaved file in scheduling

* Removed logging message in line 216

* Changed regex for all 3 platforms (forbid '/')

* Untitled file prompts to save in mainController

* removed spaces and changed save message
2019-10-15 14:29:34 -07:00
Cory Rivera
b6ef5469de Correctly handle exceptions in package upgrade promise. (#7734) 2019-10-15 13:50:30 -07:00