Commit Graph
100 Commits
Author SHA1 Message Date
Aasim Khan 67637a41f5 Making better ep highlights (#20055) 2022-07-15 15:31:01 -07:00
Aasim Khan 59889252f1 updating sts to get latest top operations changes (#20005) 2022-07-12 15:55:11 -07:00
Aasim Khan b15f3bd986 Fixing port request actions (#19966) 2022-07-12 15:54:56 -07:00
Aasim Khan 980a233aad Sorting top by cost initially (#19998) 2022-07-11 21:34:38 -07:00
Aasim Khan 53a0388858 Deleting old query plan code (#19996) 2022-07-11 19:14:47 -07:00
Aasim Khan 5d17ed6760 Updating gulp-atom-electron to update braces (#19947) 2022-07-11 09:01:44 -07:00
Aasim Khan 059b70c6a4 Fixing macos test results publishing warnings (#19968)
* Fixing macos task

* Renaming job step
2022-07-08 18:43:33 -07:00
Aasim Khan 61c38b8f83 updating ajv (#19950) 2022-07-08 16:10:34 -07:00
Aasim Khan 9cfa1436d9 Adding top operations to execution plans (#19902)
* Adding top operations to execution plans

* Adding title to links

* Fixing pr comments

* Hiding top operations icon in execution plan editor

* Reducing outline width, adding separator and removing placeholder text

* Registering TopOperationsTabView
2022-07-07 12:50:52 -07:00
Aasim Khan 19b9290dfa Updating sts (#19943) 2022-07-07 09:37:22 -07:00
Aasim Khan b8b3c65588 Updating azure-storage in build (#19936) 2022-07-06 16:09:53 -07:00
Aasim Khan 15a611d4a4 Fixing tabbing logic for tab headers (#19770)
* Fixing tabbing logic for tab headers

* Renaming stuff
Making null checks concise
Adding comments

* Renaming css class and interfaces from active to selected

* Renaming styling classes and objects

* Changing tabbing logic to match w3 behavior

* Fixing focus logic in tab

* Adding helper comment

* Code cleanup
2022-06-21 13:13:10 -07:00
Aasim KhanandCharles Gagnon 8079cf8a2d Adding arialive to flex and div container (#19757)
* Adding arialive to flex and div container

* Fixing compilation issues

* Moving ariaLive to container properties

* fixes

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-06-21 09:45:45 -07:00
Aasim Khan d4509a6528 Removing truncation from tab header components to make it match the portal look (#19746)
* Fixing truncated tab headers

* Localizing changes to horizontal tab headers

* Remove max - width

* Reverting older changes
2022-06-16 14:07:45 -07:00
Aasim Khan b980fe1106 Hiding description tooltip on escape key. (#19741)
* Hiding text tooltip on escape

* Fixing hover event
2022-06-15 18:23:18 -07:00
Aasim Khan 489259d364 Fixing graph root padding and truncating long queries in execution plan (#19703)
* Fixing graph root padding
Truncating queries to one line

* Updating remote package
2022-06-09 17:05:35 -07:00
Aasim Khan b1d8e43569 Changing plan comparison properties table logic and icons (#19700)
* Changing plan comparison logic and icons

* Removing empty class ref
2022-06-09 14:15:35 -07:00
Aasim Khan 0b89272739 Removing filter from set Data (#19640) 2022-06-06 13:44:42 -07:00
Aasim Khan 36c480699f Surfacing extension install errors (#19613)
* Surfacing extension install error

* Fixing error property

* removing unncessary await

* Fixing error type and message

* Fixing some more strings

* Adding missing period

* Consolidating some strings

* consolidating strings

* revert vbump

* Switching to ExtensionManagementError
2022-06-03 19:41:09 -07:00
Aasim Khan b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Aasim Khan f0f4a0a3cf Updating sqltoolsservice (#19614) 2022-06-03 16:25:16 -07:00
Aasim Khan 67f8ffea52 Updating vsce package (#19536)
* Updating vsce package

* Removing unsupported extensionKind
2022-05-26 13:13:25 -07:00
Aasim Khan 386c986480 Updating set-value (#19534) 2022-05-26 10:08:35 -07:00
Aasim Khan 63712909aa updating normalize-url (#19535) 2022-05-26 10:08:15 -07:00
Aasim Khan 4e39c5fcf6 Updatin kind-of (#19533) 2022-05-26 10:03:57 -07:00
Aasim Khan f7aeccb0d4 updating gulp-azure-storage (#19492) 2022-05-25 22:19:57 -07:00
Aasim Khan 36cd60f290 Reverting gulp-untar resolution (#19529) 2022-05-25 18:10:20 -07:00
Aasim Khan 6282958bd1 scoping css (#19520) 2022-05-25 10:31:29 -07:00
Aasim Khan 6838261aed Updating tar across ads (#19507) 2022-05-24 18:23:41 -07:00
Aasim Khan b194a5a784 updating gulp-eslint (#19491) 2022-05-24 10:28:50 -07:00
Aasim Khan 719a7889fc updating kind-of (#19489) 2022-05-23 17:51:12 -07:00
Aasim Khan a7749471ec Updating remote-retry-src (#19488) 2022-05-23 16:16:17 -07:00
Aasim Khan c9c670cc86 Updating a vulnerable package (#19485) 2022-05-23 15:22:03 -07:00
Aasim Khan 8bb6b5fc1a Redoing Execution Plan Comparison Editor (#19375)
* Adding code for execution plan comparison editor

* Handling floating promises and fixing a loc string

* Fixing some polygon stuff

* Fixing azdatagraph null check bug

* Adding progress notification for similar areas

* Removing some floating promises

* Fixing button enabled state
2022-05-23 14:33:18 -07:00
Aasim Khan 6dbaa7e6f6 Updating sts (#19462) 2022-05-20 10:49:46 -07:00
Aasim Khan 20800a4279 Fixing keyboard navigation in execution plan graph and using selection change events to get selected cells (#19294) 2022-05-06 12:31:00 -07:00
Aasim Khan d0aae8e95b Adding ability to style cells in slickgrid (#19195) 2022-04-25 09:09:53 -07:00
Aasim Khan 7554fbcaa0 Fixing zoomed badges (#19178) 2022-04-22 11:57:18 -07:00
Aasim Khan d7f8b0bfed Fixing parallism icon not showing up (#19085) 2022-04-14 00:19:36 -07:00
Aasim Khan 192f7cc390 Fixing broken action label logic. (#19086)
* Fixing broken action label logic.

* Cleaning up some code
2022-04-14 00:19:07 -07:00
Aasim Khan 7dfa347250 Updating the cache element and not an unlinked reference to it. (#19057) 2022-04-13 14:33:35 -07:00
Aasim Khan 387f4cd116 Adding caching to execution plan and refactoring code and some other fixes (#18913)
* Making ep code modular for easy swithcing in and out

* Changing to innerText

* Fixing renames

* Fixing var name in one file
2022-04-12 12:52:24 -07:00
Aasim Khan dd2d6e0b5c Adding link support to infobox. (#18876) 2022-04-11 20:39:41 -07:00
Aasim Khan 170950dca8 Adding badge icons to execution plan (#19004)
* Adding badge icons to executionplan

* Fixing doc comment

* Fixing doc comments

* Making enum value more readable

* Changing default to undefined.

* Fixing some icon names
2022-04-11 14:44:07 -07:00
Aasim Khan 9fcfe5b23c Adding flag to hide refresh button in dashboards. (#18964) 2022-04-09 17:52:09 -07:00
Aasim Khan d8b3db2ee3 Updating moment package (#18956)
* Updating moment package

* Fixing moment

* Fixing notebook moment package
2022-04-07 14:04:13 -07:00
Aasim Khan 4db0814b94 Adding context menu to table component (#18914)
* Adding context menu to table component

* Removing extra whitespace

* Some logic fixes

* Fixing focus logic
2022-04-04 23:47:39 -07:00
Aasim Khan 989ee0b2c7 Updating azdataGraph package to get tooltip improvements (#18877) 2022-03-30 14:28:16 -07:00
Aasim Khan 6c51b934f9 Fixing clickable state of infobox not setting properly when initializing it. (#18763)
* Fixing clickable state of infobox not set when initializing it.

* Removing unnecessary calls to a method
2022-03-17 14:11:15 -07:00
Aasim Khan a0c2dc199e Adding Execution Plan Editor to ADS (#18696)
* Pushing Execution Plan Editor

* Renaming class
Handling error

* Awaiting for handlers to be registered

* Addressing some PR comments

* Fixing return type for provider

* Fixing editor id and removing unnecessary overrides

* Adding a namespace

* adding execution plan namespace

* Adding protocol comment

* Fixing if logic

* Fixing error message

* Cleaning up code

* cleanup code

* Adding help comments

* Fixing method call

* Using path.ts to get the base file name

* converting to lambda functions

* Adding comment for run action

* Fixing pr comments

* Fixing editor label

* Fixing doc comments

* Adding some more comments

* Fixign branding in comments
2022-03-16 15:07:29 -07:00
Aasim Khan b299f7ed3f Making infobox clickable (#18676)
* Making infobox clickable

* Making it accessible

* Moving API to proposed

* Matching styling from portal

* Fixing some styling

* Moving to proposed

* Removing extra spacing

* Registering and Unregistering listeners

* Fixing listeners

* Registering emitter only once.

* Changing emitter type from undefined to void

* Adding arialabel to clickable link

* Changing property name to suit its purpose
2022-03-09 18:43:39 -08:00
Aasim Khan 02341088eb Renaming query plan to execution plan (#18551) 2022-02-25 00:49:34 -08:00
Aasim Khan 19c7971630 Bringing back leftover changes (#18527) 2022-02-22 15:44:01 -08:00
Aasim Khan 5731366a1c Fixing query editor smoke test (#18515)
* Fixing query editor smoke test

* Fixing notification toast for telemetry opt out

* Adding SQL Carbon edit
2022-02-22 14:15:12 -08:00
Aasim Khan eff847f35a Removing extra toUrl call (#18492) 2022-02-18 14:49:02 -08:00
Aasim Khan 678f2e3878 Fixing the height of the query plan (#18409)
* Fixing the height of the query plan

* Fixing layout issues
2022-02-16 15:44:33 -08:00
Aasim Khan 81e8eb9a82 Adding zoom button (#18407)
* Adding zoom button

* Fixing string
2022-02-16 15:26:14 -08:00
Aasim Khan fe360afec7 Fixing context menu strings (#18404)
* Fixing context menu strings

* Fixing string
2022-02-16 15:21:35 -08:00
Aasim Khan 25f563229f Adding tooltips and fixing spacing (#18400) 2022-02-15 16:24:40 -08:00
Aasim Khan 316c6a536f Fixing graph editing (#18361) 2022-02-14 16:34:30 -08:00
Aasim Khan 4dd59c6b8d Using proper zoom icon (#18338) 2022-02-14 15:38:55 -08:00
Aasim Khan 08815a3c0f Adding save file functionality to query plan (#18337) 2022-02-11 19:53:11 -08:00
Aasim Khan d76f239ae2 Fixing init value of custom zoom widget (#18331) 2022-02-11 17:32:07 -08:00
Aasim Khan b25935f8a5 removing feature specific query plan flag (#18330) 2022-02-11 14:17:39 -08:00
Aasim Khan b65e6d0bab Fixed tooltip not hiding when scrolling through graph control (#18314) 2022-02-11 14:17:26 -08:00
Aasim Khan 066d7a14a3 Fixing icons and styling in Query Plan (#18328)
* Fixing icons and styling

* Fixng some hc styling
2022-02-11 13:41:43 -08:00
Aasim Khan 8ac09917ca Adding search, zoom, custom zoom and additional stylings to showplan (#18255)
* Lot of changes
-Updating azdata to 0.0.13
-Updating prop views on node clicks
-Context menu on graphs
-Updating edge color on theme
-Scrolling graph control like ssms
-Zooming in, out and custom zoom on graph
-Custom zoom widget
-Node search widget

* Fixing hygine errors

* Code cleanup

* Fixing action name

* Renaming actions

* equals dropdown

* fixing tooltip

* Code cleanup
Fixing sorting function
Adding functionality for replacement strings

* Removing internal facing props from azdata proposed

* Fixing hygine issue

* Fixing web package hygiene

* Updating yarn lock files

* Fixing initial click
2022-02-10 14:43:35 -08:00
Aasim Khan 1eff096220 Vbumping STS to get latest Query Plan code (#18300)
* Vbumping sts to get latest qp code

* Updating azdataGraph in remote package.json

* Revert "Updating azdataGraph in remote package.json"

This reverts commit 704aa6b653b20c6bc439ba2ac46f4dcdead0128d.
2022-02-10 13:37:49 -08:00
Aasim Khan 424c6e34a4 Removing older show plan from results pane (#18294) 2022-02-10 08:31:22 -08:00
Aasim Khan 644d24ca13 vbumping sts to get latest execution plan changes (#18205) 2022-02-02 14:44:31 -08:00
Aasim Khan e40c31559a Adding properties view and action bar to graph and fixing styling. (#18185)
* Adding properties view and action bar to graph.

* Open Graph File

* replacing innerhtml with  innertext

* Fixing floating promises

* Fixed typo

* renaming

* Fixing hardcoded colors and comments

* Removing todo and hardcoded colors

* renaming method

* removed unused contract

* Fixed path in comment

* converting div to button

* adding checks to table width and height setter

* Make method name more meaningful

* adding method return types

* concising repeated logic

* removing unused styling

* better sorting logic

* Fixing graph parsing
Renaming some stuff
Implementing IDisposable

* Fixing bad props logic

* Fixed image loading issue

* Removing hardcoded colors

* Adding comments to localize and handling undefined cases in sort

* Changed ch to px

* moving util function to strings
2022-02-02 14:17:01 -08:00
Aasim Khan 7b29c1fdac Fixing smoke tests in import where the status bar text was not found. (#18126) 2022-01-19 14:23:00 -08:00
Aasim Khanandkburtram ea2860eb33 Pushing initial work for done in Query plan feature to main (#17986)
* Adding initial boilerplate for qp2

* Adding feature flag in query plan 2

* Clearing show plan 2 after every run

* Adding sub tree cost

* removing unused method.

* WIP 2

* Adding properties view and relative cost to query plan

* WIP

* Add icons to ads

* Assing relative costs and prop windows

* Enabling older query plan again

* Making some PR fixes

* Some more PR related fixes

* Use MS org azdataGraph module

* Moving new properties to azdata proposed.

* Moving new class properties to proposed

* added missing doc component.

* Changing how azdatagraph package is referenced

* Removing empty lines, fixing localization keys

* Removing empty line, localizing some string

* making css classes more specific

* making some logic concise

* localizing some more strings

* Making more css classes specific

* Removing important tag from css props

* Checking if sum is greater than 0 to prevent divide by zero exceptions

* Fixed loader error in bootstrap

* Fixing query index

* -fixing image paths
-making css class more class specific by using nested selectors

Co-authored-by: kburtram <karlb@microsoft.com>
2022-01-13 09:32:13 -08:00
Aasim Khan 04c1f31e24 Upgrading nested dependency 'follow-redirects' to latest version 1.14.7 (#18053)
* Upgrading nested dependency 'follow-redirects' to latest version 1.14.7

* Updating another follow-redirects in build/actions
2022-01-12 12:24:18 -08:00
Aasim Khan 3e3bc7a7fc Updating pipeline linux agent image to Ubuntu 18.04 (#17792)
* Updating the linux build image

* adding python to docker file

* adding more required libs
2021-12-06 22:08:24 -08:00
Aasim Khan 1f9a6a611b Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint

* updating the service connection

* Changing the name of acr service endpoint to SqlToolsContainer

* Updating web build acr endpoint as well.
2021-11-30 12:34:06 -08:00
Aasim Khan 447b969b5c updating sts to get sql star expansion (#17528) 2021-10-28 13:17:39 -07:00
Aasim Khan 95e82d53e6 Adding lists support in text component (#17065)
* Adding lists support in text component

* Fixing get textType

* Code cleanup

* Combining values into value
2021-09-14 12:43:14 -07:00
Aasim Khan 2d609c9cbc Adding error message and placeholder for dropdown (#17012)
* Adding error message and placeholder for dropdown

* Fixing default error message for empty required dropdown

* Fixing a small input value updating bug

* Fixed a commend

* Fixed a comment

* PR fixes

* Using codicon

* Fixed screen reader not reading error message

* Adding support for multiple dropdowns error message

* Adding error border

* Fixing error border styling.

* Added more specific classes for styling

* Making styling more specific
2021-09-10 13:40:25 -07:00
Aasim Khan cbba05f54f Using updated assessment nuget to get blocking issues (#17038) 2021-09-09 22:23:02 -07:00
Aasim Khan cc4780840c Fixing an expression typo for azure mfa in import extension (#17002)
* Fixing if expression for azure mfa in import

* updating import package number
2021-09-05 21:49:37 -07:00
Aasim Khan f5f52b19c7 Adding support for AAD connections in import wizard (#16759)
* Adding support for aad connections in import extension

* Adding support for AAD by passing azure account token

* Adding a test for aad connections and fixing broken tests

* removing extra await
2021-08-16 11:57:35 -07:00
Aasim Khan 74938d563d Adding context menu item on server level for import wizard (#16700)
* Adding context menu item on server level for import wizard

* Changing to regex instead of using duplicate oe commands
2021-08-12 09:07:02 -07:00
Aasim Khan 8be0f742bc Listing filtered locations for migration service public preview. (#16731)
* Filtering regions for public preview

* rename var

* reverting back to const
2021-08-11 17:48:44 -07:00
Aasim Khan 4bc75ef6d6 Updating mssql to get azure dashboard fixes: (#16658)
1. making cpucount and phy mem props optional in ServerInfo
2. Moving the 2 props to azdata.proposed
2021-08-10 13:06:36 -07:00
Aasim Khan 1a8a382016 updating sts to get migration service fixes (#16627) 2021-08-09 11:18:17 -07:00
Aasim Khan dc0ccba767 Changing to resource group level api to fetch dms (#16614) 2021-08-06 23:58:57 -07:00
Aasim Khan f1b9931116 Fixed assessment error handling (#16610)
Displaying striped files in sts
2021-08-06 23:01:56 -07:00
Aasim Khan 63c461dca8 Fixed: (#16594)
Summary label
DMS creation retry times
DMS dropdown resetting
2021-08-06 12:12:53 -07:00
Aasim Khan 3d7edd2d6a Revamping cutover page based on new mockups (#16547)
* WIP

* Fixing some table issues

* updating package.json

* Fixing readable time

* fixing display string

* Handling null case in get12hourtime util method
2021-08-04 16:21:01 -07:00
Aasim Khan 466193adbe Fixing the redacted migration service id by encoding it to base64 (#16528) 2021-08-02 16:26:09 -07:00
Aasim Khan 0bbbb91adf Trying to fix the scrollbar bug (#16477) 2021-07-29 10:19:28 -07:00
Aasim Khan 39f65b1881 Adding wizard step telemetry for sql migration wizard (#16469)
* Adding wizard step telemetry for sql migration wizard

* Refactoring event name

* refactoring function name
2021-07-29 10:14:45 -07:00
Aasim Khan 0e9d956ee5 Adding support for multi cloud in azure rest api calls (#16454) 2021-07-29 10:14:15 -07:00
Aasim Khan 01671b118d Adding aria label to all the migration tables (#16476) 2021-07-29 09:20:58 -07:00
Aasim Khan d1d858090c Fixing the resource name passed to create sql migration api (#16470) 2021-07-28 15:36:06 -07:00
Aasim Khan 7a35d4aeeb Adding support for sending request headers in azure core rest request API (#16443)
* Adding support for sending additional headers in azure http requests

* Added session ids in all azure rest calls

* Fixed param name

* Adding default parameter value for request headers
2021-07-27 12:36:50 -07:00
Aasim Khan 70fc6bd43d Adding Assessment Telemetry in SQL Migration (#15935)
* Adding telemetry for assessment

* Removing dms loading fix

* Fixing PR

* removing collection of account id

* moving database warning count to the server assessment event

* Removing individual warning and issue events

* Adding aggregates for database issues and warnings

* removing extra line

* Adding other telemetry events in sql migration

* Fixed changes made in the PR

* Fixing attribute names

* Consolidating issues and errors in 1 event

* Converting dependencies to dev depenedencies

* Adding a catch for the telemetry function

* moving the non type uuid to non dev

* Made hashmap code cleaner

* Fixing cutover start time

* Fixing object creation

* Reverting back to old method.

* Modifying the date time to js objects

* Converting issues and warnings to json object
2021-07-26 12:26:37 -07:00
Aasim Khan 1eb03404ad Updating assessment api response object in SQL Migration (#16334)
* Modifying the get assessments  api to match the new specs

* fixing property name

* Updating sts version
2021-07-20 13:55:58 -07:00
Aasim Khan 88fd0cae3b Adding ability to set hyperlinks as buttons in extensibility. (#16319)
* Adding option to treat hyperlinks as buttons

* Adding ext host endpoints for is button property in hyperlinks

* Removing isButton flag and plugging in aria role in the hyperlink component

* Removing attribute null check
2021-07-20 11:29:38 -07:00