ckaczor/azuredatastudio
Archived
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,270 Commits 1 Branch 152 Tags
6cf82d2611304deae13abaad60404ba79df3f452
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris LaFreniere 41a90c01c3 Listen to escape key to close nb find widget (#9247) 2020-02-21 15:54:21 -08:00
Chris LaFreniere 2503b18d4b Fix for manage access dialog focus (#9114) 
* Fix for manage access dialog focus

* Leverage eventuallyRunOnInitialized
 2020-02-13 16:40:23 -08:00
Chris LaFreniere f10a504f45 Notebooks: Listen for Enter on Add Package Tab (#9124) 
* Pressing enter searches for package

* cleanup
 2020-02-13 11:14:51 -08:00
Chris LaFreniere b4e30e17af Remove unnecessary code to sql-vnext extension (#9027) 2020-02-06 17:37:46 -08:00
Chris LaFreniere 343daf58fe Notebooks: Fix Padding on Mac SelectContainers in Toolbar (#9021) 
* fix css on mac

* change to monaco workbench mac
 2020-02-05 16:06:55 -08:00
Chris LaFreniere 8e67b104c3 BDC: Add another command for bdc extension activation events (#9050) 
* Add another command for bdc extension activation

* spaces

* Add other activation events

* spacing
 2020-02-04 20:09:39 -08:00
Chris LaFreniere 10d817b6b4 Change ps kernel version to latest 4 updated flow (#9023) 2020-02-04 11:52:28 -08:00
Chris LaFreniereandCharles Gagnon 2208666eef Books: Ensure associatedResource is Present for Untitled Notebooks that have a File Associated with them (#9037) 
* Conditionally add associatedResource t untitled nb

* Fix Jupyter Book notebook titles (#9039)

* Fix notebook titles

* Fix navigation links for books

* Added comments

Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>

* PR comment nit

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2020-02-04 11:42:24 -08:00
Chris LaFreniere de27f2c2a5 stop firing active cell change events unnecessary (#8983) 2020-01-29 13:54:48 -08:00
Chris LaFreniere 89554e5c14 Re-enable windows test (#8981) 2020-01-28 17:48:07 -08:00
Chris LaFreniere 136a1d8cee Temporarily Disable Windows_Test Job in Product Build (#8971) 
* Temporarily Disable Windows Test Job

* Ensure Windows Test is removed from dependsOn
 2020-01-27 17:32:24 -08:00
Chris LaFreniere b02bf17d1f Fixes for broken notebook experience (#8944) 
* Fixes for broken notebook experience

* add sql carbon edit

* sql carbon edit

* add another sql carbon edit for import

* Set untitledResource instead of no resource
 2020-01-23 17:06:32 -08:00
Chris LaFreniere 826e069b63 Fix passing in connection profile (#8689) 2019-12-16 13:20:43 -08:00
Chris LaFreniere 6e8a08c27a Fix Notebook Scrolling by Setting alwaysConsumeMouseWheel to False (#8686) 
* flip alwaysConsumeMouseWheel to false for nb

* remove semicolon
 2019-12-16 13:17:02 -08:00
Chris LaFreniere d1c594cfd0 Change deploy string from connections viewlet/welcome page (#8646) 
* Change deploy string from connections viewlet

* Also change welcome page
 2019-12-12 10:25:22 -08:00
Chris LaFreniere 698b4fce41 Add generic select box padding (#8635) 2019-12-10 22:14:01 -08:00
Chris LaFreniere 302e8305ef add titles to collapse expand button (#8607) 2019-12-10 21:08:28 -08:00
Chris LaFreniere bceb766d28 Notebooks: Fix Cancel for Connection Dialog to Actually Close Window (#8626) 
* Fix connection dialog not going away on cancel

* Remove unnecessary change
 2019-12-10 16:59:15 -08:00
Chris LaFreniere 62565e0577 Notebooks: Only have One Connection in Attach To Dropdown (#8582) 
* Have only one connection in attach to dropdown

* LGTM fixes

* Test fixes not unnecessarily changing context 2x

* PR Feedback
 2019-12-08 11:03:51 -08:00
Chris LaFreniere 8655044dfb Notebooks cleanup: Remove old out of proc markdown option (#8394) 
* Remove old out of proc markdown option

* Revert change to stats.js
 2019-11-20 14:00:06 -08:00
Chris LaFreniere 7e553031ce Remove open notebook entry points (#8393) 2019-11-20 13:46:03 -08:00
Chris LaFreniere 2f1f5b2376 Prevent Markdown Cells from Collapsing (#8317) 2019-11-12 18:40:06 -08:00
Chris LaFreniere 0520870754 notebooks lgtm cleanup part 1 (#8280) 2019-11-11 13:40:48 -05:00
Chris LaFreniere 55acb36e33 Update powershell kernel version to 0.1.2 (#8171) 2019-11-01 10:47:32 -07:00
Chris LaFreniere 5aff7ef4c7 Ensure cwd matches notebook path (#8137) 
* Ensure cwd matches notebook path

* add error checking

* silent, don't store history
 2019-10-31 15:10:49 -07:00
Chris LaFreniere dd270a78fc Notebooks: Improvements to Connection Profile Passing (#8105) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering

* update databaseName when it's set to master

* usinng query as example
 2019-10-30 13:22:17 -07:00
Chris LaFreniere 62af81e88c Notebooks: Fix relative images not rendering on PC for Markdown Cells (#8091) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering
 2019-10-29 19:48:57 -07:00
Chris LaFreniere 3b1c9e910d serverManager to decide if server start needed (#8017) 2019-10-25 11:11:54 -07:00
Chris LaFreniere 5b29aef5f3 fix stdin cancel breaks notebook (#8012) 2019-10-25 10:52:18 -07:00
Chris LaFreniere f8067ffada Fix for Markdown File in Jupyter Books Viewlet not Opening After 2x (#8009) 
* fix for markdown not opening after opened twice

* PR comment to add return type
 2019-10-24 22:14:24 -07:00
Chris LaFreniere f7059a2365 Fix Issue when Saving Wrong Kernel (#7974) 
* Only fire kernelChangeEmitter after lang set

* Fix unused import found by lgtm

* Fix comment
 2019-10-24 22:13:18 -07:00
Chris LaFreniere 5cfad825fc search book gone from command palette (#8002) 2019-10-24 17:45:28 -07:00
Chris LaFreniere b1e0b7c1e3 Always send \n instead of \r\n to Jupyter kernel (#7995) 
* Always send \n instead of \r\n to kernel

* Use replace instead of split/join
 2019-10-24 16:43:52 -07:00
Chris LaFreniere a33820ecdd Fix starting and separators in a row (#7861) 2019-10-24 15:20:58 -07:00
Chris LaFreniere fb4fccf2d5 Notebooks: ensure python path dirs added to path on session start (#7968) 
* ensure python path dirs add to path session start

* Change logic slightly

* PR feedback from Charles
 2019-10-23 19:22:24 -07:00
Chris LaFreniere b53cad78bd Update recommended package versions for ps (#7972) 2019-10-23 18:57:05 -07:00
Chris LaFreniere a431ca7ef2 check for ownerDocument focus for focus (#7964) 2019-10-23 18:56:43 -07:00
Chris LaFreniere c2022cac57 Fix for relative links not being resolved in notebook outputs (#7966) 
* Fix for relative links not being resolved

* Add comment
 2019-10-23 18:49:52 -07:00
Chris LaFreniere 4c24043cc8 Add Option to Halt Notebook when Error Occurs in SQL Kernel (#7884) 
* Add Option to Halt Nb when Error Occurs

* PR comments
 2019-10-22 18:19:36 -07:00
Chris LaFreniere 597a0cad6b Add (dummy) IPyWidgets Renderer (#7849) 2019-10-21 14:22:44 -07:00
Chris LaFreniere e3ae5263c6 Starting Fewer Jupyter Servers for Notebooks (#7744) 
* Start fewer Jupyter servers

* Windows fix for drive casing

* PR Feedback

* Quick fix

* Fixing bug

* Ensure environment variables set 4 session startup

* test fix

* Dummy commit to update comment
 2019-10-20 21:38:58 -07:00
Chris LaFreniere d120102805 Bump up widths for pick, remove schedule buttons (#7517) 2019-10-20 13:22:49 -07:00
Chris LaFreniere 2ee3840650 First improvements for SQL Cell Looping (#7733) 
* First improvements

* clear results

* cleanup

* error handling
 2019-10-18 17:12:10 -07:00
Chris LaFreniere 385d7f2803 Clear Output -> Clear Result for consistency (#7776) 2019-10-17 19:54:12 -07:00
Chris LaFreniere 2ee04e0cf0 null checks for onBeforeDetached (#7782) 2019-10-17 18:24:30 -07:00
Chris LaFreniere 80d46fb8a4 Add search book icon (#7777) 2019-10-17 17:20:07 -07:00
Chris LaFreniere 4c946b21a9 Jupyter Book Search First Steps (#7704) 
* Crawling for book search. needs icon

* Remove context until decision on entry point

* Add undefined check
 2019-10-15 17:04:24 -07:00
Chris LaFreniere 5eeaa5710c Adding in separators (#7651) 2019-10-11 11:06:57 -07:00
Chris LaFreniere d4feb903b0 Supporting Different Kernel JSONs for Various Platforms (#7552) 
* First go at it

* undo unnecessary change to copy api

* Revert "undo unnecessary change to copy api"

This reverts commit f95f7f7a42277586f4d4d0eb7b0733c11853b413.

* Revert "First go at it"

This reverts commit 410c0d3c61b7c7cae3a2469a2672f67fe3b745b6.

* Actual super simple fix
 2019-10-09 19:19:05 -07:00
Chris LaFreniere 5a1183a457 Fix async problem with jupyter book viewlet loading (#7591) 
* Fix async problem with jupyter book viewlet

* PR Feedback
 2019-10-09 16:06:32 -07:00
Chris LaFreniere 0b2a2ad0ed Allow git to open notebook files (#7403) 
* Allow git to open notebook files

* pr feedback
 2019-10-04 15:34:19 -07:00
Chris LaFreniere 8e1a2248e4 Notebooks: Ensure quotes and backslashes are escaped properly in text editor model (#7497) 
* Ensure quotes and backslashes are escaped properly

* PR comment

* PR comments

* Reliably fix
 2019-10-03 19:21:01 -07:00
Chris LaFreniere b8976785fd Stop grabbing focus when nb editor isn't in view (#7466) 
* Stop grabbing focus when nb editor isn't in view

* Add comments
 2019-10-02 11:56:57 -07:00
Chris LaFreniere 4c2ffdfc68 Add powershell kernel.json (#7456) 2019-10-01 16:30:09 -07:00
Chris LaFreniere 5327ed84c1 Add ps to standard kernels in package.json (#7428) 2019-09-30 14:04:25 -07:00
Chris LaFreniere 6ef415d0e6 Notebook Tokenization Fixes (#7375) 
* Fix don't like; unclear if grammar necessssary too

* Cleanup and sanity check

* Cleanup and sanity check

* Add test

* Call onBeforeAttached for 3 types of editor models
 2019-09-27 10:04:29 -07:00
Chris LaFreniere ba8ba9f68d echo extension test names (#7391) 2019-09-27 10:04:10 -07:00
Chris LaFreniere d815ae0e83 Skip failing tests due to sqlclient issues (#7346) 2019-09-24 15:04:35 -07:00
Chris LaFreniere 6125e68c1f Ensure we call layout() as few times as possible for notebook cells (#7253) 
* Call layout fewer times from queryTextEditor

* remove unused method
 2019-09-20 12:06:37 -07:00
Chris LaFreniere a584aca969 Stop clearing out connecting and connected state when cancelling out of connection dialog (#7254) 
* Stop clearing out connecting and connected state

* tweaks

* Handling cancel while connecting

* fix typo

* PR comments
 2019-09-18 17:21:32 -07:00
Chris LaFreniere 9b82b101cd Fix for notebook line height (#7248) 2019-09-17 15:41:51 -07:00
Chris LaFreniere 141226332c Add notebook grid actions (#7181) 
* Add notebook grid actions

* pr comments
 2019-09-17 14:16:35 -07:00
Chris LaFreniere 4d62983680 Add Default File Type when Saving Chart (#7235) 
* add file filter

* Code cleanup
 2019-09-17 10:38:39 -07:00
Chris LaFreniere 2128851bdf Add title to table (#7182) 2019-09-12 14:57:39 -07:00
Chris LaFreniere 4626f37671 Notebooks: Fix double-click to edit with source as array (#7027) 
* Fix dbl click to  edit with source as array

* Fix equality check
 2019-09-03 10:37:19 -07:00
Chris LaFreniere 97a583e965 Ensure context key provider set before session (#7024) 2019-08-30 15:32:55 -07:00
Chris LaFreniere 2d6f69da1c no mathjax (#6995) 2019-08-29 18:07:05 -07:00
Chris LaFreniere 40d5667e63 Don't Inform extHostNotebookDocuments Unnecessarily on Cell Source Changes (#6981) 
* Dont tell exthostnotebookdocuments on cell source

* Update comment
 2019-08-28 11:49:57 -07:00
Chris LaFreniere 50a0b6e115 Stop Using os library in NotebookTextFileModel (#6993) 
* Stop using os library

* small fix
 2019-08-27 20:45:30 -07:00
Chris LaFreniere 4e25bc9396 os.EOL instead of hardcode \n for fast notebook source changes (#6986) 
* os.EOL instead of hardcode \n

* test fixes
 2019-08-27 17:36:07 -07:00
Chris LaFreniere f6140ebd11 Only show options on Controller viewlet (#6964) 2019-08-26 19:20:05 -07:00
Chris LaFreniere 84b3e876d7 Notebook Performance Improvements to Cell Editing/Output Changes/Execution Count Changes (#6867) 
* edit perf

* Save multiline source in notebooks

* More merges

* Single, multi line works needs work

* Works with single + multi and recomputes active

* Actual perf improvements this time

* code cleanup

* Calculating output position on the fly

* Hmm can we use brackets to make this simpler?

* monday progress

* output working. lots of improvements.

* First tests working

* 10 tests now, fixed bugs

* Cleanup, add output test

* More fixes

* Need to still fix execution count bug

* Tests pass, added comments

* Cleanup

* PR comments round 1

* Deal with merge issues from master, layering

* Deleting duplicate file

* More PR Comments

* PR Comments
 2019-08-26 10:17:58 -07:00
Chris LaFreniere 54cf062737 Fix Notebook Connection Issues (#6831) 2019-08-20 13:40:15 -07:00
Chris LaFreniere 62d2fb534d Merge from vscode 709a07d51919d3266ca71699c6ddfb2d3547c0e1 (#6575) 2019-08-02 21:06:44 -07:00
Chris LaFreniere 402b50c03b Notebooks: Use much faster json parser when loading notebook initially (#6552) 
* Use much faster json parser

* fallback to old json parser
 2019-08-02 17:23:49 -07:00
Chris LaFreniere 720a7fbfa2 Multiline cell execution fix (#6522) 2019-07-29 11:19:57 -07:00
Chris LaFreniere d51bdbd094 Save multiline source in notebooks (#6445) 
* Save multiline source in notebooks

* Stop demultiline localContentManager unnecessarily
 2019-07-26 10:30:52 -07:00
Chris LaFreniere 5225b5dc55 Use in proc markdown by default (#6315) 2019-07-09 15:23:47 -07:00
Chris LaFreniere 708461eab5 Remove 'isMenu=true' from notebook toggle more (#6253) 2019-07-02 17:22:17 -07:00
Chris LaFreniere c4bf1b4180 Notebooks: Run all after/before (#6239) 
* Run all above/below

* PR comments pre tests

* Added integration test
 2019-07-02 16:49:12 -07:00
Chris LaFreniere e8d4fba3c0 Support non-default font sizes in notebooks (#6222) 
* Support non-default font sizes notebooks

* pr comments
 2019-07-01 16:10:20 -07:00
Chris LaFreniere e5858dee52 Make sure we sanitize the same way (#6233) 2019-07-01 14:05:50 -07:00
Chris LaFreniere bae573453a Accessibility: Screen Reader Thinks SelectBox is a Button on Mac (#6216) 
* Stop reading dropdowns as buttons for mac

* Remove role of combobox for sql selectbox
 2019-07-01 13:46:06 -07:00
Chris LaFreniere 8cf4120c27 Notebooks: Support for In-Proc Markdown Renderer (#6164) 
* NB improve startup using built-in markdown render

This is a sample branch showing perf improvements if we load content using built-in markdown rendering
- Has issues where images aren't correctly rendered due to sanitization, need to copy renderer code and update settings
- Moves content load up before anythign to do with providers since we can render without knowing about these things

# Conflicts:
#	src/sql/workbench/parts/notebook/cellViews/textCell.component.ts

* Re-enable logging of each cell's rendering time

* Fix test issue

* Kernel loading working with new markdown renderer

# Conflicts:
#	src/sql/workbench/parts/notebook/cellViews/textCell.component.ts

* Fixed tests, cleaned up code

* markdownOutput component integration

* PR Comments

* PR feedback 2

* PR feedback again
 2019-06-27 20:55:50 -07:00
Chris LaFreniere a2c9a0a1ae Addaria label to kernel and attach to dropdowns (#6181) 2019-06-27 10:19:22 -07:00
Chris LaFreniere 77fb060fde Notebooks: Add Command + Keyboard Shortcut to Clear Outputs of Active Cell (#6169) 
* Add command to clear cell output with test

* Fix typo

* PR Comments
 2019-06-26 15:19:12 -07:00
Chris LaFreniere 4fe81d8449 Only set notebookEditor <a> color in scrollable portion (#6140) 2019-06-24 10:46:38 -07:00
Chris LaFreniere 453caa92d4 Fix for standard in hovering in code cell (#6107) 2019-06-19 15:02:03 -07:00
Chris LaFreniere 86a3217e98 Notebooks: Log telemetry when all markdown cells rendered (#5862) 
* Log telemetry when all markdown cells rendered

* Enable referencing previous telemetry timestamps

* Fix broken unit test to do a null check

* Undo loading icon changes in textcelll

* Addressing PR comments

* PR comments II
 2019-06-10 21:55:49 -07:00
Chris LaFreniere d15a3fcc98 Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d (#5949) 
* Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d

* Fix vs unit tests and hygiene issue

* Fix strict null check issue
 2019-06-10 18:27:09 -07:00
Chris LaFreniere da164cec0a remove tabindex=0 for notebook component (#5851) 2019-06-05 08:28:00 -07:00
Chris LaFreniere 8d70544374 Notebooks: Adding Change Kernel API, 3 Integration Tests (#5287) 
* Notebook change kernel

* Fix notifying of k change too many times add tests

* Fix broken unit test

* Deal with comment
 2019-06-03 14:49:40 -07:00
Chris LaFreniere 34bc0efc1c Check if sessionManager exists (#5811) 2019-05-31 17:42:12 -07:00
Chris LaFreniere 7da0dddaa9 Notebooks: Prevent Outputs from Rendering Too Many Times on Layout Change Events (#5366) 
* Prevent output rendering too many times

* went from 250ms to 50ms without any perf penalties
 2019-05-13 13:41:23 -07:00
Chris LaFreniere 1cc3cb5408 Notebook Port Test Fix (#5433) 
* Test fixes to not rely on 7100

* PR comments
 2019-05-08 13:16:09 -07:00
Chris LaFreniere 0a67488447 Don't scroll when running code cell if in view (#5365) 2019-05-06 11:36:06 -07:00
Chris LaFreniere 8a68f0aaf9 Improvements to notebook editor code auto height (#5291) 2019-05-02 10:23:26 -07:00
Chris LaFreniere e72d0d03ed Notebooks: More Jupyter Server Hardening (#5264) 
* Do not rely on same starting port every time, misc

* put back to 5 seconds for process kill timeout

* extHostNotebook shutdown manager handle
 2019-04-30 14:13:04 -07:00
Chris LaFreniere bb9c85cd8f Improve Cleanup of Jupyter processes on Notebook and/or ADS Close (#5142) 
* Close jupyter and python

* Ensure we stop jupyter correctly on process end

* dont stopServer from clientSession shutdown

* PR comments

* close notebook after each test
 2019-04-26 15:28:26 -07:00
Chris LaFreniere 46b85ebc6b Fix casing on welcome page to be consistent (#5169) 2019-04-24 11:18:33 -07:00