* Change service installation messages to not steal focus
* Undo unnecessary changes to localized strings in serviceClient.ts
* Add default case for missing server event types
* Update admin-tool-ext-win to use new ads-extension-telemetry package
* Add AdsTelemetryService for sending telemetry events using the ADS Common Schema
* Clean up unused import and add engineType
* Address PR comments
* Update private var names
This isn't necessary since we aren't providing the VS binaries as redist-able. VS has signed off as confirming that the main extension license is enough to cover the VS binaries as well. (#5880)
* Add test for opening existing SQL file and typing text into it
* Clean up
* More cleanup, remove unneeded queryEditor and add smoke test scripts
* Update comments to be clearer
* Fix server name in URN for Azure servers and update menu when clauses
* Use setStatusBarMessage instead of constructing our own. Remove server name from URN - it's not necessary.
* Clean up unused code
* Update vscode dependency (needed for test runner) to pull latest 1.x version
* Update to use 1.1.5 instead
* Undo change to vscode engine version
* Switch to using vscodetestcover for running tests
* Switch to cobertura output for coverage reports
* Remove vscode dependency from profiler extension
* Update yarn.lock with combined changes
* Remove unnecessary 'use strict' lines and add hygiene check for them
* Move check to under tslint filters to reduce number of filters needed
* Only take first 10 lines of file
* Add support for more SsmsMin property dialogs and the Generate Script Wizard. Also fixed bug with ExtHostObjectExplorerNode getParent function
* Localize package.json entries
* Fix localization tokens
* Address PR comments
* Fix regex and getParent
* Fix Data Explorer context menu items visibility
The when clause was making the menu items show up for all nodes in the Data Explorer - even ones that didn't make sense such as the Databases folders. This change makes it only appear for the Database and Server nodes (which is how the OE tree is set up)
* Fix workspaceRoot macro for insights
The workspaceRoot macro wasn't working correctly for finding the queryFile. There were a couple of issues :
1. The path separators were hardcoded as / which wasn't xplat-compatible
2. They required the first section of the path was one of the folders in the workspace - e.g. if the workspace contained a folder named foo you'd have to specify ${workspaceRoot}\foo\myfile.sql. This is inconsistent with the folder logich was just appends the path after ${workspaceRoot} to the folder that's currently open
I changed the logic to just append the relative part of the path to every folder currently open in the workspace and choose the first one that it found that contained the file we were told to look for - which follows the convention the folder logic uses. If the file doesn't exist it'll just fall back to using the path without the macro (which is likely to not resolve and thus will display an error, but there's nothing we can do at that point anyways)
* Switch to using VS Code resolver (support for more than just workspaceRoot) and move resolution code into helper method so it can be used by the multiple places it's called. Added tests for the methods.
* Add test for invalid param
* Change resolveQueryFilePath to be a standalone exported function. Change it to throw if the file can't be resolved/found so callers can display error correctly. Added more tests to covery new scenarios. Switch to using pfs instead of fs for file existance checks.
* Add extra param to InsightsDialogController construction in test
* Fix formatting and test errors.
* Change to suiteSetup and suiteTeardown so the setup/teardown is only ran once instead of once per test - we don't need unique files and this stops a race condition error with deleting the test folder.
* spaces -> tabs
* Fix broken test
The test would always fail if it was doing the right thing - since it was asserting that there WEREN'T any cells with outputs (the opposite of what it should have been checking).
* Update error message to be clearer
* Fix spelling error
* Windows extension fixes/improvements
Remove error message when activating extension on non-win platforms (instead just don't do anything). Add hooks to kill child processes on exit if they haven't ended already. Formatting fixes.
* Remove shelljs
* Remove error messages from telemetry until I can follow up on whether we're allowed to send these up. Fix some issues with the exec callback - the child_process exec function returns an ExecException object instead of the code directly like the shelljs did so check for that correctly.
* ADS Windows support extension with LaunchSsmsDialog command
* Update readme
* Fix spacing
* Update download with new file location and name
* Update SsmsMin package with bits from latest RC build and addressed some comments.
* Update extension name. Add Context menu extension for launching server properties dialog. Remove params interface from public API
* Rename folder and update README
* Correct README title
* Fix a few issues and clean up some stuff.
* Update to azdata namespace
* Refactor to use async/await and add some more telemetry
* Add .bat for running extension tests (currently only Notebook) and set up launch.json with 2 new launch configs for running & debugging extension tests.
* Rename files to make it clear these aren't the integration tests
* Update launch.config too
* Fix spacing and missed file name update
* Fix some bugs in buildSsmsMinCommandArgs and add unit tests
We don't track installs for our extensions so the "Popular Extensions" category is just a duplicate of the full list. Removing it to reduce clutter until we can add that functionality in. This also removes the command associated with the view.
* Fix our custom dropdown control to update the tooltip text correctly when a new value is selected. Previous behavior was to always keep the initial text (<Default> for example). Now we'll update it as appropriate (and default back to Placeholder text when we're clearing the value)
* Spaces -> tabs
* Remove extra ;
* Remove tooltips from the text box part of the dropdown
* Remove tooltips from dropdown arrows
* Revert "Remove tooltips from dropdown arrows"
This reverts commit 31a0748aaea42d5009eb9752bd075ce49a6716f5.
Also fixed small issue where messages that didn't have a container would throw an error when trying to call removeClass (since this.element is pulled from the container and thus was undefined.
Tested that the flicker is gone and that messages still show up correctly
* Add .bat for running extension tests (currently only Notebook) and set up launch.json with 2 new launch configs for running & debugging extension tests.
* Rename files to make it clear these aren't the integration tests
* Update launch.config too
* Fix spacing and missed file name update
* 2 fixes :
1. Fix it so that edits made to a table with a single column will correctly create a new row when done editing. This is done by caching whether the cell is dirty in on the onCellEditEnd callback and then when onCellSelect is called to switch cells we only return early if the cell isn't dirty. Before we were returning early and thus not going into any of the code that creates the new row (submitCurrentCellChange)
2. Fix it so we don't throw an error when deleting the NULL (new) row. As noted in the code this should really be handled by not displaying the context menu to begin with for that row but that's a bit more involved of a fix so for now I'm at least making it not display an error to the user - it'll just do nothing.
Manual testing for now - I tried to add tests but the core logic and the UI layer are too intertwined so this will likely need to be a full end-to-end UI test. I'll continue working on adding some for this dialog but for now I'd like to at least submit these fixes since they're pretty painful to deal with.
* Undo changes to addRow
* Clean up resetCurrentCell and add comment to setCurrentCell
* Use reset method instead of directly initializing currentCell
* Add issue # to comment
* Modify where we add active connections so that we can use the saveTheConnection option to decide whether to add a connection to the MRU. This was necessary because the old location was called from onConnectionComplete which is sent by the SqlToolsService - and that doesn't get any UI related information like the options. The new location is still only called after the connection completes and will be added only if the connection succeeds.
Added new test and updated existing tests to handle new logic (plus a bit of async-refactoring).
* Fix couple spacing issues
* Add logic back in to short-circuit if we already have the connection in the active connections list.
* Fix spaces -> tabs
Recent changes in the VS Code layout for that viewlet caused the min-height property to affect the display (the property was set on that class before but the layout prevented it from actually being displayed as it was).
I removed the style for the messages class completely since I couldn't find a place that we actually used that ourselves - and anyways having styling on such a common name like messages isn't really a good practice since it applies to everything in ADS.
Charles Gagnon