Amir Omidi
86cc3f77ee
Fixes some code coverage issues ( #7994 )
...
* Fix code coverage issues
* Fix some code coverage stuff
2019-10-24 15:32:43 -07:00
Chris LaFreniere
a33820ecdd
Fix starting and separators in a row ( #7861 )
2019-10-24 15:20:58 -07:00
Kevin Cunnane
7babd6f3d0
Add SQL Managed Instance support and sorting ( #7996 )
...
- Add SQL Instances folder and support using existing SQLClient API
- Sort subscriptions in tree and quickpick for easier search
- Sort all resources (Databases, Servers, Instances) alphabetically too
Not in this PR:
- Will experiment with Graph API for faster perf & easier addition of other Azure resources such as PostgreSQL
2019-10-24 15:18:49 -07:00
aspnerd
e28ecf44cb
Use selected DB for import wizard schema list ( #7878 )
...
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
2019-10-24 15:08:10 -07:00
Alan Ren
93685d3a09
make the azdata install url configurable ( #7989 )
...
* make the azdata install url configurable
* use settings without reloading
* comments
2019-10-24 14:57:17 -07:00
Maddy
d660405e73
hide save book action from command pallet ( #7981 )
2019-10-24 14:44:35 -07:00
Alan Ren
684fb2566b
revert the notebook background execution ( #7984 )
2019-10-24 13:46:40 -07:00
Charles Gagnon
696f6841cb
Change BDC view errors to use modal dialog instead of error toast ( #7985 )
...
* Change BDC view errors to use modal dialog instead of error toast
* Move to common control
2019-10-24 13:05:07 -07:00
Charles Gagnon
cef60f3ae5
Fix troubleshoot URL lookup ( #7978 )
2019-10-24 10:14:39 -07:00
Alan Ren
34fe2b44cc
remove insider build check ( #7926 )
...
* remove insider build check
* fix welcome page not load issue
2019-10-23 21:53:42 -07:00
Aditya Bist
a16bfbfedd
Fix node infinitely loading when a firewall dialog is cancelled ( #7970 )
...
* add back icons for azure actions
* fix firewall infinite loop
* formatting
* change message to firewall canceled
* fix tests
2019-10-23 21:37:21 -07:00
Chris LaFreniere
fb4fccf2d5
Notebooks: ensure python path dirs added to path on session start ( #7968 )
...
* ensure python path dirs add to path session start
* Change logic slightly
* PR feedback from Charles
2019-10-23 19:22:24 -07:00
Chris LaFreniere
b53cad78bd
Update recommended package versions for ps ( #7972 )
2019-10-23 18:57:05 -07:00
Chris LaFreniere
a431ca7ef2
check for ownerDocument focus for focus ( #7964 )
2019-10-23 18:56:43 -07:00
Chris LaFreniere
c2022cac57
Fix for relative links not being resolved in notebook outputs ( #7966 )
...
* Fix for relative links not being resolved
* Add comment
2019-10-23 18:49:52 -07:00
Kevin Cunnane
806d807eae
Refactor Azure Core extension for easier resource addition ( #7958 )
...
Consolidated most logic into a base class and common resource request pattern.
Reduces cost to add new providers, which will help for SQL Managed Instance support
2019-10-23 16:29:51 -07:00
Aditya Bist
24e3b1c5e6
add back icons for azure actions ( #7963 )
2019-10-23 15:09:23 -07:00
Amir Omidi
bbe3605317
Lets try out this gh-action ( #7875 )
...
* Update blank.yml
* Update and rename blank.yml to tslint.yml
* Update tslint.yml
* Update tslint.yml
* Update tslint.yml
* Update tslint.yml
2019-10-23 13:05:36 -07:00
Cory Rivera
06d67f5ad2
Append stdErr log to error message when a streamed console command fails. ( #7868 )
2019-10-23 12:38:24 -07:00
Amir Omidi
41f9f22e38
Update lgtm.yml ( #7932 )
...
Add vs stuff as a classifier so we don't see their issues
2019-10-22 23:16:11 -07:00
Anthony Dresser
a94cbb528e
Merge from vscode f5d3ffa6a0d655c87e1eb0e1e90773df58f7ff25 ( #7929 )
...
* Merge from vscode f5d3ffa6a0d655c87e1eb0e1e90773df58f7ff25
* fix launch script
* add missing files
2019-10-22 21:49:55 -07:00
Charles Gagnon
4a68ab4659
Hygiene linting for extensions + new rule ( #7843 )
...
* linting for extensions + new rule
* Remove unneeded array
* Fix spelling mistake
* Fix bad merge
2019-10-22 18:56:31 -07:00
Chris LaFreniere
4c24043cc8
Add Option to Halt Notebook when Error Occurs in SQL Kernel ( #7884 )
...
* Add Option to Halt Nb when Error Occurs
* PR comments
2019-10-22 18:19:36 -07:00
Maddy
2ca5d18855
Update/sqlserverbook extension to stable ( #7914 )
...
* move package info from builtin-inisders to builtin extensions
* vbump for the filename fiasco change
* merged master
* revert sql.bat update
2019-10-22 17:13:48 -07:00
Kim Santiago
37426b0794
don't allow tabbing into table ( #7769 )
2019-10-22 16:25:37 -07:00
Charles Gagnon
a70ebeed1c
BDC Dashboard context sensitive troubleshoot links ( #7895 )
...
* Add context awareness to troubleshoot button on dashboard
* Remove tests for now
* Undo yarn.lock changes
* Correct yarn.lock version
* Lower case service check
2019-10-22 14:24:26 -07:00
Charles Gagnon
8f2113e6b5
Fix HDFS paths to be encoded properly ( #7896 )
2019-10-22 14:05:23 -07:00
Charles Gagnon
03cb0565d4
Clean up bdc devDependencies ( #7872 )
...
* Clean up bgc devDependencies
* Add extra files to .vscodeignore
2019-10-22 11:07:35 -07:00
Charles Gagnon
dd14f9b93d
Fix telemetry opt out message ( #7891 )
2019-10-22 11:00:57 -07:00
Kevin Cunnane
4dd15fb479
Add help text to mount HDFS dialog ( #7865 )
2019-10-22 10:40:28 -07:00
BranislavGrbicMDCS
397f6afaf1
ADS changes for new engine edition ( #7695 )
...
* Sql on demand changes
* Formating files
* Removing features for new Engine Edition
* Fixing Restore & Backup issue. Adding support for multiple conditions per flavor
* tabifying
* Formating documents
* Work in progress
* Resolving comments
* Resolving comments.
* Fixing typo
2019-10-22 12:50:15 +02:00
Anthony Dresser
65fb77ef5c
Update linting file ( #7886 )
...
* update linting file
* update pr template
2019-10-22 00:26:03 -07:00
Anthony Dresser
1e22f47304
Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998 ( #7880 )
...
* Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998
* fix pipelines
* fix strict-null-checks
* add missing files
2019-10-21 22:12:22 -07:00
Charles Gagnon
7c9be74970
Disable failing test ( #7882 )
2019-10-21 20:31:16 -07:00
Amir Omidi
5efb2cf918
Add a new unstable test ( #7874 )
2019-10-21 19:19:03 -07:00
Alan Ren
98505110a4
fix a typo ( #7871 )
2019-10-21 18:31:24 -07:00
Anthony Dresser
1a864584b6
move code to mean linting ( #7873 )
2019-10-21 17:56:58 -07:00
Charles Gagnon
8aa8dc29a1
Separate icons for non-stable builds ( #7857 )
...
* Use separate icons for non-stable builds
* Fix file name
* Switch icon
* Updated icons
* Switch to copy of code.ico until issue is fixed
* Fix icon
* remove
* add
* Fix file renaming
* Fix a couple naming issues
* Move iss changes to build file
2019-10-21 16:11:59 -07:00
Anthony Dresser
06e86e57e7
Strict null on some query and connection ( #7300 )
...
* wip
* make connection work with strict-nulls
* change comments
* fix tests; remove unneeded type forcing
* address feedback
* adjust the logic of query editor
* clean up typing
2019-10-21 15:50:12 -07:00
Alan Ren
6a375fdd8c
fix the wizard opened twice issue #7866 ( #7869 )
2019-10-21 15:32:13 -07:00
Maddy
b8ad7e3072
Updates to package.json to show books on stable ( #7836 )
...
* Updates to package.json to show books on stable
* remove notebookQuality context key
* renamed untitiled to unsaved
2019-10-21 14:26:59 -07:00
Chris LaFreniere
597a0cad6b
Add (dummy) IPyWidgets Renderer ( #7849 )
2019-10-21 14:22:44 -07:00
Amir Omidi
a646af2ad2
Move vscode from dependencies to devDependencies ( #7864 )
...
* Update package.json
Move vscode out of dependencies
* Change extensions.js
2019-10-21 14:20:46 -07:00
Amir Omidi
143b70c6a8
Revert "Fix BDC and resource-deploy extensions to not be packaged separately ( #7858 )" ( #7860 )
...
This reverts commit 53a081262d .
2019-10-21 12:06:00 -07:00
Kevin Cunnane
c1e95a2246
Fix errors due to icon to codicon rename in VSCode ( #7837 )
...
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
- acounts view
- new tab view in dashboard
- many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.
Fixes #7827
2019-10-21 12:02:30 -07:00
Charles Gagnon
53a081262d
Fix BDC and resource-deploy extensions to not be packaged separately ( #7858 )
...
* Fix BDC and resource-deploy extensions to not be packaged separately
* Update js too
2019-10-21 11:06:22 -07:00
Charles Gagnon
8b46143d48
Fix Manage Access dialog to not allow entering blank user ( #7844 )
2019-10-21 10:07:28 -07:00
Alan Ren
a05edc619c
use required attribute ( #7850 )
...
* use required attribute
* readable sql port
2019-10-21 09:53:12 -07:00
Alan Yu
6c5aa6b367
Update ThirdPartyNotices.txt ( #7479 )
...
* Update ThirdPartyNotices.txt
* tab -> spaces
2019-10-20 21:56:29 -07:00
Charles Gagnon
0246c3f895
Fix ModelView tree A11y issue ( #7835 )
...
* Fix tree A11y issue
* Toggle expanded state on enter
* Move onkeydown method to base class
2019-10-20 21:42:55 -07:00