Commit Graph

4048 Commits

Author SHA1 Message Date
Charles Gagnon
a1f600657a Add more arc tests (#11145)
* Add more arc tests

* Update comment
2020-06-30 14:05:27 -07:00
Kim Santiago
41315c6e0a Show error when trying to add file/folder that already exists to project (#11122)
* show error when trying to create file or folder that already exists

* add test for file that already exists

* add folder tests

* fix error messages

* hide Properties folder

* update comment
2020-06-30 13:42:50 -07:00
Vladimir Chernov
b875d919d2 spell error in Severity column name (#11156) 2020-06-30 23:33:52 +03:00
AzureDataStudio
59b69311d7 fix hygiene, update sqlite
skip failing tests
2020-06-30 11:31:12 -07:00
ADS Merger
1388493cc1 Merge from vscode 2cd495805cf99b31b6926f08ff4348124b2cf73d 2020-06-30 11:31:11 -07:00
Chris LaFreniere
a8a7559229 Add more notebook extension tests (#11143)
* more tests

* More tests

* More tests

* Add prompt tests
2020-06-30 11:01:51 -07:00
Chris LaFreniere
a32f42d475 Update Arc Extension with New Strings and azdata Version (#11148)
* Strings and azdata version changes

* change azdata description
2020-06-30 09:08:01 -07:00
Anthony Dresser
ef8205f918 Remove deleting the old config (unsupported) and add notification (#11142)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* remove deleting the old config (unsupported) and add notification

* fix tests

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 21:40:03 -07:00
Charles Gagnon
749c42ce41 Improve handling of connection errors for arc controllers (#11139)
* some fixes for failed connections

* cleanup

* add back in prompt
2020-06-29 19:50:27 -07:00
Anthony Dresser
93a88e38fe Messages panel wordwrap (#10970)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* fix word wrap support in the message panel

* fix width on message treee

* fix import

* fix settings editor to reflect the changes in the settings ids

* fix tests

* add configuration upgrader

* make sure to maintian execution order

* make the compiler happy

* add tests for upgrader

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 16:25:11 -07:00
Kim Santiago
6b8eafbf2e Update import project to have friendly names for the extract file organization options (#11123)
* udpate import to have friendly names for the extract file organization options

* update tests

* update message

* remove camelcase stuff

* use localized constants instead of enum
2020-06-29 15:37:28 -07:00
Anthony Dresser
5d3178f649 delete duplicate workflow (#11132) 2020-06-29 13:53:26 -07:00
Alan Ren
476e3f7299 move the macOS ESRP signing steps to a separate job (#11129)
* move ESRP signing to a separate job

* rename job

* depends on

* signing

* rename task
2020-06-29 13:41:02 -07:00
Brian Bergeron
1f558dd2aa Arc - Fix sqlmiaa initial load (#11125) 2020-06-29 13:34:46 -07:00
Charles Gagnon
064ada1d2f Change Azure region dropdown to use azurecore API (#11131)
* Change Azure region dropdown to use azurecore API for getting display name

* Fix compile errors

* Adding a few things to the vscodeignore

* and another
2020-06-29 12:44:04 -07:00
v-bbrady
e540096e07 Bbrady/fixes tour start button (#11092)
* builds getting started tour

* reorganizes ts according to amirs comments

* Fix hygiene issues

* updates class names

* adds description to new configuration value

* uses core components

* PR fixes based on Charles comments

* formats css

* updates guided tour based on charles comments

* updates css formatting

* fixes read more link

* formats gettingStartedTour.ts

* updates copy

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* updates pr based on pr comments

* removes unused decleration

* formatting

* reformats css document

* updates file path

* updates images

* fixes start button issue

* merges master

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 09:55:19 -07:00
Chris LaFreniere
061d3510b9 Run ADS Commands from Notebooks (#11069)
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
2020-06-28 21:17:50 -07:00
Aasim Khan
a9848a7a96 Added check all nulls to modify column Page (#10683) (#10751)
* -Added check all null checkbox

* Modified declarative table to add check all columns  in the column header

* -changed to using existing methods for firing events.

* -changed table height to auto
-center aligned data in table cell
-Check all generates event for only changed values

* -changes column header from text to column header (#10787)

* This fixes the weird angular stuff - we need to do this in every other component

* -added changes made by amir for dom object tracking
-added automatic checkall detection.
-made text-align center in table cells

* -fixed styling issues and issue with checkboxes

* -Removed unsued function

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-06-26 19:02:59 -07:00
Chris LaFreniere
9dc7ca056f Change nb before/after strings (#11121) 2020-06-26 17:36:28 -07:00
Alan Ren
e452cd20d4 format file and add metadata (#11108) 2020-06-26 14:57:06 -07:00
Benjin Dubishar
a3030aaf0d Update package.json (#11113) 2020-06-26 14:56:42 -07:00
Maddy
6870bdaf72 revert back to original code (#11116)
* revert back to original code

* skip failing tests
2020-06-26 14:17:42 -07:00
Hale Rankin
7ef8acf04e Markdown toolbar > Preview toggle feature (#10963)
* Added toggle preview button to Markdown toolbar. Revised components, theme and styles to present the preview as a second column beside the markdown.

* Added showPreview to model and began working on togglePreview.

* Uncommented use of cellModel.showPreview

* add cell model event for onPreviewChange

* Renamed my showPreview boolean to prevent confusion with local boolean used in toogglePreview.

* Added CSS class when preview is enabled. Adjusted styles accordingly.

* Swapped icon show/hide references for correct sequence. Modified updatePreview to include state of doShowPreview.

* Added check for isEditMode so we can run togglePreview and show it once editor closes.

* Added listener to code.component that triggers layoutEmitter on changes to peview.

* Renamed local boolean doShowPreview. Removed unneeded code. Fixed ambiguity in my use of booleans, adding a getter and setter to textCell.

* Cleaned up implementation of new get/set for toggling preview.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-06-26 13:47:17 -07:00
Hale Rankin
00fe535add 10887 - Fixes icon position beside Cell and Run all in notebook toolbar. (#10897) 2020-06-26 13:46:52 -07:00
Hale Rankin
8f6c5af94f Cleaned up code for Add cell button in both main toolbar and cell toolbar. Corrected toolip to read: Add cell. (#10829) 2020-06-26 13:46:31 -07:00
Hale Rankin
8d7b3ef6ec Cell toolbar More Actions menu -- remove duplicate separators (#10827)
* Added code to remove multiple separators from more actions menu.

* Moved check for separators after list is deduped.

* Logic cleanup

* Added unit test for cell toolbar ellipses menu.

* Fix tests

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-26 13:45:53 -07:00
Alan Ren
dbf9d3426c icon for ASDE (#11111) 2020-06-26 11:54:29 -07:00
Brian Bergeron
6c86122aae Arc - Fix KeyValueContainer refresh and disposal (#11090) 2020-06-26 09:48:35 -07:00
Aasim Khan
fb52760be1 Additional tests for import extension (#10953)
* Setting up tests on import extension

* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations

* -added code report for the import extension in ci

* changes code coverage to 36%

* adding some comments

* Removing unnecessary exports

* -refactored test code to replicate src structure
-some changes mentioned in the pr

* removed unnecessary prefixes from test case name
2020-06-25 19:22:25 -07:00
Arvind Ranasaria
cdd3d1bf2a fix: 'Arc data controller deployment fails' #11086 (#11110) 2020-06-25 19:18:42 -07:00
Kim Santiago
8e0050f2af Don't ask for db twice if connection was to a db (#11099) 2020-06-25 17:18:41 -07:00
Benjin Dubishar
770848850d Import spot-fix (#11102) 2020-06-25 15:37:05 -07:00
Brian Bergeron
dfa87eda86 Arc - Delete registration 2020-06-25 08:50:22 -07:00
Benjin Dubishar
fdef92ad6b Update README.md (#11094)
* Update README.md

* Update README.md
2020-06-25 00:59:26 -07:00
Benjin Dubishar
283c64a29d Update package.json (#11093)
Adding dependency
2020-06-24 23:44:22 -07:00
Alan Ren
710d0462d8 Alanren/notebook password notice (#11089)
* add note about the password

* wording

* more files

* more files
2020-06-24 19:55:44 -07:00
Alan Ren
20c612d9fb add note about the password (#11084)
* add note about the password

* wording
2020-06-24 19:48:41 -07:00
Charles Gagnon
2f90b56877 Add resource type filtering to deployment wizard (#11079) 2020-06-24 18:07:52 -07:00
Benjin Dubishar
8c6d77e04d Updated displayname and description (#11083) 2020-06-24 18:00:55 -07:00
Brian Bergeron
d58c15f98b Arc Postgres - Remove new database and styling 2020-06-24 15:35:21 -07:00
Alan Ren
da9e58485b add to parameter to decide whether to print the command (#11052)
* don't print command

* show password as ******
2020-06-24 15:20:06 -07:00
Charles Gagnon
c3fbce4b83 Add dashboard links to arc controller dashboard (#11076)
* Add dashboard links to arc controller dashboard

* Fix compile error
2020-06-24 15:15:27 -07:00
Brian Bergeron
e1bbbf2c9e Arc - Fix KeyValueContainer refresh (#11077) 2020-06-24 14:19:21 -07:00
Sakshi Sharma
de263eacd1 Schema Compare test coverage (#11042)
* Few tests for Schema Compare

* Addressed comment- removed wait in test

* Split setEndpointInfo for database and dacpac
2020-06-24 14:03:02 -07:00
Maddy
561b881200 Fix/highlight correct item (#11016)
* get children of unexpanded books

* highlight item inside collapsed parent in treeView

* fix path issue on windows

* refactor common code into separate func

* refactor
2020-06-24 13:44:50 -07:00
Arvind Ranasaria
c2ef27cd68 Second batch of tests for notebookEditor class (#10999)
* first few notebookEditor tests

* formating fixes

* unstash previous unfinished work

* saving

* PR feedback

* PR feedback

* copyright fixes

* improve test names and assertion messages

* saving

* PR feedback

* improve test names.

* test name change

* test name change

* remove unneeded cast

* remove spurious comment

* fix misplaced paranthesis - thanks hygiene checker!

* remove unused code

* remove deferredPromise

* createEditor test and dispose fixes

* remove unneeded import

* rempve unnecessary mock usage in dispose test

* use getContainer() for ['parent']

* use getContainer for ['parent']

* remove launch.json edits

* notebookService needs 9th constructor argument

* Add uploading debugging step

* minor changes

* remove changes to ci.yml

* working version

* formatting fixes

* pr fixes

* hygiene and exception path fixes

* remove minor debug changes

* pr feedback

* pr feedback

Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-24 13:19:12 -07:00
Charles Gagnon
c62394262a Some cleanup and fixes for Arc/BDC dashboards (#11075) 2020-06-24 12:41:33 -07:00
Brian Bergeron
6f6bf3f3b3 Fix Arc Postgres refresh (#11074) 2020-06-24 11:14:45 -07:00
Benjin Dubishar
00836e1890 Benjin/delete (#11054)
* Adding delete to package.json

* checkpoint

* Delete file working

* Working for nested folders

* Added file/folder deletion test

* addressing feedback

* Swapping QuickPick for modal

* Adding Exclude functionality

* reverting change to package.json
2020-06-24 10:27:58 -07:00
Charles Gagnon
2ba0de10df Some general cleanup/fixes for Arc dashboards (#11066)
* Some general cleanup/fixes for Arc dashboards

* more disposables

* refresh controller model for miaa dashboard too

* fixes
2020-06-24 09:06:28 -07:00