Commit Graph

131 Commits

Author SHA1 Message Date
Charles Gagnon
8da49ff14e Remove connection error popup notification (#18476)
* Remove connection error popup notification

* Fix compile
2022-02-18 09:04:13 -08:00
Alan Ren
57d5d94c46 fix connection error scenario (#18335)
* fix connection error scenario

* pr comments
2022-02-11 18:49:29 -08:00
Charles Gagnon
1c9ba64ee0 check-param-names (#18189) 2022-01-31 12:39:22 -08:00
Alan Ren
d8467f2c1a null check before calling isDisposable (#17959) 2021-12-17 09:56:04 -08:00
Alan Ren
970fe12e70 fix listener leaks (#17913)
* fix listener leaks

* add null check

* simplify

* pr comments
2021-12-14 13:35:00 -08:00
Alan Ren
a9a8fec98a open database dashboard (#17871) 2021-12-08 14:52:50 -08:00
Alan Ren
b48f392ab2 optional database name option (#17538)
* optional database name option

* object explorer connection title

* revert unexpected change

* bug fixes
2021-10-29 16:37:35 -07:00
nasc17
75d6847a65 Set original database for connection done through connection dialog (#17266)
* check if database connection

* Change name of isMaster and remove import

* Set to false

* take out connecttodatabase

* remove connecttodatabase

* Original database

* remove empty string check

* clean

* set original database for when saving connection

* pass unit test

* map -> find

* PR changes

* Comments for original database
2021-10-08 13:10:28 -07:00
Alan Ren
c20ed1bd9b use the actual unique id to compare connection (#17229)
* use the actual unique id to compare connection

* fix test error and pr comments
2021-10-04 15:24:09 -07:00
Karl Burtram
73ee6c3844 Add default auth type configuration setting for Azure resources (#16999)
* Adding user config for default auth type

* adding feature

* removing the SqlLogin default from the model

* fixing bug, removing dead code

* removing unneeded instance of configurationService

* fixing line break

* removing extra parameter

* removing comments

* Fix test breaks

* Fix build break

* More breaks

* Address code review feedback

Co-authored-by: Troy Witthoeft <troy.witthoeft@gmail.com>
2021-09-07 19:58:32 -07:00
Alex Ma
8c2cea4ea6 Added saving query (#16883)
* removed clear results and results visible.

* revert changes, still work in progress

* added small debug message

* added flag for state

* removed clear in queryResultsView

* moved carbon edit message

* simplifcation

* fixed spacing

* added clarifying message

* added clarifying comment

* added original tab clear line for future things

* added support for regular saves

* removed vscode changes

* added queryEditorTextInput to other versions

* added stuff

* reverted changes to queryTextEditorInput

* deleted duplicates

* moved untitledQueryEditorInput

* added FileQueryEditorInput constructor

* added instantiation

* added queryEditorTest

* added temporary state for save editor input

* added back in FileQueryEditorInput

* added example of both to test

* restored input.

* Added current results processing

* removed queryeditor import

* added disable dispose, WIP

* added small change to dispose

* added oldUri

* added small changes for adding renameQuery

* added first parts of renameQuery, need to add more in other parts. (Place next to disposeQuery).

* moved rename around in queryModel

* added rename to testQueryManagementServices, now need to add to queryrunner.

* added to queryRunner, need to test

* added renameQuery calls

* added renameQuery to extensions

* moved untitledQueryEditorInput to its old location

* removed duplicate untitledQueryEditorInput

* test import

* test blah

* moved fileQueryEditorInput to services

* deleted original fileQueryEditorInput

* Moved fileQueryEditorInput to new location

* added workbenchinstantiationservice

* added titledQueryEditorInput

* restored untitledQueryEditorInput.ts

* removed instantiation service

* made changes to titledQueryEditorInput

* Revert "deleted original fileQueryEditorInput"

This reverts commit dd5eb19ea1489d9c0dda159e6a798975240dab65.

* reverted back to pre move

* added altered untitledQueryEditorInput

* temporarily using old version of save until determining point where new URI is assigned.

* renamed oldUri to newUri to better reflect its actual use.

* added some debug messages for examining how uris work

* made small changes to untitledQueryEditorInput

* restored save to have actual code.

* moved renameQuery to proposed.

* added partially working save as for results (Pressing run breaks query)

* removed instantiationservice

* added newUri for dataservice

* added queryRunner.uri for queryModelService

* moved untitledQueryEditorInput to old location

* changed todomessage

* added explanation messages

* fixed spaces and added description

* moved untitledQueryEditorInput to new location

* added rename for connectionmanagementservice

* added carbon edit message

* removed carbon edit to editorservice

* removed another space

* added get and set for isSaving value

* removed accessor

* Update azdata.proposed.d.ts

added space

* fixed azdata.proposed

* added changeConnectionUriForQuery

* restored request

* replaced changeconnectionuri to changeuri

* Revert "replaced changeconnectionuri to changeuri"

This reverts commit eed8e518dee69cf2922ff86dc1763e6fb7715a71.

* made required changes

* fixed exclamation mark

* removed error on queryRunner changeconnection

* added save connect button status

* added additional state properties to save

* added wip setstate

* added changes for better naming

* added changes in preparation for vscode merge

* take screenshot of failed test before close editor (#16876)

* Add setting for enabling using new markdown renderer (#16864)

* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false

* fix refresh node and add sample (#16888)

* Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)

* Bump VS Code version to latest sync point (#16891)

* Fix duplicate editor windows on reload (#16893)

* reset the icon before use (#16896)

* Undo merge icon change (#16894)

* disable cancel button after clicked once (#16783)

* disable cancel button after clicked once

* remove enabling of cancel button when cancelling

* Update sqlite version for smoke tests (#16903)

* update sqlite

* bump distro

Co-authored-by: chgagnon <chgagnon@microsoft.com>

* add autoCutoverConfiguration to getMigrationStatus (#16803)

* Enable scripting for triggers and other objects (#16885)

* WIP 1

* Add parentName to azdata

* Add some additional types for scripting

* Add parent type name to support view subobjects

* bump dependencies and address review comments

* Modify treeDataChange event (#125214) (#16907)

Modify treeDataChange event to support firing arrays.

* Move create new option for publish to top and filter out system dbs (#16908)

* Move create new option for publish to top

* Move New tag to description

* fix

* Open project to default location (#16910)

* Have create proj from database show default save location as option (#16909)

* Default create proj location to setting

* update icons

* undo

* Put search/ status/refresh in single line (#16898)

* add horizontal scroll bar to output (#16918)

* Fix extension linting warnings and enable extension linting in pipelines (#16922)

* Fix extension linting errors

* fix test

* Update public preview readme for sql migration extension (#16920)

* Add sql bindings package reference to project (#16912)

* list packages and add packages working

* cleanup and remove list packages

* cleanup

* change to pull in latest package version

* Add STS root folder override (#16927)

* Add STS root folder override

* Display message to user

* Show once for any service

* Fix some unhandled promise lint errors (#16924)

* Moved items around to handle new untitledQueryEditorInput location (#16914)

* moved items around to handle new untitledQueryEditorInput location

* added editor inputs to constants.

* added interface for untitledQueryEditorInput

* added IUntitledQueryEditorInput

* Revert "added IUntitledQueryEditorInput"

This reverts commit 67955eb289458e7ac4e7e5ce0ee077f38ed82a2c.

* Revert "added interface for untitledQueryEditorInput"

This reverts commit 88552dbd811b643fd51d5d21f4571b677d7bfc73.

* Revert "Revert "added interface for untitledQueryEditorInput""

This reverts commit 13a89c40e4cb0a3fa495f5b150c066892387e509.

* Revert "Revert "added IUntitledQueryEditorInput""

This reverts commit 8b2258ab49275a271a39036ea1734feca98ee753.

* added extends for IUntitledQueryEditorInput

* added casting in editorGroupView

* Revert "added casting in editorGroupView"

This reverts commit 61500ea43690b08ba2393808a8d118abc60da4ac.

* Revert "Moved items around to handle new untitledQueryEditorInput location (#16914)"

This reverts commit 87a663ee6b7cc3330c0528b20fb74f557451f911.

* Revert "Fix some unhandled promise lint errors (#16924)"

This reverts commit 73218a840df188f1ae26ff1c2e1aa5b85b9cfcb0.

* Revert "Add STS root folder override (#16927)"

This reverts commit 35936d464f2e452cd29659fffef20018ac6ffdd4.

* Revert "Add sql bindings package reference to project (#16912)"

This reverts commit 72d29ed7a7d298716ba159548af1f08adc82db25.

* Revert "Update public preview readme for sql migration extension (#16920)"

This reverts commit 3b3c3921557aabe86c927e6a833c0c41b48f7e23.

* Revert "Fix extension linting warnings and enable extension linting in pipelines (#16922)"

This reverts commit f5ea3e69ae5132c09eba699e8c25d1a1a66e0914.

* Revert "add horizontal scroll bar to output (#16918)"

This reverts commit 76bf86a2536edfe84b0f323571e489d69fe9fe00.

* Revert "Put search/ status/refresh in single line (#16898)"

This reverts commit d9553d09141c159e8b1cc27f6422e51b68800c7c.

* Revert "Have create proj from database show default save location as option (#16909)"

This reverts commit 88b9b7734b467a2552dfeea9c844b90361a660de.

* Revert "Open project to default location (#16910)"

This reverts commit a46170b347a28ff77f40883b055153823a86308e.

* Revert "Move create new option for publish to top and filter out system dbs (#16908)"

This reverts commit 4be47daf63771b6c3b12b786ba687dfc6ca0e3c6.

* Revert "Modify treeDataChange event (#125214) (#16907)"

This reverts commit 4161c21abcc78a9b5a65e52ae7d7f960ea71219b.

* Revert "Enable scripting for triggers and other objects (#16885)"

This reverts commit 2ece3ffb12478faf0f49df1e66bcc7acc0631500.

* Revert "add autoCutoverConfiguration to getMigrationStatus (#16803)"

This reverts commit 366633e7247d508138b45e902d7e034c79763dec.

* Revert "Update sqlite version for smoke tests (#16903)"

This reverts commit 64f66d7b18418b028cfa56b984d6f9979f65cc50.

* Revert "disable cancel button after clicked once (#16783)"

This reverts commit 12044e30746f44188d46a781f582781bf3638762.

* Revert "Undo merge icon change (#16894)"

This reverts commit 0801d14267a9980a2c29374666ad7fee14dfcafb.

* Revert "reset the icon before use (#16896)"

This reverts commit 971c39e8bc5c774fb49d81c5c36617ec45b4078c.

* Revert "Fix duplicate editor windows on reload (#16893)"

This reverts commit 4df3085b09b645a3ef2728c3ab3778fb7a63f2ba.

* Revert "Bump VS Code version to latest sync point (#16891)"

This reverts commit c1bc6639efcdf69d9b9c57cc44af3a1d19514f83.

* Revert "Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)"

This reverts commit c92da9c02ee221ca69813af69b039d3f3846aa42.

* Revert "fix refresh node and add sample (#16888)"

This reverts commit df820f6c03d167d933d089bfadf5296a7dcaf834.

* Revert "Add setting for enabling using new markdown renderer (#16864)"

This reverts commit e3c036dfbaa0a1e1588f348eb9eb4a7edb4f9bda.

* Revert "take screenshot of failed test before close editor (#16876)"

This reverts commit d466b19a6e56a43654c779c1dab60724b1f0c3db.

* fix spaces

* changed uri to public

* fixed formatting on azdata.proposed

* added queryprovider at the end

* changed already in connections list message.

* added notifyconnectionurichanged

* added changes to fix

* fixed testQueryModelService

* fixed leftover stuff

* more renames

* Added small changes

* added messages to untitledQueryEditorInput

* added work in progress fileQueryEditorInput save as

* fixed space

* removed changeUri

* remove saveAs from queryEditorInput

* removed undefined from createFileQueryEditorInput in untitled.

* changed saveAs for fileQueryEditorInput

* changed saveAs to use createInstance

* bumped version of STS in config.json

* bump version of dataprotocol-client

* update to yarn.lock

* more changes

* removed space for untitledQueryEditorInput

* some refactoring done

* removed already has provider check due to existing provider still existing

* added a comment

* fixed typo

* change results order around

* added already existing connection message

* restored untitledQueryEditorInput

* removed message

* added existing connection

* Revert "added existing connection"

This reverts commit 3cc34f6b1e670bb7b257e046f53560471badfd34.

* add try catch to restore older overwrite file behavior

* added types and error handling

* added error comments.

* changed message of both files

* fixed formatting for azdata.proposed.d.ts

Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: stuti149 <87131830+stuti149@users.noreply.github.com>
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
2021-09-03 09:45:32 -07:00
Hai Cao
0bc2a50d78 Add token expiration handling for AzureMFA auth (#16936)
* refresh azure account token if it's expired before sending query/list requests

* fix several connection checks && add more logging

* fix async UI glitch during token refreshing

* cleanup

* minor fix

* add test for refreshAzureAccountTokenIfNecessary

* address comments

* comments

* comments

* comments

* error handling
2021-09-02 17:24:45 -07:00
Cory Rivera
0082031f97 Replace deprecated assert functions in test files. (#16945) 2021-08-31 09:04:17 -07:00
Cory Rivera
cb7b7da0a4 Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) 2021-08-25 16:28:29 -07:00
Charles Gagnon
ecb5bb4ed8 Fix scan hits (#16788) 2021-08-16 12:59:18 -07:00
Aditya Bist
2f8e2f3132 Synapse query editor dropdown fix (#16684)
* formatting

* update comment

* format doc

* fix connection test

* remove unused imports

* test server info mock

* try with mocks

* add server info check for tests

* added logic for corner case
2021-08-12 12:28:55 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
2021-06-17 08:17:11 -07:00
Alan Ren
088d6353f0 keep title up to date when connection changes (#15306) 2021-04-30 22:41:55 -07:00
Hai Cao
a0bf5df79d Use a different config name for connection sorting (#15275)
* use a different sort config name
2021-04-29 10:52:35 -07:00
Hai Cao
9bc1797e88 add sorting option for saved connections (#15229)
* add sort by name option for saved connections and groups
2021-04-28 11:41:09 -07:00
Charles Gagnon
cf862854c5 Update return types that can return undefined (#14660) 2021-03-11 10:09:50 -08:00
Drew Skwiers-Koballa
733c3628a1 drag n drop bounding characters (pgsql fix) (#14376)
* specifies object handling for all current providers

* implements the same for column dragndrop

* adjusted test

* adds pgsql provider name constant
2021-03-05 15:22:47 -08:00
Justin M
c6c65000ca Added NoAuth authenticationType for Kusto (#14375)
* Added NoAuth authenticationType for Kusto

* Added SqlLogin to Kusto as an AuthType. Renamed NoAuth to None
2021-02-26 12:28:43 -08:00
Justin M
aff9adf730 Add dstsAuth as option for saved credential in connectionStore.ts (#14332) 2021-02-18 10:30:02 -08:00
Karl Burtram
ce612a3d96 Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)
* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests
2021-02-09 16:15:05 -08:00
Justin M
8f5dc1526a Initial commit for dSTS Auth (#13802)
* Initial commit for dSTS Auth

* Removed getDstsToken from accountManagementService. Renamed azureAccount to token.

* Renamed dstsToken to _token in connectionWidget

* Code Review Feedback. Renamed token to authToken in onFetchDatabases.

* Removed dsts options from Kusto package.json
2021-02-01 10:48:16 -08:00
Justin M
c18a54bc1d 12666 Passed azureAccount into onFetchDatabases and set on tempProfile. (#13239) 2020-11-16 11:24:22 -08:00
Alan Ren
7819d25c95 resource label update (#13129)
* resource label update

* preserve existing behavior

* fix connection group color

* comments
2020-10-29 14:42:01 -07:00
Tony Xia
607447365d Fixed minor typos (#12936) 2020-10-15 09:55:00 -07:00
Christopher Suh
6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295)
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
2020-10-03 11:42:05 -07:00
Alex Ma
82648fab3e connection tests for connectionDialogWidget (#11160)
* Added providerRegistered test

* test for EditConnectionDialog

* changed wording

* added test for connectionInfo

* utils.ts tests added

* hasRegisteredServers test

* commented out editconnection tests, addl. tests

* added onConnectionChangedNotification test

* added changeGroupId tests

* Added connection  profile changes

* added connectIfNotConnected test

* added delete connection test

* isRecent and disconnect editor tests

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* added registerIconProvider test

* Fix for ensureDefaultLanguageFlavor test

* added a few tests

* utils prefix test updated

* added utils tests

* disconnect tests added

* Added additional get connection info tests

* added some more tests

* minor additions to tests

* again another commit

* another change

* connectionManagementService finalized

* connectionDialogWidget test WIP

* wip connectiondialogwidget test

* added working connectionDialogWidget test

* added more tests

* current connectionDialogWidget tests

* undid space

* hanging promise addressed

* added open test

* finished connectionDialogWidget tests

* Added showDialog test

* mockConnectionDialogService added

* added accessorConnectionDialogService

* removed accessor service

* added openDialogAndWait test

* added fake error to test

* added error tests

* Added comments to test

* more coverage

* async to await change

* registerCapabilities test added

* connectionDialogService tests finished

* undefined added

* Added views for tests

* tslint disable added

* error catchers added

* added empty connectioninfo

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-09-30 08:39:54 -07:00
Charles Gagnon
253aa78650 Fix root group name check (#12660) 2020-09-29 10:03:55 -07:00
Anthony Dresser
503090856a Strict null scripting (#12126)
* strict null scripting

* fix compile

* fix tests

* fix icon
2020-09-04 18:04:08 -07:00
Amir Omidi
4659d727b7 strict null checks azure (#11928)
* strict null checks azure

* strict compilation

* Fix compilation issues

* Return empty arrays instead
2020-08-25 18:12:47 -07:00
Anthony Dresser
adfdd56907 Even more strictness (#11879)
* add more to strict nulls

* maintain error handling properly

* fix lint

* the rest of workbench/services

* fix compile
2020-08-20 14:00:26 -07:00
Charles Gagnon
3c538d1c2d Add AsyncServerTree (#11838)
* wip

* Fixes

* More fixes

* more fixes

* Disable when preview features disabled

* remove unused imports

* Handle promises

* PR feedback

* Single default ServerGroup color value
2020-08-19 14:01:10 -07:00
Shafiq Ur Rahman
97b6d71a06 Kusto - ADS Core changes (#11750)
* ADS Core changes

* Generic fix to get language mode based on providerId

* Addressed comments

* Fix failing tests

* Fix for "New Notebook" from file menu option

* Remove line

* Fix for merge conflict

* Add removed comment back

* Addressed comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-08-19 12:27:16 -07:00
Anthony Dresser
60c62c0668 Fix a bunch of strict issues (#11857)
* fix a bunch of strict issues

* fix tests

* fix tests
2020-08-19 10:37:30 -07:00
Arvind Ranasaria
9b4931bb0e tests for KernelsDropdown class (#11476)
* add return type for a function

* tests for KernelsDropdown class

* remove inadvertent change

* remove inadvertent change

* formatting changes

* pr feedback

* pr feedback
2020-07-22 17:49:01 -07:00
Anthony Dresser
93a88e38fe Messages panel wordwrap (#10970)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* fix word wrap support in the message panel

* fix width on message treee

* fix import

* fix settings editor to reflect the changes in the settings ids

* fix tests

* add configuration upgrader

* make sure to maintian execution order

* make the compiler happy

* add tests for upgrader

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 16:25:11 -07:00
Charles Gagnon
a303144226 getCredentials returns credentials for any saved connection (#11029)
* getCredentials returns credentials for any saved connection

* Update doc comment

* Add tests

* cleanup

* cleanup
2020-06-23 11:04:13 -07:00
Alex Ma
e01723f195 Additional tests for connection (#10944)
* Added providerRegistered test

* test for EditConnectionDialog

* changed wording

* added test for connectionInfo

* utils.ts tests added

* hasRegisteredServers test

* commented out editconnection tests, addl. tests

* added onConnectionChangedNotification test

* added changeGroupId tests

* Added connection  profile changes

* added connectIfNotConnected test

* added delete connection test

* isRecent and disconnect editor tests

* added registerIconProvider test

* Fix for ensureDefaultLanguageFlavor test

* added a few tests

* utils prefix test updated

* added utils tests
2020-06-22 13:51:39 -07:00
Amir Omidi
21fd8b22e7 Fix a memory leak on listener (#10294)
* Fix leak

* We don't need the full connection profiles for drag drop control

* Remove unused code

* Change test definition

* Change test definition

* Change equality check
2020-06-16 19:36:10 -07:00
Amir Omidi
3860f07cab Make azure portal work from server area (#10699) 2020-06-03 14:02:23 -07:00
Amir Omidi
b519d51052 Replace the ID of the generated connection profile with the one through edit data (#10413) 2020-05-15 10:48:56 -07:00
Anthony Dresser
df5df38a55 Query Runner Tests (#10252)
* rework some code and write an inital test

* fix strict

* add more to standard test

* add to existing workflow test

* fix tests

* simplify the code

* add more tests

* remove bad import

* fix compile

* fix timestampiong
2020-05-06 13:38:12 -07:00
Alex Ma
921e546fd7 Edit Connection Feature added, edit existing connection in connection tree. (#10214)
* Added Edit Connection Command

* Wip changes for new connection dialog

* Testing

* WIP commit

* added ID check to ensure connection

* wip commit

* model id check implemented

* addfooterbutton now accepts events

* wip commit

* message explaining check

* temporary change

* connectionManagementService restored

* Revert "connectionManagementService restored"

This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.

* formatting test

* editConnection promise testing

* edit existing connection command added

* WIP Connection Edit

* disconnect added to editConnection promise

* WIP on editExistingConnection

* changed isEdit to true

* Amir/edit connection (#10112)

* Get edit connection working

* Delete unused code

* check for isEdit as well

* connection tree test added

* WIP connection management tests

* comment out test to find out what's wrong

* fix for one error

* added note about test skipped

* changed signature of saveprofile

* saveprofile fixed

* wrote working test

* added additional test

* changed message

* Fixes made

* fix for matcher

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-05-05 13:21:05 -07:00
Anthony Dresser
bd8c4a44c8 change to freeze configuration models (#9644) 2020-03-17 15:45:29 -07:00
Charles Gagnon
efab499f1f Fix TSA scan issue (#9417) 2020-03-02 16:08:51 -08:00
Anthony Dresser
1b78a9b1e0 Merge from vscode e6a45f4242ebddb7aa9a229f85555e8a3bd987e2 (#9253)
* Merge from vscode e6a45f4242ebddb7aa9a229f85555e8a3bd987e2

* skip failing tests

* remove github-authentication extensions

* ignore github compile steps

* ignore github compile steps

* check in compiled files
2020-02-21 12:11:51 -08:00