Anthony Dresser
9af1f3b0eb
More layering ( #9111 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* remove no longer good parts
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
2020-02-12 18:24:08 -06:00
Charles Gagnon
eac05c85f1
Make connectionProfileGroup support undefined values ( #9102 )
...
* Make connectionProfileGroup able to support undefined values being passed
* Fix strict null checks
* More strict null check fixes
2020-02-10 13:03:57 -08:00
Anthony Dresser
56695be14a
More layering and compile strictness ( #8973 )
...
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* remove jsdoc
2020-01-29 20:35:11 -08:00
Anthony Dresser
5fd29d5ad8
Missing changes ( #8972 )
...
* add more folders to strictire compile, add more strict compile options
* update ci
* remove unnecessary assertion
* add missing checks
2020-01-27 16:47:42 -08:00
Anthony Dresser
64929de09d
Add more folders to strict compile ( #8954 )
...
* add more folders to strictire compile, add more strict compile options
* update ci
* remove unnecessary assertion
2020-01-27 16:26:49 -08:00
Anthony Dresser
2f6c944317
Add editor contribution tests ( #8784 )
...
* wip
* rewrite association
* fix tests
* add more tests
* fix tests
* fix more tests
* fix tests
2020-01-10 18:57:47 -08:00
Anthony Dresser
30d9e9c141
Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 ( #8722 )
...
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1
* remove tests that aren't working
2019-12-18 00:14:28 -08:00
Anthony Dresser
642920504a
Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12 ( #8670 )
...
* Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12
* fix null strict checks
2019-12-13 00:50:37 -08:00
swjain23
0bf4790a64
Add changes for flavor selection ( #8419 )
...
* Add changes for flavor selection
* Use getDefaultProviderId method
* Update default engine user setting description
* Add back check for codeEditor
* Add test for multiple providers
* Removing extra merge line
* Add an attribute to ConnectionProviderProperties for language flavor
Adding a boolean property to ConnectionProviderProperties for providers that are language flavors. When it is set to true, the provider will be part of drop down for changing SQL language flavor.
* Update variable name
* Put logic for removing CMS at one place and remove flag for flavor provider
* Using keys instead of entries
Using Object.keys instead of entries as doing [0] can be error prone if no provider matches.
* Adding logic to check from params
* Updating variable names
* Rename dedup map
* Fix action
2019-12-05 15:28:35 -08:00
Rich Smith
b631530753
Modify connection management to support Active Directory authType for non-SQL DBs ( #8434 )
...
* First attempt to add Azure MFA login for PostgreSQL
* Finish merge with master
* Fix auth type default selection
* Add AzureMFAAndUser auth type for Orcas
* Fix formatting
* Update change log
* Incorporate some review comments
* Missed an occurrence of AzureResource
* Try to move all changes out of azdata.d.ts and sqlops.d.ts
* Concrete implementation of ConnectionProfile in azdata no longer has azureAccount
* Use enum names instead of numbers in config files
2019-11-26 10:32:59 -08:00
Anthony Dresser
df0c505452
No unused locals ( #8231 )
...
* add no unused local
* fix strict null
* fix compile errors
* update vscode comments
2019-11-06 17:22:05 -08:00
Anthony Dresser
564f78b6f6
Revert "Revert "Remove typings and replace missing methods with vscodes ( #8217 )"" ( #8242 )
...
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217 )" (#8240 )"
This reverts commit e801a04bcf .
* fix runtime error
* add tests for chartview
2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf
Revert "Remove typings and replace missing methods with vscodes ( #8217 )" ( #8240 )
...
This reverts commit 22a427f934 .
2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934
Remove typings and replace missing methods with vscodes ( #8217 )
...
* remove typings and replace missing methods with vscodes
* fix strict-null-checks
* fix tests
2019-11-05 13:03:20 -08:00
Anthony Dresser
ade68b184d
Move code around for more linting ( #8190 )
...
* testing
* moving around all the code
* fix strict nulls
2019-11-04 10:41:28 -08:00
Amir Omidi
b62c0cf2ab
More promise cleanup ( #8100 )
...
* Some promise cleanup
* Handle more promise issues
* Remove changes that aren't needed anymore
* Use log service
* another one
* Be more explicit
* Some more promises cleaned up
* Handle promises here too
* Strings for errors
* Some more cleanup
* Remove unused imports
2019-10-31 14:30:08 -07:00
Aditya Bist
a16bfbfedd
Fix node infinitely loading when a firewall dialog is cancelled ( #7970 )
...
* add back icons for azure actions
* fix firewall infinite loop
* formatting
* change message to firewall canceled
* fix tests
2019-10-23 21:37:21 -07:00
Anthony Dresser
06e86e57e7
Strict null on some query and connection ( #7300 )
...
* wip
* make connection work with strict-nulls
* change comments
* fix tests; remove unneeded type forcing
* address feedback
* adjust the logic of query editor
* clean up typing
2019-10-21 15:50:12 -07:00
Charles Gagnon
e4e71af597
Fix all await-promise tslint errors ( #7530 )
...
* Fix all await-promise tslint errors
* Remove unnecessary await
2019-10-07 17:52:01 -07:00
Anthony Dresser
aad9c0f965
Add more areas to strict null ( #7243 )
...
* add more areas to strict null
* fix compile errors
* fix tests
* fix checks
* address PR comments
2019-09-18 12:27:19 -07:00
Anthony Dresser
ea0f9e6ce9
Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 ( #7206 )
...
* Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463
* fix config changes
* fix strictnull checks
2019-09-15 22:38:26 -07:00
Anthony Dresser
c9128d56c0
Handle some promises better in cms ( #7166 )
...
* handle some promises better in cms
* 💄
2019-09-13 12:28:16 -07:00
Anthony Dresser
823d136a00
No browser from common ( #7178 )
...
* no browser from common
* clean up some imports
2019-09-12 14:52:42 -07:00
Karl Burtram
9df66deb81
Initial LiveShare extension scaffolding ( #7170 )
...
* LiveShare initial shared connection
* Various cleanups
* Fix type
* Fix hygiene
2019-09-11 15:24:08 -07:00
Anthony Dresser
02f497712d
clean up some promise use in cms ( #7004 )
2019-09-06 15:58:47 -07:00
Anthony Dresser
5b9a08359d
remove circular dependency between server group and connection management ( #6916 )
2019-08-23 14:53:54 -07:00
Anthony Dresser
8e070454c3
Global object linting ( #6857 )
...
* add more linting
* fix linting issues
2019-08-22 10:51:59 -07:00
Anthony Dresser
85bf22322f
Isolate features ( #6792 )
...
* working; new query and scripting
* working; removing manage from menus and combining data explorer contributions
* consolidate dashboard contributions; move manage action to dashboard contributions; make groupings the same
* fix notebook actions
* fix tests
2019-08-21 09:51:02 -07:00
Anthony Dresser
6fd4b5eaf2
Fix encoding of uris for data protocol ( #6723 )
...
* fix encoding or uris
* fix tests
2019-08-13 09:58:16 -07:00
Amir Omidi
5994269ca8
Label of DB update when remaking profile ( #6561 )
2019-08-02 10:00:58 -07:00
Charles Gagnon
86cde4c511
Fix some connection listener leaks ( #6357 )
...
* Fix some connection listener leaks
* More descriptive name and update summary
* Dispose some more connections and fix a few spelling errors
2019-07-29 11:00:11 -07:00
Charles Gagnon
b2b2840990
Add double quotes for localize hygiene check ( #6492 )
...
* Add localize single quote hygiene task
* Update localize calls
* Update comment
* Fix build failures and remove test code
2019-07-25 10:35:14 -07:00
Anthony Dresser
c23738f935
Inital platform relayering ( #6385 )
...
* moving test files and inital refactoring
* relayer extension host code
* fix imports
* make insights work
* relayer dashboard
* relayer notebooks
* moveing more code around
* formatting
* accept angular as browser
* fix serializer
* add missing files
* remove declarations from extensions
* fix build errors
* more relayering
* change urls to relative to help code relayering
* remove layering to prep for merge
* fix hygiene errors
* fix hygiene errors
* fix tests
2019-07-18 17:29:17 -07:00
Anthony Dresser
0b7e7ddbf9
Merge from vscode 8e0f348413f4f616c23a88ae30030efa85811973 ( #6381 )
...
* Merge from vscode 8e0f348413f4f616c23a88ae30030efa85811973
* disable strict null check
2019-07-15 22:35:46 -07:00
Charles Gagnon
49619e5b39
Clear Azure token if connection doesn't need it ( #6244 )
...
* Clear Azure token if connection doesn't need it
* Update function name
2019-07-02 21:01:53 +00:00
Aditya Bist
678b2737bd
CMS - SQL Login ( #5989 )
...
* initial SQL Login with save password working
* fix switching auth types
* remove metadata from package file
* allow editing connections for unsaved password connections
* review comments
* change thenables to async/awaits
* review comments
* changed thenables to promises
* remove authTypeChanged bool
* removed unused import
* review comments
* removed try catches
* cr comments
* review comments
2019-07-01 11:40:11 -07:00
Alan Ren
b9a0c9ce7e
getConnections API ( #5651 )
...
* getConnections
* update
* fix the condition check
* pr feedback
* fix test cases
* add test for the new method
* address comments
2019-06-19 22:51:53 -07:00
Charles Gagnon
9e7282d16a
Connection dialog cleanup ( #6076 )
...
* Update names to be clearer and remove some unnecessary code
* Remove unused/inaccurate CMS display name value
2019-06-18 21:33:21 +00:00
Kevin Cunnane
6ff34d9894
Fix #6022 connection dialog broken ( #6023 )
...
Opening connection dialog was broken if you have a postgres connection
listed in the Connections view and the extension isn't installed.
The capabilities service breaks as it returns an undefined object.
Added handling, so now it does show as "loading..." forever
but doesn't crash
2019-06-13 16:50:00 -07:00
Charles Gagnon
5aa730b5d4
Add logging to try and find a possible connection race condition ( #5813 )
...
* Add logging to try and find a possible connection race condition
* Fix tests
* More test fixes
* Update error message and use error level
2019-06-12 00:08:51 +00:00
Karl Burtram
5a7562a37b
Revert "Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d ( #5949 )" ( #5983 )
...
This reverts commit d15a3fcc98 .
2019-06-11 12:35:58 -07:00
Chris LaFreniere
d15a3fcc98
Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d ( #5949 )
...
* Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d
* Fix vs unit tests and hygiene issue
* Fix strict null check issue
2019-06-10 18:27:09 -07:00
Charles Gagnon
673ecc3870
Change hardcoded MSSQL provider name to use constant instead ( #5953 )
2019-06-10 18:10:39 +00:00
Aditya Bist
1773dede25
CMS fit and finish ( #5542 )
...
* cms connections dont save
* added value to enum
* remove refresh and update provider name for cms
* removed ownerUri from saved connection and contributed to array
* removed owneruri
* ownerUri not needed any more
* removed AAD from cms
* initial review
* changed comments
* add back saveProfile option for connectionProfile
* review fixes and other UI improvements
* fixed auth
* added cms integration tests
* added constants
* removed utils from apiwrapper
* changed connection type name
* review comments
* clearer code and addressed reviews
2019-05-31 11:14:37 -07:00
Gene Lee
34273907f7
Made connection icon to be remembered by memento in ConnectionManagementService ( #5523 )
2019-05-28 14:45:28 -07:00
Anthony Dresser
d0ce6bb066
move status bar contribution to contribution file ( #5609 )
2019-05-24 12:22:39 -07:00
Anthony Dresser
db5a0a892a
fix issue with empty connection ( #5602 )
2019-05-23 16:07:28 -07:00
Anthony Dresser
aae1480e4f
Allow data explorer to use connect ( #5564 )
...
* wip
* handle save password; get correct profile
* ensure resolve is being called
* fix tests
* fix more tests
2019-05-23 11:44:18 -07:00
Anthony Dresser
2ca39b571a
removes unused vscode changes ( #5533 )
2019-05-21 21:48:57 -07:00
Karl Burtram
fe17955fa1
Add support for setting query options in settings and through API ( #5484 )
...
Initial query execution options PR. This is the second in a set of query editor extensibility improvements I'm making. The PRs include (1) bug fix for webview in query tab (2) dynamic toolbars and (3) fix query event sequencing and event metadata info.
2019-05-16 16:31:30 -07:00