Alan Ren
a895f53029
min version check ( #8038 )
...
* min version check
* comments
2019-10-25 17:11:32 -07:00
Karl Burtram
78d3b9d555
Fix typo in icon path ( #8033 )
2019-10-25 16:00:44 -07:00
Aditya Bist
42e1b28130
add twitter account badge to readme ( #8034 )
2019-10-25 15:58:15 -07:00
Karl Burtram
5590d60c5a
Revert icon update 8aa8dc29a1 ( #8030 )
...
* Revert icon update 8aa8dc29a1
* Add build electron.js file
2019-10-25 14:37:15 -07:00
Maddy
d79423c728
Task/checkfile length ( #7959 )
...
* add hygiene task to test file length
* check for the filename length instead of the path
* formatted the error message
* added check for entire path including directories
* error messaged fixed
* check relative length for 150 as agreed upon
* error message to include 150
* added file length filter
* check the file length seperately
* ffsdfsdf
* remove the test file
* move it to last
* restore the filtered files for further checks
* removed comment
* test
* test
* remove the test file
* test commit
* remove the test file
* restore fileLengthFilter
* test
* remove the testfile
* revert
* xfgdgdfg
* huh
* test file
* revert.
* add all to the filter
2019-10-25 14:30:43 -07:00
Alan Ren
d1a0ae43c8
update the message ( #8031 )
2019-10-25 14:11:25 -07:00
Alan Ren
e4b0371b2a
fix 2 issues found during testing ( #8029 )
2019-10-25 13:54:19 -07:00
Anthony Dresser
e191556d3b
Update pipelines ( #7993 )
...
* update pipelines
* update
* fix scripts
* testing something
* testing something
* testing something
* add github token
* testing something
* delete fiels
2019-10-25 13:04:41 -07:00
Karl Burtram
5a269fc49a
Package LiveShare outside core ADS ( #8024 )
2019-10-25 12:59:10 -07:00
Amir Omidi
613cd58aa3
Don't pack the hgh level node_modules directory ( #7998 )
2019-10-25 12:09:55 -07:00
Arvind Ranasaria
af9984f73b
pass install paths to notebooks ( #8008 )
...
* pass install paths to notebooks
* onComplete
* discover and publish actual installation Path
* pass the path to notebook
* minor fixes needed post merge of code from remote
* fix some errors
* remove unused variable
2019-10-25 12:06:55 -07:00
Chris LaFreniere
3b1c9e910d
serverManager to decide if server start needed ( #8017 )
2019-10-25 11:11:54 -07:00
Chris LaFreniere
5b29aef5f3
fix stdin cancel breaks notebook ( #8012 )
2019-10-25 10:52:18 -07:00
Anthony Dresser
b65a7795df
Testing out ci with workflows ( #8005 )
...
* add workflow for ci
* add another step
* remove more steps
2019-10-25 10:30:53 -07:00
BranislavGrbicMDCS
c6a78456b8
Adjusting context menu for SqlOnDemand ( #8018 )
2019-10-25 17:33:17 +02:00
Chris LaFreniere
f8067ffada
Fix for Markdown File in Jupyter Books Viewlet not Opening After 2x ( #8009 )
...
* fix for markdown not opening after opened twice
* PR comment to add return type
2019-10-24 22:14:24 -07:00
Chris LaFreniere
f7059a2365
Fix Issue when Saving Wrong Kernel ( #7974 )
...
* Only fire kernelChangeEmitter after lang set
* Fix unused import found by lgtm
* Fix comment
2019-10-24 22:13:18 -07:00
Alan Ren
d013b594b1
suppress the alert ( #8007 )
2019-10-24 20:13:32 -07:00
Charles Gagnon
c5d427ebb1
Fix column text overflow on BDC status pages ( #7928 )
...
* Fix column text overflow on status page
* Fix typo
* Fix another typo
2019-10-24 18:31:57 -07:00
Udeesha Gautam
240b90610f
Work with single ext loc file ( #7894 )
...
* try loc with single file model
* adding filter and languages
* add links in langpack json
* changing variable name and limiting the list to only tested extensions
2019-10-24 18:12:04 -07:00
Chris LaFreniere
5cfad825fc
search book gone from command palette ( #8002 )
2019-10-24 17:45:28 -07:00
Alex Ma
8918d1593c
reclassified autoinstallrequired message to error ( #7986 )
...
* reclassified autoinstallrequired message to error
* Changed level to warning
2019-10-24 17:00:07 -07:00
Chris LaFreniere
b1e0b7c1e3
Always send \n instead of \r\n to Jupyter kernel ( #7995 )
...
* Always send \n instead of \r\n to kernel
* Use replace instead of split/join
2019-10-24 16:43:52 -07:00
Amir Omidi
3a5e4cbeac
delete workflow ( #8000 )
2019-10-24 16:29:54 -07:00
Alan Ren
7bfa6e611e
Remove RC from strings ( #8001 )
2019-10-24 16:03:22 -07:00
Maddy
004c177f7b
builtinExtension-insiders to builtinExtension ( #7973 )
...
* builtinExtension-insiders to builtinExtension
* maintain both insiders and stable.
* builtinExtension.js is for build time and skipping the check for dev.
* check quality and pick insider vs stable json
2019-10-24 15:34:12 -07:00
Amir Omidi
86cc3f77ee
Fixes some code coverage issues ( #7994 )
...
* Fix code coverage issues
* Fix some code coverage stuff
2019-10-24 15:32:43 -07:00
Chris LaFreniere
a33820ecdd
Fix starting and separators in a row ( #7861 )
2019-10-24 15:20:58 -07:00
Kevin Cunnane
7babd6f3d0
Add SQL Managed Instance support and sorting ( #7996 )
...
- Add SQL Instances folder and support using existing SQLClient API
- Sort subscriptions in tree and quickpick for easier search
- Sort all resources (Databases, Servers, Instances) alphabetically too
Not in this PR:
- Will experiment with Graph API for faster perf & easier addition of other Azure resources such as PostgreSQL
2019-10-24 15:18:49 -07:00
aspnerd
e28ecf44cb
Use selected DB for import wizard schema list ( #7878 )
...
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
* Update fileConfigPage.ts
2019-10-24 15:08:10 -07:00
Alan Ren
93685d3a09
make the azdata install url configurable ( #7989 )
...
* make the azdata install url configurable
* use settings without reloading
* comments
2019-10-24 14:57:17 -07:00
Maddy
d660405e73
hide save book action from command pallet ( #7981 )
2019-10-24 14:44:35 -07:00
Alan Ren
684fb2566b
revert the notebook background execution ( #7984 )
2019-10-24 13:46:40 -07:00
Charles Gagnon
696f6841cb
Change BDC view errors to use modal dialog instead of error toast ( #7985 )
...
* Change BDC view errors to use modal dialog instead of error toast
* Move to common control
2019-10-24 13:05:07 -07:00
Charles Gagnon
cef60f3ae5
Fix troubleshoot URL lookup ( #7978 )
2019-10-24 10:14:39 -07:00
Alan Ren
34fe2b44cc
remove insider build check ( #7926 )
...
* remove insider build check
* fix welcome page not load issue
2019-10-23 21:53:42 -07:00
Aditya Bist
a16bfbfedd
Fix node infinitely loading when a firewall dialog is cancelled ( #7970 )
...
* add back icons for azure actions
* fix firewall infinite loop
* formatting
* change message to firewall canceled
* fix tests
2019-10-23 21:37:21 -07:00
Chris LaFreniere
fb4fccf2d5
Notebooks: ensure python path dirs added to path on session start ( #7968 )
...
* ensure python path dirs add to path session start
* Change logic slightly
* PR feedback from Charles
2019-10-23 19:22:24 -07:00
Chris LaFreniere
b53cad78bd
Update recommended package versions for ps ( #7972 )
2019-10-23 18:57:05 -07:00
Chris LaFreniere
a431ca7ef2
check for ownerDocument focus for focus ( #7964 )
2019-10-23 18:56:43 -07:00
Chris LaFreniere
c2022cac57
Fix for relative links not being resolved in notebook outputs ( #7966 )
...
* Fix for relative links not being resolved
* Add comment
2019-10-23 18:49:52 -07:00
Kevin Cunnane
806d807eae
Refactor Azure Core extension for easier resource addition ( #7958 )
...
Consolidated most logic into a base class and common resource request pattern.
Reduces cost to add new providers, which will help for SQL Managed Instance support
2019-10-23 16:29:51 -07:00
Aditya Bist
24e3b1c5e6
add back icons for azure actions ( #7963 )
2019-10-23 15:09:23 -07:00
Amir Omidi
bbe3605317
Lets try out this gh-action ( #7875 )
...
* Update blank.yml
* Update and rename blank.yml to tslint.yml
* Update tslint.yml
* Update tslint.yml
* Update tslint.yml
* Update tslint.yml
2019-10-23 13:05:36 -07:00
Cory Rivera
06d67f5ad2
Append stdErr log to error message when a streamed console command fails. ( #7868 )
2019-10-23 12:38:24 -07:00
Amir Omidi
41f9f22e38
Update lgtm.yml ( #7932 )
...
Add vs stuff as a classifier so we don't see their issues
2019-10-22 23:16:11 -07:00
Anthony Dresser
a94cbb528e
Merge from vscode f5d3ffa6a0d655c87e1eb0e1e90773df58f7ff25 ( #7929 )
...
* Merge from vscode f5d3ffa6a0d655c87e1eb0e1e90773df58f7ff25
* fix launch script
* add missing files
2019-10-22 21:49:55 -07:00
Charles Gagnon
4a68ab4659
Hygiene linting for extensions + new rule ( #7843 )
...
* linting for extensions + new rule
* Remove unneeded array
* Fix spelling mistake
* Fix bad merge
2019-10-22 18:56:31 -07:00
Chris LaFreniere
4c24043cc8
Add Option to Halt Notebook when Error Occurs in SQL Kernel ( #7884 )
...
* Add Option to Halt Nb when Error Occurs
* PR comments
2019-10-22 18:19:36 -07:00
Maddy
2ca5d18855
Update/sqlserverbook extension to stable ( #7914 )
...
* move package info from builtin-inisders to builtin extensions
* vbump for the filename fiasco change
* merged master
* revert sql.bat update
2019-10-22 17:13:48 -07:00